From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6CF36C7115C for ; Wed, 25 Jun 2025 08:57:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0F7CF6B0098; Wed, 25 Jun 2025 04:57:48 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0A8796B00A8; Wed, 25 Jun 2025 04:57:48 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EB3206B00A9; Wed, 25 Jun 2025 04:57:47 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id D1E676B0098 for ; Wed, 25 Jun 2025 04:57:47 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id AA3FA161A01 for ; Wed, 25 Jun 2025 08:57:47 +0000 (UTC) X-FDA: 83593320174.15.D132689 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf21.hostedemail.com (Postfix) with ESMTP id 4AA681C0003 for ; Wed, 25 Jun 2025 08:57:45 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=LZt7iKgE; spf=pass (imf21.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1750841865; a=rsa-sha256; cv=none; b=7MyygsuZJSeCaJGnqdFHyVcgnsjLeQvta81l+sPH1W04Oo4S2ke0LTTma8qHnNi4W68dok Nhm/NQ9qgZ2nfeAifa4EBDHNRld/REgY2lSueVmvZt1cMg99DkJ/C0RlvnWUox85a5xmm0 /cgLrpixUDz/Gls6sDza9zxOD9trjL4= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=LZt7iKgE; spf=pass (imf21.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1750841865; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=mN4I4L2hgAMe8omNzujSzKavpyJh1uCnngDNdOxcT+A=; b=ty+d1tM/zf1IMvFNNH6iOyX9u1k4NWVtVnmPHrstsXX23lMlAFMg++nvuyTPpfOFVEAxS8 3tTgZV/n//Wd1tAGGLOod8iM2X1exaBMabRsz2LpXkh2H6eCCN3welMpsQSJxJmW8P8RxR ItxAivyZTEcNWgrqm/ko74NSNqw7l7s= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1750841864; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=mN4I4L2hgAMe8omNzujSzKavpyJh1uCnngDNdOxcT+A=; b=LZt7iKgE5zPhg6s9GhSgDW0gYi6DPe6ot1ouGGvdrGqwQ5ZCY0FK1cgf6w9E5d3Q3bXqow j4wv1v4g/woBfDMCSTMZRztJV/uWaqFixjwr/OCS+mKdRsW/Agf5U4PmEwpBOs7XDyEuo1 N65w14uQonoz9hU5zDiQgmGVZ0bJCjU= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-460-pGDvR_29NR-glAkcCpcdTA-1; Wed, 25 Jun 2025 04:57:43 -0400 X-MC-Unique: pGDvR_29NR-glAkcCpcdTA-1 X-Mimecast-MFC-AGG-ID: pGDvR_29NR-glAkcCpcdTA_1750841862 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-3a4e713e05bso2839547f8f.3 for ; Wed, 25 Jun 2025 01:57:43 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750841862; x=1751446662; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=mN4I4L2hgAMe8omNzujSzKavpyJh1uCnngDNdOxcT+A=; b=AbG5GEFkcUCHX3GbgO397qtgQRL2ZPmx3lXkb7L2sW3AX7YLlR47GCLvkIA45OsOz8 MLCgQRapZvQSDpkSMgSpYImrPxTw7fCsjk/oYYS+hsoyIHFWK8GNsIdjf9bh3L+arj8v P2AXyMwKrYzRtMDQ11tExfsNPGlssXKIty6UWVV9mt0okrPaNlgwVLLp+z1lInDmxi98 2TABDBAeoq+LVRA1GvkQGzXFnstF0+5HmnUZWXEDnQ0t4lJ6ii4rhzjxp59FfQM9kR0d HmAz594oK7661ar1adCn87OBdXPk9nZL8msF1FwQIdnkRlBSVP4bpGDQ/lZns5b9XH0x CLQg== X-Forwarded-Encrypted: i=1; AJvYcCUUgYWGER1xkfLiOxx+a+k5kKRy38k6kspxw3w+ey1C0dqlsJIiQZiB32gGy20aeNMRAIHd3XPboA==@kvack.org X-Gm-Message-State: AOJu0Yx1vxXFISENjGAn93FAoD/EvGxQ8fKUzYVtJCr/GYGb2oUUkpSK EZxJNKs59k0aKAEYQkBpfpJe7yi1lK8qs3926XbKCqF41nIegxMM/QkY0kjSeZyg1zVSTlC/bvT fpY7Hn9GBKzwAkte9fOExPZ8oJbDO5nmZbpyQTAL52/LPXUtC5409 X-Gm-Gg: ASbGncvKmq1xA6Ym7rt1k8SRgCtj9598BJ/iD/rvf8soSy5RJvMtylS9Iv2L5Eych3a nXcg6WsNvp4Kp+OroCtQMDNHOTnG9IW81xOseiahz3V/tSk9iyMvDRBQaT/euPuZfyN3GUyLPyF 02k8/vQErrtD2qBhRPCz4LqU7MbsyZP8ArjAPHmQciNHQkZUkCCieNXty9OYT9qkgC0Gmim/JcG b97A7G+PUP1+XZRFHObYGyNoY80zy7lmKnu3kFEbDbibfsmRazOOu7uWn95BJz2+/YfZ1aBezqT zgLC2JfPYsHSgoxUnDTZ6+PIYDBcLD0aS5bmn2A8iaUYj5jReOYkZG42NCuzkeM6duiZktZnMeY 5GfQ8LmCO6xY6lr7+Efyw+vWBZd5VIpMK7PbqUhUn0+bA X-Received: by 2002:a05:6000:4a0d:b0:3a4:f70d:8673 with SMTP id ffacd0b85a97d-3a6ed6412e5mr1866842f8f.25.1750841862273; Wed, 25 Jun 2025 01:57:42 -0700 (PDT) X-Google-Smtp-Source: AGHT+IH2wzVVSUssZLp51IOGd4e/arg5P8SkkJKDt1VKkOp/GrEtmtzZfN1e1gqooQJhBiA1eP15VQ== X-Received: by 2002:a05:6000:4a0d:b0:3a4:f70d:8673 with SMTP id ffacd0b85a97d-3a6ed6412e5mr1866814f8f.25.1750841861910; Wed, 25 Jun 2025 01:57:41 -0700 (PDT) Received: from ?IPV6:2003:d8:2f12:1b00:5d6b:db26:e2b7:12? (p200300d82f121b005d6bdb26e2b70012.dip0.t-ipconnect.de. [2003:d8:2f12:1b00:5d6b:db26:e2b7:12]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a6e8055f0asm4046669f8f.4.2025.06.25.01.57.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 25 Jun 2025 01:57:41 -0700 (PDT) Message-ID: <1ea2de52-7684-4e27-a8e9-233390f63eeb@redhat.com> Date: Wed, 25 Jun 2025 10:57:39 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH RFC 10/14] mm/memory: factor out common code from vm_normal_page_*() To: Oscar Salvador Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, nvdimm@lists.linux.dev, Andrew Morton , Juergen Gross , Stefano Stabellini , Oleksandr Tyshchenko , Dan Williams , Alistair Popple , Matthew Wilcox , Jan Kara , Alexander Viro , Christian Brauner , Zi Yan , Baolin Wang , Lorenzo Stoakes , "Liam R. Howlett" , Nico Pache , Ryan Roberts , Dev Jain , Barry Song , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Jann Horn , Pedro Falcato References: <20250617154345.2494405-1-david@redhat.com> <20250617154345.2494405-11-david@redhat.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 7h7HYx5841YihGJwBzrq3rVvLExl172cd7rNkLxca_E_1750841862 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Stat-Signature: 4ssjqztkgyoz39m4jszmzs655d8q37o1 X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 4AA681C0003 X-Rspam-User: X-HE-Tag: 1750841865-596022 X-HE-Meta: U2FsdGVkX1/lLtu0YZUe0XbOUQqKg2Inh/PUY/tMyDDyENceHdPCZdXY74v8uYuDzF6xhQPcX0bvy6Thx4EMuun59WtMoxBP9jMBoCTiBD7aIYIYCzNO26Lu1UKnHEQy/5kav8r8wBtsSoXfgSFBaTPOrSiXAAQYkh7cZb2Kj0dClrAgasjGdTd6vpGibzC2ZsxAjmkP4OnLwsQ8qVQbhFvf/kZGokpNS2K9eIexl5fGMdA2w0OnEIka5euaX/HErVGLn3apnvFxKnz3VaBznDE2QTLlhroK7bcmhoYDomtYXhQQ+I59kSe/vNnH63Bzhmrofk8r8T1ScbRFmNBeFAbURYCKeqYISYXzmWXzw2JYQ4PTnvVCWxxcI5n2HckZYGnqDAK4wvYuRudSe7fEvr3MRWfnPFMoqDeIe37roLxeTnTxTxv3jf+KedhaLzuIy2MfvRP4qkiKT3PkJcoZ4az6wqF03fK5Cto5IiYYaf01D6/lOZCrp8MNcbyBgJtHvqNJ6nNQXt4uEiPN6MuKxRR0EZpeNWohROG3Sc1zV05/K/Tn8oYN0vIsLPtkhAMTG2K4le2MGQkQxr90VALVDpC5FGwlEJwYNc9PDQJQwF8moqv9cZTZ1Is8RQ9AZs/XqlCK7yPnAODwdS+yoM70ZwC133v5ty75vtzZiylJiCvmHiRW9CUm3CoXsf8L8kL229z/aiNSv6Mjotn31Pb91Rxw1doOLjEYFTAruuNf0d9OvFOD6zHXJkV9X/lFsMFGuzg1AoAxVI8T5GNc17fOrxWHjyqFiwxuX+TBnFvLIfiG+ah1ovs32juMz4AH+boPWB61vUkeiAhpzGhS8hdLVc9ncwXsd1Go0hMXvJPrdGqCLLwM7aEtzbVLI8I6ggxnx5sJZZC1Q4Fa3f8jkhAh6Q05OPizt4RC4PQluoORBOopkAsjxUNDbBBju0ImzCjM0QiOnZPMd3GI+ae9dzC 6l17qFlw v6pZs3V0NXb0UxeGvH3fMWyrkADIIp+sJWrlSLtObDmG7bH7kQmNLw/IpuQAl0xtbkoLJ+FWyvlSKvaioseFOLjKUbyBzUOfqvnHYVCIAZu7Tpu8zheqebquDBp25zQWsYx7q06DIz39Swv8PEKULSSbHIhkf85MJhb9mYBoizRRwoI4bwsqSVAOGl0pcfETwHWB0PHQ5JcpTga+SDMxQkuhnA2fP1bdg/aSJuigKFWshE5p3taKyZ4QIxxaKmpBI+if0CA7/RxMHXJvNohNglPOcYuwHyucedmr1wn5bV91PEAqQ03Ol19K2o86t30LOyTm4LHDDWDr8s+7YLiJYYX2Syy+I0sRcitjqlwRSp6cewL6wI7zthls2QWFftrLcqtTFZMSYhJ6JnJiwGhzfQLN2ES7UGmH7TygizTsuiTHxy9NzmQ1uBYn2LR0HLCpptsX+s+9zUYeYQ+U+JLOcKbBOXRNJbJZkJMCi X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 25.06.25 10:53, Oscar Salvador wrote: > On Tue, Jun 17, 2025 at 05:43:41PM +0200, David Hildenbrand wrote: >> Let's reduce the code duplication and factor out the non-pte/pmd related >> magic into vm_normal_page_pfn(). >> >> To keep it simpler, check the pfn against both zero folios. We could >> optimize this, but as it's only for the !CONFIG_ARCH_HAS_PTE_SPECIAL >> case, it's not a compelling micro-optimization. >> >> With CONFIG_ARCH_HAS_PTE_SPECIAL we don't have to check anything else, >> really. >> >> It's a good question if we can even hit the !CONFIG_ARCH_HAS_PTE_SPECIAL >> scenario in the PMD case in practice: but doesn't really matter, as >> it's now all unified in vm_normal_page_pfn(). >> >> While at it, add a check that pmd_special() is really only set where we >> would expect it. >> >> No functional change intended. >> >> Signed-off-by: David Hildenbrand > > Reviewed-by: Oscar Salvador > > Comment below > >> struct folio *vm_normal_folio(struct vm_area_struct *vma, unsigned long addr, >> @@ -650,35 +661,12 @@ struct page *vm_normal_page_pmd(struct vm_area_struct *vma, unsigned long addr, >> { >> unsigned long pfn = pmd_pfn(pmd); >> >> - /* Currently it's only used for huge pfnmaps */ > > Although the check kind of spells it out, we could leave this one and also add > that huge_zero_pfn, to make it more explicit. I don't think that comment is required anymore -- we do exactly what vm_normal_page() does + documents, What the current users are is not particularly important anymore. Or why do you think it would still be important? -- Cheers, David / dhildenb