From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2F413EB64DA for ; Wed, 5 Jul 2023 15:19:28 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5FFDF8D0002; Wed, 5 Jul 2023 11:19:27 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5AFEE8D0001; Wed, 5 Jul 2023 11:19:27 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 451728D0002; Wed, 5 Jul 2023 11:19:27 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 3563F8D0001 for ; Wed, 5 Jul 2023 11:19:27 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 086AB80BC4 for ; Wed, 5 Jul 2023 15:19:27 +0000 (UTC) X-FDA: 80977917174.13.0A2F8F3 Received: from mail-il1-f176.google.com (mail-il1-f176.google.com [209.85.166.176]) by imf19.hostedemail.com (Postfix) with ESMTP id 0EF151A0018 for ; Wed, 5 Jul 2023 15:19:24 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=acm.org (policy=none); spf=pass (imf19.hostedemail.com: domain of bart.vanassche@gmail.com designates 209.85.166.176 as permitted sender) smtp.mailfrom=bart.vanassche@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1688570365; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=vhOVd+fM39By6Neo4SNlvIwXWgDBhgramNmEhS79nFc=; b=DNaS77okv9alxauLxeC7WVWElblj3Q636fZQZbriyAmWr3G3FStoNeyMMg7HorIXtTUap5 g0DOuoWzI0nc8sx+OtaTdGEUzBNA5L6LI6YfMZ3YEk5jJRyLzRD27IWc1vAOct8VB0I/94 Xd0OR30wAVPG7fl+oYMKEDRzI4xjO2c= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=acm.org (policy=none); spf=pass (imf19.hostedemail.com: domain of bart.vanassche@gmail.com designates 209.85.166.176 as permitted sender) smtp.mailfrom=bart.vanassche@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1688570365; a=rsa-sha256; cv=none; b=VpoKxjqljf9jI+zDP9aYNZ/D8XGD4kMYddPqIS8+HumWUmuoTwIvYmG9xWDiYR57HmSvKL bYiU6M7N98zPr0buAjOgRrZyp4k2xTfRjAkInkqzhVHaGBtkD2KdfAYWR6BwExfY2oZcs/ gXP48/G9t1xFK/IUXwdcuGWJh2i5Lbg= Received: by mail-il1-f176.google.com with SMTP id e9e14a558f8ab-345db6c12b4so25136455ab.0 for ; Wed, 05 Jul 2023 08:19:24 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688570364; x=1691162364; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=vhOVd+fM39By6Neo4SNlvIwXWgDBhgramNmEhS79nFc=; b=g1s/bAxRcQdRVj2SxaRaBzGugUxyH7lSVzo5oZTZyg/gEkCgyFOE9YdQDXAUFvY/Eo +R9/wgnSn87np67IA1DYFQ+1pDQWt7X7Xq5xmfSEONiS7Wf/Fsyzu50JroWBNKjfEcgk jxDXEnpW5J5SBeC7dCk+v+lppcIPn57kyYgcqnjxfTVGWSeKfySTHX8wHRQdO7tM7ZXv buPSXu0ht+0dpLDOhWCo96lCHEVPw+lkRm5g5uU8/7bQZ38GR55dJ8ZwK+4OUdXs2aT5 oAIqBUKWuwdzW923Fs3wxZ6L39NjddDiHG5aDz0o28s0NOjFekEGIi/FEl6eqvU6hTJw hkzQ== X-Gm-Message-State: AC+VfDyEX1dvrQ4aF05Z8fGYqbWQvTxe8590ojAftim93zLEujS8eCVf giDddQ3BMWZG0KxNOIfQquY= X-Google-Smtp-Source: ACHHUZ70uoI88DRVhGiNe4v8NMOn4CckRug5A25bO6UrnrhXn4O+oQb9CB+u9z1UucgpvIObIHjohw== X-Received: by 2002:a05:6602:2113:b0:784:314f:8d68 with SMTP id x19-20020a056602211300b00784314f8d68mr18093430iox.1.1688570364015; Wed, 05 Jul 2023 08:19:24 -0700 (PDT) Received: from ?IPV6:2620:15c:211:201:c1f1:7d21:6172:cbd2? ([2620:15c:211:201:c1f1:7d21:6172:cbd2]) by smtp.gmail.com with ESMTPSA id l6-20020a656806000000b005579c73d209sm15456631pgt.1.2023.07.05.08.19.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 05 Jul 2023 08:19:23 -0700 (PDT) Message-ID: <1ea08f84-f900-92f2-e32b-2db242a74559@acm.org> Date: Wed, 5 Jul 2023 08:19:16 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH 01/32] block: Provide blkdev_get_handle_* functions Content-Language: en-US To: Matthew Wilcox Cc: Jan Kara , linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org, Jens Axboe , Christoph Hellwig , Alasdair Kergon , Andrew Morton , Anna Schumaker , Chao Yu , Christian Borntraeger , "Darrick J. Wong" , Dave Kleikamp , David Sterba , dm-devel@redhat.com, drbd-dev@lists.linbit.com, Gao Xiang , Jack Wang , Jaegeuk Kim , jfs-discussion@lists.sourceforge.net, Joern Engel , Joseph Qi , Kent Overstreet , linux-bcache@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-erofs@lists.ozlabs.org, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-mm@kvack.org, linux-mtd@lists.infradead.org, linux-nfs@vger.kernel.org, linux-nilfs@vger.kernel.org, linux-nvme@lists.infradead.org, linux-pm@vger.kernel.org, linux-raid@vger.kernel.org, linux-s390@vger.kernel.org, linux-scsi@vger.kernel.org, linux-xfs@vger.kernel.org, "Md. Haris Iqbal" , Mike Snitzer , Minchan Kim , ocfs2-devel@oss.oracle.com, reiserfs-devel@vger.kernel.org, Sergey Senozhatsky , Song Liu , Sven Schnelle , target-devel@vger.kernel.org, Ted Tso , Trond Myklebust , xen-devel@lists.xenproject.org References: <20230629165206.383-1-jack@suse.cz> <20230704122224.16257-1-jack@suse.cz> From: Bart Van Assche In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 0EF151A0018 X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: m33meu4k64hr8aub7rzuw3p3uy7karam X-HE-Tag: 1688570364-171444 X-HE-Meta: U2FsdGVkX18DZWwMVSXTDB66fk26qrK3ulRa6G3fcjDaoTgNePCzNoaKXPOxowzf93Pmm/ZvGTQ0e//4+wWTig0tzE0d9pp4S0IZZ51jRtEmICAp6Bto/WPwvWhai086p+USUcar2jJaXaWY8CBttggbTjv6BdDDMPTpiFIWRzxk9xXPWhjsJCOSzGePYa4lMrSSN6aJDgukZPc2/emW7acQVnuWth5GnZeKjL3wZYjeeDWTpkxSC4TFcXKv741keuU1vFtSVFZ40GEs1f5g9X5SvnS9hxbPv7fKxOX6UlUl01fpe0ZenLY5/ReEKBeP9bqCgzTfY+reUOO7myGn39JdFC318piX5riOIs6g/cBxT19tBy8G0zKYRc1CHjkdROznccZFVV8M2HACJwj0q6hufzbfBa6NhMVA/KK1bmWsaNS1fn8lhXp5LH10ncQyxiYi7KKBAZIKkZuWkeDL3H4gPpenfPqNSr0JJEBgd/wjGn+OWg5K6/8PQ4Nuls82g0wAkV4cuEJtaEFuyxfN1sM/HoUk/pu4Wz3D+cNscdsdhIEQFZt1AkSnNqq+rADfkoJEBKTqyW26GsnEIxML7nsuAgehiNS5ldcYyovq46fYmC3LjC5MLwPNeslQRnAPg4yytcdQ9JbXr9e0w2rrGvxH4+4etkVldi+mqjH5P71gPDGie2XcLAlgZBWYQnD/B1g7bglWUNgsa+qPhDb004eFHIeyaAH1kCnhP4xPYUn99i2C/E5K7eOHmKDaagsPXTO8uCVHBPY6/t1JEGfi7WQ5OAnqrShpLEPAr+/gSLBZuUOx87hy3voK9g3HFBTPDym7La4/IwuD+i1CP/OVZAV3OSy5RDFZTRWVJ8H3WYJuFnpg6hDUBNIgQUOjIo8RGKCfJpj8mVtOBM7aLZSg5nJHh2df4u0f8P4tHAxBHxq+HrjSJFgczrwuoro5B5EgvH1Ls1E26PvOykvd76V M4rM2Qv0 ZQGOvDY+dTKq3t/LKUblv+wEAsixAuEYRBKz7oXWr/u1zhga0ar/D54+T0Ign+iZI3VujqoxEmr36Sh1wfcWVaxKcOkPektN+5ozlzuTl0cAlRFV3bkP4sLi8BZojIO6YilHMmCnfP/ERRVwqlxcjqUDOKO99Mufg8kB3zQsZiioYGCMD9SWJjZPS18251vGFdmJu3DemCkNLBcZZdomxbhzcQIKgXzF0OzwthHD4Xv14zkA9zQi/N/OeblYaWowf2rX8xknoq+L4YiQakAcp1+r+8eV1XMA164Ia/eQiR/+ht8bf0Y5mz9IB3QqnUVGBLel9d48C/CTooHOHOWd63H/N2tKMMOdtltWgF9R94Uk+RuLjcrVMu+lN8kwXjpE7iPhBeJCGh3PJKCfJoN5EB/C7Gpy5sNpe41KK4FFzivdxpbf/LHwn6GuBms35sZZZ2HHznYeWalSQvKVOCslkA89lhXjE0DMQ2W3LXuKJ/FdL0BACbgARJH3P+yDEthEYPZSEbhEChzeq+wqrnj3h2hmgnL4Xe77fXj1QZZfQX5b5P68dZ7YLV62Y4ktKj3Ns8sqb/FIac+2/C81I9a//VP5V/8KGAWL5ZquYgcMOaeLe5aQYbBq1sbj3ofa08NUOr0843iFpoCIvr/msI/3yxk2mxaFv4WotqL2trwlDep1g4VjdRFh68tz50MUXBqpvtKb0RKTX5mNIXecmNsRiDkTBag== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 7/4/23 09:14, Matthew Wilcox wrote: > On Tue, Jul 04, 2023 at 07:06:26AM -0700, Bart Van Assche wrote: >> On 7/4/23 05:21, Jan Kara wrote: >>> +struct bdev_handle { >>> + struct block_device *bdev; >>> + void *holder; >>> +}; >> >> Please explain in the patch description why a holder pointer is introduced >> in struct bdev_handle and how it relates to the bd_holder pointer in struct >> block_device. Is one of the purposes of this patch series perhaps to add >> support for multiple holders per block device? > > That is all in patch 0/32. Why repeat it? This cover letter: https://lore.kernel.org/linux-block/20230629165206.383-1-jack@suse.cz/T/#t? The word "holder" doesn't even occur in that cover letter so how could the answer to my question be present in the cover letter? Bart.