From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id ACF59C25B78 for ; Tue, 4 Jun 2024 13:02:14 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1D1C66B00A6; Tue, 4 Jun 2024 09:02:14 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 181026B00AF; Tue, 4 Jun 2024 09:02:14 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 048616B00B2; Tue, 4 Jun 2024 09:02:13 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id DAABB6B00A6 for ; Tue, 4 Jun 2024 09:02:13 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 30D91120BBC for ; Tue, 4 Jun 2024 13:02:13 +0000 (UTC) X-FDA: 82193219346.23.C22FE81 Received: from smtp-out.cvt.stuba.sk (smtp-out.cvt.stuba.sk [147.175.1.21]) by imf29.hostedemail.com (Postfix) with ESMTP id 87AFD12002A for ; Tue, 4 Jun 2024 13:02:09 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=stuba.sk header.s=20180406 header.b=F4u4ZTD9; dmarc=pass (policy=none) header.from=stuba.sk; spf=pass (imf29.hostedemail.com: domain of matus.jokay@stuba.sk designates 147.175.1.21 as permitted sender) smtp.mailfrom=matus.jokay@stuba.sk ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1717506130; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=I1tK3w2AP9asXV5BRpDDe4dl5b2p5RS5w5CWAe5+twU=; b=x+TSK91Mz53KTBHMz3EIDxHZIOBB+PJb3fmAWg1HSedP9Gpo12VhswotPkN1h24DETNlQx 9zvvbvW420i5rNO6Escuu/RjNtrPXAek8vQSR511ohSyL33cZk6n3b+9+F8LVVLOEE5TEY emCugPJWbJ+0HPaHOaO1fbbhQjVRmmg= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=stuba.sk header.s=20180406 header.b=F4u4ZTD9; dmarc=pass (policy=none) header.from=stuba.sk; spf=pass (imf29.hostedemail.com: domain of matus.jokay@stuba.sk designates 147.175.1.21 as permitted sender) smtp.mailfrom=matus.jokay@stuba.sk ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1717506130; a=rsa-sha256; cv=none; b=jLbQCuDFnE89vWvpc1jqXtzc4dkXR4s/PfCJDUU2sv289U4z3lhW2YGUPYiHQNGYs0Sbc+ R3TLY5W2zhIeUvAxl/ID9dzABD2YFPdRMsbRvkI6GYJhxPqbkhOPhNu8M1oQnJdhAUsONd PLusP+Q8+HxkNHIeS/XP1N1lKThoK3o= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=stuba.sk; s=20180406; h=Content-Transfer-Encoding:Content-Type:From:To:Subject: MIME-Version:Date:Message-ID; bh=I1tK3w2AP9asXV5BRpDDe4dl5b2p5RS5w5CWAe5+twU= ; t=1717506129; x=1717938129; b=F4u4ZTD9HahQ+V1munJkIVYQEY5n7z+zVsnm+21Seki7X NOqXdIhPVyUVjZv34SfzkzH8UeJkPJBqNNtnoEqj7a2DOIGNGilnJzHwRa5aWnOeNjesY4BuVw3b5 FL42XF6IxMPxRYwIeXZz2fniRKweGO8eNZD1uR5dxHzJAgKcAivNH29SrODCUxFP5MpMpa/24n1OU viAd3lx+dKozfOnly0Fb6rmDG/wfNQPenHPEUVVgLMwWdyBre6bWS17nRAl9aXOjd5Zu0o4QIlxbN WlDQDcBq4M798Rfoe+deN7jkguTnbpJ73Rnkwer8HhDQlehgDT/vzRZCTTMNd2jyEw==; X-STU-Diag: 732c0afafb52b10d (auth) Received: from ellyah.uim.fei.stuba.sk ([147.175.106.89]) by mx1.stuba.sk (Exim4) with esmtpsa (TLS1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (envelope-from ) id 1sETnh-00025l-OF; Tue, 04 Jun 2024 15:02:05 +0200 Message-ID: <1e967ef4-57d0-4090-a42f-6457a04680cf@stuba.sk> Date: Tue, 4 Jun 2024 15:02:05 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/6] fs/exec: Drop task_lock() inside __get_task_comm() To: Yafang Shao , torvalds@linux-foundation.org Cc: linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, audit@vger.kernel.org, linux-security-module@vger.kernel.org, selinux@vger.kernel.org, bpf@vger.kernel.org, Alexander Viro , Christian Brauner , Jan Kara , Eric Biederman , Kees Cook References: <20240602023754.25443-1-laoar.shao@gmail.com> <20240602023754.25443-2-laoar.shao@gmail.com> Content-Language: en-US From: Matus Jokay In-Reply-To: <20240602023754.25443-2-laoar.shao@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 87AFD12002A X-Stat-Signature: uxf6tddwu6f5z8ummyqgke8mp8bwopaj X-Rspam-User: X-Rspamd-Server: rspam04 X-HE-Tag: 1717506129-626716 X-HE-Meta: U2FsdGVkX1+f5oV3KMUtaP/UCVf+JIhUZLepvsQswG4S0aKuwakJcF2Y0BShICifswaD7UMYbma2QuOBuXU+lOW8pqwwuzxXG+eS/ctmaPaQiJTypHoDuKFiSJh+bsdiL6C1MROhyapOqPn+4OWRdOit30N8Ng+X/kslShy7NXCrV7fPN4CluXxJDyGS/LZ7bMv3EJgnRa9Ato5ZN2DoNs4olRWrCk+on0IehriZ3s6spWJftEt+LwDs+OxhvMcF/Ra+y9v/DUGecUC6Bc36KVgo99ZHDmbvNgytcD11grvktzl3hOZgnkQ1qJIHI/MmNZKc6o+8EKQcw+25TlGf6Mm0xruGizsjNUBmjg3kpM0vn04hWvklsBciz1BlgdPHAhrhoE4AllE+tvSjIXT0hl6ZuYr6yqxniMbJ8+rSBjwn1AeTC9Sqt/h9bkOL4R+MqMHI0CBHCAS6vaWIJQl7s1hiPDsGJYsDpwRITYfNVKmjHoSGOA27NFMWN2fG8qwyfWX51y7IC3DbcUaOedJdUajb5V/SnwylVdJXQKt2v2DBMZU+YsCyXzsKjAoRPmoDvAGuCAmbTRf/ROVDNCeSkc944iK2QchYSL4/F9eSLGXe8BzB6Zq5HQmTlbn+gY5Mwoo8IKjVThSzzbp6bEzbHxDEduQ0H6CevMozqfaGZyY7/qoXJXHvd2QILvuf/0yS9RC2Fcd4SCZ1YlaUyCUOJ+TrtDgt8Cw/SnSGH07ClvI5zb5lkj9CRwCbq25ipVFnz+/lZ4b0HiI9HWjBGy6ZHAGcNUlfupOuLO+P+mpWFEjn4z2vR3A6Y3Zrus1Gjw+kWWTuNeOuM+gPYIg4bZnrG/BkFk8k+HPm+tuvzo8MgCKl4gw6qJ6icyQ6LtizmAG6M819X9NNpyVyYGbT9/LsRXnMeOAtTLU14As9vYkh88wLy2YJLv3HE3NqPrqvJXyu1zWFt8w9PM4AgNmv8+v mNDmA7Jc 4HwrgTragvqHxD6qBTBb8AMNYQGF+Rj/ZCy74ZZUP0K3aDpebyaeEaYp7QPE/b3XxgOAQc6duVAUSmjwOwgfIPymxiMJqlzh6R1Ki0lw5Cjzmxy5qQW6y9sNXKIAsyaZTSutL+/G3vv73mVvlvPEHostTWKOOFp56d8wU2d/KGrqjJyNxIWrmN82+Pa5jpo9X8bc4KcodaepRkt649iMJjlqzA9pNO5POSWoQKl2k/Zmg+zdrp3c1+ELDDio83OW8E02K2cZCXcZ7YpTmvYwbA2nARG6Bdr0bV0FZRW3ZmVe5pWxLrC3NJmIeiVgX6f9JXmvP/7ZF3btf72p7JCiEQHi67A== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi Yafang, > diff --git a/include/linux/sched.h b/include/linux/sched.h > index c75fd46506df..56a927393a38 100644 > --- a/include/linux/sched.h > +++ b/include/linux/sched.h > @@ -1083,7 +1083,7 @@ struct task_struct { > * > * - normally initialized setup_new_exec() > * - access it with [gs]et_task_comm() > - * - lock it with task_lock() > + * - lock it with task_lock() for writing since you are updating this comment, you might as well fix other comments concerning ->comm, e.g. diff --git a/include/linux/sched.h b/include/linux/sched.h index c75fd46506df..95b382d790d9 100644 --- a/include/linux/sched.h +++ b/include/linux/sched.h @@ -1081,9 +1081,9 @@ struct task_struct { /* * executable name, excluding path. * - * - normally initialized setup_new_exec() - * - access it with [gs]et_task_comm() - * - lock it with task_lock() + * - normally initialized begin_new_exec() + * - access it with __[gs]et_task_comm() + * - lock it with task_lock() for writing */ char comm[TASK_COMM_LEN]; -- Thanks mY