From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 671FEC54EBC for ; Tue, 10 Jan 2023 14:28:17 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D8AA18E0003; Tue, 10 Jan 2023 09:28:16 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D39CE8E0001; Tue, 10 Jan 2023 09:28:16 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BB4908E0003; Tue, 10 Jan 2023 09:28:16 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id A8E818E0001 for ; Tue, 10 Jan 2023 09:28:16 -0500 (EST) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 0453380485 for ; Tue, 10 Jan 2023 14:28:15 +0000 (UTC) X-FDA: 80339119392.10.6CD2138 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by imf17.hostedemail.com (Postfix) with ESMTP id 09E9A4001A for ; Tue, 10 Jan 2023 14:28:13 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b="FWFe/2g3"; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=6lEdOHu4; spf=pass (imf17.hostedemail.com: domain of vbabka@suse.cz designates 195.135.220.28 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1673360894; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=+ifLyQ+MOB8va2XR1K/FSEoQ13TM793cM+jcIwLQQ1I=; b=JQfJIvunR8zJhE5tSj8Tq6eS4BgZrJGygElFuiXBSl3d9rOzY7RaTcr7DzKMdX8Nhm03mW jE7o1YtFW1Tcj5EN0hsiYpkdUsGp1Y8x9lKml/LzQitOMqUtFY7srnT95/p2v5GL5FkaEw Fm/iIXktpKVYB3w5Fe4F3mgqNcVwyz4= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b="FWFe/2g3"; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=6lEdOHu4; spf=pass (imf17.hostedemail.com: domain of vbabka@suse.cz designates 195.135.220.28 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1673360894; a=rsa-sha256; cv=none; b=1ap5qAAcggHxbI1pJrzTwzQQ41UuPWUEaKHKpfZKWw8ewSaxYcW/mD7NcXSrXWP7XNi1S0 JwK+RSb0pa7iF6meD2z7I+0NQfKA/Du8laj34MSeZG8BdpUAywf/Ie2NFsUBMVUmicrWoy GQ/HZSeUe3CRjMaXSrmYgcGbWr/D8m0= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 8C0864EE9B; Tue, 10 Jan 2023 14:28:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1673360892; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+ifLyQ+MOB8va2XR1K/FSEoQ13TM793cM+jcIwLQQ1I=; b=FWFe/2g3VcdAzJMPRdwrZ/OV4tN95vwMMNoC8plTb9de6EmMq3WlidVmHDvga3gj+unvfS LQGtgpctufOtAovPRn+ZLX+g59MWli6aVvXivzuKbo0sFH3gIWzLL66S0b3jt7IhZsyoT6 kGwDynhFTtXsMT1xiPgKXujn9R2Puw4= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1673360892; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+ifLyQ+MOB8va2XR1K/FSEoQ13TM793cM+jcIwLQQ1I=; b=6lEdOHu4gM5jCStFiKTGkzXIvnRYZV/jQZj3Wnw6qGvDjmyc4OyNmubcBNTEMiWpGuCES8 lfENQdqnaiBv3ZAA== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 6EFC41358A; Tue, 10 Jan 2023 14:28:12 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 0W16Gvx1vWOcXgAAMHmgww (envelope-from ); Tue, 10 Jan 2023 14:28:12 +0000 Message-ID: <1e862dbf-1618-c546-f0d9-ca54f129285c@suse.cz> Date: Tue, 10 Jan 2023 15:28:12 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH] mm/sl{a,u}b: fix wrong usages of folio_page() for getting head pages Content-Language: en-US To: SeongJae Park , akpm@linux-foundation.org Cc: willy@infradead.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Christoph Lameter , David Rientjes , Hyeonggon Yoo <42.hyeyoo@gmail.com> References: <20230110005124.1609-1-sj@kernel.org> From: Vlastimil Babka In-Reply-To: <20230110005124.1609-1-sj@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 09E9A4001A X-Stat-Signature: k5f915hhc16yoa4w14yc9jxq7dkxkcea X-HE-Tag: 1673360893-967211 X-HE-Meta: U2FsdGVkX19Vk2z41bzScjK+0NAS+KJtT6u0Sgc/K/31gtDo9QrxpRP5NTbUbyS2DUeQknbm275VhslDBf+ug4EkWwxeufulHikJl2OsJljodu4k7ljQ8DE2dxAaDj0lqCZaklB/kM9B58mgZYZXT/moiZripXGV7dyNIp/rEEeHLzFCk8lodts0BekL2JJ1kWfsokHP6IqGY/W6FS+O5k65MEIkyATnvkqo/TA579ckco3W3bwR3ZXyXaBZ+ogb+Ow1kfSesxGZSo2flfXESW7aicPujRydhXgsWW0NYyjL+Z5S2WPP+MuFu3deZs6z0WfQGawzMMJ6o3ds/T9/YlzpdOFNS9TCu8AkcD1QMdXXjuWVtoLAh888BOsfr23JT1m0jJdzWAWChFlbw58AfTMJcWzK+TjvllBGnHsNucOuTZ+CcpZcaAZxqr74T3X27+ZREzihk/6GkeWtHTNbocmjGyNPfvazqsv02Cy96U4cs8RfiNCrVw6hYdz7S4v1vzbVjde13jEvz2bPdFrIC/5IryFweB0IEWgAJVYbMtnPsNFEGJn0/g64tKinenvXnr6o4facK51otPSW+nvmPgF5fHjnJ2gVO8YJiuKW3ncLI97NvrWkFORTHjv6qwg0yvWbUEzS8dhjmicrzsly8fzUt4scrCH5BUZRhrNylQHwe1Kit6JGkR49BuAaVJVzRJbOSAYzwMUNaJ/k5xWIgefbGLRQ18CTo9D5SWQSJqCbCrdftj1NXFH30+59XbnqW0lek+5RYEffhUvIb+Id5Z8DF2mkFLbKu1SAsXwyFoEeG5bvAYGFodxv5m4EYN/MNsq0zngS4odcM4/ito/ykteFi88L5NRK1hjVEtgi10/89gcFSRt3+Gc3jNnZbGwtYWcQZfcnXe1KAgRHHTjXeyX11bw0ZrU13NpEtLwZ6L4ggoYuGxGJS8jDUDl3K56Y/EhuhGABXK2sq2CyO4O b7RyBlP+ IXr4HgXfDlj0C3t03PgISo+pNalrY+PMcJtFOfAKTSxA00m0dNW9GmgGT+Q== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 1/10/23 01:51, SeongJae Park wrote: > The standard idiom for getting head page of a given folio is > '&folio->page', but some are wrongly using 'folio_page(folio, 0)' for > the purpose. Fix those to use the idiom. > > Suggested-by: Matthew Wilcox > Signed-off-by: SeongJae Park Thanks, pushed to slab/for-6.3/cleanups > --- > mm/slab.c | 4 ++-- > mm/slub.c | 2 +- > 2 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/mm/slab.c b/mm/slab.c > index b77be9c6d6b1..a5398676dc60 100644 > --- a/mm/slab.c > +++ b/mm/slab.c > @@ -1389,7 +1389,7 @@ static void kmem_freepages(struct kmem_cache *cachep, struct slab *slab) > > BUG_ON(!folio_test_slab(folio)); > __slab_clear_pfmemalloc(slab); > - page_mapcount_reset(folio_page(folio, 0)); > + page_mapcount_reset(&folio->page); > folio->mapping = NULL; > /* Make the mapping reset visible before clearing the flag */ > smp_wmb(); > @@ -1398,7 +1398,7 @@ static void kmem_freepages(struct kmem_cache *cachep, struct slab *slab) > if (current->reclaim_state) > current->reclaim_state->reclaimed_slab += 1 << order; > unaccount_slab(slab, order, cachep); > - __free_pages(folio_page(folio, 0), order); > + __free_pages(&folio->page, order); > } > > static void kmem_rcu_free(struct rcu_head *head) > diff --git a/mm/slub.c b/mm/slub.c > index 67020074ecb4..d5f20c062004 100644 > --- a/mm/slub.c > +++ b/mm/slub.c > @@ -2066,7 +2066,7 @@ static void __free_slab(struct kmem_cache *s, struct slab *slab) > if (current->reclaim_state) > current->reclaim_state->reclaimed_slab += pages; > unaccount_slab(slab, order, s); > - __free_pages(folio_page(folio, 0), order); > + __free_pages(&folio->page, order); > } > > static void rcu_free_slab(struct rcu_head *h)