From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 00163EE49A7 for ; Wed, 11 Sep 2024 13:14:39 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 67CB4940035; Wed, 11 Sep 2024 09:14:39 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 60519940021; Wed, 11 Sep 2024 09:14:39 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 45882940035; Wed, 11 Sep 2024 09:14:39 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 22621940021 for ; Wed, 11 Sep 2024 09:14:39 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id C7712C1858 for ; Wed, 11 Sep 2024 13:14:38 +0000 (UTC) X-FDA: 82552501836.04.01180AC Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf30.hostedemail.com (Postfix) with ESMTP id 867958001A for ; Wed, 11 Sep 2024 13:14:35 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=aOufYMOl; spf=pass (imf30.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1726060447; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=bkCOG6izXsnlZnjNQ3l2VZQ+6FIky3ox9qKNwZv98vM=; b=opYG9gS7+SbO5coA/KkUtDm/VhM+eqC2t47/mWGwxa4aSnlQg4fY1KC+n1xzWCrBq2AucD DgKfEGEkb0HIfVgcVf2shVq8lhJ5QAlNnaW2b2A/QHvOFe49uQOjMpm+JNR8+QPAixGcxL pFG5DMfAA3HuE+jWwbM4FpLVulIlSPM= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=aOufYMOl; spf=pass (imf30.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1726060447; a=rsa-sha256; cv=none; b=S/GINFXghRoKEI1y0p036xMpSAAZbslY2QYX4X6A13Si2jfmELUAKAEgbbAsbEELUCQ2g1 ymQ66I165S8kSSWmWf2slhbVbot2PIvzCy4kubZKVafTAdkrhEpRzX+HWJxanV8ndvWUPs OSj4020eelnlAJ/xjhhbx5+w3EmpqCw= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1726060474; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=bkCOG6izXsnlZnjNQ3l2VZQ+6FIky3ox9qKNwZv98vM=; b=aOufYMOlq9o3LfZ5RKxJ9x/eILa7Shoo0Y8Syg1hv9CKJwR2EV2ALXNGJV9ACWnzPPM1gg kdo+coZiNpiQmtJbvRWCyWryeZw0sdttKWWm5QZMTRn+HUovvHPcnm4a9Au7Mbvu3oXw0L y1/N+S+QBsJpCGKxTKIMLNoE2Kfk51c= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-587-EZlZnWJcObGJAtyMM1sm5w-1; Wed, 11 Sep 2024 09:14:33 -0400 X-MC-Unique: EZlZnWJcObGJAtyMM1sm5w-1 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-42cb998fd32so15609395e9.1 for ; Wed, 11 Sep 2024 06:14:33 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726060472; x=1726665272; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=bkCOG6izXsnlZnjNQ3l2VZQ+6FIky3ox9qKNwZv98vM=; b=hVl8gvQkWluNoLZN4KbQz3CrSCJhKKJAe+gHmZ+MMRXATzjduMyKp5Mek7p6Ymsfl8 Gy+Zlvf0M9YEWZhdiB38SRgyNDYOdSCia/xM/6lY6K5jjjDwiRDNHNb9J8AZlvAni3GC bLaeABzLkSCfRCOivaG8JwZCyiXcVtxJ0HQH3QX2IgKtSDPsablx+idVWXWdLELXvHbX rNll/Q45LtkT2/rGPqCV0Pdmq1hs4efCdfji/x2MeL10vB0sV6qXKrdEi2B1w0y/JXv7 fk3GqSz6QMey/D/Cxi9ZjazaFV5WVbKHJlcdSO+eTQQhsy4hrITU8YxUorSoDVN4aiat 0Sbw== X-Forwarded-Encrypted: i=1; AJvYcCVfntsp7tet/HQJF5TxadSQgoXb2RSXgzGWA1lV1YHD2LcBMc5MVqo4qbJA6GTeABHrkvVCQhK0KQ==@kvack.org X-Gm-Message-State: AOJu0YyRRXhyUakCFYYWlrH7TCqHPeUEEpWaMjJpA5dezP6DxWumVlAR V7y3rimYpz0iji0OOr/vC4MXMHOgY+ZplkSJQmMAbPiTS2OuS+YRyckv4MW/aS/72r0IBNQ7Gmy E7SOU4SLn3xeN0XN3vGKKNa7yQc+LEt1a6LwaXYTk/N1JhhUs X-Received: by 2002:a5d:6712:0:b0:374:c0c9:d178 with SMTP id ffacd0b85a97d-378b0796583mr1906609f8f.9.1726060472178; Wed, 11 Sep 2024 06:14:32 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFADlyM7i81oTh6MMg5f4MdFZhfMAlSWiXsWWTdqomexRMLEC3vWgtq+M3/jWLI+l6a1OsmGQ== X-Received: by 2002:a5d:6712:0:b0:374:c0c9:d178 with SMTP id ffacd0b85a97d-378b0796583mr1906580f8f.9.1726060471435; Wed, 11 Sep 2024 06:14:31 -0700 (PDT) Received: from ?IPV6:2003:cb:c700:7e00:c672:608:5b3e:df8c? (p200300cbc7007e00c67206085b3edf8c.dip0.t-ipconnect.de. [2003:cb:c700:7e00:c672:608:5b3e:df8c]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-42caeb8b7f1sm143705455e9.48.2024.09.11.06.14.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 11 Sep 2024 06:14:30 -0700 (PDT) Message-ID: <1e722a8f-0d07-40d0-aa30-4ee43dff7951@redhat.com> Date: Wed, 11 Sep 2024 15:14:29 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 1/2] mm: Abstract THP allocation To: Dev Jain , akpm@linux-foundation.org, willy@infradead.org, kirill.shutemov@linux.intel.com Cc: ryan.roberts@arm.com, anshuman.khandual@arm.com, catalin.marinas@arm.com, cl@gentwo.org, vbabka@suse.cz, mhocko@suse.com, apopple@nvidia.com, dave.hansen@linux.intel.com, will@kernel.org, baohua@kernel.org, jack@suse.cz, mark.rutland@arm.com, hughd@google.com, aneesh.kumar@kernel.org, yang@os.amperecomputing.com, peterx@redhat.com, ioworker0@gmail.com, jglisse@google.com, wangkefeng.wang@huawei.com, ziy@nvidia.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org References: <20240911065600.1002644-1-dev.jain@arm.com> <20240911065600.1002644-2-dev.jain@arm.com> <8bc0e51b-0e9b-4eeb-997f-e2a0b1a0c0f8@arm.com> <62df853c-98fb-4900-9cc6-04208e9611c6@arm.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <62df853c-98fb-4900-9cc6-04208e9611c6@arm.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspam-User: X-Stat-Signature: h86iuzqagocwb4eu8wtfm9ecm6hxqjdw X-Rspamd-Queue-Id: 867958001A X-Rspamd-Server: rspam11 X-HE-Tag: 1726060475-882072 X-HE-Meta: U2FsdGVkX1/1IuUlpNd7NKIQkTOBNbRkcxMceVsW5OhaqJ+AfLisAceGgjOlxcHK6Rp8vPsp1eDf41R7CuuxSyU31T9Q0QKLFEZULjvPks9N5x3eh+aQyTd+//ICfk0+7couKmVN2uCLnbybCY/krwt9z7vGqZK0rwXn49YySVHO2zxlIFsv89OuEJ9Kgk7XXk8Kx0/3qCXhBlQAdVe4moo3TonGN6Eh2Q60D1lf6dgFP0P+lpg0Spv3GMyPXO7b/it4IOQTPybaggSKTH+Qw6xdq1P/zhRR4juELycPghmP1ZDkTrJxHi+mlYndBITJHJUlAV78tL94RcHf4AaABHN00xUvqellYio6jdD8Cdr8lymUeu2PVmt/jX+OUDXykV1oQFDokCC9x1nMnnyFw0C9Vvi+88VHCSSzRqo+dFYIYDP5n7UkU+bwMPb00zjEDpnUp9ZKQYFLbi3MFM1B9oMsyP4gvlKw0IcFUWLJ/5bCEUjeO1jo0hPBQN6NmXRNhSp00wnspGUUaa0esuW+GLDGZ1G2xqb9X48hcATH2+K26iJyrhpTNekcWlWKQtR2bYtK/M4bzr/Fk892QKroJRPAkn9LUp8R/9EhEcjqUZar0AjFKF9ZkJ4f5ocuhUkw3amQp/effMhKeMqMpXweqsrLzCsmMb5Rt0Nx/9918FPCf/c6vT3wnPkjPSzfoZEzwnACLEJ3FE0/u7qFkpKtAKnbxi4giPzoupmePeac7FOff9bIIVjErv6H/OhruNuXqFlKGkm4S8jrs7cx70lp9wX1c3nrY9VLorYnrCW1DYUxaAkakz94nVeiSUx6T7M33UPEOwxLq2GvN1L1W+buZeo3lAYzik9mrcwiO1uoHWzhjS6g1uyuHREUlHCK/FuZuTpy5kzgvXjf0b0lwGHp+RVO+JURvSPR8ZwqlMZVyabX/LOg4Q6UbPhvRtxbqNLkCuQkQy+rhValk2mQ3M2 UDbKznR2 YEVj3UG7s8j8MjemQHDpLx75P8RgMipsWbBjDVMtQbP7W3m9aYXnUx1AS/X3vF/swkOEP65TR4W7Mdueoz8a1KIaFTpmuNyvX9ImHxm1UYgbw8NpLHCrezOalu98i3tPulxASb4Pdjc/xcJXr8Dq6D2OCJwE3oL1Vl9WmQJhkKV1jc6qhOnc9/V6333I+xCGv7N//1COaaQECl6YUzPhoYSZ2vJ1vsZp/8UyeTCj4+Rdoy6o+6p4zMj6aLPAWYzygS89Y0zew4ayzrvFvURQdE6KmEIZaMC25zWKvnW6Zy4o4BHs5naWLfpq6Wd0RZRaLwI5i64oZErtqEQRsba9hchjXirwx9hRiOea1 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 11.09.24 15:05, Dev Jain wrote: > > On 9/11/24 18:30, David Hildenbrand wrote: >> On 11.09.24 14:53, Dev Jain wrote: >>> >>> On 9/11/24 14:57, David Hildenbrand wrote: >>>> On 11.09.24 08:55, Dev Jain wrote: >>>>> In preparation for the second patch, abstract away the THP allocation >>>>> logic present in the create_huge_pmd() path, which corresponds to the >>>>> faulting case when no page is present. >>>>> >>>>> There should be no functional change as a result of applying >>>>> this patch. >>>>> >>>> >>>> [...] >>>> >>>>> + >>>>> +static void map_pmd_thp(struct folio *folio, struct vm_fault *vmf, >>>>> +            struct vm_area_struct *vma, unsigned long haddr) >>>>> +{ >>>>> +    pmd_t entry; >>>>> + >>>>> +    entry = mk_huge_pmd(&folio->page, vma->vm_page_prot); >>>>> +    entry = maybe_pmd_mkwrite(pmd_mkdirty(entry), vma); >>>>> +    folio_add_new_anon_rmap(folio, vma, haddr, RMAP_EXCLUSIVE); >>>>> +    folio_add_lru_vma(folio, vma); >>>>> +    set_pmd_at(vma->vm_mm, haddr, vmf->pmd, entry); >>>>> +    update_mmu_cache_pmd(vma, vmf->address, vmf->pmd); >>>> >>>> It's quite weird to see a mixture of haddr and vmf->address, and >>>> likely this mixture is wrong or not not required. >>>> >>>> Looking at arc's update_mmu_cache_pmd() implementation, I cannot see >>>> how passing in the unaligned address would do the right thing. But >>>> maybe arc also doesn't trigger that code path ... who knows :) >>> >>> If I am reading correctly, arch/arc/mm/tlb.c: update_mmu_cache_pmd() >>> calls update_mmu_cache_range() which is already expecting an unaligned >>> address? But... >> >> So update_mmu_cache_pmd() calls >> >>     update_mmu_cache_range(NULL, vma, addr, &pte, HPAGE_PMD_NR); >> >> But update_mmu_cache_range() only aligns it *to page boundary*: >> >>     unsigned long vaddr = vaddr_unaligned & PAGE_MASK; > > Ah, totally missed that it was PAGE_MASK. Thanks. >> >> We obtain the correct hugepage-aligned physical address from the PTE >> >>     phys_addr_t paddr = pte_val(*ptep) & PAGE_MASK_PHYS; >> >> Then, we look at the offset in our folio >> >>     unsigned long offset = offset_in_folio(folio, paddr); >> >> And adjust both vaddr and paddr >> >>     paddr -= offset; >>     vaddr -= offset; >> >> To then use that combination with >> >>     __inv_icache_pages(paddr, vaddr, nr); >> >> If I am not wrong, getting a non-hugepage aligned vaddr messes up >> things here. But only regarding the icache I think. > > Looks like it... As we are adding a fresh page where there previously wasn't anything mapped (no icache invaldiation required?), and because most anon mappings are not executable, maybe that's why nobody notices so far. -- Cheers, David / dhildenb