From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D2846C77B7A for ; Wed, 7 Jun 2023 15:09:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4F589900007; Wed, 7 Jun 2023 11:09:48 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 43033900005; Wed, 7 Jun 2023 11:09:48 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2A93C900007; Wed, 7 Jun 2023 11:09:48 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 183E3900005 for ; Wed, 7 Jun 2023 11:09:48 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id C9BAD1C773C for ; Wed, 7 Jun 2023 15:09:47 +0000 (UTC) X-FDA: 80876286414.03.86EBADC Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by imf29.hostedemail.com (Postfix) with ESMTP id 14AF4120084 for ; Wed, 7 Jun 2023 15:09:16 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=TlA09rAX; spf=pass (imf29.hostedemail.com: domain of dave.hansen@intel.com designates 192.55.52.151 as permitted sender) smtp.mailfrom=dave.hansen@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1686150557; a=rsa-sha256; cv=none; b=yf2pOn5EfptZ4Nzvtf4H3S92RKu0d6aGpFou90T1R7g9PD857NzoNUSFjAou1S4Wl28XB2 vT5VXUl4As5HJFmTBzfBTzdzFKPYQtIKJ/k5stx3C1SmxxO8fd2JsIog2F3ygBcghBiJVl AF94UDk88Ju7jvqiW79EE8lN4Nn4KRU= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=TlA09rAX; spf=pass (imf29.hostedemail.com: domain of dave.hansen@intel.com designates 192.55.52.151 as permitted sender) smtp.mailfrom=dave.hansen@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1686150557; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=4/xucj685Se4gBbsQEPrRz3ldHSMxMdFZo78dqEYtjo=; b=bl6LEYI0mug60H6PnDDoIfp77wfRfVTe2VhPh9SBfLc3DxxzS96MjH8wq6S/YNEfTNSXkm ChpqElm2KXRhlXlu2lKUnSEZmJ6jYltt2bPQCNr1Ez80ZB9xpk9n1tT5y0mkhvZOCEHD7H JMrC9nskJ8iYHj+/WE/Jlo3LZlauy28= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1686150557; x=1717686557; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=dkmBvMVEaR9WNW+FaDgHJkj5zFLkk93xq/0IXE9EB+g=; b=TlA09rAXGHSHldZSiHKmFDQBlnbExP6qf/jsixv1kHhxnn1FEYtHmQqD e0GuVN8vQTEncnoTkdkv3f4RTPD9AsTnxUDti8LtgGzr4LJUWWHU3tnJM zGMWyAgDqX5dbnY6bwKq7r1JTXzwLDYvoqNm+7PHNMes7ds8W2HDmdcvf 0BwUGDLe3DsaalPU/5UIZ1Veq9EH7PM9RGX4CZXvGgCWobl017Vukrd1b WXUjb6JhH3woUySzO/w0iq8bQpOYfhljIChK5vS8ZhU9R8vHy0cBlXlN8 Xb4sq86D36MlpBdP7FuUS4OyVA0eNe3/vO6mnQ8gxxqc5bA2+GhCDZ9Id w==; X-IronPort-AV: E=McAfee;i="6600,9927,10734"; a="337376313" X-IronPort-AV: E=Sophos;i="6.00,224,1681196400"; d="scan'208";a="337376313" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Jun 2023 08:08:49 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10734"; a="687032427" X-IronPort-AV: E=Sophos;i="6.00,224,1681196400"; d="scan'208";a="687032427" Received: from vsmyers-mobl2.amr.corp.intel.com (HELO [10.212.146.233]) ([10.212.146.233]) by orsmga006-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Jun 2023 08:08:48 -0700 Message-ID: <1e58e3df-ae9a-607c-cfc3-4f3d033ed531@intel.com> Date: Wed, 7 Jun 2023 08:08:48 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH v11 06/20] x86/virt/tdx: Handle SEAMCALL running out of entropy error Content-Language: en-US To: Kai Huang , linux-kernel@vger.kernel.org, kvm@vger.kernel.org Cc: linux-mm@kvack.org, kirill.shutemov@linux.intel.com, tony.luck@intel.com, peterz@infradead.org, tglx@linutronix.de, seanjc@google.com, pbonzini@redhat.com, david@redhat.com, dan.j.williams@intel.com, rafael.j.wysocki@intel.com, ying.huang@intel.com, reinette.chatre@intel.com, len.brown@intel.com, ak@linux.intel.com, isaku.yamahata@intel.com, chao.gao@intel.com, sathyanarayanan.kuppuswamy@linux.intel.com, bagasdotme@gmail.com, sagis@google.com, imammedo@redhat.com References: <9b3582c9f3a81ae68b32d9997fcd20baecb63b9b.1685887183.git.kai.huang@intel.com> From: Dave Hansen In-Reply-To: <9b3582c9f3a81ae68b32d9997fcd20baecb63b9b.1685887183.git.kai.huang@intel.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 14AF4120084 X-Stat-Signature: a5yt6t1bigqqjor3pr4ixritrcufic61 X-Rspam-User: X-HE-Tag: 1686150556-608916 X-HE-Meta: U2FsdGVkX18j+DSuGzFaJ42chT3zSpF2z3wiyhSmL6Wh1x8eJF4QRS/9x4yY0I3zUuB7gBOCcVbEqHPVSWmarn0IW5W3bw+wofK2LFai4Q4I5y8WCKd4tPVWqfDZhNsyoOL+IciRpOiVixROfMVKqYQoPgE1mbDeuh2PtfzBLBo4yxXjzV4nTHHDvpCuB3jJ8kOn/K1oQl16cju953AGNOqk9+5RotPchwUIITgjEx4rcIygJqLkn5sDO8vohNrmcAvIu7p78/PFJEjnKAhwIfSZPMV9iNAOMlnKy05aRlZMuYL6mws5rT/qLgJsa9+sf4jkxK5U91iHiNx7rjJVdAYqtjigPWQjwz7nZisu1JSzm6q2u9kYEDG//nNZNoSOWP52wL4b5sX1Z1aYMwVW4J2d9NQBiYkl/b2xS7EyAyfKpYGuRLwZJMmo5EvwGbDwXhDVoFEHZIUn4nqgX+aeSc1tOgowM1scUVnHwWG6ZSFWtG8kYeKtNGLlhuca9Z2kqmrw3ZltGwTDzmOWd/BdlBcA0oT6McbQ8MqM0gCRI0Aa/5t9yGwrAtTdcsL2oCAj/RRbuJOZGCdnNfpL1MyjVw95jPhVDMM4mQAJX3XodX0LdxeblA9NtG27GhTiEINZz70Zz0kdGoUf/BOQxun+yOGW3n2jbw7yn9N/AT1meRpAJySua1Ya9v1Vwt+nPBbisEFUrlcwOh60jhiWv7M/nCRWaHJ3ea9JrZfhCurt5+SSCL1pT2I847eWwVyAbOuWk/tjs5E+EtfAPzQpa6iZc+ARR877gb8ZVBLqOS2cHnJaFCkFbiHIFJBZzUujH+VpN6zEbQ17Qd38jCSihr3dlf/qnoz09aEgOwLvNZv5TMFH2PvU3jlY3sveqB353PNwuXMQhwQ5MveZ3y4DWiRUijgVrKKPbgyEJhxTWLXDJ3XWLH3738xtVazZa1SuR3MhS3cZGa00YtYdxC67PFc W7fOB9s0 bON4Xd5Dn6GFOXp/7bHVPhEWqJAAR5yi1iUHGDh9QpTEwp9clFMVUXQ9PUgGo9U0g9AErZhqYzqEre6OTknqIMoh64lCIHBmdEUE8OFVaUaZ2dre3y8IbpVyPAh49MCjPQwEj5Zt7dRMv3HpPn4gvqxgAotwSMj+9FjwSeIWrEjbnKAs= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000032, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 6/4/23 07:27, Kai Huang wrote: > Certain SEAMCALL leaf functions may return error due to running out of > entropy, in which case the SEAMCALL should be retried as suggested by > the TDX spec. > > Handle this case in SEAMCALL common function. Mimic the existing > rdrand_long() to retry RDRAND_RETRY_LOOPS times. ... because who are we kidding? When the TDX module says it doesn't have enough entropy it means rdrand. Reviewed-by: Dave Hansen