From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 72E4AC3ABD8 for ; Fri, 16 May 2025 14:54:59 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3DED96B0191; Fri, 16 May 2025 10:54:57 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3B5686B0192; Fri, 16 May 2025 10:54:57 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 255756B0193; Fri, 16 May 2025 10:54:57 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 056C86B0191 for ; Fri, 16 May 2025 10:54:56 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 358C08088F for ; Fri, 16 May 2025 14:54:58 +0000 (UTC) X-FDA: 83449068276.01.EC7ADFA Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf01.hostedemail.com (Postfix) with ESMTP id 9024040014 for ; Fri, 16 May 2025 14:54:55 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=SEU7Gbn2; spf=pass (imf01.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=SEU7Gbn2; spf=pass (imf01.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1747407295; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=LD4o5M1xb49Wzg+l8iYWhHX8QQJZuE63lxcgIPd7AkI=; b=YybGRHHDXep7wEozO4s00/74bL1B3gFFtf5GtQbUIWPRZ7Af7eWs+Ab8BAfpytV+wEGXgw 1kuJhJC0wAIQoHSUgnh9DM2eRpvyNZAIe9YVj1Vy/I2nyub2CPGKy4EMu/05czRbiOA8oM DIPcVw9hMhndnReYCHEv0pf9dyLmxIc= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1747407295; a=rsa-sha256; cv=none; b=TnKH+iw7n+z/kRMnZt8Lw5cEWUzZNkwHF5IaDI9bHC4iSuN3XuaQXQOIEDKw9WZl6eL2Ac /P+LiUfhiiBTxojzw3iD6cOfENdzx7j0iO5mnSunQbEKclTS/XG1ThGfAxADq+zOh3b4b8 I9qlBmbGacmVqeH02aLiWQNufbR1qVg= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1747407295; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=LD4o5M1xb49Wzg+l8iYWhHX8QQJZuE63lxcgIPd7AkI=; b=SEU7Gbn283jZLjiKwRAEdaMG2RZuz7FsqW15RdAuo6xYEv8Ig1rPh9d8SbQz4bm0UoZ0xy hGpWOnS/g5cCtEmBmbrV6Z9t51WKF9+E3Yop5yzsi+X6BOXix/zWU+J6rAM9A/5gdLMEH3 7iUkuWxEwQ1cM137Vk/KDw4kAr5fvWg= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-581-Uwff5ID4Ouiqs2XG4IuiIg-1; Fri, 16 May 2025 10:54:53 -0400 X-MC-Unique: Uwff5ID4Ouiqs2XG4IuiIg-1 X-Mimecast-MFC-AGG-ID: Uwff5ID4Ouiqs2XG4IuiIg_1747407293 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-43ceeaf1524so12956695e9.1 for ; Fri, 16 May 2025 07:54:53 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1747407292; x=1748012092; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=LD4o5M1xb49Wzg+l8iYWhHX8QQJZuE63lxcgIPd7AkI=; b=iJw7h0+ZC59x5fEHjVEJx44FVPp4UvzQuuT/T55CLivA50pGHIsi0h3TDhKwU6r95E VPgHUpkxheXBklj5kMaXwuzjPIyGUXixeuN2lKE8IB941OptG3QUhECMcdeWtIzAbLWp 7MSAJQuouT6uOlUJlHNxm81Xa6sBRMu+7zpVcE5uVA0Csblj52+PDFoqZI15z1e0v19t j5iUV9br+rHZ4WtBFobEvB0dvXLnFGyzntqjJolEkVFr0Z4TZmc+9lOcYNS1woiVuSn4 QwXY/8IbRmeFqVHqWVLeGnfOxg5nHReTxnbglEQFW/3Lqz8JSYvNBojzZcAdCxhTlzx2 OQTQ== X-Forwarded-Encrypted: i=1; AJvYcCVDUVOOIznJ6qQW1wCVkpTCKGJfKNZWLyOWcpoBUxQ/GukH1MWVsMhhLVRgeqMwV9DtYkgoGaZobQ==@kvack.org X-Gm-Message-State: AOJu0YxKuMDib7Lexlo9wxvZKgUmSLSUmo5LS2LeYBTXh++htaEE6z9t Pq3+ymkBSSCO0g/tG/TinV64gZ3u2+ydOQ1HzC14Q5DGmBRKFP2HhDmyv3aIIa17u2JTygkSmpB FNl8ep8aeNHaIAujm7UrXz8+AUcjWPDj+aP55Y3m3QGw1Oa8Gkmeh X-Gm-Gg: ASbGncumkXm6koX1sKVG4S3RrVL0ok20vZNtjzRiIwNULYKlVTmidAHgBtpOSlfefsK jvcV5ql7/gTc36vrn+k3uuTX+w+ckMRRckU8aVOp/6pqmIlQ87Oo7o8o9fW32SHtpQSqgxIEDIj miPhrbA+omkjs/1WP1uQ5TIDQq282OwUH0TPk0LPjCv/aiJbNzyDyVN6XTGcfc4+P/lx0O1jfr7 cderuXpqaCMA+DhPenVr2w7iqcKzXBs89iCRELmtYb9gKjA+mah84xufjNdkWvYvAMSrXd9lBoq Y1OQLieXFm1XeOmprL5pu60Obu1gH69SPbP/5s6MuvU1Fd+qZJN0IJms5aALGxNp+GRrMsR21eL IkL3NkcRg5esd46KQ8dBgxGuhVRQgBHNwrdgkpDE= X-Received: by 2002:a05:600c:ccd:b0:43b:c7f0:6173 with SMTP id 5b1f17b1804b1-442fd93ce92mr37193285e9.4.1747407292678; Fri, 16 May 2025 07:54:52 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHq5Gdy3Qhjo8HXYvMMt4++cpmafTe237v1vk7ja2/lEEeZn4qAZfPbeL+gGW5mKrjS9TsanQ== X-Received: by 2002:a05:600c:ccd:b0:43b:c7f0:6173 with SMTP id 5b1f17b1804b1-442fd93ce92mr37192955e9.4.1747407292284; Fri, 16 May 2025 07:54:52 -0700 (PDT) Received: from ?IPV6:2003:d8:2f47:4700:e6f9:f453:9ece:7602? (p200300d82f474700e6f9f4539ece7602.dip0.t-ipconnect.de. [2003:d8:2f47:4700:e6f9:f453:9ece:7602]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-442fd50ee03sm36155655e9.14.2025.05.16.07.54.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 16 May 2025 07:54:51 -0700 (PDT) Message-ID: <1e571419-9709-4898-9349-3d2eef0f8709@redhat.com> Date: Fri, 16 May 2025 16:54:50 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC 1/3] mm: add large zero page for efficient zeroing of larger segments To: "Pankaj Raghav (Samsung)" Cc: Pankaj Raghav , "Darrick J . Wong" , hch@lst.de, willy@infradead.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, mcgrof@kernel.org, gost.dev@samsung.com, Andrew Morton References: <20250516101054.676046-1-p.raghav@samsung.com> <20250516101054.676046-2-p.raghav@samsung.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: -pKqTgWnXfYHCSprlww5Z1xmNkv9EHKqpRfJnkiAX5I_1747407293 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 9024040014 X-Stat-Signature: t5x5gnzr9bdtrusrqhkkf91nz96pgztt X-Rspam-User: X-HE-Tag: 1747407295-62274 X-HE-Meta: U2FsdGVkX18P8Y1mfF6kuZ1zfy59GgKi6C/hfrV0Rb29iICiqjkJaMoKLOKRQ8o3R7fIzVnEgi0ab6eQSa6rv9s36Get8hcKrv/hnEeAp0ZL9JltgmgJkPNro0Aqm1SecCVT8Z6WOuKfJtn5k5jMIOTBak05/rBVinVmKS3bqia7eDvdSPAURlJRwlS1wU4bsGpe9/m8Ep4qVbSBQE7mTeEn0RxGq059ZBKTMNTX6fuQpZ4BRRGe3EpXh32zAhMEbs3fgjFS8WqXdBiAHFsY1R7Wxmo0EgAbDjxfUVlo0lwCNmQZnuYZadqm/olSt9+irMdIDii6REX/C32Mvvzapc0RIBY0gQwVY6bbXtqn4AQ2eXGqLqejoNjGiTtDAEnsU3vj4N6MgqwlujPyRgZ5BpBh8DrToPyC8mGIAARZbAluga8OloyYwFHGd7l/0wx4wFR4n52tOKa1+oZ89P1qxa+4/voYcfGwMclh4z5PjhsGYpoTKiid/7MpFHL2NSrJLPa5sjB7giiXZUoG/HJeYvIhDt1Sqt+1dnuH3lK/mpxJBPxGUUl9bw5WJg4gVGBieJInQhmwuHYwJPXqWjBckdushuEovmDlF+oMCCZGKzLodg/bA1QRgu8diD6Dur5KHPpPz/WtmnuJAHa+aWmKTHdZ8plHazRrjCJWJmRhi0GtYuc9BYtE204Y7W1xu4XGap0ALPPdD0vr5v/z1Hi5Tyn6LkCpcAgH+Nn4G3SiWOPNOco545X2fgvASku9Kdfe9vQZq+FBjR5+1j3r6dTecO/yilhsWM5eVSi+XQ6H1Po3bRYePzAHoG2nE51pxKUjpVVDECie5rg2WJnN8wF85cH8tQN89vg/TTS3V6/5JFZVEOnBMFhnlNpCAGgLQwQhkLh5Pn2Mgqd1wtDA+j+4uXVOKDodixOJlRLDzlhXfc/F+bkpc71pAyNBUwdH6bNpRunTWa4OJmm3GDojFfP 7ADGbgHL WI+J+K24Vanewg/3lqCOg/8C4GgQXaw93emdNX20njV/OPU+ekTImkVnxkAus2IZIWCS2rmdymuY1Lqh8l3OsWBjBv1m54EgfIR6bY2Nc7YifCeWj/fgL8IC++3+OI2zjroXN6ogTBREB9aP9I9WPUWRsiqXUajReyQMSQOYDv0tKmTHZsxrvcWTwWqSHXJbFC8ytURU0VsISkpXvb5oiNZSnDEDAFn1/8ytBjdxDm+6bPdfEEBL22AUptn0NIs3QzR5B0zW4dB94wyX7DGwP3kbF+44QPszaYbzZy5a+k8rChNRFPToGSbEd0el352tcUEUjFsGXXKktL8wm22fSP4Y3Lex4J3NBDxs5kdrH7j+fpgh8U5EGZj2YOnHljSWoJKUVPRLgEg81NNF6E3YdBVIcbQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 16.05.25 15:03, Pankaj Raghav (Samsung) wrote: > On Fri, May 16, 2025 at 02:21:04PM +0200, David Hildenbrand wrote: >> On 16.05.25 12:10, Pankaj Raghav wrote: >>> Introduce LARGE_ZERO_PAGE of size 2M as an alternative to ZERO_PAGE of >>> size PAGE_SIZE. >>> >>> There are many places in the kernel where we need to zeroout larger >>> chunks but the maximum segment we can zeroout at a time is limited by >>> PAGE_SIZE. >>> >>> This is especially annoying in block devices and filesystems where we >>> attach multiple ZERO_PAGEs to the bio in different bvecs. With multipage >>> bvec support in block layer, it is much more efficient to send out >>> larger zero pages as a part of single bvec. >>> >>> While there are other options such as huge_zero_page, they can fail >>> based on the system memory pressure requiring a fallback to ZERO_PAGE[3]. >> >> Instead of adding another one, why not have a config option that will always >> allocate the huge zeropage, and never free it? >> >> I mean, the whole thing about dynamically allocating/freeing it was for >> memory-constrained systems. For large systems, we just don't care. > > That sounds like a good idea. I was just worried about wasting too much > memory with a huge page in systems with 64k page size. But it can always be > disabled by putting it behind a config. Exactly. If the huge zero page is larger than 2M, we probably don't want it in any case. On arm64k it could be 512 of MiBs. Full of zeroes. I'm wondering why nobody ever complained about that before, and I don't see anything immediate that would disable the huge zero page in such environments. Well, we can just leave that as it is. In any case, the idea would be to have a Kconfig where we statically allocate the huge zero page and disable all the refcounting / shrinking. Then, we can make this Kconfig specific to sane environments (e.g., 4 KiB page size). From other MM code, we can then simply reuse that single huge zero page. > > Thanks, David. I will wait to see what others think but what you > suggested sounds like a good idea on how to proceed. In particular, it wouldn't be arch specific, and we wouldn't waste on x86 2x 2MB for storing zeroes ... -- Cheers, David / dhildenb