From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 755D6C87FD2 for ; Thu, 29 Aug 2024 18:43:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 154326B00B1; Thu, 29 Aug 2024 14:43:30 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 104406B00C2; Thu, 29 Aug 2024 14:43:30 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F35286B00BE; Thu, 29 Aug 2024 14:43:29 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id D54A16B00C2 for ; Thu, 29 Aug 2024 14:43:29 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 7957E1C5FB6 for ; Thu, 29 Aug 2024 18:43:29 +0000 (UTC) X-FDA: 82506156138.22.784371E Received: from mail-4316.protonmail.ch (mail-4316.protonmail.ch [185.70.43.16]) by imf02.hostedemail.com (Postfix) with ESMTP id B50CD80011 for ; Thu, 29 Aug 2024 18:43:27 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=proton.me header.s=protonmail header.b=j1+mGw1p; dmarc=pass (policy=quarantine) header.from=proton.me; spf=pass (imf02.hostedemail.com: domain of benno.lossin@proton.me designates 185.70.43.16 as permitted sender) smtp.mailfrom=benno.lossin@proton.me ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1724956908; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=PrOIXUmPfGYqq2ocopMHRuco9LPY6PWH9M8dhHPmIts=; b=mVBO5Bn8MjmVbpQuekgmBSnjQGZk3+e9rbHMo52cNShGXZRBSXOkFe3XE8bUSVCHQSayM/ nsqlcwqCXG04XLPxNWlAKtSRBy5mrrbyRBNokbhXdbvkhrGc+B7BA1M9nwEhlZTQeS6hHZ A1OQVtHvBIgOhkHsUg+YJZmOezAqpDg= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1724956908; a=rsa-sha256; cv=none; b=q8WzlR73/eb16IhPE+kRxvcHUafDGwEwjj0L7C/eFICrafWCuY5xSD+6FUFXyJi8MtzULx pIiz0OjShXUfp9f/EjUBe9K1JG/JuDpscHpqHq+KwlNldpKsLuz7ZTHmFJ6YHz+Nn1riV0 tAtOc0MvczXHTlQ59X3SNCH6PxZUAxY= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=proton.me header.s=protonmail header.b=j1+mGw1p; dmarc=pass (policy=quarantine) header.from=proton.me; spf=pass (imf02.hostedemail.com: domain of benno.lossin@proton.me designates 185.70.43.16 as permitted sender) smtp.mailfrom=benno.lossin@proton.me DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=proton.me; s=protonmail; t=1724957005; x=1725216205; bh=PrOIXUmPfGYqq2ocopMHRuco9LPY6PWH9M8dhHPmIts=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector; b=j1+mGw1pPF4UxjdWVxpIsSVII1MPS73G2KyaNUae/ktsbUVLOVOxfW7h333MmzjSN S4Bj0GTw4F4FU2t6uTa/tW2o8+ePc9v/scJybd29px4EMfKNADnEYoT0Q+HXi+g/aP GuJmMs2dlDX0tm09MkS2/tCFjUybkZRu2VnUR6uylydH+D2vG3YfHH1+PiRdHYTrHA PQSPSxUFza/b4RdcSoJ49PDlGJkC2CaUn1VjVaxBPPM4uD6h+SV3EDJgFRxJlPU4jj L7w+Djw5CcBl1Hs64XXDfLK9VvL8D34Dx6HEGmNqXYgtVAcMWJNWBK5fhWVYPzJbec 4cxrwtu3pGfrg== Date: Thu, 29 Aug 2024 18:43:20 +0000 To: Danilo Krummrich , ojeda@kernel.org, alex.gaynor@gmail.com, wedsonaf@gmail.com, boqun.feng@gmail.com, gary@garyguo.net, bjorn3_gh@protonmail.com, a.hindborg@samsung.com, aliceryhl@google.com, akpm@linux-foundation.org From: Benno Lossin Cc: daniel.almeida@collabora.com, faith.ekstrand@collabora.com, boris.brezillon@collabora.com, lina@asahilina.net, mcanal@igalia.com, zhiw@nvidia.com, cjia@nvidia.com, jhubbard@nvidia.com, airlied@redhat.com, ajanulgu@redhat.com, lyude@redhat.com, linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH v6 23/26] rust: str: test: replace `alloc::format` Message-ID: <1e36b27c-fea6-44a1-9956-14916e5cd3f9@proton.me> In-Reply-To: <20240816001216.26575-24-dakr@kernel.org> References: <20240816001216.26575-1-dakr@kernel.org> <20240816001216.26575-24-dakr@kernel.org> Feedback-ID: 71780778:user:proton X-Pm-Message-ID: 63d698293bc76c54053ea8df5e5851aebf3e9acb MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: B50CD80011 X-Stat-Signature: n4pmzbbj57zhn5atb4tzj9grga1jjrdt X-Rspam-User: X-HE-Tag: 1724957007-421055 X-HE-Meta: U2FsdGVkX1/aAronMOQBV2XAovPoP7dE+wXT7CKdUQ3LPQyrH06+n9VTqo/TdsmGCbZmMZYY05HhhxCEFQRfI8uzUIRaXcGplsL3nSXIeV0/s5tzNassTduOrQCdmwsbfamJ+VLHaqQ3zMVQNZ6iIkx9Le55NvcvQliyjlHQu45T9kv+0+1lmpgKRJBRkKU/3H81l+/NMIxXLkiCpD2XOkEVTgj1WoOdGEOTS5kVvLUceYUiob21u9SaJGq280Q4DXtSavJGHoQimXd9cDeXIZ0tDHaTPf9IKC5Or7MM+9c6PZ2eCNyL7u9pJ0iOA4DMjucdK2HUH+s000dE6rY3SvQ92YbtKsmvNY3Kg7bB4lBGIgiAkkCAbQ/XyI2zE384NenbUltMKSeIXddgIwwgI2LEc1Xd3SQ2HsUw9RVyrcFHMUQwx9bQiB4Hv+Ly9wD3rurlURNSey6LOiAlH7644ZMnIhX61EpEIiuNLMikYBXftkw1aSrsMutSkx7coN7V7RmA5WaY3E8Cz0EwxGzSq+YF4g7ChVV18UulZSxTA65sJmmwodBDxvdnQBnrMm4rFiSfUCvKyZIOTT6R6wn2gvyBHh1SD/wrI5XK75yJW5IkIYbU1RCqaFQ6DDFHRL2He4eRtEBuKngKxVm/nR09n8LddyH05dsw+kg4KX7FFQiI4SZWvYxp8slJWdzSYxq48gsplYqjBMM0kxe8JvVRtSpc6qsrAfeUyZD78CFbzolIByR01lEdQMamPMiqXtGYQRATVnCoL21hMnc8Yyzrqr2B0B4VIsAh47lS6Ts+8wSPImXgrVNNWeKGUw6veBOiKO0i8uXSYuS4ZNbBHiu/JaCq+gUZSsfFr36TtTgD0seP+I7l6IqQe4t9c3kv6n/gaaIHbCHzetV2psPbO5J5m32M9q3EtACHmwtjhQiHQ1Irh+JPr9xUncIqvKRKO80CVhrt51wxAVbs2yb/zkp YRjj4crg FUVYPGwJc8AGcpfYMGRxRAOEUPfhG8gN1oJx1SI2NmBDrzHCjG6Muevp+Csn0RT8OAibcvEHvWjWjev8oH6QWEwrn2OQIJ70FmODdErFToLH+hupfJ12Ypss7gFwCa94M3/UFX3VYXULFiUnUXorDDxDMB67updOIIF7nZocSZnnLL/q2FRyqLOIilfhv0i8M2XIQ1bNSjXjdQK4xFQNpfpB6nRoRYSqckdzH4yX4tvfbdnOXHKJtTrfn4P/96wOd/bgMgBDiR1N5l5V/GP9BWJ1kMOStEjekyd2+rJNYFarBukXQoeclETQyais4AlPc61AAOQCn7rTOjf+vu+nf30VvBLyjpQxnT83TI4eK0wL/sl9SoncH8WDUNBS4qjBPIcaN7ot+84u1AE40Yhub1yO0+zO9URZkc6SR6tRCclmY4+g= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 16.08.24 02:11, Danilo Krummrich wrote: > The current implementation of tests in str.rs use `format!` to format > strings for comparison, which, internally, creates a new `String`. >=20 > In order to prepare for getting rid of Rust's alloc crate, we have to > cut this dependency. Instead, implement `format!` for `CString`. >=20 > Note that for userspace tests, `Kmalloc`, which is backing `CString`'s > memory, is just a type alias to `Cmalloc`. >=20 > Reviewed-by: Alice Ryhl > Signed-off-by: Danilo Krummrich Reviewed-by: Benno Lossin --- Cheers, Benno > --- > rust/kernel/str.rs | 23 ++++++++++++++++++++++- > 1 file changed, 22 insertions(+), 1 deletion(-) >=20 > diff --git a/rust/kernel/str.rs b/rust/kernel/str.rs > index 209ad1bb1a49..726329530338 100644 > --- a/rust/kernel/str.rs > +++ b/rust/kernel/str.rs > @@ -523,7 +523,28 @@ macro_rules! c_str { > #[cfg(test)] > mod tests { > use super::*; > - use alloc::format; > + > + struct String(CString); > + > + impl String { > + fn from_fmt(args: fmt::Arguments<'_>) -> Self { > + String(CString::try_from_fmt(args).unwrap()) > + } > + } > + > + impl Deref for String { > + type Target =3D str; > + > + fn deref(&self) -> &str { > + self.0.to_str().unwrap() > + } > + } > + > + macro_rules! format { > + ($($f:tt)*) =3D> ({ > + &*String::from_fmt(kernel::fmt!($($f)*)) > + }) > + } >=20 > const ALL_ASCII_CHARS: &'static str =3D > "\\x01\\x02\\x03\\x04\\x05\\x06\\x07\\x08\\x09\\x0a\\x0b\\x0c\\x= 0d\\x0e\\x0f\ > -- > 2.46.0 >=20