From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DC4BFC4332F for ; Tue, 12 Dec 2023 16:49:51 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 705EC6B009D; Tue, 12 Dec 2023 11:49:51 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 6B6946B02D5; Tue, 12 Dec 2023 11:49:51 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 557326B015D; Tue, 12 Dec 2023 11:49:51 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 4466A6B030B for ; Tue, 12 Dec 2023 11:49:51 -0500 (EST) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 18D8B40A63 for ; Tue, 12 Dec 2023 16:49:51 +0000 (UTC) X-FDA: 81558752982.22.4795D27 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf24.hostedemail.com (Postfix) with ESMTP id CD470180013 for ; Tue, 12 Dec 2023 16:49:48 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=i6XeMFoy; spf=pass (imf24.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1702399788; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=U31blXLuv1FscQFhYlnv8QDpXhDfT7lrRPJT7d/kyes=; b=nXdZoKiRwfiIJ1gqVD4yh/+x84xSSmzeht5r8HuQt8zF1p8nZDGLS6QmrHtEwwCbKQQVQr va7yiULGEcBnWvBBAfJkWlI39//Ws9H/NWsImY3yKzzEbrzltSqgJ0OHy+3w4Q0aEo44Yp sV4xOvjbs3znSDqSkAUnfDijL39u+nI= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1702399788; a=rsa-sha256; cv=none; b=NT/VKQPZ5bpVnyLXFPmvO8NCZXUO8YM+eUYNTjT4R7aDaQK4O3nVhdznBt9ArCqw9ODTnd +FE7GdIYlWj5iloKoBjla8tP99oDccRM99SgQZr1l4NBdn4XdNg4GVbOgFSR6C3fSUFHIF G4CA9/SkBlfO8wUOJ8KXuCAdOq6XuWY= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=i6XeMFoy; spf=pass (imf24.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1702399788; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=U31blXLuv1FscQFhYlnv8QDpXhDfT7lrRPJT7d/kyes=; b=i6XeMFoycnqAOfqNgVK2WYiSSl4I3ZGz7YFDBLo6M1voRW3DtuDz98Auh42S1BsbbS+ZVv OOgNnXrXPra6RS+e0Sr8zNRaFBdFwG15dYWNCZQRK+2sDDr+YrGAd7vvAeF+x3Yodwftwr mDYv2k5M/ku/qmLqKZYs4W/0HueqD14= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-665-1NBon8UCNkmOmohpqodBxw-1; Tue, 12 Dec 2023 11:49:45 -0500 X-MC-Unique: 1NBon8UCNkmOmohpqodBxw-1 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-33342e25313so5118666f8f.3 for ; Tue, 12 Dec 2023 08:49:44 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702399784; x=1703004584; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=U31blXLuv1FscQFhYlnv8QDpXhDfT7lrRPJT7d/kyes=; b=btyTftqd0NpbwIUOrGT72CGhyX7KKyFowUvp1tQWgIhTikmRger+YdcmSWMnU9S1X1 MYfLiGGY4/5BGD4NYOF5bBYCvlhm+Akmy3zchi8HvHuu0ber7QtcYROBj/YWtC92I7qD CagRDP/EL2TXDPwogDKLRuvR3ioCV5gJkt0SZQAbod092fqJv+Pk4SiGbWYHab08+LIG c0rsLbGB4ZNSyI/I1BDewy49aUJx2be2qACL/apNRSJx/4UIXvlVBnu2nVFoBuCFZt5c oe8lH4Km/A0WwJt6NAL1aEeFezgvMQFDrQMfIkL/KNqQPheK0/Sx93WEnEhN4eZE9Bcg cSnQ== X-Gm-Message-State: AOJu0YxcKRA7/Szr0Y24M8ZEppUu8E5QJk7j/CrTOJz8JMm52DXnOHYV WBwtK/hZrr23w3R5aAagJwYZLghuRcc9KRtOgjK0ZMxvA/ef5f+bJgpUdEhkQ3O66dEjS6V2a/d b75HJiFjMVv8= X-Received: by 2002:a05:6000:180e:b0:332:fce8:4c49 with SMTP id m14-20020a056000180e00b00332fce84c49mr3659279wrh.20.1702399783538; Tue, 12 Dec 2023 08:49:43 -0800 (PST) X-Google-Smtp-Source: AGHT+IHklSrdZraJ8sTBv1OcYKQEf17DmaYccmJ5C68nFc571nvlDbnYtZKhFIBuN6EvedSfge2kZw== X-Received: by 2002:a05:6000:180e:b0:332:fce8:4c49 with SMTP id m14-20020a056000180e00b00332fce84c49mr3659275wrh.20.1702399783153; Tue, 12 Dec 2023 08:49:43 -0800 (PST) Received: from ?IPV6:2003:cb:c74b:ca00:4ca2:ff2c:9092:f070? (p200300cbc74bca004ca2ff2c9092f070.dip0.t-ipconnect.de. [2003:cb:c74b:ca00:4ca2:ff2c:9092:f070]) by smtp.gmail.com with ESMTPSA id u10-20020a5d434a000000b0033342338a24sm11335286wrr.6.2023.12.12.08.49.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 12 Dec 2023 08:49:42 -0800 (PST) Message-ID: <1e234787-f9fb-413b-b6fc-09e08a2f1a4f@redhat.com> Date: Tue, 12 Dec 2023 17:49:42 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm: Remove PageAnonExclusive assertions in unuse_pte() To: "Matthew Wilcox (Oracle)" , Andrew Morton Cc: linux-mm@kvack.org References: <20231212164813.2540119-1-willy@infradead.org> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20231212164813.2540119-1-willy@infradead.org> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Stat-Signature: 9ja6hkrrp3phqdo7ojhckwy1rqays1zh X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: CD470180013 X-Rspam-User: X-HE-Tag: 1702399788-323011 X-HE-Meta: U2FsdGVkX18tZIF9f6oGgkzVaZQUq0mB/ycKQ9VTBEOFZZCzzPHrRmkJU7TRpFky6GFIi8oYQNycC9VKOoaczA25m5oIOqRtVBR+rr4oCZZlHp9hbtBkco4CL3CgLe6sYUPnO2t8tSHs02IDjDWi53PSPqYLB8DrbL2ozmkZQEcgWxwza8/k0lQ4VM2D+QkWRxYfwyziLQPdWe9uECdTOIKZkYWjz4sS1Ugcuq6brLPXky5r9smL2wiKpGCcwzGSFVpQUalhTL+IbQ0jStCAZqEAKxwkS4/Jgsn2jJSFQI0CihogpLe8B6ESk9IVfMUPgNErGL55+XZniMBSzg5J+O9EbGgeXs+2es9eZabzRDiKoiiuhliJ360tu53zQmp20VwXDu4xaua+2FvK46qKfsGt6awQIEr0lH1WLZamGA5kFh20Au8t4LPnGTLVQSpzJ4MFmoxEZYVsRGskX17Cj/SPRFbHyIdD5e//G8TOHuFQJxlD+RJBxad9KVr8LkqvdiSrssP+A1oOVScW/2NdhzDdTUtIw/fToIJ1nv6e9pvMJmkXEhjV/JIp00COUUNfYmwEnqM/IcqrpCw/XtcUsMdSun2s6tJWYFxmy4KQchTHxtOtrLb7lI7DvGS3DiZk2I4DlnDI9wv1qsjOdCJCxWhyURSuyL7tiFqktj1Yoa1CsxbxmwbDKS2iUqm5ULBfhGbFT1qremIyxC0nZI8ICWs4jkFRJutrdgkHbWDnsjBkFcLWQDGYM1n8b7GbDYln71bZNtxNfUdPnypxJm5nnmaKZI/nbLKA+Xn1e67/rt7i7R8z+bD0qAPxxHJPmwau1Y8hwu9rNFQDAB3aeFVciaQAz7syd20EzvQuqaoqjQpa7oc/gEtRGN3E4MgabcnGKNYYSIqrAEjEh8A4cdDEq+N+b0PF6zk/9lABleW5dhbamkvHzG5lywM/BPirugdTru7U8snMNpWTZ7nCY1K FUYUzgXy eZ5oTT9Y61GZiiW+7ia2X2S5nxAj/ZFJnDRbhFUbhsFKXj9g+sOM0VcQqQtPxvFcsSszkUzOqH82JlXUQL06rvPZ+855G/bFiK7YaH7BJQs5iNJzzBWKvooqry2qyuhO78IZ5ypwlOCRXu/h8KRoU8jc8LXOjZ+VcZ/2Kf0ep/i8+l6hns7pzwpECU5aDazPNsakm6oJOWET+occa7KnRS6MLRuyKSNRfb3SywVcCW4yFPTpJdKsXZKIhIGr78mmeR+rEyapzDiEEzAn7OMWx7Uq6el7xnDDXi+F1SLrYYzyV7d6EYIqUAiJ0xxopnj0M8I/BkdN++rvFmteT+CLnuucAVV6690JOw7CfPHcZ2MwbMSTAGICHReq4ectUNA+SVoPZnj3nGyfCB/7my0Yw0QfAvB3UlBaNwdxR4hoUxwnoLdknU1vkx9B4Q3Z5qEa81zZ2mzprlZbiz5pdV5a8fpLYX3KBNqWYiCoTT4b+1TmTymbZh50F3HKgbpBiAhdEEyGgohQA/LkB9WGLX25WiZ1M6/kGlBkmuIT7LxwYnqruX58= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 12.12.23 17:48, Matthew Wilcox (Oracle) wrote: > The page in question is either freshly allocated or known to be in > the swap cache; these assertions are not particularly useful. > They fortunately never triggered, so it's all stable no. > Signed-off-by: Matthew Wilcox (Oracle) > --- > mm/swapfile.c | 4 ---- > 1 file changed, 4 deletions(-) > > diff --git a/mm/swapfile.c b/mm/swapfile.c > index 0371b7b3cd27..85f9c355cb99 100644 > --- a/mm/swapfile.c > +++ b/mm/swapfile.c > @@ -1788,10 +1788,6 @@ static int unuse_pte(struct vm_area_struct *vma, pmd_t *pmd, > */ > arch_swap_restore(entry, page_folio(page)); > > - /* See do_swap_page() */ > - BUG_ON(!PageAnon(page) && PageMappedToDisk(page)); > - BUG_ON(PageAnon(page) && PageAnonExclusive(page)); > - > dec_mm_counter(vma->vm_mm, MM_SWAPENTS); > inc_mm_counter(vma->vm_mm, MM_ANONPAGES); > get_page(page); Reviewed-by: David Hildenbrand -- Cheers, David / dhildenb