From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C9E7DC74A5B for ; Thu, 23 Mar 2023 22:12:25 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6BE406B0071; Thu, 23 Mar 2023 18:12:25 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 66EFA6B0072; Thu, 23 Mar 2023 18:12:25 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 560826B0074; Thu, 23 Mar 2023 18:12:25 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 4946B6B0071 for ; Thu, 23 Mar 2023 18:12:25 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 1F6CAC02A1 for ; Thu, 23 Mar 2023 22:12:25 +0000 (UTC) X-FDA: 80601562650.11.5107528 Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by imf02.hostedemail.com (Postfix) with ESMTP id D86638000C for ; Thu, 23 Mar 2023 22:12:22 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=IqTPSg3k; spf=pass (imf02.hostedemail.com: domain of dave.hansen@intel.com designates 192.55.52.136 as permitted sender) smtp.mailfrom=dave.hansen@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1679609543; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Zz3Ov2fObzRXPF9kbY1Ne6we4sdSYntV08ICIG+RpDg=; b=f0GGtisHVkYlok+lStHvz/t7ps/3wV7K2rSoWS3mL6z3JwDiHYgujqwLg4oxIQCcMzTJk3 jyENY+UROcIJN4Ec91xyc0j5f87ErRaJAcL3r3XCNTHPzXGrsbY2IyTc0RiOzvBjOVBcR6 o9NwCfSwjkpXA8ZnbpKLgFEw9QEniEg= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=IqTPSg3k; spf=pass (imf02.hostedemail.com: domain of dave.hansen@intel.com designates 192.55.52.136 as permitted sender) smtp.mailfrom=dave.hansen@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1679609543; a=rsa-sha256; cv=none; b=Ye+22ldBIxBCSb0w60PJ+DUL99OHiu3QkCHDFYTITUDXT2jq41c2NPKj8ePPXu3tZ+Pajo zPNdYpISH6pCRYzFkbY7tZccFb7YbVAb80qwqMtM4BIHl6iZtXTCVhaNc52FToYWEJUVOy RzIAyXkqUQuWz4xMApXGWgffExrMBZg= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1679609543; x=1711145543; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=EnfZCJwEr26LuV84t2yJLMX9tU08wBX0EGiJmK5z7Uc=; b=IqTPSg3kUyaEhZH+ndvbNEDVayzB9GwDu2f4GJanA1fOZBv4RRObtjf9 3Sjr1MozzxWk4Sc0FGSCX/XuzZnStqx93zXeDxclH5NEMFr5cyb5xivZs dd/axDWbHp3UFqJU4hKd8q/389yI4PE3bmydwuDm3+UIcAyNF+QPjQMRp RSUBIIyFSzPXt3Abc+yu2UGVHtAsp4rVRiyhCurxL4vAdBzJLQ8iWO6Tt 2kAtRPMQkmqwLlg/aulG9rxBQZGAJsPWeWBmn2PIate5j1tDjo/jTJ+xg pidOu08b1vUROeY4D9Qy5kuvfsBP8xZ9jfcp2Wy1MNwxFXEj/BjaW0bTs Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10658"; a="319297874" X-IronPort-AV: E=Sophos;i="5.98,286,1673942400"; d="scan'208";a="319297874" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Mar 2023 15:12:18 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10658"; a="659806468" X-IronPort-AV: E=Sophos;i="5.98,286,1673942400"; d="scan'208";a="659806468" Received: from jball6-mobl.amr.corp.intel.com (HELO [10.209.105.116]) ([10.209.105.116]) by orsmga006-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Mar 2023 15:12:17 -0700 Message-ID: <1e1bec34-36bd-a719-7d3b-23ab268f7092@intel.com> Date: Thu, 23 Mar 2023 15:12:16 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH v10 05/16] x86/virt/tdx: Add skeleton to enable TDX on demand Content-Language: en-US To: "Huang, Kai" , "isaku.yamahata@gmail.com" Cc: "kvm@vger.kernel.org" , "Luck, Tony" , "david@redhat.com" , "bagasdotme@gmail.com" , "ak@linux.intel.com" , "Wysocki, Rafael J" , "linux-kernel@vger.kernel.org" , "Chatre, Reinette" , "Christopherson,, Sean" , "pbonzini@redhat.com" , "tglx@linutronix.de" , "linux-mm@kvack.org" , "kirill.shutemov@linux.intel.com" , "Yamahata, Isaku" , "Shahar, Sagi" , "peterz@infradead.org" , "imammedo@redhat.com" , "Gao, Chao" , "Brown, Len" , "sathyanarayanan.kuppuswamy@linux.intel.com" , "Huang, Ying" , "Williams, Dan J" References: <20230308222738.GA3419702@ls.amr.corp.intel.com> <96b56c5b8a5876aaf6d5ccbb81bab334b10983eb.camel@intel.com> <20230313234916.GC3922605@ls.amr.corp.intel.com> <5c4a28c8-f17d-7395-cc63-3cbd9b31befb@intel.com> <141def31-dcbb-70ae-2935-4fb06a986036@intel.com> <6be93d78e01906ff5c3714005170d761e5b40d41.camel@intel.com> From: Dave Hansen In-Reply-To: <6be93d78e01906ff5c3714005170d761e5b40d41.camel@intel.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: D86638000C X-Stat-Signature: gocswtg3oprm5hfrzadwcgo3nceeghsn X-HE-Tag: 1679609542-416623 X-HE-Meta: U2FsdGVkX18oPbA/WuOb9lKPBjZi2/2ztIzdkW88EVbeFwSdpISDJl4EqIHo5WUgskoQcsC/I9i+aFjNcYsZmky6lWhLikT+cST2tzdQHYfS+LCyhgT98GRSli2x9vR+x//942Dt+EDVFrdQnRGgzCe01rQ9GyR121mCxEyq6dZNEgV2c0BOTUQzfBUSstizgsf7bVtu8fiOS8YZo6dJD9n3zP2DvToOS05cC9/QhxhVUto1z33KS6inEUoF4SsRpwIUk0+zjmNNWKqPd+uHdMLgAOgshSCSu4/7wLsl2F2zGB6JfwN9VGgbMj034atSPPcdO8ecfvw+ftc84lakMZVgFLKBkerMblcD3xytBKZHEabxvh6ieMC3apWTmlJ3zff8VV4wbPkW3zafl47FVGoRe90U3FZDXIwrzUgtUJBgmwzyJbBHWc9/oioC9XIyBwYMLwD4zrw/79EPHsUjyJ2Q6Z07aF38UXZo+20K7fsb0istc8nmTtFZNhWmoKRxlcj9qBBX7DrXLUbCaDwe3VzBTH2te2MUEtOJzawyeYhFSfVTmtvmFQmHLzn1t6zSTJUJODsJ+CSRnG2lh0O83VgBGyei6+sN6c9ZPPbkb5iGvbsbQ8yVIUeNDqPzdT1pfkjzRUzcuTa5ZLIVVQq3MZG++mzqWOgMfLI5p2BnwXSOB0U1t8Bv9dNKCVwZVlci3akBZ2VF8TqbPzo6LtAuYv/BS9lH8bALYuY0EsvbgvzFE+7zSDB7IGFAWPZeWMUvAlJmqSS0Z8g/uXwfR5+Av0EaDSn7e7uLhc3pheWjsf+mwAPipsRhyTloweVrwelzCW49d9rQaplpm4CuV9Sg9mk4hVTgaSphwSRFznHLHVZ+tCipVpN3G291zHg/CRlnVtUuSr94b7RSJ4C5+HSqsKDAwcQwWfl3iUdLTK+3IHhZL++na5l7aPIlP/JYFUrgfrIe/Bma/cTbfmQYB0P PWkevF3X a9sfEL+ssgdCfwCg39psUIWfqWsaoMi5/2fmNElGs4APBhhG6oOndpqb2QQRDyOMeloDZriXLvT2H5CaqimbNgp03p5NYWb+dgNNzi4OO83U+hbOXg2/RJuzJocGSLUj9vYqn/3TpCZ4xf3SlF0rJh3xvUeLfOoDDH/ujOdvwMw3tCrXlbq2YM9RxfMHrAPqC7Js3bpsV3Ep8YYPvSNV6yPLE+5dbeyne/RHFndg5kg95L0i6kiQyJAFh6g6W51PtwItmBMvmeZdgOEL4p/gDKsuRZw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 3/23/23 15:09, Huang, Kai wrote: > 1) In TDH.SYS.INIT, ask TDX module team to return TDX_RND_NO_ENTROPY instead of > TDX_SYS_BUSY when running out of entropy. > > 2) In TDH.SYS.KEY.CONFIG, ask TDX module to return TDX_RND_NO_ENTROPY instead of > TDX_KEY_GENERATION_FAILED when running out of entropy. Whether > TDX_KEY_GENERATION_FAILED should be still kept is up to TDX module team > (because it looks running concurrent PCONFIGs is also related). > > 3) Ask TDX module to always return TDX_RND_NO_ENTROPY in _ALL_ SEAMCALLs and > keep this behaviour for future TDX modules too. Yes, that's all fine. > 4) In the common seamcall(), retry on TDX_RND_NO_ENTROPY. > > In terms of how many times to retry, I will use a fixed value for now, similar > to the kernel code below: > > #define RDRAND_RETRY_LOOPS 10 Heck, you could even just use RDRAND_RETRY_LOOPS directly. It's hard(er) to bikeshed your choice of a random number that you didn't even pick.