From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 30D24E7718B for ; Sun, 29 Dec 2024 15:01:13 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 97FF56B007B; Sun, 29 Dec 2024 10:01:12 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 92E5E6B0083; Sun, 29 Dec 2024 10:01:12 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7CF446B0085; Sun, 29 Dec 2024 10:01:12 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 5E9816B007B for ; Sun, 29 Dec 2024 10:01:12 -0500 (EST) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id CB4A31217C4 for ; Sun, 29 Dec 2024 15:01:11 +0000 (UTC) X-FDA: 82948307820.13.76D066E Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by imf18.hostedemail.com (Postfix) with ESMTP id B76FB1C000A for ; Sun, 29 Dec 2024 15:00:48 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=HvObE2TV; dmarc=pass (policy=none) header.from=ibm.com; spf=pass (imf18.hostedemail.com: domain of donettom@linux.ibm.com designates 148.163.158.5 as permitted sender) smtp.mailfrom=donettom@linux.ibm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1735484426; a=rsa-sha256; cv=none; b=B8vxY2lUQ/2S5l6ATCR7goCmChPOR23AEoQttoGcWvFVSWw89azV2e0I/+IvI8FBxdeelC VPluqGuV1nWq8H6gS/9tCsP4ugk2gq16FPsPfqwdnNueRAjrRrW99Cb/N7ck6hHxPCSzQN GfyNM567DYeRR5tQKJ5EBQTdNbMlEbk= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=HvObE2TV; dmarc=pass (policy=none) header.from=ibm.com; spf=pass (imf18.hostedemail.com: domain of donettom@linux.ibm.com designates 148.163.158.5 as permitted sender) smtp.mailfrom=donettom@linux.ibm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1735484426; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=wCsKj2QOObw+fJoFNyPGKQuWkj9ZTSu+UzQ7CGaXLbg=; b=cbUum/iMEpWeqjqVI7dvWh3BKN8VcqGEtkJDKWurdNtHtJtxF41aTfMak8wfp4/z2I2k7b 7k2nQ7OhStNsfuPtTAQO8sI8zOtEIonNbKNwp+SIi5oj4MfrRtIzHFjLC4oyjdp4rHp3Ti RbiG0jiiN60ojRWviDOdtO5G3pTE840= Received: from pps.filterd (m0360072.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 4BTCRJQV016737; Sun, 29 Dec 2024 15:01:05 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=pp1; bh=wCsKj2 QOObw+fJoFNyPGKQuWkj9ZTSu+UzQ7CGaXLbg=; b=HvObE2TVzb9twzvN/gwAms tPSxTv7g5GlNMwRM4yNDha4BSExqpDVSt+X4cxLYQw/Fv6UDn/QSrXxlgp68sOPQ 0BT6xJoPIQdZ+a/Zn+wKci2zVq1Tdh77NVHSvCOCbiynQGIVyoHIYi2Sj1wU5fNt 3lz3uX84NGLHmC+3MMkatKkkLuNkfsu3e2tw0DFrDzEhyT/5qsRCmfJCcr/nZHfP uEzypvHU8ifgQUkmy15mEXRkSdWQzYC8D0O/vR28ndjq7VSrgf47SWPQ1bnKfVZg 89hchCmmRrmbasPmNypIL9nCuQq3bwOiScw5/gD7BHA+B1DP3T2BEjalUzLUAadg == Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 43u2m28rev-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sun, 29 Dec 2024 15:01:05 +0000 (GMT) Received: from m0360072.ppops.net (m0360072.ppops.net [127.0.0.1]) by pps.reinject (8.18.0.8/8.18.0.8) with ESMTP id 4BTExTRP026700; Sun, 29 Dec 2024 15:01:05 GMT Received: from ppma12.dal12v.mail.ibm.com (dc.9e.1632.ip4.static.sl-reverse.com [50.22.158.220]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 43u2m28res-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sun, 29 Dec 2024 15:01:05 +0000 (GMT) Received: from pps.filterd (ppma12.dal12v.mail.ibm.com [127.0.0.1]) by ppma12.dal12v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id 4BTCbVFk014606; Sun, 29 Dec 2024 15:01:04 GMT Received: from smtprelay06.wdc07v.mail.ibm.com ([172.16.1.73]) by ppma12.dal12v.mail.ibm.com (PPS) with ESMTPS id 43tunsa52q-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sun, 29 Dec 2024 15:01:04 +0000 Received: from smtpav06.wdc07v.mail.ibm.com (smtpav06.wdc07v.mail.ibm.com [10.39.53.233]) by smtprelay06.wdc07v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 4BTF13YX29885024 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sun, 29 Dec 2024 15:01:03 GMT Received: from smtpav06.wdc07v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 7F51058054; Sun, 29 Dec 2024 15:01:03 +0000 (GMT) Received: from smtpav06.wdc07v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id F41AE5804E; Sun, 29 Dec 2024 15:00:57 +0000 (GMT) Received: from [9.171.1.162] (unknown [9.171.1.162]) by smtpav06.wdc07v.mail.ibm.com (Postfix) with ESMTP; Sun, 29 Dec 2024 15:00:57 +0000 (GMT) Message-ID: <1e103f72-01e0-4187-bb55-c9bd8f17eec2@linux.ibm.com> Date: Sun, 29 Dec 2024 20:30:56 +0530 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC v2 PATCH 5/5] migrate,sysfs: add pagecache promotion To: Gregory Price Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, nehagholkar@meta.com, abhishekd@meta.com, kernel-team@meta.com, david@redhat.com, nphamcs@gmail.com, akpm@linux-foundation.org, hannes@cmpxchg.org, kbusch@meta.com, ying.huang@linux.alibaba.com References: <20241210213744.2968-1-gourry@gourry.net> <20241210213744.2968-6-gourry@gourry.net> Content-Language: en-US From: Donet Tom In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-GUID: CqAg9N1_bCqD0injjVLDojONhPTrAAbZ X-Proofpoint-ORIG-GUID: KMBSt-LSqk9ymqEHJNxx7kVo69B2mwiR X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1051,Hydra:6.0.680,FMLib:17.12.62.30 definitions=2024-10-15_01,2024-10-11_01,2024-09-30_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 lowpriorityscore=0 priorityscore=1501 mlxlogscore=526 suspectscore=0 impostorscore=0 mlxscore=0 adultscore=0 spamscore=0 phishscore=0 bulkscore=0 clxscore=1015 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2411120000 definitions=main-2412290134 X-Stat-Signature: xyi4s768t3o8tpp5y4wddyfgif1z5k64 X-Rspam-User: X-Rspamd-Queue-Id: B76FB1C000A X-Rspamd-Server: rspam08 X-HE-Tag: 1735484448-230908 X-HE-Meta: U2FsdGVkX1//2lvr3EqxYhqjrv7YjEvEVOGYqSjLZO4E0oMP4ILUKTorK0EL1zTV853AzXeJXNKMpWilt+PV0A5d0PdQUL8ouHGoPQ2VqvnuowOJWh38abWTYfMicwssrdC9iIV61S0hRsVDn7oHm4+XYum6p4gaxDeE8DGN04iu3Gzjh99RetEM9Qkaf9ch68QBFxo4nwnCppsufLp5s1v5K29hAqUy8iy2uSlJoQOACKGBgfR2CsHbH11AE+de5kjl7JpLhMTXuKFaqYMUi+I0OerTotcOjhu26WKEkIUK9cAvDg1zp8ugdH8Wj07FNMa68d1gq6SUuk9cGNGQEVQW7djRYxnI7gbm9ZKNE06fB1YnKqgVYWRYq9hJAuTRcYa0aCk3RATqgvk87nakII53iGiRj0gwzhCIXWQfBri3ZW7f01J3P468EExNMEba0YlKTdmDsniAPdcVHDo7JfMFeBKJFPt8eOieiVxTS+hHog0Nrh8SENAI8augWDRVAAn8J3FMvnma4zVF4X5CtZNH3naGAgtbCH+RRiD0a3w1CxJffXFSC0B9fPfHb85vKmUzAEtbmP6HlMzORZBorgEE482wIGZfa2OnbQ1xy/7qjIF2E8BpUNIHDW5gCLZOJD4bbIQeSD/p2tCpHWH79JTjFZfOQHWsn/G8WNw0Vo0AcErk+lQwAMe8o6bSYshFwWpsd7d/BKL+idVt7z3qyELkCpr7Qcr88o3M1Vl2ke5iDNPhyLf0x7eKtvN+810N0KOH9QL7CSSCe3bNbot2xnCPOWm9SpX8dEhQgrJ1cufhiWIZn8GSy9KSlJ7X89dWuE81K2dCmS9sYhPkGExMWWC6DfrtI/vGzcJsyIcHCj+EpSLIJL4q0NFuhJA2LrHUZqMgkjPjPSfCenf8gFPXD3eMHkTZ/G1rVN89KP7cPzfYDWJPXDvaASMWXpAAkTQd5kVjtR5l8dDmkmcsS/6 W08a3+vT 1winMFOsky5EUNideDhNg2foIgCxdxF63Td/lo4ZDc7Oahvu5aHUythSsfn22khFAqgYX5WLJ6Ddh8J+aqvOr+1VxwYr3VyaRgoDOkSvQrR6q5fjBYe1nujwmEzKBs+nOrFlOhl7aMuvhJnMtX25t32rdU4P9wgdFvd9Jte1c62zyeUNsna/5XuEZY6Zk9ZWHhYDhBle8TSzPMS3z+Qx4kbSBz6n4/ozvCVojyE5RaWpSvXacC32l8BlkYOZqVCo2P1L+HNY/MgoN9kT/XWGDidhRGG81ws6W6aVvnC8qnzTU2yNAE9V3FR6pUYEND8/u5r+H X-Bogosity: Ham, tests=bogofilter, spamicity=0.000021, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 12/27/24 21:26, Gregory Price wrote: > On Fri, Dec 27, 2024 at 04:31:48PM +0530, Donet Tom wrote: >>> folio_clear_referenced(folio); >>> workingset_activation(folio); >>> + } else { >>> + >> In the current implementation, promotion will not work if we enable MGLRU, >> right? >> Is there any specific reason we are not enabling promotion with MGLRU? >> > folio_mark_accessed may not be the best place to interpose for MGLRU, > since MGLRU's semantics are so different. I didn't want to dive that > deep until I could show traditional LRU benefit. > > Certainly open to ideas if you're familiar with MGLRU semantics. Thanks. I will take a look at it. > > ~Gregory >