From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8A1A5E7717F for ; Tue, 17 Dec 2024 03:05:22 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DDAC96B007B; Mon, 16 Dec 2024 22:05:21 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D63326B0082; Mon, 16 Dec 2024 22:05:21 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C03B06B0083; Mon, 16 Dec 2024 22:05:21 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 9DF196B007B for ; Mon, 16 Dec 2024 22:05:21 -0500 (EST) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 5F031422E0 for ; Tue, 17 Dec 2024 03:05:21 +0000 (UTC) X-FDA: 82902957900.17.6D8B39F Received: from out30-133.freemail.mail.aliyun.com (out30-133.freemail.mail.aliyun.com [115.124.30.133]) by imf18.hostedemail.com (Postfix) with ESMTP id BBFF31C000C for ; Tue, 17 Dec 2024 03:05:04 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=linux.alibaba.com header.s=default header.b="PH0/0c/O"; spf=pass (imf18.hostedemail.com: domain of xueshuai@linux.alibaba.com designates 115.124.30.133 as permitted sender) smtp.mailfrom=xueshuai@linux.alibaba.com; dmarc=pass (policy=none) header.from=linux.alibaba.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1734404699; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=JYaV8tUHY5DY/QNPB9vrWmARi1TH7zIIIk5o2rlYGdA=; b=l0oD8SGFVg38+uf7dFnSc596x+HUNmh0jqfWU3u+i5uYbD9/0jqONZcs4646NMRWu5bR77 35KUOfJ0UCwrArSnu/ER2NoSmOR4jsvJhZlBJ7l5K4cCgyebD3B9sPP2uINWFmzPkoVMjb fe9sYMvkdMpEeto6pJ00EhOG7GCvQhM= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=linux.alibaba.com header.s=default header.b="PH0/0c/O"; spf=pass (imf18.hostedemail.com: domain of xueshuai@linux.alibaba.com designates 115.124.30.133 as permitted sender) smtp.mailfrom=xueshuai@linux.alibaba.com; dmarc=pass (policy=none) header.from=linux.alibaba.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1734404699; a=rsa-sha256; cv=none; b=u84dJhOuWmEGj+6whg7cvODR5U+splUiAP8cJWmaqZdtX13uhVEq2d7x/L4vjoX7HPA2Wp N2q8BPlv5E/c5/KW+kbKP+lcz3jEPMC0+Lgl3ZZq4dEJE56FDQT0TMD0Mo+tgLF3adnNrr wc9UVqYzw8JrypgVc+UByEQuDJuVSJo= DKIM-Signature:v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.alibaba.com; s=default; t=1734404715; h=Message-ID:Date:MIME-Version:Subject:To:From:Content-Type; bh=JYaV8tUHY5DY/QNPB9vrWmARi1TH7zIIIk5o2rlYGdA=; b=PH0/0c/OtyMeIukeEL7h1vhk9BKDpn+ZIVdSD18qd15tHEa76qiPQCsamM8cUPGt5kv58LchXUuWvEF/JlrLa1xRwvLvR6Lq1817LQfPeY1C5BYXm5pSxEj6qRkuIGTg6eYR47mYBbDM6ekhsT99gftVJePZyaX87WjpI7orccQ= Received: from 30.246.161.240(mailfrom:xueshuai@linux.alibaba.com fp:SMTPD_---0WLh6bXS_1734404711 cluster:ay36) by smtp.aliyun-inc.com; Tue, 17 Dec 2024 11:05:13 +0800 Message-ID: <1e0a0f9b-7c58-4f70-b2d4-6b3c2c4143de@linux.alibaba.com> Date: Tue, 17 Dec 2024 11:05:11 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v17 2/3] mm: memory-failure: move return value documentation to function declaration To: jane.chu@oracle.com, yazen.ghannam@amd.com, mark.rutland@arm.com, catalin.marinas@arm.com, mingo@redhat.com, robin.murphy@arm.com, Jonathan.Cameron@Huawei.com, bp@alien8.de, rafael@kernel.org, linux-arm-kernel@lists.infradead.org, wangkefeng.wang@huawei.com, tanxiaofei@huawei.com, mawupeng1@huawei.com, tony.luck@intel.com, linmiaohe@huawei.com, naoya.horiguchi@nec.com, james.morse@arm.com, tongtiangen@huawei.com, gregkh@linuxfoundation.org, will@kernel.org, jarkko@kernel.org Cc: linux-acpi@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, akpm@linux-foundation.org, linux-edac@vger.kernel.org, x86@kernel.org, justin.he@arm.com, ardb@kernel.org, ying.huang@intel.com, ashish.kalra@amd.com, baolin.wang@linux.alibaba.com, tglx@linutronix.de, dave.hansen@linux.intel.com, lenb@kernel.org, hpa@zytor.com, robert.moore@intel.com, lvying6@huawei.com, xiexiuqi@huawei.com, zhuo.song@linux.alibaba.com References: <20241202030527.20586-1-xueshuai@linux.alibaba.com> <20241202030527.20586-3-xueshuai@linux.alibaba.com> <51d231c2-3659-461a-b6c3-d0e7f9fddfc1@oracle.com> From: Shuai Xue In-Reply-To: <51d231c2-3659-461a-b6c3-d0e7f9fddfc1@oracle.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam05 X-Stat-Signature: tyzz8awatjb41h86kxt3ewkonnbe96zc X-Rspamd-Queue-Id: BBFF31C000C X-Rspam-User: X-HE-Tag: 1734404704-392423 X-HE-Meta: U2FsdGVkX187oZyLhqP+MrUU6UTHYDX8g6bg0I3DSX0JtSNs7cG2QULzHFtuhqAb2xltKdb2wNQVWR3aAwA0Ap5N1BWBf02ny/wtur90H4NFAKAsQmwrsLgLjo/Pn+5vA2TNkZVTnbuQDKbgq+sXBqjsx0WQ6cM9lVLC9fki91PoCmtVZxp4q3nbj5y+o4taWkikpH6z5po8QVmX0CIWPcoK7RARGshCHKhQYQjbbmg/lz6px/CJlzlJHUC5R5mrgMmPUDPdquK4IG5ye+Ir/vm/360teYDPhS6PwgaPkI8eoTlGRy1edyokRYyOtn6ZKvtrGXSgxV03EhZQiO87Uz6zJS22m9Zbaeh3a7b38+FLPLE1pq/EPQVvvFTZWlJJya8EOGRgMkL2rwNC7W9ifi76O9Mf78gC+3bmf7JPJrDGmIRZwreGdGl6KQ/1na7gfIk+J4ipmg2CbSGh61cCbUPom48PLRuHM4mja2b3Xc6CqTfMxGJE3QLaqEVfSTiNvdMo8O5NuS0WdKCoFbmPm9yze/njyWzXj5RlCOkfGqoETASpWs/HWW0ncTdvJuFCRQ7ytyuxbnygz2qT5MfSrkvc9GhBRfbzhYOt92GeLi6oQQ+qrEZownCbIxVf892DrPbJqTMg52UMeJzvqN15BYL0dema4c25WYv1F57JA80liwB2tkdGdZyuaIUt4urg4zXsZ6m9W8h55LH8HszLbSOzAkYWf6Ob6yTroyoGOd6kkvvrgoxjwBcKgbWjQxt82gIZY/aaBdtLzg2ebgLZzcUZmuo48lYQGV+qjGGQk64NzAT5Mmink8HY6C40KG9bdc6ib3fIyOZ0a1+NCV8KwXWSVlA13iHywpqIJ8xv4Ys4qN+B9EQujsU+LDvQ4qeG4lHnvknT9GNLgizuvWIaaXT71fe9C9SWm62EvLoShZraH2ASzI5A5mZIb85saifMX3m7nqIT2G6LfOk+XtJ mHu/ESEa PsElL7iao/zF9F3EDn+/6dQ6C6E4Kavsy0vyvm0oTStLTyEI7FW+psk/BOEQeDDXFAPp89/2zBDWGCRHYtoQiEpPwvyoR0AWa2NXpoMA/Ldk+JS4fGX7huCR/4aaG5vUag4Vbycq56pOFuZ5BFHh80IWUlHeUiwlxtwpc5MceaTXYVrTjoXYwgnO6fXyq9DIwilKx15ItlFXeU+GmYJIvJj+23cdEImfhHJZekt5MVoWVOIDskjhrI7iAfKROef0AJsVzoDZybvHUlAS56/ahgLxpOYyrRhbbwLps43L++Jtfi0hhzs4ucseGuoBNkR7Rva1jn1+U1FEZkdh3Y4rJoSOnkmWkCPVYa0gu4O/djzhXusI0VJtNTu3+EJFDUqDUpuAVg9VDnU9T75w= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: 在 2024/12/17 07:37, jane.chu@oracle.com 写道: > > On 12/1/2024 7:05 PM, Shuai Xue wrote: >> Part of return value comments for memory_failure() were originally >> documented at the call site. Move those comments to the function >> declaration to improve code readability and to provide developers with >> immediate access to function usage and return information. >> >> Signed-off-by: Shuai Xue >> Reviewed-by: Jarkko Sakkinen >> Reviewed-by: Jonathan Cameron >> Reviewed-by: Yazen Ghannam >> --- >>   arch/x86/kernel/cpu/mce/core.c |  7 ------- >>   mm/memory-failure.c            | 10 +++++++--- >>   2 files changed, 7 insertions(+), 10 deletions(-) >> >> diff --git a/arch/x86/kernel/cpu/mce/core.c b/arch/x86/kernel/cpu/mce/core.c >> index 7fb5556a0b53..d1dd7f892514 100644 >> --- a/arch/x86/kernel/cpu/mce/core.c >> +++ b/arch/x86/kernel/cpu/mce/core.c >> @@ -1398,13 +1398,6 @@ static void kill_me_maybe(struct callback_head *cb) >>           return; >>       } >> -    /* >> -     * -EHWPOISON from memory_failure() means that it already sent SIGBUS >> -     * to the current process with the proper error info, >> -     * -EOPNOTSUPP means hwpoison_filter() filtered the error event, >> -     * >> -     * In both cases, no further processing is required. >> -     */ >>       if (ret == -EHWPOISON || ret == -EOPNOTSUPP) >>           return; >> diff --git a/mm/memory-failure.c b/mm/memory-failure.c >> index a7b8ccd29b6f..14c316d7d38d 100644 >> --- a/mm/memory-failure.c >> +++ b/mm/memory-failure.c >> @@ -2211,9 +2211,13 @@ static void kill_procs_now(struct page *p, unsigned long pfn, int flags, >>    * Must run in process context (e.g. a work queue) with interrupts >>    * enabled and no spinlocks held. >>    * >> - * Return: 0 for successfully handled the memory error, >> - *         -EOPNOTSUPP for hwpoison_filter() filtered the error event, >> - *         < 0(except -EOPNOTSUPP) on failure. >> + * Return: >> + *   0             - success, >> + *   -ENXIO        - memory not managed by the kernel >> + *   -EOPNOTSUPP   - hwpoison_filter() filtered the error event, >> + *   -EHWPOISON    - the page was already poisoned, potentially >> + *                   kill process, >> + *   other negative values - failure. >>    */ >>   int memory_failure(unsigned long pfn, int flags) >>   { > > Looks good. > > Reviewed-by: Jane Chu > > -jane Thanks. Best Regards, Shuai