From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5E13CC433EF for ; Thu, 27 Jan 2022 04:07:11 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EDA8E6B0078; Wed, 26 Jan 2022 23:07:10 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id E8A226B007B; Wed, 26 Jan 2022 23:07:10 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D797B6B007D; Wed, 26 Jan 2022 23:07:10 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay033.a.hostedemail.com [64.99.140.33]) by kanga.kvack.org (Postfix) with ESMTP id C8F4F6B0078 for ; Wed, 26 Jan 2022 23:07:10 -0500 (EST) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 93F5522C61 for ; Thu, 27 Jan 2022 04:07:10 +0000 (UTC) X-FDA: 79074731820.01.9BB9075 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf01.hostedemail.com (Postfix) with ESMTP id 2E12340003 for ; Thu, 27 Jan 2022 04:07:10 +0000 (UTC) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 7C3C41FB; Wed, 26 Jan 2022 20:07:09 -0800 (PST) Received: from [10.163.42.218] (unknown [10.163.42.218]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 658B53F7D8; Wed, 26 Jan 2022 20:07:07 -0800 (PST) Subject: Re: [RFC V1 02/31] mm/mmap: Clarify protection_map[] indices To: Christoph Hellwig Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, akpm@linux-foundation.org References: <1643029028-12710-1-git-send-email-anshuman.khandual@arm.com> <1643029028-12710-3-git-send-email-anshuman.khandual@arm.com> From: Anshuman Khandual Message-ID: <1e06189a-7d69-7d6c-b9b4-3740604c371b@arm.com> Date: Thu, 27 Jan 2022 09:37:13 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 2E12340003 X-Rspam-User: nil Authentication-Results: imf01.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf01.hostedemail.com: domain of anshuman.khandual@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=anshuman.khandual@arm.com X-Stat-Signature: b71ufi7syssba3abwgficqc49prn4ru1 X-HE-Tag: 1643256430-942663 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 1/26/22 12:46 PM, Christoph Hellwig wrote: >> + [VM_NONE] = __P000, >> + [VM_READ] = __P001, >> + [VM_WRITE] = __P010, >> + [VM_READ|VM_WRITE] = __P011, >> + [VM_EXEC] = __P100, >> + [VM_EXEC|VM_READ] = __P101, >> + [VM_EXEC|VM_WRITE] = __P110, >> + [VM_EXEC|VM_READ|VM_WRITE] = __P111, >> + [VM_SHARED] = __S000, >> + [VM_SHARED|VM_READ] = __S001, >> + [VM_SHARED|VM_WRITE] = __S010, >> + [VM_SHARED|VM_READ|VM_WRITE] = __S011, >> + [VM_SHARED|VM_EXEC] = __S100, >> + [VM_SHARED|VM_READ|VM_EXEC] = __S101, >> + [VM_SHARED|VM_WRITE|VM_EXEC] = __S110, >> + [VM_SHARED|VM_READ|VM_WRITE|VM_EXEC] = __S111 > > Please add whitespaces around the | operators. Sure, will add. > > Otherwise looks good: > > Reviewed-by: Christoph Hellwig >