From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4657CC433F5 for ; Wed, 9 Mar 2022 21:39:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CE0418D0003; Wed, 9 Mar 2022 16:39:31 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id C8FDC8D0001; Wed, 9 Mar 2022 16:39:31 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B80E48D0003; Wed, 9 Mar 2022 16:39:31 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.28]) by kanga.kvack.org (Postfix) with ESMTP id AA03A8D0001 for ; Wed, 9 Mar 2022 16:39:31 -0500 (EST) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 799C060453 for ; Wed, 9 Mar 2022 21:39:31 +0000 (UTC) X-FDA: 79226164542.03.3352692 Received: from mail-il1-f173.google.com (mail-il1-f173.google.com [209.85.166.173]) by imf03.hostedemail.com (Postfix) with ESMTP id ACB982000A for ; Wed, 9 Mar 2022 21:39:30 +0000 (UTC) Received: by mail-il1-f173.google.com with SMTP id b9so1063358ila.8 for ; Wed, 09 Mar 2022 13:39:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=zOnqPnT6Pa2ZicR2EFcXEDxd/ntBqJXzc8CY9w8hS4s=; b=SwKsVqpxG6sd3JP9ZBuyzq1EvlLs2+s94s1mQ7gbDmpqo5mrxWlJJWzHpnSwa/ULRH CIwgbl4Nxw3U+4FG/NMEGvb+B9XD09Z8qiF2cnuPwUtmiywsc8th2+Gn0lUvaXqWB1Dp cCipwEhr9ODyyNGJA6CdE4d+yc0Y3NhT6m+Y4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=zOnqPnT6Pa2ZicR2EFcXEDxd/ntBqJXzc8CY9w8hS4s=; b=4liDC7hzAwgCV8VvjnI8y9Yjftp8uEHs3hreoNtE00Sw9QmNUZSWM3SIdL1b+teoxJ /omvchyoxOmLUGcNbv7hCqFxX2r3utIr/6bym4BeZ7nFFxZ6woGZu3ffS1uOK53MjhkM Bymr1GNbuP+jp7JyxnAP+Pqk1+VQXzkT0bG5fB0HrI3xXWQRbcK43rZ9DKfbz9pk/HM5 2c4hE0WfOPb/uJKTdoH/XFe1OopePNvbyG77NeRf3NULydKaCel3LxxvC6uDK7jAGedh xulEUGK1ZuZxCwCrYw+25H+5gUKL/OuhwenH2Qtx8M5pSJZeXf9jp+xebn1q1nEl8Smn YULQ== X-Gm-Message-State: AOAM533OXWyFy3Qah4pfEXeF2vNvFbpuiqRGlsIDCa467gF2t+QlPcig r9eeT79IfZ2wY3JA2NltpXWz8g== X-Google-Smtp-Source: ABdhPJy61oVAoTBdNapdnWk8a09TumWKakoLj4S/3jgje9lwQAIa32+X0V3f7AbApGGP501Oabaa9g== X-Received: by 2002:a05:6e02:1a4a:b0:2c6:6a0d:b8f0 with SMTP id u10-20020a056e021a4a00b002c66a0db8f0mr1189404ilv.85.1646861969934; Wed, 09 Mar 2022 13:39:29 -0800 (PST) Received: from [192.168.1.128] ([71.205.29.0]) by smtp.gmail.com with ESMTPSA id c6-20020a056e020bc600b002c6731e7cb8sm1158182ilu.31.2022.03.09.13.39.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 09 Mar 2022 13:39:29 -0800 (PST) Subject: Re: [PATCH 3/3] kfence: test: try to avoid test_gfpzero trigger rcu_stall To: Peng Liu , brendanhiggins@google.com, glider@google.com, elver@google.com, dvyukov@google.com, akpm@linux-foundation.org, linux-kselftest@vger.kernel.org, kunit-dev@googlegroups.com, linux-kernel@vger.kernel.org, kasan-dev@googlegroups.com, linux-mm@kvack.org Cc: wangkefeng.wang@huawei.com, Shuah Khan References: <20220309014705.1265861-1-liupeng256@huawei.com> <20220309014705.1265861-4-liupeng256@huawei.com> From: Shuah Khan Message-ID: <1dfeea09-cd4a-39fc-18f4-775bec99afa4@linuxfoundation.org> Date: Wed, 9 Mar 2022 14:39:28 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <20220309014705.1265861-4-liupeng256@huawei.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: ACB982000A X-Stat-Signature: 7jkqjsfuinpruzuxhiix8uidrq6psc9t X-Rspam-User: Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=google header.b=SwKsVqpx; dmarc=pass (policy=none) header.from=linuxfoundation.org; spf=pass (imf03.hostedemail.com: domain of skhan@linuxfoundation.org designates 209.85.166.173 as permitted sender) smtp.mailfrom=skhan@linuxfoundation.org X-Rspamd-Server: rspam03 X-HE-Tag: 1646861970-269962 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 3/8/22 6:47 PM, Peng Liu wrote: > When CONFIG_KFENCE_DYNAMIC_OBJECTS is set to a big number, kfence > kunit-test-case test_gfpzero will eat up nearly all the CPU's > resources and rcu_stall is reported as the following log which is > cut from a physical server. > > rcu: INFO: rcu_sched self-detected stall on CPU > rcu: 68-....: (14422 ticks this GP) idle=6ce/1/0x4000000000000002 > softirq=592/592 fqs=7500 (t=15004 jiffies g=10677 q=20019) > Task dump for CPU 68: > task:kunit_try_catch state:R running task > stack: 0 pid: 9728 ppid: 2 flags:0x0000020a > Call trace: > dump_backtrace+0x0/0x1e4 > show_stack+0x20/0x2c > sched_show_task+0x148/0x170 > ... > rcu_sched_clock_irq+0x70/0x180 > update_process_times+0x68/0xb0 > tick_sched_handle+0x38/0x74 > ... > gic_handle_irq+0x78/0x2c0 > el1_irq+0xb8/0x140 > kfree+0xd8/0x53c > test_alloc+0x264/0x310 [kfence_test] > test_gfpzero+0xf4/0x840 [kfence_test] > kunit_try_run_case+0x48/0x20c > kunit_generic_run_threadfn_adapter+0x28/0x34 > kthread+0x108/0x13c > ret_from_fork+0x10/0x18 > > To avoid rcu_stall and unacceptable latency, a schedule point is > added to test_gfpzero. > > Signed-off-by: Peng Liu > --- > mm/kfence/kfence_test.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/mm/kfence/kfence_test.c b/mm/kfence/kfence_test.c > index caed6b4eba94..1b50f70a4c0f 100644 > --- a/mm/kfence/kfence_test.c > +++ b/mm/kfence/kfence_test.c > @@ -627,6 +627,7 @@ static void test_gfpzero(struct kunit *test) > kunit_warn(test, "giving up ... cannot get same object back\n"); > return; > } > + cond_resched(); This sounds like a band-aid - is there a better way to fix this? > } > > for (i = 0; i < size; i++) > thanks, -- Shuah