From: David Hildenbrand <david@redhat.com>
To: "Kirill A. Shutemov" <kirill@shutemov.name>
Cc: Michal Hocko <mhocko@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Dan Williams <dan.j.williams@intel.com>,
Vlastimil Babka <vbabka@suse.cz>, Mel Gorman <mgorman@suse.de>,
"Jin, Zhi" <zhi.jin@intel.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
"Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>
Subject: Re: [PATCH] mm/page_alloc: Skip non present sections on zone initialization
Date: Fri, 10 Jan 2020 19:05:19 +0100 [thread overview]
Message-ID: <1dfd6a03-c444-720a-17c4-049f5953acb9@redhat.com> (raw)
In-Reply-To: <20200110175519.myahx3tnxajt4eam@box>
On 10.01.20 18:55, Kirill A. Shutemov wrote:
> On Fri, Jan 10, 2020 at 03:56:14PM +0100, David Hildenbrand wrote:
>> On 10.01.20 15:54, Kirill A. Shutemov wrote:
>>> On Fri, Jan 10, 2020 at 03:48:39PM +0100, David Hildenbrand wrote:
>>>>>> + if (!present_section_nr(section_nr))
>>>>>> + return section_nr_to_pfn(next_present_section_nr(section_nr));
>>>>>
>>>>> This won't compile. next_present_section_nr() is static to mm/sparse.c.
>>>>
>>>> We should then move that to the header IMHO.
>>>
>>> It looks like too much for a trivial cleanup.
>>>
>>
>> Cleanup? This is a performance improvement ("fix the issue."). We should
>> avoid duplicating code where it can be avoided.
>
> My original patch is in -mm tree and fixes the issue. The thread is about
> tiding it up.
Just send a v2? This thread is review of this patch.
If you don't want to clean it up, I can send patches ...
--
Thanks,
David / dhildenb
next prev parent reply other threads:[~2020-01-10 18:05 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-30 9:38 Kirill A. Shutemov
2019-12-31 1:23 ` Baoquan He
2019-12-31 1:33 ` Baoquan He
2020-01-08 14:40 ` Michal Hocko
2020-01-10 13:15 ` David Hildenbrand
2020-01-10 13:45 ` Kirill A. Shutemov
2020-01-10 14:34 ` David Hildenbrand
2020-01-10 14:47 ` Kirill A. Shutemov
2020-01-10 14:48 ` David Hildenbrand
2020-01-10 14:54 ` Kirill A. Shutemov
2020-01-10 14:56 ` David Hildenbrand
2020-01-10 17:55 ` Kirill A. Shutemov
2020-01-10 18:05 ` David Hildenbrand [this message]
2020-01-10 18:22 ` Kirill A. Shutemov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1dfd6a03-c444-720a-17c4-049f5953acb9@redhat.com \
--to=david@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=dan.j.williams@intel.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=kirill@shutemov.name \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@suse.de \
--cc=mhocko@kernel.org \
--cc=vbabka@suse.cz \
--cc=zhi.jin@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox