From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 32417C433F5 for ; Mon, 20 Dec 2021 01:56:08 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A34AA6B0074; Sun, 19 Dec 2021 20:55:51 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 9E3476B0075; Sun, 19 Dec 2021 20:55:51 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8AA196B0078; Sun, 19 Dec 2021 20:55:51 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0135.hostedemail.com [216.40.44.135]) by kanga.kvack.org (Postfix) with ESMTP id 7C15E6B0074 for ; Sun, 19 Dec 2021 20:55:51 -0500 (EST) Received: from forelay.prod.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by fograve03.hostedemail.com (Postfix) with ESMTP id D281F181327CF for ; Mon, 20 Dec 2021 01:19:06 +0000 (UTC) Received: from smtpin29.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 9D7EF805DE for ; Mon, 20 Dec 2021 01:18:56 +0000 (UTC) X-FDA: 78936413472.29.9F550F5 Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by imf16.hostedemail.com (Postfix) with ESMTP id 766FF180013 for ; Mon, 20 Dec 2021 01:18:55 +0000 (UTC) X-IronPort-AV: E=McAfee;i="6200,9189,10203"; a="226930819" X-IronPort-AV: E=Sophos;i="5.88,219,1635231600"; d="scan'208";a="226930819" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Dec 2021 17:18:53 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,219,1635231600"; d="scan'208";a="507496332" Received: from allen-box.sh.intel.com (HELO [10.239.159.118]) ([10.239.159.118]) by orsmga007.jf.intel.com with ESMTP; 19 Dec 2021 17:18:51 -0800 Cc: baolu.lu@linux.intel.com, iommu@lists.linux-foundation.org, suravee.suthikulpanit@amd.com, willy@infradead.org, linux-kernel@vger.kernel.org, john.garry@huawei.com, linux-mm@kvack.org, hch@lst.de Subject: Re: [PATCH v3 6/9] iommu/vt-d: Use put_pages_list To: Robin Murphy , joro@8bytes.org, will@kernel.org References: <2115b560d9a0ce7cd4b948bd51a2b7bde8fdfd59.1639753638.git.robin.murphy@arm.com> From: Lu Baolu Message-ID: <1df4cd6c-7f70-4358-e57f-754d98807abe@linux.intel.com> Date: Mon, 20 Dec 2021 09:18:29 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 MIME-Version: 1.0 In-Reply-To: <2115b560d9a0ce7cd4b948bd51a2b7bde8fdfd59.1639753638.git.robin.murphy@arm.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Stat-Signature: ptjjp1nooru3up1tzg1s3uo3rmg5iqp3 X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 766FF180013 Authentication-Results: imf16.hostedemail.com; dkim=none; spf=none (imf16.hostedemail.com: domain of baolu.lu@linux.intel.com has no SPF policy when checking 134.134.136.126) smtp.mailfrom=baolu.lu@linux.intel.com; dmarc=fail reason="No valid SPF, No valid DKIM" header.from=intel.com (policy=none) X-HE-Tag: 1639963135-390262 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Robin, On 12/17/21 11:31 PM, Robin Murphy wrote: > From: "Matthew Wilcox (Oracle)" > > page->freelist is for the use of slab. We already have the ability > to free a list of pages in the core mm, but it requires the use of a > list_head and for the pages to be chained together through page->lru. > Switch the Intel IOMMU and IOVA code over to using free_pages_list(). > > Signed-off-by: Matthew Wilcox (Oracle) > [rm: split from original patch, cosmetic tweaks, fix fq entries] > Signed-off-by: Robin Murphy I had boot tests on my development machines with both strict and lazy flushing modes. I didn't see any regression, the disk i/o and network i/o worked good for me. For changes in iommu/vt-d: Reviewed-by: Lu Baolu Best regards, baolu