From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B7C1EC636D4 for ; Wed, 15 Feb 2023 20:01:00 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id ECE5B6B0072; Wed, 15 Feb 2023 15:00:59 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id E56766B0073; Wed, 15 Feb 2023 15:00:59 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CF85E6B0074; Wed, 15 Feb 2023 15:00:59 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id BB26D6B0072 for ; Wed, 15 Feb 2023 15:00:59 -0500 (EST) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 84945C0EDB for ; Wed, 15 Feb 2023 20:00:59 +0000 (UTC) X-FDA: 80470594638.08.A83A3D3 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf25.hostedemail.com (Postfix) with ESMTP id 93EDEA0036 for ; Wed, 15 Feb 2023 20:00:55 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=D9d14n1T; spf=pass (imf25.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1676491255; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=pM6ZuLLAVBgaXnAlM0ysAj5P46WWetvT+AboXXV0/P0=; b=xYN4HIqYAxfB84eCEU6w3Zu+YgUj7uZXwRMCCEZ09/el8FidutV9KSWadaNDZCXNfAUnIu LlbpJBAv0xvHdFCxbhmfa8yV+YNsNXVZyemJilSaM7OQSRQzaT8+sVjqN/5ElL3nqjWWQb 5F7QF73J04hX8dogQ4HvSfwRZGRhS6E= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=D9d14n1T; spf=pass (imf25.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1676491255; a=rsa-sha256; cv=none; b=BoXeLo9+uSxyqzFYrTcWKcLGdR7g46HGEI/MvHMfXyMPwvV5BLDDsNmp5ywSgEH5z5sVaU O2F9AoN6tGC9sQe7dAELdxx46b/f4w5LAjq0I30fmUpAyhlVSPHGUOsoFV/bLyNdWNenoa KOOX/o3RzFthzYZ5mdwIrCiXB0EgMJI= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1676491254; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=pM6ZuLLAVBgaXnAlM0ysAj5P46WWetvT+AboXXV0/P0=; b=D9d14n1Tz1tVlLpR9bs6atfPLpyqS0n2cbTbVwj2YT9UKhY0RUTJj6X53QLNmjLquMrBcy 4XaJhbkveihfunLU0e+bbRCSEWO4fvz1agyRVNzgTLpjR5QBxJDX6yXHV4pO8ZtVpw1gsG S8l4Qs/qIAXNUauuS7FLo9cITIcOPb8= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-588-jp22bOSAMXue2T8Zf6JO1A-1; Wed, 15 Feb 2023 15:00:53 -0500 X-MC-Unique: jp22bOSAMXue2T8Zf6JO1A-1 Received: by mail-wm1-f71.google.com with SMTP id j20-20020a05600c1c1400b003dc5dd44c0cso9706031wms.8 for ; Wed, 15 Feb 2023 12:00:53 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=pM6ZuLLAVBgaXnAlM0ysAj5P46WWetvT+AboXXV0/P0=; b=PeFTTcnbIn39MgpG/lmLOJzP65y9v/PihNgFxrFGZtiCudIJofQt6e4MxtLV9Zjl+e wHimpT8j1zBtci9Ey3UDA6M95d9tePfLTYh0ddr4skfgVdQ7gK0awdEWzRDP3YO0RCf+ pmbXt/FywvTIJDY+e00+QoO8OJ8PHbf/6Ut41UKNi/8kITh00wIY7H3YVio980FKmlY6 8/dfKlJbZdi3qHvq4t15MFd46AwLfCAkrAN26xMHuldRNr+Xo3iO8VyANmQuqDDb/ErE RQsm0st2u4f6Od1SwrRJ3oX96x1LEydMcdecNI/R9J4qZfLVbPQKlIIw4vU7Kh4nrrqX H1yA== X-Gm-Message-State: AO0yUKUW6UaWULUIqn9c/iUcywwpI4jvPmuJyVOa+lBhGk1cZeHdA0KE WZekXYO9esGSoeWvG/O7FHviNt0UH1OsE9qiLIN/1W31FGPwtlMZv46xey5QB17MtKFAXdkww7/ VsUUAe9Dq0GA= X-Received: by 2002:a5d:544b:0:b0:2c5:534d:eebb with SMTP id w11-20020a5d544b000000b002c5534deebbmr2901865wrv.13.1676491252230; Wed, 15 Feb 2023 12:00:52 -0800 (PST) X-Google-Smtp-Source: AK7set8yuqeosoikVPd5aJzudaeycPQRLEyT0zOy6UwFihA/3b+WnGmJgbNqpboh+yuCfhJLq2KqCg== X-Received: by 2002:a5d:544b:0:b0:2c5:534d:eebb with SMTP id w11-20020a5d544b000000b002c5534deebbmr2901840wrv.13.1676491251804; Wed, 15 Feb 2023 12:00:51 -0800 (PST) Received: from ?IPV6:2003:cb:c707:1400:b7d:4122:28d:f4c3? (p200300cbc70714000b7d4122028df4c3.dip0.t-ipconnect.de. [2003:cb:c707:1400:b7d:4122:28d:f4c3]) by smtp.gmail.com with ESMTPSA id d1-20020adffd81000000b002bfe08c566fsm15989893wrr.106.2023.02.15.12.00.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 15 Feb 2023 12:00:51 -0800 (PST) Message-ID: <1ddc2eff-f1bd-be62-3c62-abe6d539feef@redhat.com> Date: Wed, 15 Feb 2023 21:00:50 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 Subject: Re: [PATCH] mm/memory_hotplug: return zero from do_migrate_range() for only success To: SeongJae Park Cc: akpm@linux-foundation.org, osalvador@suse.de, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20230215180316.75431-1-sj@kernel.org> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20230215180316.75431-1-sj@kernel.org> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 93EDEA0036 X-Rspam-User: X-Stat-Signature: hjz4tyznmnkby34pcignzmj4mspp37nu X-HE-Tag: 1676491255-34035 X-HE-Meta: U2FsdGVkX18xAazlz5xKwlU+iieHZoQdl4Ue/+G8cKlKjdUz3997PnutU2gRg4vsNNNRg9D56s9M30vHY6Q4cTglEEwzCfZMsY3t5Z6oOvbMkBwdyvy34n/2qigSLLlCT0nZbSA3NcJKkc0QBsecbFHFvwyf+11xkMdRWxSnd4WyGVP5dGckxv1G77dmgffUbWg3zflOTus1YreDhTkJlJa9TCmNdlFJIIoYilP0goDFSoRLgfAgfIkq52Ws9K3UExiSYEKyG/XqpPPubNvII6OGwo7h4rbOYtCah8ah1Y3FKRMQc2VuUWiXJ/VI59zyoDKdsh1h17iyhB1xKR43VzGbHOwhmy+ptZBi+MjOfLSajJ/Um+4y/NWII5p+T4+bZxjARnnqdzruq6ZHwsz+ckUpoC70PQbjq4+ZyA1yccJisNsFWCg188GqxtIKiAk2G1ih6dYa7PjFVh/KBRH3SKT19SN1mpI6BhI7Ex1GsG27/SKw+x3Hsn6fwsD3xBxS5Mw0WIDgP8rv5vJEv7txaonnf2dPamNovmYmj9mrryXF514xml3M/kT2oKOkKbvbUi5kfEekyt9yFW7JpD1CvlDilMf7jRqW1T3I5G4S1K4TdJlZj0Lg+WzBO2JrZRxjfgw1v80HTpaMSEmA42YmrvzJbfA5MXeOHQFsCyShlHUQyGoXvclTM7dq6M7UVFq5dhvHhqWgFpsed0HYAE0RN3fn6xNduAFMQBhJ0xPA8nYjHI6ov4GoGFf3fa43iJSZ/qJfx9ESO4dNe06Zp2KHM69w8t2W9GU2Kwed/uurx1625MB5uei+kwu/KwFRC/Uz4V3wrZYV9BXVz6KbDSVkhmCy677JEnoaX22eaY2NBUYKOi9Ogc0KVz5a++t8ytki56Zqo1H6sWX9AL+Ci7SSVMlyUQGI2YtEPxGCYz1VPD4xCTGy3U8mjrrNgGQZSgNheAuLep9Jq9kHdR8u+nF 3DNt++Xu iqaVbXw3FmWDZFE9YG5Xg7ar79VLRT9R5XFdpJ+3HvdVp+U6BDFHnEwHtVosUiBHz+eLwwDLwWV1JLAWhqLM6W78FxS/8A9pmmm7IRXUIC2kE6hY+gXPMB90Aqu/c4UX+2jFK8VSxTI3TPG0p/bIDPqmt2BvYUMlRyCZhcNWb7K15Omlv2ohRScROoCogs3xEyedfb5pzS5fVkKC96GW8WgdWT9mw4feBsDqHyDA+2OfcPowGFyXZEVOSv19sRCuNYe1rzoA3dmuz9EBb8rzmdUZE747HDkO5fWBqNXkUu7qWpo/EBfk+DrDo8YTlVcWbSywJ20LhIg3yckF7wCpdN+hDbKCxe9ANzpcTLbTH2CHpDsTqBZGjFV3EJcpmvpvrT47I7y2SLw/K3aXdUdEbLjqxtO8ZD0yUPZypXu5714wwzfIEkPQGJZi6rnGcyR02M+xeOmvEVwQi4XDPf4Hnl4pn7g== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 15.02.23 19:03, SeongJae Park wrote: > On Wed, 15 Feb 2023 14:16:05 +0100 David Hildenbrand wrote: > >> On 14.02.23 23:32, SeongJae Park wrote: >>> do_migrate_range() returns migrate_pages() return value, which zero >>> means perfect success, in usual cases. If all pages are failed to be >>> isolated, however, it returns isolate_{lru,movalbe}_page() return >>> values, or zero if all pfn were invalid, were hugetlb or hwpoisoned. So >>> do_migrate_range() returning zero means either perfect success, or >>> special cases of isolation total failure. >>> >>> Actually, the return value is not checked by any caller, so it might be >>> better to simply make it a void function. However, there is a TODO for >>> checking the return value. >> >> I'd prefer to not add more dead code ;) Let's not return an error instead. > > Makes sense, I will send next spin soon. > >> >> It's still unclear which kind of fatal migration issues we actually care >> about and how to really detect them. > > What do you think about treating the isolation/migration rate limit > (migrate_rs) hit in do_migrate_range() as fatal? It warns for the event > already, so definitely a bad sign. > > If that's not that bad enough to be treated as fatal, I think we could have yet > another rate limit to be considered fatal. IIRC, there are some setups where offlining might take several minutes (e.g., heavy O_DIRECT load) and that's to be expected. So the existing code warns for better debugging, but keeps trying. So the ratelimit is rather to not produce too much debug output, not to really indicate that something is fatal. -- Thanks, David / dhildenb