From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7F9B7C5475B for ; Thu, 14 Mar 2024 08:54:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E5F5D8008F; Thu, 14 Mar 2024 04:54:25 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E0E7F80073; Thu, 14 Mar 2024 04:54:25 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CFD0F8008F; Thu, 14 Mar 2024 04:54:25 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id C049280073 for ; Thu, 14 Mar 2024 04:54:25 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 959CBC1433 for ; Thu, 14 Mar 2024 08:54:25 +0000 (UTC) X-FDA: 81895033290.16.A4DA17F Received: from madrid.collaboradmins.com (madrid.collaboradmins.com [46.235.227.194]) by imf08.hostedemail.com (Postfix) with ESMTP id D23FB16001B for ; Thu, 14 Mar 2024 08:54:23 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=collabora.com header.s=mail header.b=kZVhG8GF; spf=pass (imf08.hostedemail.com: domain of usama.anjum@collabora.com designates 46.235.227.194 as permitted sender) smtp.mailfrom=usama.anjum@collabora.com; dmarc=pass (policy=quarantine) header.from=collabora.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1710406464; a=rsa-sha256; cv=none; b=z/ZzoCURxMsg5qFfiO/r9+vOp+ZWZtNB+gjxZWdMIVR3ZvKSJxuGryFBneo4kQojjiit0l HIVbFZvgkvnK6PdzKDBm/sABZQIRlg9xhuXda+QZNlBa3abRXeHOmOqrZiHg/U2qKZjQNw N779gWgGFdp7ss0GDfcu2B944FI49x0= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=collabora.com header.s=mail header.b=kZVhG8GF; spf=pass (imf08.hostedemail.com: domain of usama.anjum@collabora.com designates 46.235.227.194 as permitted sender) smtp.mailfrom=usama.anjum@collabora.com; dmarc=pass (policy=quarantine) header.from=collabora.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1710406464; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=7tQw2ERd9IuEhQNPrM+KrNK4Se7Ufikq8Ju0dETI9Bw=; b=PtMEH6nSokqv+uNX4Rwp/okbA7SlNZ2f7nX4MPdNaa64jbve1Ka1m80xpfDQvbJMalGKhJ UhFcoCUFnwZ/BGsVo714fpJJwbxZ7wCgsZFhH6SSWKmiSyGG7oiGNtdK3Q+pE4KFL1ToEr TEaimFmXfvG9VzdJ60FgHWvNQ5If0+k= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1710406462; bh=Hug4VpcwNwwqAOdVuGR3r5w2hzLyi1ZErcpgeoCjrpg=; h=Date:Cc:Subject:To:References:From:In-Reply-To:From; b=kZVhG8GFZYYC3OAzSAy08JnBI7ueSsyszQUf5fEmjQ2II8WGNRD/wgTbcyAhltdca MhX/nATboCzW2kCOzEjw200OyBhiHWNi28f+Fd+CF34xT/cGtMpvxqs/HpBWXPzb5Y qxiBfmUXTOs078rdLjOkbZ3cRZYX9bGtVSx5svoldhVQ6/3Bh0AL+rblWfyAAQpfWZ gPtW+AA3MdPR0h8MwGVzD7p2bORCWGQ2kq+cYRnrCemV5qYCWemsZpFJGCXNrrZZDO glDgKLSjJjuhnhYBKNjVFoCvbhaj+BZUq8o7TqrhP48UsGCGqdi4+LuVbzRJwLhi9p R8ea4uLifDcRw== Received: from [10.193.1.1] (broslavsky.collaboradmins.com [68.183.210.73]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: usama.anjum) by madrid.collaboradmins.com (Postfix) with ESMTPSA id A3105378105A; Thu, 14 Mar 2024 08:54:19 +0000 (UTC) Message-ID: <1dd87e89-2306-4669-844f-ffe9e56523b6@collabora.com> Date: Thu, 14 Mar 2024 13:54:50 +0500 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Cc: Muhammad Usama Anjum , Shuah Khan , Mark Brown , linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org Subject: Re: [PATCH] selftests/exec: execveat: Improve debug reporting Content-Language: en-US To: Kees Cook , Eric Biederman References: <20240313185606.work.073-kees@kernel.org> From: Muhammad Usama Anjum In-Reply-To: <20240313185606.work.073-kees@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: D23FB16001B X-Stat-Signature: kbrjfaey5nej8rucsecehgxicjmw33os X-Rspam-User: X-HE-Tag: 1710406463-516659 X-HE-Meta: U2FsdGVkX1//Rg3L4SW1oFRqp2zz8kCT2qeGzLsJN8B3LalnHdr2J2/jZr0rvli/TWYEPrGyAyUISZszPp1GkLK1yfdSBM2Tlsnb8Lu6QQoFlU+c2zrNU0O6sLbXx6LcismGKkwJSKXy4EKHnmtRq+qq2regpxE7J6oR+mnuaU1yiL5i4/AZlSKjgrGBxykz+O7XEpzwmDDyBKmy3qrf1JdJoO+HKSYfpJYN20QmYdkMyhwad5mEpzvlnhf3nX7olLUv8NyeDc6viCRv+ejlp3/NPx80AzicEsgERp2vawt8EG6vQmj2QcjLOwqtKovx60FUyrDNezVt2mlANzehENUdyylY0/UcDxVlcgGUSnYLc6uCr89Js0t3AMt+lo4rCuBeLNzS/HHIpfuCQNzpc/AT7ifB3ZOjottt9/DDroXRukw8cYNXJ3/24QSmPNQWgs90Qmpghj+EfLpVb4/WsPnmLJ6bs2uIO0l+foivvvan84If03THFMioh8DOEHQz6scwr1l+nyZ6b3XufX/d+4SM0MY+gWWOCKrJEwr1QVGzX7rxTo8JWM+Asv/SvRhbTIWeOJeHFrs33pE/PpgXAbYQm/xY80GZLQ+zF4P19bS8elrDAi6bdU0rSHMvOWVboVm/6EeNkboEaJKWBINX1p3h1sNqIlqeF+gQjqshbyRGav1gKQRUbtyjJMkDFOWf2RTSbtrBsoXBbUTwraawfyIgBajoGU75i06+PP86E1HUxiJEKEpLQIcEkEAV2W9U41PavSegV4dfH+ZZjEhnXtY40OHeqbe/W3KdjLPZj4cr7Hi1FtRE9MlzaVtXSDfEH5kDIxlvXgQbkAFeDdK385iYVyzA+oQRTAy3SHr3v57yWY3vw/A+zgMEd883/i1WQ0A1GvlyRRQbOlKQxBneaumHVtnbUEIzqfA51H8+W3RU/oVCTUwu8fKbBnFifPZi3IVVbQUZnPykQeuYi6y f00inT+N BzmezCLROlBYjZyOeBToJm/kewjsK6UFUWk030Rm2V3SfhrABm62t7pPkglIbbw25Oa/UaSfLKsSw5j1dTu9YmSYMFVpFg+TqH2pF3UbrxirfBDabJ7zPDLQ95Ym89EadJCFjdHLJtGFek4IozZR8sFKedSR61QnGYM8KTcqIjmKxcQIak6YKd/WTHlt10WdCPe3iGU2U/Lj4zp2+YS0DRvKIl7u1ZTccF31lvvX3/ID3VBLXXhMl2TU12fXl0kvczTWqEc7fQqqDBD5eScm9wrmnL2/prv+c5d/86VHd3kU8BRxKXNXrO1f+esBrmh8Sr6UETKiIFdiioCJ26XaKwFofMdRZOPLnDCEEjmhWp7daZqQ2muIdffSGBhmp7YRwKiSxO2evRuX6kIaCSwFocG7ZRkBkJ4lgdBwjl7otJ8PXRkHe0Qzh2W3VF1ma2Q895gR9N9noqkqiG3FWMLObyerGR4dcAcjzuBIoNl6xyhwiDftC0woyXO3vQtUw6C6JYYQfI7SqUWK35eNm8F/VCV9KNw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 3/13/24 11:56 PM, Kees Cook wrote: > Children processes were reporting their status, duplicating the > parent's. Remove that, and add some additional details about the test > execution. > > Signed-off-by: Kees Cook > --- > Cc: Eric Biederman > Cc: Shuah Khan > Cc: Mark Brown > Cc: Muhammad Usama Anjum > Cc: linux-mm@kvack.org > Cc: linux-kselftest@vger.kernel.org Reviewed-by: Muhammad Usama Anjum > --- > tools/testing/selftests/exec/execveat.c | 12 +++++++----- > 1 file changed, 7 insertions(+), 5 deletions(-) > > diff --git a/tools/testing/selftests/exec/execveat.c b/tools/testing/selftests/exec/execveat.c > index 0546ca24f2b2..6418ded40bdd 100644 > --- a/tools/testing/selftests/exec/execveat.c > +++ b/tools/testing/selftests/exec/execveat.c > @@ -98,10 +98,9 @@ static int check_execveat_invoked_rc(int fd, const char *path, int flags, > if (child == 0) { > /* Child: do execveat(). */ > rc = execveat_(fd, path, argv, envp, flags); > - ksft_print_msg("execveat() failed, rc=%d errno=%d (%s)\n", > + ksft_print_msg("child execveat() failed, rc=%d errno=%d (%s)\n", > rc, errno, strerror(errno)); > - ksft_test_result_fail("%s\n", test_name); > - exit(1); /* should not reach here */ > + exit(errno); > } > /* Parent: wait for & check child's exit status. */ > rc = waitpid(child, &status, 0); > @@ -226,11 +225,14 @@ static int check_execveat_pathmax(int root_dfd, const char *src, int is_script) > * "If the command name is found, but it is not an executable utility, > * the exit status shall be 126."), so allow either. > */ > - if (is_script) > + if (is_script) { > + ksft_print_msg("Invoke script via root_dfd and relative filename\n"); > fail += check_execveat_invoked_rc(root_dfd, longpath + 1, 0, > 127, 126); > - else > + } else { > + ksft_print_msg("Invoke exec via root_dfd and relative filename\n"); > fail += check_execveat(root_dfd, longpath + 1, 0); > + } > > return fail; > } -- BR, Muhammad Usama Anjum