From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5B7E4C4332F for ; Fri, 21 Oct 2022 08:21:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B7A7E8E0002; Fri, 21 Oct 2022 04:21:33 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B2AE88E0001; Fri, 21 Oct 2022 04:21:33 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A1C3D8E0002; Fri, 21 Oct 2022 04:21:33 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 920338E0001 for ; Fri, 21 Oct 2022 04:21:33 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 651CE120B0B for ; Fri, 21 Oct 2022 08:21:33 +0000 (UTC) X-FDA: 80044262466.27.760A992 Received: from alexa-out-sd-02.qualcomm.com (alexa-out-sd-02.qualcomm.com [199.106.114.39]) by imf13.hostedemail.com (Postfix) with ESMTP id C1B8D2003E for ; Fri, 21 Oct 2022 08:21:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; i=@quicinc.com; q=dns/txt; s=qcdkim; t=1666340492; x=1697876492; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=h2fCMR48Gpr6g0cjkfiTbdcqeaJO7CWEJP2WPO9iyJM=; b=B7K5M7JOwKU2AXTCbIFAatgxORBcUXJJXMfYtxPLTGJ5/2uVYA75cFmd C/Cqhx4YmY9DmnsbSdNJW+vCc/b+IbAr0lhGCYNe+elEoWK6ljFFrK1a5 QxgWD77NXoVJaTpY9qkZ9PNQM9NlcFf7cA9IO0fBjTYJy2T8p1uSY3rwZ E=; Received: from unknown (HELO ironmsg-SD-alpha.qualcomm.com) ([10.53.140.30]) by alexa-out-sd-02.qualcomm.com with ESMTP; 21 Oct 2022 01:21:31 -0700 X-QCInternal: smtphost Received: from unknown (HELO nasanex01a.na.qualcomm.com) ([10.52.223.231]) by ironmsg-SD-alpha.qualcomm.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Oct 2022 01:21:31 -0700 Received: from [10.239.133.73] (10.80.80.8) by nasanex01a.na.qualcomm.com (10.52.223.231) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.29; Fri, 21 Oct 2022 01:21:29 -0700 Message-ID: <1dd08ecb-2b08-0556-64ac-3f39a8fec76c@quicinc.com> Date: Fri, 21 Oct 2022 16:21:26 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.3.0 Subject: Re: [PATCH v2 1/1] mm/page_isolation: fix clang deadcode warning To: David Hildenbrand , , , , CC: , References: <20221021051936.15346-1-quic_aiquny@quicinc.com> <20221021051936.15346-2-quic_aiquny@quicinc.com> From: "Aiqun(Maria) Yu" In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01a.na.qualcomm.com (10.52.223.231) To nasanex01a.na.qualcomm.com (10.52.223.231) ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1666340493; a=rsa-sha256; cv=none; b=Q6RDngbedI+U0Sd1shp+F/XWzojJ5j+G/VodQ430cB3AN2RNXPSBEnpW8l+610RIJdiAIQ Ihzn2usNPlvCUk98CfUPx7WixaFwPO5I+jCBkC3k3v+fmLpAgBPCSInelPch2nA8foenKw 5ndqHQ0wzQgJWSZOZ4XOvMXEGn4FkS0= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=quicinc.com header.s=qcdkim header.b=B7K5M7JO; spf=pass (imf13.hostedemail.com: domain of quic_aiquny@quicinc.com designates 199.106.114.39 as permitted sender) smtp.mailfrom=quic_aiquny@quicinc.com; dmarc=pass (policy=none) header.from=quicinc.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1666340493; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=h2fCMR48Gpr6g0cjkfiTbdcqeaJO7CWEJP2WPO9iyJM=; b=kOXbF2vJfEyXFI0BPbm4FAMRIQa3CjIz/7HYm/RVt2BTe3HyEa3hRRMTZMAngrU1B/OUD6 BYZPk2iXgt2W0VCYeCbnKApNt6YSrMniuIgnPWf3XFMbqlYMgTDKWBCRgr0jU7b/dNJiRO JWwJLwQqGhNeTP+D+exFrCySKrCAqQ4= X-Stat-Signature: k55widnjxaghfaaabou3oirgnfpto9e3 X-Rspamd-Queue-Id: C1B8D2003E Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=quicinc.com header.s=qcdkim header.b=B7K5M7JO; spf=pass (imf13.hostedemail.com: domain of quic_aiquny@quicinc.com designates 199.106.114.39 as permitted sender) smtp.mailfrom=quic_aiquny@quicinc.com; dmarc=pass (policy=none) header.from=quicinc.com X-Rspam-User: X-Rspamd-Server: rspam05 X-HE-Tag: 1666340492-998417 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 10/21/2022 2:54 PM, David Hildenbrand wrote: > On 21.10.22 07:19, Maria Yu wrote: >> When !CONFIG_VM_BUG_ON, there is warning of >> clang-analyzer-deadcode.DeadStores: >> Value stored to 'mt' during its initialization >> is never read. >> >> Signed-off-by: Maria Yu >> --- >>   mm/page_isolation.c | 5 ++--- >>   1 file changed, 2 insertions(+), 3 deletions(-) >> >> diff --git a/mm/page_isolation.c b/mm/page_isolation.c >> index 04141a9bea70..a7a478a22123 100644 >> --- a/mm/page_isolation.c >> +++ b/mm/page_isolation.c >> @@ -330,9 +330,8 @@ static int isolate_single_pageblock(unsigned long >> boundary_pfn, int flags, >>                         zone->zone_start_pfn); >>       if (skip_isolation) { >> -        int mt = >> get_pageblock_migratetype(pfn_to_page(isolate_pageblock)); > > __maybe_unused should work as well. Was that considered? > good idea. -- Thx and BRs, Aiqun(Maria) Yu