From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D2AF1C3DA6E for ; Fri, 5 Jan 2024 08:15:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 551716B00D5; Fri, 5 Jan 2024 03:15:40 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 501DF6B00D6; Fri, 5 Jan 2024 03:15:40 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3F1566B00D8; Fri, 5 Jan 2024 03:15:40 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 2C3056B00D5 for ; Fri, 5 Jan 2024 03:15:40 -0500 (EST) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 05EDB120A3B for ; Fri, 5 Jan 2024 08:15:40 +0000 (UTC) X-FDA: 81644548440.21.5D3975F Received: from mail3-relais-sop.national.inria.fr (mail3-relais-sop.national.inria.fr [192.134.164.104]) by imf27.hostedemail.com (Postfix) with ESMTP id 17E514000E for ; Fri, 5 Jan 2024 08:15:37 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=inria.fr header.s=dc header.b=gsiiH6r3; dmarc=pass (policy=none) header.from=inria.fr; spf=pass (imf27.hostedemail.com: domain of julia.lawall@inria.fr designates 192.134.164.104 as permitted sender) smtp.mailfrom=julia.lawall@inria.fr ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1704442538; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding:in-reply-to: references:dkim-signature; bh=GhpmqrsCpB96lWZrxL1eEyGjcO/feDML5CJRxm8/ghg=; b=2AsP9tWlS4eSBYcah5Ifzb+sOjYd+WdOS3y5ulmwGrucFGez5YoWmqffblu5+QcRD04FH/ OySgnHZtBBotycyY3H/yLC73RuA6sm7ymKqVYWl7RIdwiLMuAVBPg3VflJrEGa1b8r3CQw j70ufxNTk3BQTRvNeWUhiPLbdfADpb0= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=inria.fr header.s=dc header.b=gsiiH6r3; dmarc=pass (policy=none) header.from=inria.fr; spf=pass (imf27.hostedemail.com: domain of julia.lawall@inria.fr designates 192.134.164.104 as permitted sender) smtp.mailfrom=julia.lawall@inria.fr ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1704442538; a=rsa-sha256; cv=none; b=E9Mjf7ro20wovhgKUlhaaXnDiRBz3xf8EHczus6HH4PKLdTCQEJGkKhveL1PKUTBfuO1L2 GRZ+UH+kKlaIajeUpE5eXHulW8reMPrAaLkE1Sc56NPNUpmoU0M3rTgUJpLVhE0KUFy33R M06L0pL7H5YhezCVXF+q9HDIurhFEm8= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=inria.fr; s=dc; h=date:from:to:cc:subject:message-id:mime-version; bh=GhpmqrsCpB96lWZrxL1eEyGjcO/feDML5CJRxm8/ghg=; b=gsiiH6r3Aug2Sjm51kaTT3fH0HBbRb4usQ4O60IbIzIMd+xkmxUj8dSM tiRdQ9HvG2kqkujgIh+KLNG8Bao5qk4FCdiKkOdZ7y3zU5o9oyXRatlXu lHx8yBTo78FWAvIRpmpPcz0tYGjSd8wp9cXcrx0gQs9xsiU/glJgQ1DLx o=; X-IronPort-AV: E=Sophos;i="6.04,333,1695679200"; d="scan'208";a="75922341" Received: from dt-lawall.paris.inria.fr ([128.93.67.65]) by mail3-relais-sop.national.inria.fr with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Jan 2024 09:15:37 +0100 Date: Fri, 5 Jan 2024 09:15:35 +0100 (CET) From: Julia Lawall To: Geetha sowjanya cc: Linux Memory Management List , oe-kbuild-all@lists.linux.dev Subject: [linux-next:master 2314/12403] drivers/net/ethernet/marvell/octeontx2/af/rvu_npc_fs.c:575:9-32: duplicated argument to & or | (fwd) Message-ID: <1dcdf9e9-44f1-194-29a9-39994370fe0@inria.fr> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 17E514000E X-Stat-Signature: 65bqah1n6ymfzg45zu9m81umwempi7pu X-HE-Tag: 1704442537-799612 X-HE-Meta: U2FsdGVkX1+lDy+JFyNfMhk9/M7z5aXgsW8i+aPrLP5l+pmkaquUtijvKH/MQztjA54bTdu/scA2FiZ/RInkMtMW0OQ+jwGiLmVNlvsvqgZU45Uk4UQvckxjd3zgXqytUX+L4xlSrLw1RmWRlETRaNt7+OBTQ8+n9G8JoxTlabsGXaiVnY06VOP840hHv0FpzltwIRfuta+094CxrqWOqYTQzy9e4jWpmRFcprE6KJv67JnElCIkBRfqFp6mMqS2himoO5xnX6DwQL1ChsJ038P6jakQNL74/AoGOzhAXiRG8Crc99a4SLnKfjsZFUlglgZAs7VPXS/LFBbYB1CJddtLVU4L45j++0Im6HGWYA4WE0mxOQSFuqE+dP/TagzQW9fDUZ5t6RZ3lJ18t0vnQx7Cq6K5MPLNi9SSCnkUeOa9vFPzcB35lp63MnGXozSm6U9msrtHMm4w+WAY2OyRY5byflhgIwj3xMwAultyoXWhr1C60O7rEbGad/QfNn+871LT+GQunlzw/E6ae4tckL8HCz1xdfknx2ZOtnBn1fjvohgX1JLL8DbZWnBwU4XINreW6FtSVZt4kpCTlZnZ+/eJZj6skNtFh2iqKPfvfgiy3AfpSbCTEa5RCF5QI1YLDyK6kl52f/mUk4gi9XemICuX5EubMFc7yM1+J5zwDcA+P69q/QPplaqEzIdi3Ov9qLMRZQLcBwF3var1WUKjnE5FGo/n7jlZ8nRCd4UNMW/wtL8O2sN7LYYLxzeByfubzUlEpLPRbFsHQkQu/tIizwSmTVSWZYT9DSanMio1D8/Z68R8NhCTnBjGRn+ssDbMLd5Kh1mP2kPbcYwuOfszf67uZiwOJzsoJaXPgzOt/XEy0BdsDQ1hLA8EWf7ZxDvH X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hello, Please check lines 575 and 576, which are identical. julia ---------- Forwarded message ---------- Date: Fri, 5 Jan 2024 12:29:52 +0800 From: kernel test robot To: oe-kbuild@lists.linux.dev Cc: lkp@intel.com, Julia Lawall Subject: [linux-next:master 2314/12403] drivers/net/ethernet/marvell/octeontx2/af/rvu_npc_fs.c:575:9-32: duplicated argument to & or | BCC: lkp@intel.com CC: oe-kbuild-all@lists.linux.dev CC: Linux Memory Management List TO: Geetha sowjanya tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master head: d0b3c8aa5e37775cd7c3ac07b256218df0fd6678 commit: a8d4879d5f1fac060719567d1a8e8f8e68a127fc [2314/12403] octeontx2-pf: TC flower offload support for ICMP type and code :::::: branch date: 23 hours ago :::::: commit date: 6 weeks ago config: arm64-randconfig-r053-20240104 (https://download.01.org/0day-ci/archive/20240105/202401051229.BdWGEvJ9-lkp@intel.com/config) compiler: aarch64-linux-gcc (GCC) 13.2.0 If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Reported-by: Julia Lawall | Closes: https://lore.kernel.org/r/202401051229.BdWGEvJ9-lkp@intel.com/ cocci warnings: (new ones prefixed by >>) >> drivers/net/ethernet/marvell/octeontx2/af/rvu_npc_fs.c:575:9-32: duplicated argument to & or | drivers/net/ethernet/marvell/octeontx2/af/rvu_npc_fs.c:575:35-58: duplicated argument to & or | vim +575 drivers/net/ethernet/marvell/octeontx2/af/rvu_npc_fs.c 9b179a960a96d5 Subbaraya Sundeep 2020-11-15 557 9b179a960a96d5 Subbaraya Sundeep 2020-11-15 558 static void npc_set_features(struct rvu *rvu, int blkaddr, u8 intf) 9b179a960a96d5 Subbaraya Sundeep 2020-11-15 559 { 9b179a960a96d5 Subbaraya Sundeep 2020-11-15 560 struct npc_mcam *mcam = &rvu->hw->mcam; 9b179a960a96d5 Subbaraya Sundeep 2020-11-15 561 u64 *features = &mcam->rx_features; a8d4879d5f1fac Geetha sowjanya 2023-11-22 562 u64 proto_flags; b7cf966126eb16 Naveen Mamindlapalli 2021-01-11 563 int hdr; 9b179a960a96d5 Subbaraya Sundeep 2020-11-15 564 9b179a960a96d5 Subbaraya Sundeep 2020-11-15 565 if (is_npc_intf_tx(intf)) 9b179a960a96d5 Subbaraya Sundeep 2020-11-15 566 features = &mcam->tx_features; 9b179a960a96d5 Subbaraya Sundeep 2020-11-15 567 9b179a960a96d5 Subbaraya Sundeep 2020-11-15 568 for (hdr = NPC_DMAC; hdr < NPC_HEADER_FIELDS_MAX; hdr++) { b7cf966126eb16 Naveen Mamindlapalli 2021-01-11 569 if (npc_check_field(rvu, blkaddr, hdr, intf)) 9b179a960a96d5 Subbaraya Sundeep 2020-11-15 570 *features |= BIT_ULL(hdr); 9b179a960a96d5 Subbaraya Sundeep 2020-11-15 571 } 9b179a960a96d5 Subbaraya Sundeep 2020-11-15 572 a8d4879d5f1fac Geetha sowjanya 2023-11-22 573 proto_flags = BIT_ULL(NPC_SPORT_TCP) | BIT_ULL(NPC_SPORT_UDP) | 9b179a960a96d5 Subbaraya Sundeep 2020-11-15 574 BIT_ULL(NPC_DPORT_TCP) | BIT_ULL(NPC_DPORT_UDP) | a8d4879d5f1fac Geetha sowjanya 2023-11-22 @575 BIT_ULL(NPC_SPORT_SCTP) | BIT_ULL(NPC_DPORT_SCTP) | a8d4879d5f1fac Geetha sowjanya 2023-11-22 576 BIT_ULL(NPC_SPORT_SCTP) | BIT_ULL(NPC_DPORT_SCTP) | a8d4879d5f1fac Geetha sowjanya 2023-11-22 577 BIT_ULL(NPC_TYPE_ICMP) | BIT_ULL(NPC_CODE_ICMP); 9b179a960a96d5 Subbaraya Sundeep 2020-11-15 578 9b179a960a96d5 Subbaraya Sundeep 2020-11-15 579 /* for tcp/udp/sctp corresponding layer type should be in the key */ a8d4879d5f1fac Geetha sowjanya 2023-11-22 580 if (*features & proto_flags) { b7cf966126eb16 Naveen Mamindlapalli 2021-01-11 581 if (!npc_check_field(rvu, blkaddr, NPC_LD, intf)) a8d4879d5f1fac Geetha sowjanya 2023-11-22 582 *features &= ~proto_flags; b7cf966126eb16 Naveen Mamindlapalli 2021-01-11 583 else b7cf966126eb16 Naveen Mamindlapalli 2021-01-11 584 *features |= BIT_ULL(NPC_IPPROTO_TCP) | b7cf966126eb16 Naveen Mamindlapalli 2021-01-11 585 BIT_ULL(NPC_IPPROTO_UDP) | a8d4879d5f1fac Geetha sowjanya 2023-11-22 586 BIT_ULL(NPC_IPPROTO_SCTP) | a8d4879d5f1fac Geetha sowjanya 2023-11-22 587 BIT_ULL(NPC_IPPROTO_ICMP); b7cf966126eb16 Naveen Mamindlapalli 2021-01-11 588 } b7cf966126eb16 Naveen Mamindlapalli 2021-01-11 589 2b9cef66790209 Naveen Mamindlapalli 2021-03-18 590 /* for AH/ICMP/ICMPv6/, check if corresponding layer type is present in the key */ 2b9cef66790209 Naveen Mamindlapalli 2021-03-18 591 if (npc_check_field(rvu, blkaddr, NPC_LD, intf)) { b7cf966126eb16 Naveen Mamindlapalli 2021-01-11 592 *features |= BIT_ULL(NPC_IPPROTO_AH); 2b9cef66790209 Naveen Mamindlapalli 2021-03-18 593 *features |= BIT_ULL(NPC_IPPROTO_ICMP); 2b9cef66790209 Naveen Mamindlapalli 2021-03-18 594 *features |= BIT_ULL(NPC_IPPROTO_ICMP6); 2b9cef66790209 Naveen Mamindlapalli 2021-03-18 595 } b7cf966126eb16 Naveen Mamindlapalli 2021-01-11 596 b7cf966126eb16 Naveen Mamindlapalli 2021-01-11 597 /* for ESP, check if corresponding layer type is present in the key */ b7cf966126eb16 Naveen Mamindlapalli 2021-01-11 598 if (npc_check_field(rvu, blkaddr, NPC_LE, intf)) b7cf966126eb16 Naveen Mamindlapalli 2021-01-11 599 *features |= BIT_ULL(NPC_IPPROTO_ESP); 9b179a960a96d5 Subbaraya Sundeep 2020-11-15 600 9b179a960a96d5 Subbaraya Sundeep 2020-11-15 601 /* for vlan corresponding layer type should be in the key */ 9b179a960a96d5 Subbaraya Sundeep 2020-11-15 602 if (*features & BIT_ULL(NPC_OUTER_VID)) b7cf966126eb16 Naveen Mamindlapalli 2021-01-11 603 if (!npc_check_field(rvu, blkaddr, NPC_LB, intf)) 9b179a960a96d5 Subbaraya Sundeep 2020-11-15 604 *features &= ~BIT_ULL(NPC_OUTER_VID); dce677da57c0ed Subbaraya Sundeep 2021-08-27 605 12aa0a3b93f3ad Ratheesh Kannoth 2023-08-09 606 /* Set SPI flag only if AH/ESP and IPSEC_SPI are in the key */ 12aa0a3b93f3ad Ratheesh Kannoth 2023-08-09 607 if (npc_check_field(rvu, blkaddr, NPC_IPSEC_SPI, intf) && 12aa0a3b93f3ad Ratheesh Kannoth 2023-08-09 608 (*features & (BIT_ULL(NPC_IPPROTO_ESP) | BIT_ULL(NPC_IPPROTO_AH)))) 73b4c04e2e9af8 Ratheesh Kannoth 2023-08-01 609 *features |= BIT_ULL(NPC_IPSEC_SPI); 73b4c04e2e9af8 Ratheesh Kannoth 2023-08-01 610 dce677da57c0ed Subbaraya Sundeep 2021-08-27 611 /* for vlan ethertypes corresponding layer type should be in the key */ dce677da57c0ed Subbaraya Sundeep 2021-08-27 612 if (npc_check_field(rvu, blkaddr, NPC_LB, intf)) dce677da57c0ed Subbaraya Sundeep 2021-08-27 613 *features |= BIT_ULL(NPC_VLAN_ETYPE_CTAG) | dce677da57c0ed Subbaraya Sundeep 2021-08-27 614 BIT_ULL(NPC_VLAN_ETYPE_STAG); 2cee6401c4eaa5 Suman Ghosh 2022-10-31 615 2cee6401c4eaa5 Suman Ghosh 2022-10-31 616 /* for L2M/L2B/L3M/L3B, check if the type is present in the key */ 2cee6401c4eaa5 Suman Ghosh 2022-10-31 617 if (npc_check_field(rvu, blkaddr, NPC_LXMB, intf)) 2cee6401c4eaa5 Suman Ghosh 2022-10-31 618 *features |= BIT_ULL(NPC_LXMB); a63df366d0915a Hariprasad Kelam 2023-09-21 619 a63df366d0915a Hariprasad Kelam 2023-09-21 620 for (hdr = NPC_MPLS1_LBTCBOS; hdr <= NPC_MPLS4_TTL; hdr++) { a63df366d0915a Hariprasad Kelam 2023-09-21 621 if (npc_check_field(rvu, blkaddr, hdr, intf)) a63df366d0915a Hariprasad Kelam 2023-09-21 622 *features |= BIT_ULL(hdr); a63df366d0915a Hariprasad Kelam 2023-09-21 623 } 9b179a960a96d5 Subbaraya Sundeep 2020-11-15 624 } 9b179a960a96d5 Subbaraya Sundeep 2020-11-15 625 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki