From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1AC25C43334 for ; Fri, 10 Jun 2022 09:29:13 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9CAA88D0085; Fri, 10 Jun 2022 05:29:12 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 97B4D6B0152; Fri, 10 Jun 2022 05:29:12 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 843688D0085; Fri, 10 Jun 2022 05:29:12 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 753846B0151 for ; Fri, 10 Jun 2022 05:29:12 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay12.hostedemail.com (Postfix) with ESMTP id 4347E120817 for ; Fri, 10 Jun 2022 09:29:12 +0000 (UTC) X-FDA: 79561802544.26.F0C1F03 Received: from szxga03-in.huawei.com (szxga03-in.huawei.com [45.249.212.189]) by imf16.hostedemail.com (Postfix) with ESMTP id 33BC818005A for ; Fri, 10 Jun 2022 09:29:10 +0000 (UTC) Received: from dggpemm500021.china.huawei.com (unknown [172.30.72.53]) by szxga03-in.huawei.com (SkyGuard) with ESMTP id 4LKFyQ3zdlz9sw6; Fri, 10 Jun 2022 17:28:46 +0800 (CST) Received: from dggpemm500001.china.huawei.com (7.185.36.107) by dggpemm500021.china.huawei.com (7.185.36.109) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Fri, 10 Jun 2022 17:29:07 +0800 Received: from [10.174.177.243] (10.174.177.243) by dggpemm500001.china.huawei.com (7.185.36.107) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Fri, 10 Jun 2022 17:29:05 +0800 Message-ID: <1dca24a0-b538-86c1-a0f5-68fad15e76fe@huawei.com> Date: Fri, 10 Jun 2022 17:29:04 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH v3 3/6] mm: Ratelimited mirrored memory related warning messages Content-Language: en-US To: Wupeng Ma , , , , CC: , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , References: <20220607093805.1354256-1-mawupeng1@huawei.com> <20220607093805.1354256-4-mawupeng1@huawei.com> From: Kefeng Wang In-Reply-To: <20220607093805.1354256-4-mawupeng1@huawei.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.177.243] X-ClientProxiedBy: dggems706-chm.china.huawei.com (10.3.19.183) To dggpemm500001.china.huawei.com (7.185.36.107) X-CFilter-Loop: Reflected ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1654853351; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=iMiDWsDOw5HEFK8sjwPN/UaFRZ9humLD/YLiPidYnLc=; b=CKtcVJaAkPuC2/9Ea1wvQ762vX3AU/K+E4I3zyCEJMaBakcR/sjbuP4k7bPMn6K4a2pwbq rDkD92GvYu6XcYKIM5/5yxsuFHwnaDiGBZJMHl56xZ/oc20Bf3zwXoq+a03klnf3AzDLG5 M+3Zcf4gDyPV3XsASUFhgTEEzlTZ2OI= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1654853351; a=rsa-sha256; cv=none; b=eHy3jcmSAoZ4hb8mU89/uLPH1VTJ36ubz4wvHXdXeTpmI+b4IuPSHCQnWjB/d2F4UiXPF3 UKGIkdgPBq3PicOy+btXi/XKFkXSi+TCWk33gogO0d7mOBibLIbmFwGQhUF51rHDHpT/hb ZI1+XIp9iOuPZTrnMZKaCv+BovnMboU= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf16.hostedemail.com: domain of wangkefeng.wang@huawei.com designates 45.249.212.189 as permitted sender) smtp.mailfrom=wangkefeng.wang@huawei.com X-Rspamd-Server: rspam11 X-Rspam-User: Authentication-Results: imf16.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf16.hostedemail.com: domain of wangkefeng.wang@huawei.com designates 45.249.212.189 as permitted sender) smtp.mailfrom=wangkefeng.wang@huawei.com X-Stat-Signature: ms6cf1ht8oeqjsq5syhn6wjiqi8zsdid X-Rspamd-Queue-Id: 33BC818005A X-HE-Tag: 1654853350-30626 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2022/6/7 17:38, Wupeng Ma wrote: > From: Ma Wupeng > > If system has mirrored memory, memblock will try to allocate mirrored > memory firstly and fallback to non-mirrored memory when fails, but if with > limited mirrored memory or some numa node without mirrored memory, lots of > warning message about memblock allocation will occur. > > This patch ratelimit the warning message to avoid a very long print during > bootup. > > Signed-off-by: Ma Wupeng > --- > mm/memblock.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/mm/memblock.c b/mm/memblock.c > index e4f03a6e8e56..b1d2a0009733 100644 > --- a/mm/memblock.c > +++ b/mm/memblock.c > @@ -327,7 +327,7 @@ static phys_addr_t __init_memblock memblock_find_in_range(phys_addr_t start, > NUMA_NO_NODE, flags); > > if (!ret && (flags & MEMBLOCK_MIRROR)) { > - pr_warn("Could not allocate %pap bytes of mirrored memory\n", > + pr_warn_ratelimited("Could not allocate %pap bytes of mirrored memory\n", > &size); > flags &= ~MEMBLOCK_MIRROR; > goto again; > @@ -1384,7 +1384,7 @@ phys_addr_t __init memblock_alloc_range_nid(phys_addr_t size, > > if (flags & MEMBLOCK_MIRROR) { > flags &= ~MEMBLOCK_MIRROR; > - pr_warn("Could not allocate %pap bytes of mirrored memory\n", > + pr_warn_ratelimited("Could not allocate %pap bytes of mirrored memory\n", > &size); > goto again; > } Reviewed-by: Kefeng Wang