From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C4550C54734 for ; Tue, 27 Aug 2024 14:57:15 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5BF8B6B0085; Tue, 27 Aug 2024 10:57:15 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 56FBC6B0088; Tue, 27 Aug 2024 10:57:15 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 41A616B0089; Tue, 27 Aug 2024 10:57:15 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 25CA96B0085 for ; Tue, 27 Aug 2024 10:57:15 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id CB02E41A43 for ; Tue, 27 Aug 2024 14:57:14 +0000 (UTC) X-FDA: 82498328388.02.AC2AC9F Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf13.hostedemail.com (Postfix) with ESMTP id 679CE20015 for ; Tue, 27 Aug 2024 14:57:12 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b="qqqB3/yM"; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=NSKMILkA; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b="qqqB3/yM"; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=NSKMILkA; spf=pass (imf13.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1724770589; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=0yy2NBHYFODj+vVUY3LM84oVsDd+wzAI8m1uYlDnrZM=; b=g3m93QeFFS+RcFtkBTHU0QiRwOuAn0N0O9eV1p4r5Wy3GiVvdUXvv3bhZ2xZ6ntgWLr8ZU fAedusu7GqU0FrjjdMF5Bf0us3Ae2QZ5H9j1JcHFselyE8hmnHsD2rgBh7jIugmpQGVVQa Kv5yNJX1JuYzMQVx1NnEOImBqEiCMpw= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b="qqqB3/yM"; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=NSKMILkA; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b="qqqB3/yM"; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=NSKMILkA; spf=pass (imf13.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1724770589; a=rsa-sha256; cv=none; b=rZfghRuMmxa889U+p2+PHzOuWnsDK9VczGkEtmsLI7y2/OgDxWH2HRIfdr324N+hi3Lufr siNVkmSwwf5BpH+TpefGrJ1iPF9V36Kj4/L8IH9KgQC8iLUnyQa94zmuH2BBiPSU0soEFS H4zSOgevMYMQMs+G4u85Lmjr4u6R3D8= Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 8AA3921ABC; Tue, 27 Aug 2024 14:57:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1724770630; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=0yy2NBHYFODj+vVUY3LM84oVsDd+wzAI8m1uYlDnrZM=; b=qqqB3/yM5UTdsTl/bdqMjLtvdWDZne27shmrVd58ge4FpTP+ryDINSxr6pBoEkOmBns01e LTxgt/awj1DOD2Uh7jGC2ENG5/vSM6scra7Wn5v7RLbe5O5LORFeBX/JHyyy1YjJhFzd7N T6C3pE8LHCUoFsQjl8eB/bq3JdSa1RQ= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1724770630; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=0yy2NBHYFODj+vVUY3LM84oVsDd+wzAI8m1uYlDnrZM=; b=NSKMILkAxMN2OvsccqWYDhidKWUaxaiuK37jQdWI0D3+uGQv5Ksz6ZslJTM1OPZakhu7I5 beyTfSkafgfldbAQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1724770630; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=0yy2NBHYFODj+vVUY3LM84oVsDd+wzAI8m1uYlDnrZM=; b=qqqB3/yM5UTdsTl/bdqMjLtvdWDZne27shmrVd58ge4FpTP+ryDINSxr6pBoEkOmBns01e LTxgt/awj1DOD2Uh7jGC2ENG5/vSM6scra7Wn5v7RLbe5O5LORFeBX/JHyyy1YjJhFzd7N T6C3pE8LHCUoFsQjl8eB/bq3JdSa1RQ= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1724770630; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=0yy2NBHYFODj+vVUY3LM84oVsDd+wzAI8m1uYlDnrZM=; b=NSKMILkAxMN2OvsccqWYDhidKWUaxaiuK37jQdWI0D3+uGQv5Ksz6ZslJTM1OPZakhu7I5 beyTfSkafgfldbAQ== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 69AFA13724; Tue, 27 Aug 2024 14:57:10 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id r8wYGUbpzWbJGgAAD6G6ig (envelope-from ); Tue, 27 Aug 2024 14:57:10 +0000 Message-ID: <1dc544a0-5c32-43dc-8f6c-d0bf130cecad@suse.cz> Date: Tue, 27 Aug 2024 16:57:10 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1] mm:slab:use kmem_cache_free() to free Content-Language: en-US From: Vlastimil Babka To: "Christoph Lameter (Ampere)" , Yan Zhen Cc: penberg@kernel.org, rientjes@google.com, iamjoonsoo.kim@lge.com, akpm@linux-foundation.org, roman.gushchin@linux.dev, 42.hyeyoo@gmail.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, opensource.kernel@vivo.com, Kees Cook References: <20240822022704.1195439-1-yanzhen@vivo.com> <1bb9fcbc-310a-ad36-9e96-61dc80681f12@gentwo.org> Autocrypt: addr=vbabka@suse.cz; keydata= xsFNBFZdmxYBEADsw/SiUSjB0dM+vSh95UkgcHjzEVBlby/Fg+g42O7LAEkCYXi/vvq31JTB KxRWDHX0R2tgpFDXHnzZcQywawu8eSq0LxzxFNYMvtB7sV1pxYwej2qx9B75qW2plBs+7+YB 87tMFA+u+L4Z5xAzIimfLD5EKC56kJ1CsXlM8S/LHcmdD9Ctkn3trYDNnat0eoAcfPIP2OZ+ 9oe9IF/R28zmh0ifLXyJQQz5ofdj4bPf8ecEW0rhcqHfTD8k4yK0xxt3xW+6Exqp9n9bydiy tcSAw/TahjW6yrA+6JhSBv1v2tIm+itQc073zjSX8OFL51qQVzRFr7H2UQG33lw2QrvHRXqD Ot7ViKam7v0Ho9wEWiQOOZlHItOOXFphWb2yq3nzrKe45oWoSgkxKb97MVsQ+q2SYjJRBBH4 8qKhphADYxkIP6yut/eaj9ImvRUZZRi0DTc8xfnvHGTjKbJzC2xpFcY0DQbZzuwsIZ8OPJCc LM4S7mT25NE5kUTG/TKQCk922vRdGVMoLA7dIQrgXnRXtyT61sg8PG4wcfOnuWf8577aXP1x 6mzw3/jh3F+oSBHb/GcLC7mvWreJifUL2gEdssGfXhGWBo6zLS3qhgtwjay0Jl+kza1lo+Cv BB2T79D4WGdDuVa4eOrQ02TxqGN7G0Biz5ZLRSFzQSQwLn8fbwARAQABzSBWbGFzdGltaWwg QmFia2EgPHZiYWJrYUBzdXNlLmN6PsLBlAQTAQoAPgIbAwULCQgHAwUVCgkICwUWAgMBAAIe AQIXgBYhBKlA1DSZLC6OmRA9UCJPp+fMgqZkBQJkBREIBQkRadznAAoJECJPp+fMgqZkNxIQ ALZRqwdUGzqL2aeSavbum/VF/+td+nZfuH0xeWiO2w8mG0+nPd5j9ujYeHcUP1edE7uQrjOC Gs9sm8+W1xYnbClMJTsXiAV88D2btFUdU1mCXURAL9wWZ8Jsmz5ZH2V6AUszvNezsS/VIT87 AmTtj31TLDGwdxaZTSYLwAOOOtyqafOEq+gJB30RxTRE3h3G1zpO7OM9K6ysLdAlwAGYWgJJ V4JqGsQ/lyEtxxFpUCjb5Pztp7cQxhlkil0oBYHkudiG8j1U3DG8iC6rnB4yJaLphKx57NuQ PIY0Bccg+r9gIQ4XeSK2PQhdXdy3UWBr913ZQ9AI2usid3s5vabo4iBvpJNFLgUmxFnr73SJ KsRh/2OBsg1XXF/wRQGBO9vRuJUAbnaIVcmGOUogdBVS9Sun/Sy4GNA++KtFZK95U7J417/J Hub2xV6Ehc7UGW6fIvIQmzJ3zaTEfuriU1P8ayfddrAgZb25JnOW7L1zdYL8rXiezOyYZ8Fm ZyXjzWdO0RpxcUEp6GsJr11Bc4F3aae9OZtwtLL/jxc7y6pUugB00PodgnQ6CMcfR/HjXlae h2VS3zl9+tQWHu6s1R58t5BuMS2FNA58wU/IazImc/ZQA+slDBfhRDGYlExjg19UXWe/gMcl De3P1kxYPgZdGE2eZpRLIbt+rYnqQKy8UxlszsBNBFsZNTUBCACfQfpSsWJZyi+SHoRdVyX5 J6rI7okc4+b571a7RXD5UhS9dlVRVVAtrU9ANSLqPTQKGVxHrqD39XSw8hxK61pw8p90pg4G /N3iuWEvyt+t0SxDDkClnGsDyRhlUyEWYFEoBrrCizbmahOUwqkJbNMfzj5Y7n7OIJOxNRkB IBOjPdF26dMP69BwePQao1M8Acrrex9sAHYjQGyVmReRjVEtv9iG4DoTsnIR3amKVk6si4Ea X/mrapJqSCcBUVYUFH8M7bsm4CSxier5ofy8jTEa/CfvkqpKThTMCQPNZKY7hke5qEq1CBk2 wxhX48ZrJEFf1v3NuV3OimgsF2odzieNABEBAAHCwXwEGAEKACYCGwwWIQSpQNQ0mSwujpkQ PVAiT6fnzIKmZAUCZAUSmwUJDK5EZgAKCRAiT6fnzIKmZOJGEACOKABgo9wJXsbWhGWYO7mD 8R8mUyJHqbvaz+yTLnvRwfe/VwafFfDMx5GYVYzMY9TWpA8psFTKTUIIQmx2scYsRBUwm5VI EurRWKqENcDRjyo+ol59j0FViYysjQQeobXBDDE31t5SBg++veI6tXfpco/UiKEsDswL1WAr tEAZaruo7254TyH+gydURl2wJuzo/aZ7Y7PpqaODbYv727Dvm5eX64HCyyAH0s6sOCyGF5/p eIhrOn24oBf67KtdAN3H9JoFNUVTYJc1VJU3R1JtVdgwEdr+NEciEfYl0O19VpLE/PZxP4wX PWnhf5WjdoNI1Xec+RcJ5p/pSel0jnvBX8L2cmniYnmI883NhtGZsEWj++wyKiS4NranDFlA HdDM3b4lUth1pTtABKQ1YuTvehj7EfoWD3bv9kuGZGPrAeFNiHPdOT7DaXKeHpW9homgtBxj 8aX/UkSvEGJKUEbFL9cVa5tzyialGkSiZJNkWgeHe+jEcfRT6pJZOJidSCdzvJpbdJmm+eED w9XOLH1IIWh7RURU7G1iOfEfmImFeC3cbbS73LQEFGe1urxvIH5K/7vX+FkNcr9ujwWuPE9b 1C2o4i/yZPLXIVy387EjA6GZMqvQUFuSTs/GeBcv0NjIQi8867H3uLjz+mQy63fAitsDwLmR EP+ylKVEKb0Q2A== In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam03 X-Rspam-User: X-Rspamd-Queue-Id: 679CE20015 X-Stat-Signature: tqs48uri6agwctjs13dja3bpsdstbf4p X-HE-Tag: 1724770632-499457 X-HE-Meta: U2FsdGVkX192bDLFPfRYLPEPkrYNG5c2vxUJZY1t0dQmcRtnBPO/1j79CopMy+5fXKHen702fxwAs5NYB6H8uFsNIMnFgL7/2W41RJ/nn3xVmzWYgpx/WLT3sVhJt7jdwrTuF+pJkYuX1j9K/Xk091x51fc6a3VAYlFe30dwBn0y+tPzTGqznL61PeE4kVvrFQ2h/jprkNklpsrlkR22yqes6gi7TgGN330esHUCEg87mMW6NGkw2Y+dJVRKbDKLq09258jn+4DEytaPWPY6H3vF2Yc3qZA/M6JNPb01wF0CidmtnTshHb2FWB3+x7b/glPVvNHJnnPUT032F+jkRjk1RRFCba9tu2hZnNpRTn0xU22KeR69/I/hJ+PyHyNFqS8TRG/PIOKAxo5pRNul8aFENBl0AnTznIuFg6CKspxp3DMmH083prWalr8xwKf+Jw6EhElFKiEHHi1ojrwsvUlOPgSgIS2Cj2m6VNggYXtbZcI8UjhbSQ9F/R6LdzW1KQiokx4k5BxNs6vpiqIMy9ps4NtZkSwhh/saCh+C23yn5p2Jka5KnhKiECjSPhvtddaKc05YDl8qr9aVknftuVhadcVlMdNOeiNKd+95TebA+9zxO8vKPOqqWUhTLArj+a5sS/qPsb+YHVUPgWPobrvz175wKtYnT90nCsmIlCz6Z9d/crHaGBMupvddfmuyLA05FspJi7V+OFA93avVnaZJcU/+PNBWtW4eOT85v/JAPkZc2Y/KsMestNiRnLY6kaIK0ceSiQLKhbIxWzJbYXam2Hg45/IGcXBdeSuNZ8sl9wm8YX3lOe9ho6VInVyjrFiF082jxFK0P/0LTCSNwPeN3gtH46q4iMQrIIeX7/MiC5aKSwXeXrjEIqSjWHxeq0+rPVbZpTvG/fjOFmTbjz5GM/uzIx9ZD0MMcHgci/8ARVYKzQbcQ7YLoecFcQxm7GoNJ3V0qZ/SsZb1O4m zVVLU1fp 3KvHQGPETuWe/7s6jCOg/lxOmdISVm32pYqNdcwIFG6Mo8KysGTIDycnkdA48+JMrGo0k34vaK+btkOZkQ9wDYjUP8mcaHVc+HfVYb8hUKcNBGp6dHapzOrpT3GMgNHmyGKKpoyoq/VCanE0PblxTphW1sVBS21uLrgoeLCyWbVbEbq5oJbnuEi2A7xW1Zc2EhdXoFtmxcDA0PZ8SO4ZXeyvcN0vSI0l2fNd5+2fV8jZ4hxiRbAcYyI8+b9ElZHG7/PG3cin57f9M5zGGnQHPLzyrcFPT3tDFP+jOfkwwajc3ysZ4SDmR36QG9YdRslShhhmGOMf6CCddXQGLMFgHJOqtiFD6Po6wUxTRSeNQ34qBvw/chjwH7RMmx3m7XLBlqxTKdXJfOudws288tlSA+EvSJX7Gy/QKMphFJ0kop5+GvHrBvaytcSTj+A== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 8/27/24 16:49, Vlastimil Babka wrote: > On 8/22/24 18:59, Christoph Lameter (Ampere) wrote: >> On Thu, 22 Aug 2024, Yan Zhen wrote: >> >>> The kmem_cache_alloc() is typically used to free memory allocated through >>> the kernel memory cache (slab allocator). oh but _alloc() is used to alloc, not free. >> >> Well yes but since we removed SLOB we can use kfree() on any slab object. >> >>> Using kmem_cache_free() for deallocation may be more reasonable. so I've reworded the commit log a bit. mm, slab: use kmem_cache_free() to free from kmem_buckets_cache In kmem_buckets_create(), the kmem_buckets object is allocated by kmem_cache_alloc() from kmem_buckets_cache, but in the failure case, it's freed by kfree(), which is not wrong, but using kmem_cache_free() is the more common pattern, so use it. >> It is more symmetric and looks better. > > Right, added to slab/for-next, thanks. > >> Reviewed-by: Christoph Lameter >