From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 25F70D65C66 for ; Thu, 14 Nov 2024 09:43:55 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8D28A6B007B; Thu, 14 Nov 2024 04:43:54 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 882B06B0082; Thu, 14 Nov 2024 04:43:54 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6FC8C6B0083; Thu, 14 Nov 2024 04:43:54 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 4F7176B007B for ; Thu, 14 Nov 2024 04:43:54 -0500 (EST) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id C41F81210E1 for ; Thu, 14 Nov 2024 09:43:53 +0000 (UTC) X-FDA: 82784212560.21.7B132F2 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by imf23.hostedemail.com (Postfix) with ESMTP id 4652614075E for ; Thu, 14 Nov 2024 09:42:58 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=lH+paarg; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=8gmWwWer; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=lH+paarg; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=8gmWwWer; spf=pass (imf23.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1731577263; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=UPHmLcVcL9xfETg7OAJ2zqh9E1K9i5STeOVJBWrux7c=; b=mSKfjXAM2l9wviXZ0+D5Ld6d1h56qGSqjcDeFfOE6cpkPrukoSmj0wLY13XibbGsL2zjI2 Azvj6GS0TOwYH9EicklfQPZVRJDPNKMHEhAc/bMx52ZL8LrojdkDX9vummOhnWNWAJOYtb grDZp7ylGtn4FBAty8qFqfk1+Tf8sZc= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1731577263; a=rsa-sha256; cv=none; b=wPb6YjIB6asdcRInWnmyZ/QP6AvyLh7qM5qTay4G8JJwY+FVvsF3zQxq+FMj0NheN/IK0O S/+80ZafyZ9Nntwu/CL7K2srClm0ZN5aW5EwshUZev5F8yR51QwWpCmTss1BI5N8RG1hHv u/BLwRoQTAA5mZH9iIicyAWWTDiUMhY= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=lH+paarg; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=8gmWwWer; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=lH+paarg; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=8gmWwWer; spf=pass (imf23.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 719FB1F78A; Thu, 14 Nov 2024 09:43:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1731577405; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=UPHmLcVcL9xfETg7OAJ2zqh9E1K9i5STeOVJBWrux7c=; b=lH+paargPPFs7fdK+5c20Hdd0lEOl3gVObeEtxMViRQPYTYYwlT3Tp7bgw0y7gkTSa0Olb OXpOQ5jhq6QwJVwN7OwkWcavcnbbS5em+4lvGK5nxRw+17Ba9Y4wBLdr5jcVG/6jeBVGfN J2fYloM+77XON/WH/zCRmKNc3z/Y/b8= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1731577405; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=UPHmLcVcL9xfETg7OAJ2zqh9E1K9i5STeOVJBWrux7c=; b=8gmWwWerVB2Q1TMOv5Podk1LMJepG9g36fZZy5j5X1ABpFbnnNKXy19pG6qkgNGr565Nxa TM5R5GYWjjpefgCQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1731577405; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=UPHmLcVcL9xfETg7OAJ2zqh9E1K9i5STeOVJBWrux7c=; b=lH+paargPPFs7fdK+5c20Hdd0lEOl3gVObeEtxMViRQPYTYYwlT3Tp7bgw0y7gkTSa0Olb OXpOQ5jhq6QwJVwN7OwkWcavcnbbS5em+4lvGK5nxRw+17Ba9Y4wBLdr5jcVG/6jeBVGfN J2fYloM+77XON/WH/zCRmKNc3z/Y/b8= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1731577405; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=UPHmLcVcL9xfETg7OAJ2zqh9E1K9i5STeOVJBWrux7c=; b=8gmWwWerVB2Q1TMOv5Podk1LMJepG9g36fZZy5j5X1ABpFbnnNKXy19pG6qkgNGr565Nxa TM5R5GYWjjpefgCQ== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 4C08B13794; Thu, 14 Nov 2024 09:43:25 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id VtowEj3GNWcsEgAAD6G6ig (envelope-from ); Thu, 14 Nov 2024 09:43:25 +0000 Message-ID: <1db4bb59-bd68-4aff-883b-1af40ca123b2@suse.cz> Date: Thu, 14 Nov 2024 10:43:25 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC PATCH v1 04/57] mm/page_alloc: Make page_frag_cache boot-time page size compatible Content-Language: en-US To: Ryan Roberts , Andrew Morton , Anshuman Khandual , Ard Biesheuvel , Catalin Marinas , David Hildenbrand , Greg Marsden , Ivan Ivanov , Kalesh Singh , Marc Zyngier , Mark Rutland , Matthias Brugger , Miroslav Benes , Will Deacon Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org References: <20241014105514.3206191-1-ryan.roberts@arm.com> <20241014105912.3207374-1-ryan.roberts@arm.com> <20241014105912.3207374-4-ryan.roberts@arm.com> <1d9f9188-42b1-4f83-87e7-e02a22b67caa@suse.cz> <0aabbc9e-8808-4aaa-a722-49ed3d45d15e@arm.com> From: Vlastimil Babka Autocrypt: addr=vbabka@suse.cz; keydata= xsFNBFZdmxYBEADsw/SiUSjB0dM+vSh95UkgcHjzEVBlby/Fg+g42O7LAEkCYXi/vvq31JTB KxRWDHX0R2tgpFDXHnzZcQywawu8eSq0LxzxFNYMvtB7sV1pxYwej2qx9B75qW2plBs+7+YB 87tMFA+u+L4Z5xAzIimfLD5EKC56kJ1CsXlM8S/LHcmdD9Ctkn3trYDNnat0eoAcfPIP2OZ+ 9oe9IF/R28zmh0ifLXyJQQz5ofdj4bPf8ecEW0rhcqHfTD8k4yK0xxt3xW+6Exqp9n9bydiy tcSAw/TahjW6yrA+6JhSBv1v2tIm+itQc073zjSX8OFL51qQVzRFr7H2UQG33lw2QrvHRXqD Ot7ViKam7v0Ho9wEWiQOOZlHItOOXFphWb2yq3nzrKe45oWoSgkxKb97MVsQ+q2SYjJRBBH4 8qKhphADYxkIP6yut/eaj9ImvRUZZRi0DTc8xfnvHGTjKbJzC2xpFcY0DQbZzuwsIZ8OPJCc LM4S7mT25NE5kUTG/TKQCk922vRdGVMoLA7dIQrgXnRXtyT61sg8PG4wcfOnuWf8577aXP1x 6mzw3/jh3F+oSBHb/GcLC7mvWreJifUL2gEdssGfXhGWBo6zLS3qhgtwjay0Jl+kza1lo+Cv BB2T79D4WGdDuVa4eOrQ02TxqGN7G0Biz5ZLRSFzQSQwLn8fbwARAQABzSBWbGFzdGltaWwg QmFia2EgPHZiYWJrYUBzdXNlLmN6PsLBlAQTAQoAPgIbAwULCQgHAwUVCgkICwUWAgMBAAIe AQIXgBYhBKlA1DSZLC6OmRA9UCJPp+fMgqZkBQJkBREIBQkRadznAAoJECJPp+fMgqZkNxIQ ALZRqwdUGzqL2aeSavbum/VF/+td+nZfuH0xeWiO2w8mG0+nPd5j9ujYeHcUP1edE7uQrjOC Gs9sm8+W1xYnbClMJTsXiAV88D2btFUdU1mCXURAL9wWZ8Jsmz5ZH2V6AUszvNezsS/VIT87 AmTtj31TLDGwdxaZTSYLwAOOOtyqafOEq+gJB30RxTRE3h3G1zpO7OM9K6ysLdAlwAGYWgJJ V4JqGsQ/lyEtxxFpUCjb5Pztp7cQxhlkil0oBYHkudiG8j1U3DG8iC6rnB4yJaLphKx57NuQ PIY0Bccg+r9gIQ4XeSK2PQhdXdy3UWBr913ZQ9AI2usid3s5vabo4iBvpJNFLgUmxFnr73SJ KsRh/2OBsg1XXF/wRQGBO9vRuJUAbnaIVcmGOUogdBVS9Sun/Sy4GNA++KtFZK95U7J417/J Hub2xV6Ehc7UGW6fIvIQmzJ3zaTEfuriU1P8ayfddrAgZb25JnOW7L1zdYL8rXiezOyYZ8Fm ZyXjzWdO0RpxcUEp6GsJr11Bc4F3aae9OZtwtLL/jxc7y6pUugB00PodgnQ6CMcfR/HjXlae h2VS3zl9+tQWHu6s1R58t5BuMS2FNA58wU/IazImc/ZQA+slDBfhRDGYlExjg19UXWe/gMcl De3P1kxYPgZdGE2eZpRLIbt+rYnqQKy8UxlszsBNBFsZNTUBCACfQfpSsWJZyi+SHoRdVyX5 J6rI7okc4+b571a7RXD5UhS9dlVRVVAtrU9ANSLqPTQKGVxHrqD39XSw8hxK61pw8p90pg4G /N3iuWEvyt+t0SxDDkClnGsDyRhlUyEWYFEoBrrCizbmahOUwqkJbNMfzj5Y7n7OIJOxNRkB IBOjPdF26dMP69BwePQao1M8Acrrex9sAHYjQGyVmReRjVEtv9iG4DoTsnIR3amKVk6si4Ea X/mrapJqSCcBUVYUFH8M7bsm4CSxier5ofy8jTEa/CfvkqpKThTMCQPNZKY7hke5qEq1CBk2 wxhX48ZrJEFf1v3NuV3OimgsF2odzieNABEBAAHCwXwEGAEKACYCGwwWIQSpQNQ0mSwujpkQ PVAiT6fnzIKmZAUCZAUSmwUJDK5EZgAKCRAiT6fnzIKmZOJGEACOKABgo9wJXsbWhGWYO7mD 8R8mUyJHqbvaz+yTLnvRwfe/VwafFfDMx5GYVYzMY9TWpA8psFTKTUIIQmx2scYsRBUwm5VI EurRWKqENcDRjyo+ol59j0FViYysjQQeobXBDDE31t5SBg++veI6tXfpco/UiKEsDswL1WAr tEAZaruo7254TyH+gydURl2wJuzo/aZ7Y7PpqaODbYv727Dvm5eX64HCyyAH0s6sOCyGF5/p eIhrOn24oBf67KtdAN3H9JoFNUVTYJc1VJU3R1JtVdgwEdr+NEciEfYl0O19VpLE/PZxP4wX PWnhf5WjdoNI1Xec+RcJ5p/pSel0jnvBX8L2cmniYnmI883NhtGZsEWj++wyKiS4NranDFlA HdDM3b4lUth1pTtABKQ1YuTvehj7EfoWD3bv9kuGZGPrAeFNiHPdOT7DaXKeHpW9homgtBxj 8aX/UkSvEGJKUEbFL9cVa5tzyialGkSiZJNkWgeHe+jEcfRT6pJZOJidSCdzvJpbdJmm+eED w9XOLH1IIWh7RURU7G1iOfEfmImFeC3cbbS73LQEFGe1urxvIH5K/7vX+FkNcr9ujwWuPE9b 1C2o4i/yZPLXIVy387EjA6GZMqvQUFuSTs/GeBcv0NjIQi8867H3uLjz+mQy63fAitsDwLmR EP+ylKVEKb0Q2A== In-Reply-To: <0aabbc9e-8808-4aaa-a722-49ed3d45d15e@arm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Action: no action X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 4652614075E X-Stat-Signature: c8ri3tzesogep76ariz5qghj3n6649i8 X-HE-Tag: 1731577378-246696 X-HE-Meta: U2FsdGVkX1+fZgCOhMewiKwge0K40yu0023lWiwXTtCePUX5POmnd/BabO5WEjHUL7MXFAtngr+AB9uKBxZ/QPHtUOYEiPNDd+EA5hWiccFahdhLxCwFWaR49sUr79T5ndXTRCdK/T/+LqD6FVL+Ebf9vciWcWdiZuHN/xRw1ebqRR30F8Yum+CU9WDu4joWAwdJn+ek+9NLsjkYRQSRQEn9UzDjloQdimeE71D1KD+eCAgaH5KA/qfjQ/sI11Ai/59E2oOS0i6Xg7MCB7AONQfZx3xjmV6Su7Y0vIzrM2IgU+MWwXF4ceDbzVWWZsOoxi6xqRlxWVl4xfYwJyDKtiQ0mDve6G3YX3Ko7QrXMqrjrFh1h6sbkU37hm0xFA2xVRJJYcdqUF8EjxTMqxFbO7Rw8lXl/4unGiu1zYK5fy+7dBlA32Uqefl2bb24B2tKPsqTIhmtEyq1MHAdZIH7cQEVSjKwfGQmHjpWnWEmeYw9wM3FotYStMcWrQ7kLHhhEJknv9TVCN86P9sblE2WfC9+vT2N8pCSnu8D//wiSB4cuC9JYA3/WKQWPuN3k8guFh1R52qDLShm51wMFA+VGkq8jrmkT06c609z8dYCVm5kq3ue67NDU3PeKh9ErfK/1ggG6A6PQ8N4AHuc73R3PMApdK7fF/WGD32WmI0U83uP+8VlozT0VKHj2nHnbtgQek6eRpjM0NjR98PIUWzse9ePGP1SnIN/YSyxOOAnbhZUDwkLU/MzxoJZrqVYthet6j8R7BHa1U3w/+vfFjeR3MugAiDSXKQPyaJKJ+Vfl3GLq2eFviX+DLhO8FCBcwtWQie4N2RHh6fPjajj5+l8JZdxowCMfzQGkq8XtetO7bpRLbDW37SFxgizNsG+mVDgJSPCjLvsIfIP+SI2bYZ68jlr4Icb3dY3ZedYaLs+qKPOZVi97McSt4VkXnWhCLstWfKrlAHsCrVV07bI7lb 3sA8xMRQ qoAETwuMLIW+UGpOenMUEUoR3pDUapqU49DnGbxsBzEqSPhqqCc7XfR+NecNTf5fddPnKC3tVQZEkcQhhl81wV4ZtesAx79yTtIC6EjsiBx+71tA3VrXgnvCGhI3CH6yDMQSjE2ikMG+hSFs3JB4C/WYuio6ZnYz62YepbuXGEUdUSCy/zeXfBAq0x6aFGhwWtbmPK5/pfKhylM4yaC2ziBhXDuUDVrTc9Cp+eI9oqVCQ8RAWnWjb8i9XXyjH7eXv+uFROWBMCPBSe9U90f77Jq7daQPuVG1Guy2E76fVxO6zgz1BiZoVo1afeZ+4D1H0p/Ynt2Rjz1SzAjTi0slQoyt0khbM8UgoNcVhfSC2DSvhxnpKxUHos80/ICC18vGMqAk4pWXT6nKF8Q0= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 11/14/24 10:36, Ryan Roberts wrote: > On 14/11/2024 08:23, Vlastimil Babka wrote: >> On 10/14/24 12:58, Ryan Roberts wrote: >>> "struct page_frag_cache" has some optimizations that depend on page >>> size. Let's refactor it a bit so that those optimizations can be >>> determined at run-time for the case where page size is a boot-time >>> parameter. For compile-time page size, the compiler should dead code >>> strip and the result is very similar to before. >>> >>> One wrinkle is that we don't know if we need the size member until >>> runtime. So remove the ifdeffery and always define offset as u32 (needed >>> if PAGE_SIZE is >= 64K) and size as u16 (only used when PAGE_SIZE <= >>> 32K). We move the members around a bit so that the overall size of the >>> struct remains the same; 24 bytes for 64-bit and 16 bytes on 32 bit. >>> >>> Signed-off-by: Ryan Roberts >> >> Looks ok, but ideally the PAGE_FRAG_CACHE_MAX_ORDER #define should also be >> replaced by some variable that's populated just once. It can be static local >> to page_alloc.c as nothing else seems to use it. > > I can certainly do that, but wouldn't that be penalizing a compile-time page > size configuration? My current change means that PAGE_FRAG_CACHE_MAX_ORDER still > resolves to a compile-time constant in that situation and the compiler can > eliminate conditional branches it knows will never be taken. Or perhaps you're Ah, I see. > suggesting I conditionally make it a variable if PAGE_SIZE_MIN != PAGE_SIZE_MAX? Given the only place it's being used, it shouldn't be worth it after all. You can add for this patch: Acked-by: Vlastimil Babka > Thanks, > Ryan