From: Mike Kravetz <mike.kravetz@oracle.com>
To: Muchun Song <songmuchun@bytedance.com>,
akpm@linux-foundation.org, osalvador@suse.de, mhocko@suse.com,
song.bao.hua@hisilicon.com, david@redhat.com,
chenhuang5@huawei.com, bodeddub@amazon.com, corbet@lwn.net
Cc: duanxiongchun@bytedance.com, fam.zheng@bytedance.com,
zhengqi.arch@bytedance.com, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH 1/5] mm: hugetlb: introduce helpers to preallocate/free page tables
Date: Thu, 10 Jun 2021 14:49:19 -0700 [thread overview]
Message-ID: <1db48b66-8b99-ab4d-4b15-b4dcb7084e8d@oracle.com> (raw)
In-Reply-To: <20210609121310.62229-2-songmuchun@bytedance.com>
On 6/9/21 5:13 AM, Muchun Song wrote:
> On some architectures (e.g. x86_64 and arm64), vmemmap pages are usually
> mapped with huge pmd. We will disable the huge pmd mapping of vmemmap
> pages when the feature of "Free vmemmap pages of HugeTLB page" is enabled.
> This can affect the non-HugeTLB pages. What we want is only mapping the
> vmemmap pages associated with HugeTLB pages with base page. We can split
> the huge pmd mapping of vmemmap pages when freeing vmemmap pages of
> HugeTLB page. But we need to preallocate page tables. In this patch, we
> introduce page tables allocationg/freeing helpers.
>
> Signed-off-by: Muchun Song <songmuchun@bytedance.com>
> ---
> mm/hugetlb_vmemmap.c | 54 ++++++++++++++++++++++++++++++++++++++++++++++++++++
> mm/hugetlb_vmemmap.h | 12 ++++++++++++
> 2 files changed, 66 insertions(+)
These helper routines are pretty straight forward.
Reviewed-by: Mike Kravetz <mike.kravetz@oracle.com>
--
Mike Kravetz
next prev parent reply other threads:[~2021-06-10 21:58 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-09 12:13 [PATCH 0/5] Split huge PMD mapping of vmemmap pages Muchun Song
2021-06-09 12:13 ` [PATCH 1/5] mm: hugetlb: introduce helpers to preallocate/free page tables Muchun Song
2021-06-10 21:49 ` Mike Kravetz [this message]
2021-06-09 12:13 ` [PATCH 2/5] mm: hugetlb: introduce helpers to preallocate page tables from bootmem allocator Muchun Song
2021-06-09 12:13 ` [PATCH 3/5] mm: sparsemem: split the huge PMD mapping of vmemmap pages Muchun Song
2021-06-09 12:13 ` [PATCH 4/5] mm: sparsemem: use huge PMD mapping for " Muchun Song
2021-06-09 12:13 ` [PATCH 5/5] mm: hugetlb: introduce CONFIG_HUGETLB_PAGE_FREE_VMEMMAP_DEFAULT_ON Muchun Song
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1db48b66-8b99-ab4d-4b15-b4dcb7084e8d@oracle.com \
--to=mike.kravetz@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=bodeddub@amazon.com \
--cc=chenhuang5@huawei.com \
--cc=corbet@lwn.net \
--cc=david@redhat.com \
--cc=duanxiongchun@bytedance.com \
--cc=fam.zheng@bytedance.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=osalvador@suse.de \
--cc=song.bao.hua@hisilicon.com \
--cc=songmuchun@bytedance.com \
--cc=zhengqi.arch@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox