From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5DA39EB64DD for ; Fri, 11 Aug 2023 16:49:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E832D6B0074; Fri, 11 Aug 2023 12:49:02 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E331D6B0078; Fri, 11 Aug 2023 12:49:02 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CFAAC6B007B; Fri, 11 Aug 2023 12:49:02 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id BCFD46B0074 for ; Fri, 11 Aug 2023 12:49:02 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 66933B1869 for ; Fri, 11 Aug 2023 16:49:02 +0000 (UTC) X-FDA: 81112408524.30.178C270 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf07.hostedemail.com (Postfix) with ESMTP id B42E440007 for ; Fri, 11 Aug 2023 16:49:00 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=RAAJf3tl; spf=pass (imf07.hostedemail.com: domain of "SRS0=VRW/=D4=paulmck-ThinkPad-P17-Gen-1.home=paulmck@kernel.org" designates 139.178.84.217 as permitted sender) smtp.mailfrom="SRS0=VRW/=D4=paulmck-ThinkPad-P17-Gen-1.home=paulmck@kernel.org"; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1691772540; a=rsa-sha256; cv=none; b=JucXvOFvw+i30fmnA48mWV2JKjGgK+4hXUXYo1lbAeK5dpv8rI5n2Zgt6aOTa/vkXe/Mb5 M00kr8ts5zdUqJI9+nFTs2xzs0nE+88Rc5zMkJZKtjVDtOnc+TsPSBHZEKG/OB0bpsu/AQ LyV5x+FEwmZWv0baEQYh5g15xYeFmh0= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=RAAJf3tl; spf=pass (imf07.hostedemail.com: domain of "SRS0=VRW/=D4=paulmck-ThinkPad-P17-Gen-1.home=paulmck@kernel.org" designates 139.178.84.217 as permitted sender) smtp.mailfrom="SRS0=VRW/=D4=paulmck-ThinkPad-P17-Gen-1.home=paulmck@kernel.org"; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1691772540; h=from:from:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=a4f4Gl4gPPK9KYIng0Wo6us9VJ41ZYoyq1t+FbhSoRo=; b=7nGofNideNfExEmKMppHJLJm/mFRhBM5ktLCqMmj4nktgtnZy+FKNTKZvcy6YuPdS7KMOi 1o19EhP5aLavSgLkh3+Bq7R1xge5BsLsC7rjIXCNbpQJGWOKWqGvM44hdgA+p+wOt0jvEI AIdfgj+uILBYyMUYwPClwdbw2nXQpII= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id D9D28653A0; Fri, 11 Aug 2023 16:48:59 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4C6BEC433C8; Fri, 11 Aug 2023 16:48:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1691772539; bh=Av3U0Q7AgXiB9TVGvCYc5p4MZ/bSQz3gqzAlPVvE6j0=; h=Date:From:To:Cc:Subject:Reply-To:References:In-Reply-To:From; b=RAAJf3tlrDlpl4WMhbaBAuSlCvU2eDGiumVqde4GY03O3gITQZSeyiDS060BnbOun P648GI+a3YdVq/NX+gON96/LuiW4G43KksBA0b1L+wtJzO1oAhFpGYZWT05B9ldPRa AZT7RSdMVyl2bf85Fyh44ngFAnHMJg+xbpuK26zkWdITROqfnoxy1lHSn3El0FsLGE SPzzOyj5+3TLeG6RIl/BlsFa7F7x6un8wJFENLy3con6YtqTwlr8AnK0g6qZqyp41X MOfOfqEuau79rvZVjq0SikAMOcp6WclDtjNKaHS6IDBZcDLjZhIuj43RQLS4Qg2Fp6 n8cBkGtK0+ZRg== Received: by paulmck-ThinkPad-P17-Gen-1.home (Postfix, from userid 1000) id D0FDFCE0593; Fri, 11 Aug 2023 09:48:58 -0700 (PDT) Date: Fri, 11 Aug 2023 09:48:58 -0700 From: "Paul E. McKenney" To: kernel test robot Cc: llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev, Linux Memory Management List Subject: Re: [linux-next:master 5658/8441] kernel/rcu/update.c:529:6: warning: no previous prototype for function 'torture_sched_setaffinity' Message-ID: <1dae5399-9a1b-4c55-a62b-1bece1f349c8@paulmck-laptop> Reply-To: paulmck@kernel.org References: <202308111926.gYjAUtn4-lkp@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: B42E440007 X-Stat-Signature: tb59ej5j1kw5ng74ghwg4549gz3gfspr X-Rspam-User: X-HE-Tag: 1691772540-901007 X-HE-Meta: U2FsdGVkX19KWxsvSzjczVrceCpEkJRVlwoEcEoVH5/2JbPBiFx6Yzb6SHEaemRmj54jjmJn2fr9U0b+dTSehnCBs+PMbrLFtsZ721vWdGtPuKNlA08JG0SQ0BYm2tLYiB4461IbhJethLgNiP7dRN+bV9D18LlEouo4wqTK7wPLWzzQtVQJH1KIb5TsQERLNOaBom9ttgvEHqDJsl2Ayi5z2dW6wfCvC0QZmmJG0IIJfQ0oHhFBXV/o9KJlBOZxZKDxdyqf/BsgXXdj1ybb/XODICjJSow5Q8aTW7bsbaO2RxJ1Y8vfbwncYjbPb81/PNiku7iBk/C+xookwNp0u1VYdIjJEZBvFybGjTS6RwkbMVOxHVuQAiM8brZZGkSO3fXhRdnMmP07m4unVXj04GqkVuBba9Z7ahJvLYyvPOjEkTNRwPxMuaG9tyyiRkgvdRLkmxlii87zrBZ5z2ZYvOAOzglLkweTc2+qUHH8M0C2BxRslF4pIzO9F4H3Rab4fYj73NnTZeFwvJ0o8XsFuoRMAYsEs6zZRG4OrYu1aVoy37Wfrs/TrL4xrhrc65dTfSQZw5+FzcLreR6D8NV/ymcgyEWuE3jO8nSS2t8pNDTys8m8YRo2K0ccDudtM8ISOVaREEnxeaPY5SKOGhVgiScDlCPJP+genTM8N908HdKuTixkRzv98Y0BtyCeZgpcZwqjaAiF4rNqH5TTFnqXR7e7s+FEM6G7hva7ufhkdRNHJZsCYhec2yoXFCHCdW+g9g/5zdFJxawFDbEebWVsTTgnlDNiZflW4K6WIYzZLjvCR/k7JOJrQ1yBnB0QEtz7vwuy15+lj2UzpFEDXCp7pFF0DN69l8K2UXAXZUA4s9SfTwWjPuM7i+M8pk5a3Bpx8RvcOfNse8HtIVTavgoUfc5f0GTeWetn+X0PfXAS4q23iU85Su3MAXn9vFcm6En/qamAexAHnJ4WuuRM1kf nFawagqV 8iOcbtqUpxcFv7cxR1pVQdRPLlsw8g5IDE1vf7YjuSHaLw7UL3P4lhDmAd/qTw60YjNQ4iFFwZgwYsoivyt8lem8DM+A2RxIcWPoQYcVV1kiBli8cAfOJBGs4zGgryPUzQZnLipSEpgLS7TG8KsO1PnssaHp7lnhoqzdC9aXvmbLGY2xAdcKIa3W3ahiohMQFcjADmCg/kBhwgD8sXau4IMPa96OKsvucS9pcvdLjiroy+UMIaPZzbs1o9w8sQCSvru6/qBx5sbbl9w7xKEtDTNU3VsZW/OZGVMGl180Vq5XyM7TcJWe2VxuKrithx+BexlKIgNgfl7CKLNXHlDGTiwm8Sy9zJ/i9qjtIXUErxE625tuBFH1T4gozjxR4zByvpyGugOAovY0k2V6wWP9t7qPlBABFpisxi8W/2mbl26ET8UFrZDQk9eDwWGcnFJymYPFlSkwtl74VeRbAKcsOyf/BC9Nz9iSt4NV7nTBAxap7GMJOaeeH3V6LlZCqRguPOc8fOBS39dYfKZ3ei3YosNtsEZybLIZleQtdiKG9QIUW85fwTXY276Uld4NwQFuZD2vcZElMX4IO8L4wuHXfTLdFnYJw6Okj4rsw2104FKNjaF0VrCgqoxZR+Qeykx9LcFCIxZXuRvnraIsSu6YU8PVIiz0cjgfgTYmu2lJNFm/t3ZSqy63sqcz8ic4EfUxe+XEdhrrpycG/RxaVz0fnq7X43ovkl7chwRuOI6N+n8fvOcr2+3wSv0+jaLHXqVv3h0JKLbZOfm2fJCrvZR2Th9EJYJXvVo8R2nWxAKW8F8ZDCr8fOgnqdsxaVQ5FHY5P7k61dA6xTUpVneT+xDW6xdg9lw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Aug 11, 2023 at 09:10:39AM -0700, Paul E. McKenney wrote: > On Fri, Aug 11, 2023 at 07:13:48PM +0800, kernel test robot wrote: > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master > > head: 21ef7b1e17d039053edaeaf41142423810572741 > > commit: 521ec59e5453e03a255e183ccee844fe3612f1b4 [5658/8441] torture: Move rcutorture_sched_setaffinity() out of rcutorture > > config: x86_64-randconfig-x012-20230811 (https://download.01.org/0day-ci/archive/20230811/202308111926.gYjAUtn4-lkp@intel.com/config) > > compiler: clang version 16.0.4 (https://github.com/llvm/llvm-project.git ae42196bc493ffe877a7e3dff8be32035dea4d07) > > reproduce: (https://download.01.org/0day-ci/archive/20230811/202308111926.gYjAUtn4-lkp@intel.com/reproduce) > > > > If you fix the issue in a separate patch/commit (i.e. not just a new version of > > the same patch/commit), kindly add following tags > > | Reported-by: kernel test robot > > | Closes: https://lore.kernel.org/oe-kbuild-all/202308111926.gYjAUtn4-lkp@intel.com/ > > > > All warnings (new ones prefixed by >>): > > > > >> kernel/rcu/update.c:529:6: warning: no previous prototype for function 'torture_sched_setaffinity' [-Wmissing-prototypes] > > long torture_sched_setaffinity(pid_t pid, const struct cpumask *in_mask) > > ^ > > kernel/rcu/update.c:529:1: note: declare 'static' if the function is not intended to be used outside of this translation unit > > long torture_sched_setaffinity(pid_t pid, const struct cpumask *in_mask) > > ^ > > static > > 1 warning generated. > > > > > > vim +/torture_sched_setaffinity +529 kernel/rcu/update.c > > > > 526 > > 527 #if IS_ENABLED(CONFIG_RCU_TORTURE_TEST) || IS_MODULE(CONFIG_RCU_TORTURE_TEST) || IS_ENABLED(CONFIG_LOCK_TORTURE_TEST) || IS_MODULE(CONFIG_LOCK_TORTURE_TEST) > > 528 /* Get rcutorture access to sched_setaffinity(). */ > > > 529 long torture_sched_setaffinity(pid_t pid, const struct cpumask *in_mask) > > 530 { > > 531 int ret; > > 532 > > 533 ret = sched_setaffinity(pid, in_mask); > > 534 WARN_ONCE(ret, "%s: sched_setaffinity(%d) returned %d\n", __func__, pid, ret); > > 535 return ret; > > 536 } > > 537 EXPORT_SYMBOL_GPL(torture_sched_setaffinity); > > 538 #endif > > 539 > > Hmmm... The update.c source file includes torture.h which provides the > declaration with the same set of #if conditions as the definition. > > But does this diff help? Never mind! Fixed by this commit: 778df208f001 ("rcu: Include torture_sched_setaffinity() declaration") Thanx, Paul > ----------------------------------------------------------------------- > > diff --git a/include/linux/torture.h b/include/linux/torture.h > index c98d0c83d117..7d2c070e66d2 100644 > --- a/include/linux/torture.h > +++ b/include/linux/torture.h > @@ -128,8 +128,6 @@ void _torture_stop_kthread(char *m, struct task_struct **tp); > #define torture_preempt_schedule() do { } while (0) > #endif > > -#if IS_ENABLED(CONFIG_RCU_TORTURE_TEST) || IS_MODULE(CONFIG_RCU_TORTURE_TEST) || IS_ENABLED(CONFIG_LOCK_TORTURE_TEST) || IS_MODULE(CONFIG_LOCK_TORTURE_TEST) > long torture_sched_setaffinity(pid_t pid, const struct cpumask *in_mask); > -#endif > > #endif /* __LINUX_TORTURE_H */