From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9BAB6C001DE for ; Wed, 26 Jul 2023 09:41:07 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0E3288D0001; Wed, 26 Jul 2023 05:41:07 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 093CC6B0078; Wed, 26 Jul 2023 05:41:07 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EC3E08D0001; Wed, 26 Jul 2023 05:41:06 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id DD14F6B0074 for ; Wed, 26 Jul 2023 05:41:06 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 939AFC09CA for ; Wed, 26 Jul 2023 09:41:06 +0000 (UTC) X-FDA: 81053269332.09.EFAA82F Received: from out30-98.freemail.mail.aliyun.com (out30-98.freemail.mail.aliyun.com [115.124.30.98]) by imf21.hostedemail.com (Postfix) with ESMTP id 8BB6B1C0012 for ; Wed, 26 Jul 2023 09:41:03 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=alibaba.com; spf=pass (imf21.hostedemail.com: domain of joseph.qi@linux.alibaba.com designates 115.124.30.98 as permitted sender) smtp.mailfrom=joseph.qi@linux.alibaba.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1690364464; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=SMp22aUAVq4Iw7OXiIgTyL4ngCRPy00sHfK8XUdN0Tc=; b=4tGmx0FFTEXL8HFNssvryd656d6fIrtUWA/Ls4u9/r2eN452aiiy2u/3D9k3Yfs/F/u6Vq gYDGJOrIxKNCS5eEZbWvhXVYWqhnZ+V5/mF1ZW9oCHM/S3JJS9VID6Gt2U+Ygjx8zQjVav 1Glsb5pXQPqAWBrs98zZj/ej9MsT5lE= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=alibaba.com; spf=pass (imf21.hostedemail.com: domain of joseph.qi@linux.alibaba.com designates 115.124.30.98 as permitted sender) smtp.mailfrom=joseph.qi@linux.alibaba.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1690364464; a=rsa-sha256; cv=none; b=PwICL5nVDkfizLCO00W/QTjVmURPECYw0x+WQa9sfobl1H8TqY/CJ6kMpO2/eozCt/QSbA ZAc/gEDuzqLhCKprk7IywlrsRFUWYWsRKuMxSRxWITyKcw8OIRnujkonCNOEcdqr8KRTzB 0HMSk/PVjr32AM+PxqezJGC52n1vWpk= X-Alimail-AntiSpam:AC=PASS;BC=-1|-1;BR=01201311R161e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018045170;MF=joseph.qi@linux.alibaba.com;NM=1;PH=DS;RN=24;SR=0;TI=SMTPD_---0VoGYt9._1690364457; Received: from 30.221.136.164(mailfrom:joseph.qi@linux.alibaba.com fp:SMTPD_---0VoGYt9._1690364457) by smtp.aliyun-inc.com; Wed, 26 Jul 2023 17:40:58 +0800 Message-ID: <1da81657-2ee1-0ef3-c222-66e00d021c24@linux.alibaba.com> Date: Wed, 26 Jul 2023 17:40:57 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH v6 1/7] fs: pass the request_mask to generic_fillattr Content-Language: en-US To: Jeff Layton Cc: Dave Chinner , Anthony Iliopoulos , v9fs@lists.linux.dev, linux-kernel@vger.kernel.org, linux-afs@lists.infradead.org, linux-btrfs@vger.kernel.org, ceph-devel@vger.kernel.org, codalist@coda.cs.cmu.edu, ecryptfs@vger.kernel.org, linux-erofs@lists.ozlabs.org, linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, cluster-devel@redhat.com, linux-nfs@vger.kernel.org, ntfs3@lists.linux.dev, ocfs2-devel@lists.linux.dev, devel@lists.orangefs.org, linux-cifs@vger.kernel.org, samba-technical@lists.samba.org, linux-mtd@lists.infradead.org, linux-mm@kvack.org, linux-xfs@vger.kernel.org References: <20230725-mgctime-v6-0-a794c2b7abca@kernel.org> <20230725-mgctime-v6-1-a794c2b7abca@kernel.org> From: Joseph Qi In-Reply-To: <20230725-mgctime-v6-1-a794c2b7abca@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 8BB6B1C0012 X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: 7fqbyf34xp1kftnzqbqtd8kmo96sfcwo X-HE-Tag: 1690364463-485899 X-HE-Meta: U2FsdGVkX19S8al/dNzLYoRVRR9gtZAukfLdZHseOat0Cex91RHQ8mc2tfV1chdbRQt5biOcpF3csRUS6cgPsfUS2ym6uQS2ex9my0rdWrkG/15xSB5T7u58WYmvXP0HPJjTX5pZoNcY12waKhqn3cHK1DBs/KqZ0v4WwFRwl8etG9aHP1SV7jmhJkR82zWo/mR+2D1/JNO6+LlbmU8kdb7n4x/SzMujmc8/knT1sibbUOycIW8K568ukIpbARt/KX3gVZjWFmAPvJz3D8VWJPmapl/QU5uPm5hbVO+UJii+lw/QbDj9ZVl3ArtqjjhGhC/E5dcW1f9OA0ShAYyIHMzp0anrTdrzu2HVeQBaeDuSvzk1v9suYfSO89pciidxYaMRaAoJupYmkyA3Jh9GQuTnfKtvbXu31FYBrwVne7pOOvqeELMh4KBh3qNMbTAdvAcQQJJhyM0f6OW5rvJFoGITQggr/bBfL1uRvgQPrKiwmN5legf39HedQY9eSCmQVA+Ag+1WqIVtg+P5mL6zhuXS3AlmCL+I50xgnhhRziyTfvfmWHhT/c04kVO1lJlGOcElra2bHKhqRSw6aUe7nhxPhftjJkcC/LHLUu1KWFXQZnozCfFFwlUapHywpaHFpWiT24uEG+rTkhWU9I/OKn0+CEuq2q0hW2Jw5ldtcsBWpPfalmjVxW9R5N2TNM9wsb4KhOp/BNNA6Wt5VDJErUT+QteNwH7DjRWldORIf8TitRJhikjyIsQ5UfKJA5JXqj8foOTVpBOWpZqpW7/6uXs1YGYWRNEiLkp0NZWoB20sxHpqKYAKqIgr5LujtAhTySxz+fDcBXV0PIOE6ZHZehUcORO7Yb/5FBqD3WvaL2ElgstTZadSHYDHPV0+VBIw7amEhY8dCmllE+2LrtESTqH9sgA/uA4lH1qWYNsv0Fayb2TGUFLfaecHoBQPedFn+lB54yFRQiu81INW6mI v+mY8HlY DIMFic5JW+QSYyAg9iwx8G1dRKFxSSBz2enPSKYsVUQOLOAl3WHgCfZptZ5GlVW7CwUFCPSQEmSpJzR6GK6vgEzjJbwnngPlQMWlBYOC/SEGK9Pb1cGfczZmiRFCzJOdgwZz5TKhnyvttmsGV65jAlFgMMRIke3HPG3xIRbK1UkA6/sYnJJg3Gy+l0wsvmzx7//Wt2sRYHiGx7jm3Aeq574WR2A== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 7/25/23 10:58 PM, Jeff Layton wrote: > generic_fillattr just fills in the entire stat struct indiscriminately > today, copying data from the inode. There is at least one attribute > (STATX_CHANGE_COOKIE) that can have side effects when it is reported, > and we're looking at adding more with the addition of multigrain > timestamps. > > Add a request_mask argument to generic_fillattr and have most callers > just pass in the value that is passed to getattr. Have other callers > (e.g. ksmbd) just pass in STATX_BASIC_STATS. Also move the setting of > STATX_CHANGE_COOKIE into generic_fillattr. > > Signed-off-by: Jeff Layton > --- > fs/9p/vfs_inode.c | 4 ++-- > fs/9p/vfs_inode_dotl.c | 4 ++-- > fs/afs/inode.c | 2 +- > fs/btrfs/inode.c | 2 +- > fs/ceph/inode.c | 2 +- > fs/coda/inode.c | 3 ++- > fs/ecryptfs/inode.c | 5 +++-- > fs/erofs/inode.c | 2 +- > fs/exfat/file.c | 2 +- > fs/ext2/inode.c | 2 +- > fs/ext4/inode.c | 2 +- > fs/f2fs/file.c | 2 +- > fs/fat/file.c | 2 +- > fs/fuse/dir.c | 2 +- > fs/gfs2/inode.c | 2 +- > fs/hfsplus/inode.c | 2 +- > fs/kernfs/inode.c | 2 +- > fs/libfs.c | 4 ++-- > fs/minix/inode.c | 2 +- > fs/nfs/inode.c | 2 +- > fs/nfs/namespace.c | 3 ++- > fs/ntfs3/file.c | 2 +- > fs/ocfs2/file.c | 2 +- > fs/orangefs/inode.c | 2 +- > fs/proc/base.c | 4 ++-- > fs/proc/fd.c | 2 +- > fs/proc/generic.c | 2 +- > fs/proc/proc_net.c | 2 +- > fs/proc/proc_sysctl.c | 2 +- > fs/proc/root.c | 3 ++- > fs/smb/client/inode.c | 2 +- > fs/smb/server/smb2pdu.c | 22 +++++++++++----------- > fs/smb/server/vfs.c | 3 ++- > fs/stat.c | 18 ++++++++++-------- > fs/sysv/itree.c | 3 ++- > fs/ubifs/dir.c | 2 +- > fs/udf/symlink.c | 2 +- > fs/vboxsf/utils.c | 2 +- > include/linux/fs.h | 2 +- > mm/shmem.c | 2 +- > 40 files changed, 70 insertions(+), 62 deletions(-) > ... > diff --git a/fs/ocfs2/file.c b/fs/ocfs2/file.c > index 1b337ebce4df..8184499ae7a5 100644 > --- a/fs/ocfs2/file.c > +++ b/fs/ocfs2/file.c > @@ -1319,7 +1319,7 @@ int ocfs2_getattr(struct mnt_idmap *idmap, const struct path *path, > goto bail; > } > > - generic_fillattr(&nop_mnt_idmap, inode, stat); > + generic_fillattr(&nop_mnt_idmap, request_mask, inode, stat); For ocfs2 part, looks fine to me. Acked-by: Joseph Qi > /* > * If there is inline data in the inode, the inode will normally not > * have data blocks allocated (it may have an external xattr block). ... > diff --git a/fs/stat.c b/fs/stat.c > index 8c2b30af19f5..062f311b5386 100644 > --- a/fs/stat.c > +++ b/fs/stat.c > @@ -29,6 +29,7 @@ > /** > * generic_fillattr - Fill in the basic attributes from the inode struct > * @idmap: idmap of the mount the inode was found from > + * @req_mask statx request_mask s/req_mask/request_mask > * @inode: Inode to use as the source > * @stat: Where to fill in the attributes > * > @@ -42,8 +43,8 @@ > * uid and gid filds. On non-idmapped mounts or if permission checking is to be > * performed on the raw inode simply passs @nop_mnt_idmap. > */ > -void generic_fillattr(struct mnt_idmap *idmap, struct inode *inode, > - struct kstat *stat) > +void generic_fillattr(struct mnt_idmap *idmap, u32 request_mask, > + struct inode *inode, struct kstat *stat) > { > vfsuid_t vfsuid = i_uid_into_vfsuid(idmap, inode); > vfsgid_t vfsgid = i_gid_into_vfsgid(idmap, inode); > @@ -61,6 +62,12 @@ void generic_fillattr(struct mnt_idmap *idmap, struct inode *inode, > stat->ctime = inode_get_ctime(inode); > stat->blksize = i_blocksize(inode); > stat->blocks = inode->i_blocks; > + > + if ((request_mask & STATX_CHANGE_COOKIE) && IS_I_VERSION(inode)) { > + stat->result_mask |= STATX_CHANGE_COOKIE; > + stat->change_cookie = inode_query_iversion(inode); > + } > + > } > EXPORT_SYMBOL(generic_fillattr); > > @@ -123,17 +130,12 @@ int vfs_getattr_nosec(const struct path *path, struct kstat *stat, > stat->attributes_mask |= (STATX_ATTR_AUTOMOUNT | > STATX_ATTR_DAX); > > - if ((request_mask & STATX_CHANGE_COOKIE) && IS_I_VERSION(inode)) { > - stat->result_mask |= STATX_CHANGE_COOKIE; > - stat->change_cookie = inode_query_iversion(inode); > - } > - > idmap = mnt_idmap(path->mnt); > if (inode->i_op->getattr) > return inode->i_op->getattr(idmap, path, stat, > request_mask, query_flags); > > - generic_fillattr(idmap, inode, stat); > + generic_fillattr(idmap, request_mask, inode, stat); > return 0; > } > EXPORT_SYMBOL(vfs_getattr_nosec); ...