From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9E897C004C0 for ; Mon, 23 Oct 2023 16:57:50 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F0B186B0123; Mon, 23 Oct 2023 12:57:49 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id EBAA96B0124; Mon, 23 Oct 2023 12:57:49 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D5B8E6B0125; Mon, 23 Oct 2023 12:57:49 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id C6F606B0123 for ; Mon, 23 Oct 2023 12:57:49 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 7F539C0A55 for ; Mon, 23 Oct 2023 16:57:49 +0000 (UTC) X-FDA: 81377333058.18.E73E744 Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.88]) by imf17.hostedemail.com (Postfix) with ESMTP id 0168A4001E for ; Mon, 23 Oct 2023 16:57:45 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=ZS8Zdunf; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf17.hostedemail.com: domain of dave.hansen@intel.com designates 192.55.52.88 as permitted sender) smtp.mailfrom=dave.hansen@intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1698080266; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=FcNZQchT0tDHl7gg0LqjOnU6T0P/yUVlyZNQkJrYCqM=; b=JtnnGe7TnA3HFS6czGQmeGhklS+Zdb0gjkmjA9YpVlqSynf5f75JOnBlePSTQDYmWG0+1k 8Cu44mm1w7MUPgXtfpszguQZ0yGa91TkcEIeYAEam0+4+VWC2O0iUVOp0jWX9oS9HIYJt9 Y3T0VUbMAplGWQk2Vw1mV4bGhyexJnI= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=ZS8Zdunf; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf17.hostedemail.com: domain of dave.hansen@intel.com designates 192.55.52.88 as permitted sender) smtp.mailfrom=dave.hansen@intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1698080266; a=rsa-sha256; cv=none; b=hZoZwWg8Haxu5hwDo5iblenV/EtEELTtozulxyudXrWBelOlBaCZ5eBedBHHenAbdKfVp/ +vCD9MLQbvhMbQGuBamPZRnemcoLD2rXYewI+E+Qvl8CqGTUjoGcPAMPGrF6DlZf2WWTbI nmqlvdJ5g3zBYfFVz57w3Bx6mCLLOnU= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1698080266; x=1729616266; h=message-id:date:mime-version:subject:to:references:from: in-reply-to:content-transfer-encoding; bh=FcNZQchT0tDHl7gg0LqjOnU6T0P/yUVlyZNQkJrYCqM=; b=ZS8ZdunfjjJ2TbsDCOwL/1pZw17ZbjEyMkEGmFeqpYQ/xDQOX22RAPmN qdvvR0uq0PmvN0ECZn4hdIOubRnMV9qATy70VEkHdeVrJkabAT4aQAh0c lglmJxzzXL7NvaLzYejuwX0F9nJZ1sgsrlZTC5sfR9yd4n/nqqpto2BqH tpAJkqDbWDpk5Z3XYk+BAD4Ikbd4Oomn1xrLPa9VrsJtyHv17HuKsOObN HmXALgVLdL8qN0m72SNVqnQbUXQF6GWmZeZyIUiNjqkgQp+aoz9e4VAfZ V0JJXg9Qa53XfzWvn984iJsIoBYS4564cfsTsz8az2EdUTMzvpMK3vG87 A==; X-IronPort-AV: E=McAfee;i="6600,9927,10872"; a="418013081" X-IronPort-AV: E=Sophos;i="6.03,246,1694761200"; d="scan'208";a="418013081" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Oct 2023 09:57:36 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10872"; a="1005361732" X-IronPort-AV: E=Sophos;i="6.03,246,1694761200"; d="scan'208";a="1005361732" Received: from dahansge-mobl.amr.corp.intel.com (HELO [10.212.208.196]) ([10.212.208.196]) by fmsmga006-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Oct 2023 09:57:35 -0700 Message-ID: <1d9c03d9-9ec4-4b59-93ae-bf0a6c163217@intel.com> Date: Mon, 23 Oct 2023 09:57:34 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 00/10] Handle set_memory_XXcrypted() errors Content-Language: en-US To: "Michael Kelley (LINUX)" , Rick Edgecombe , "x86@kernel.org" , "tglx@linutronix.de" , "mingo@redhat.com" , "bp@alien8.de" , "dave.hansen@linux.intel.com" , "hpa@zytor.com" , "luto@kernel.org" , "peterz@infradead.org" , "kirill.shutemov@linux.intel.com" , "elena.reshetova@intel.com" , "isaku.yamahata@intel.com" , "seanjc@google.com" , "thomas.lendacky@amd.com" , Dexuan Cui , "sathyanarayanan.kuppuswamy@linux.intel.com" , "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" , "linux-s390@vger.kernel.org" References: <20231017202505.340906-1-rick.p.edgecombe@intel.com> <73b02835-dbd6-4662-91f9-e8324d8cbf98@intel.com> From: Dave Hansen Autocrypt: addr=dave.hansen@intel.com; keydata= xsFNBE6HMP0BEADIMA3XYkQfF3dwHlj58Yjsc4E5y5G67cfbt8dvaUq2fx1lR0K9h1bOI6fC oAiUXvGAOxPDsB/P6UEOISPpLl5IuYsSwAeZGkdQ5g6m1xq7AlDJQZddhr/1DC/nMVa/2BoY 2UnKuZuSBu7lgOE193+7Uks3416N2hTkyKUSNkduyoZ9F5twiBhxPJwPtn/wnch6n5RsoXsb ygOEDxLEsSk/7eyFycjE+btUtAWZtx+HseyaGfqkZK0Z9bT1lsaHecmB203xShwCPT49Blxz VOab8668QpaEOdLGhtvrVYVK7x4skyT3nGWcgDCl5/Vp3TWA4K+IofwvXzX2ON/Mj7aQwf5W iC+3nWC7q0uxKwwsddJ0Nu+dpA/UORQWa1NiAftEoSpk5+nUUi0WE+5DRm0H+TXKBWMGNCFn c6+EKg5zQaa8KqymHcOrSXNPmzJuXvDQ8uj2J8XuzCZfK4uy1+YdIr0yyEMI7mdh4KX50LO1 pmowEqDh7dLShTOif/7UtQYrzYq9cPnjU2ZW4qd5Qz2joSGTG9eCXLz5PRe5SqHxv6ljk8mb ApNuY7bOXO/A7T2j5RwXIlcmssqIjBcxsRRoIbpCwWWGjkYjzYCjgsNFL6rt4OL11OUF37wL QcTl7fbCGv53KfKPdYD5hcbguLKi/aCccJK18ZwNjFhqr4MliQARAQABzUVEYXZpZCBDaHJp c3RvcGhlciBIYW5zZW4gKEludGVsIFdvcmsgQWRkcmVzcykgPGRhdmUuaGFuc2VuQGludGVs LmNvbT7CwXgEEwECACIFAlQ+9J0CGwMGCwkIBwMCBhUIAgkKCwQWAgMBAh4BAheAAAoJEGg1 lTBwyZKwLZUP/0dnbhDc229u2u6WtK1s1cSd9WsflGXGagkR6liJ4um3XCfYWDHvIdkHYC1t MNcVHFBwmQkawxsYvgO8kXT3SaFZe4ISfB4K4CL2qp4JO+nJdlFUbZI7cz/Td9z8nHjMcWYF IQuTsWOLs/LBMTs+ANumibtw6UkiGVD3dfHJAOPNApjVr+M0P/lVmTeP8w0uVcd2syiaU5jB aht9CYATn+ytFGWZnBEEQFnqcibIaOrmoBLu2b3fKJEd8Jp7NHDSIdrvrMjYynmc6sZKUqH2 I1qOevaa8jUg7wlLJAWGfIqnu85kkqrVOkbNbk4TPub7VOqA6qG5GCNEIv6ZY7HLYd/vAkVY E8Plzq/NwLAuOWxvGrOl7OPuwVeR4hBDfcrNb990MFPpjGgACzAZyjdmYoMu8j3/MAEW4P0z F5+EYJAOZ+z212y1pchNNauehORXgjrNKsZwxwKpPY9qb84E3O9KYpwfATsqOoQ6tTgr+1BR CCwP712H+E9U5HJ0iibN/CDZFVPL1bRerHziuwuQuvE0qWg0+0SChFe9oq0KAwEkVs6ZDMB2 P16MieEEQ6StQRlvy2YBv80L1TMl3T90Bo1UUn6ARXEpcbFE0/aORH/jEXcRteb+vuik5UGY 5TsyLYdPur3TXm7XDBdmmyQVJjnJKYK9AQxj95KlXLVO38lczsFNBFRjzmoBEACyAxbvUEhd GDGNg0JhDdezyTdN8C9BFsdxyTLnSH31NRiyp1QtuxvcqGZjb2trDVuCbIzRrgMZLVgo3upr MIOx1CXEgmn23Zhh0EpdVHM8IKx9Z7V0r+rrpRWFE8/wQZngKYVi49PGoZj50ZEifEJ5qn/H Nsp2+Y+bTUjDdgWMATg9DiFMyv8fvoqgNsNyrrZTnSgoLzdxr89FGHZCoSoAK8gfgFHuO54B lI8QOfPDG9WDPJ66HCodjTlBEr/Cwq6GruxS5i2Y33YVqxvFvDa1tUtl+iJ2SWKS9kCai2DR 3BwVONJEYSDQaven/EHMlY1q8Vln3lGPsS11vSUK3QcNJjmrgYxH5KsVsf6PNRj9mp8Z1kIG qjRx08+nnyStWC0gZH6NrYyS9rpqH3j+hA2WcI7De51L4Rv9pFwzp161mvtc6eC/GxaiUGuH BNAVP0PY0fqvIC68p3rLIAW3f97uv4ce2RSQ7LbsPsimOeCo/5vgS6YQsj83E+AipPr09Caj 0hloj+hFoqiticNpmsxdWKoOsV0PftcQvBCCYuhKbZV9s5hjt9qn8CE86A5g5KqDf83Fxqm/ vXKgHNFHE5zgXGZnrmaf6resQzbvJHO0Fb0CcIohzrpPaL3YepcLDoCCgElGMGQjdCcSQ+Ci FCRl0Bvyj1YZUql+ZkptgGjikQARAQABwsFfBBgBAgAJBQJUY85qAhsMAAoJEGg1lTBwyZKw l4IQAIKHs/9po4spZDFyfDjunimEhVHqlUt7ggR1Hsl/tkvTSze8pI1P6dGp2XW6AnH1iayn yRcoyT0ZJ+Zmm4xAH1zqKjWplzqdb/dO28qk0bPso8+1oPO8oDhLm1+tY+cOvufXkBTm+whm +AyNTjaCRt6aSMnA/QHVGSJ8grrTJCoACVNhnXg/R0g90g8iV8Q+IBZyDkG0tBThaDdw1B2l asInUTeb9EiVfL/Zjdg5VWiF9LL7iS+9hTeVdR09vThQ/DhVbCNxVk+DtyBHsjOKifrVsYep WpRGBIAu3bK8eXtyvrw1igWTNs2wazJ71+0z2jMzbclKAyRHKU9JdN6Hkkgr2nPb561yjcB8 sIq1pFXKyO+nKy6SZYxOvHxCcjk2fkw6UmPU6/j/nQlj2lfOAgNVKuDLothIxzi8pndB8Jju KktE5HJqUUMXePkAYIxEQ0mMc8Po7tuXdejgPMwgP7x65xtfEqI0RuzbUioFltsp1jUaRwQZ MTsCeQDdjpgHsj+P2ZDeEKCbma4m6Ez/YWs4+zDm1X8uZDkZcfQlD9NldbKDJEXLIjYWo1PH hYepSffIWPyvBMBTW2W5FRjJ4vLRrJSUoEfJuPQ3vW9Y73foyo/qFoURHO48AinGPZ7PC7TF vUaNOTjKedrqHkaOcqB185ahG2had0xnFsDPlx5y In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 0168A4001E X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: 8haqre344q4zw9aigpqbfznsft33x9kp X-HE-Tag: 1698080265-382777 X-HE-Meta: U2FsdGVkX1/kV3I6xRqOK9Mo98+7iBCSgYgPhFH9jOOFYCKvS+gIOHn1gxHsmDPe1G2rjvzS3ZsMuFjjXJEWTmE39I+7SBnawV94bnevfySphRd4g46IieK+YGqwqCytFKWHxtcRsvB18dEFvCz5PYLO78s4kNupiu/gZjQ0aPCDRAphbqC+cJf44IySvyLQQlIMnZz/McxSveka0XKVDz++qknu48dO2Sm+CpZhM6aJpclgzNQsBYZpvC71qgZthaUX2eEd2JQen/xbmjAMoW1+gJDzPEcynD2PXMFJxw5sxghaR0A1qre0NxtMDH540J1+s95RUc9mggZ9kf80WVATz4xSoPR4LjZOOxMjEZ01S9mll3/Qz9vvNxyPOmU/yaWgUm+TM05cviaTA3qopi2R40Wrqr96TkigAsyf2XB1mYPzSKFgnCJQLyLnalaOKQvn18hd/y3gbPOjoPR4ZR+3cHmEMZ80fFdRYY94QDFc2yUGME2aFrkJ0uw7/BY5Q8/XWuWNK8i8twPc+gLf2Wv1VT3/TRgqslyZN3tt55NH2b2mzzzoJMsG0/OiICQqL4EPRW0lV1B6U71JzrVZxfu8SCm3xWrWaLCl3cVECsSAtCxBo1qLlrltkHwwhhS+tTruyrrtJaffJLq1M+DQ7ZRg43Rsj/9MlI98vI5dJ+xoe2Rd2/W1J2l6cV/NanT9sydiYqMT2ai8OA+7y3uWILXILW8v+uoZMRvPnMO6So6gL8sQTZq5Id2Img/2c32DgMB/8x+nnylB7K99DJed8KpFECQKAzZieYoU3DMwEMenpGxQji7LbLPrISW0UOLDYTnIxizolhcAdu020rwRVVqjNCCRzr7dgum1CN/KNB7Tbl8S7YCTPox5vXFNel0jktfBWWBuEhLqA/gsZa8MSbS2S/N8PPQP6IfL9GYWVlch5f2So7+IYcV+TeP3j9iD64O5reZblH0rkSIk7nx aFkUEtRa N+ShhXLuQMdDvO6BccJaBCU4pOkA2ymLKNa9DTOrj4wWYt7Mfr89w1/QlvDIhU7UdyJ2P7uFeH0Iv+c0sEqJiKieAfKSQJVBOfYgakwCLybSy7gO9iK5r6Q221JnDGeR8eVgNdc0sXUyVanlI9vc40b0gT/FatCkmxuC1gB823Hd99bPtuD47iQ9x9PyO5QmxcT6fcb1D7Y96JjxyIDY20q/pv6iufkEr71fSrv7dqvOQLgHmZmnMK4w0cHqsr/5eNo2BbHxJtN4e8j4= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 10/23/23 09:47, Michael Kelley (LINUX) wrote: > For paranoid CoCo VM users, using panic_on_warn=1 seems workable. > However, with current code and this patch series, it's possible have > set_memory_decrypted() return an error and have set_memory_encrypted() > fix things up as best it can without generating any warnings. It seems > like we need a WARN or some equivalent mechanism if either of these > fails, so that CoCo VMs can panic if they don't want to run with any > inconsistencies (again, assuming the host isn't malicious). Adding a warning to the fixup path in set_memory_encrypted() would be totally fine with me.