From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E6A1EC7EE30 for ; Wed, 2 Jul 2025 08:48:29 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8A6D76B00CD; Wed, 2 Jul 2025 04:48:29 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 87ECD6B00CE; Wed, 2 Jul 2025 04:48:29 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 746336B00CF; Wed, 2 Jul 2025 04:48:29 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 5CA5D6B00CD for ; Wed, 2 Jul 2025 04:48:29 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id CAEE9C072B for ; Wed, 2 Jul 2025 08:48:28 +0000 (UTC) X-FDA: 83618698296.03.F26535A Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf01.hostedemail.com (Postfix) with ESMTP id 3E9B74000D for ; Wed, 2 Jul 2025 08:48:26 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=IswaN3be; spf=pass (imf01.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1751446106; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=9P/HggBDTGiN4FSKj5JuJB6QP5aE4j+fL8SIRJ5pI5U=; b=yN1bB5nbrYn1AcyOB1lV3WbizESHzaCfM/Ll0erQlMZIJGGZR2OtB+cV0PZCtqdAYq5P5A UFycP1LxMsIQQlsGV42IBUt9F4MkqX1DlOavEr8yBk7i/XJgmRWN4bNQawxmKQBMqfyF/8 jMjpA9YkYzFKcMf8fxXslDTDbSAlklc= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1751446106; a=rsa-sha256; cv=none; b=TuOKIG8xez0itwGtbzMhHWib/3FWQ8Rg5GsqVqFCgKISkK1H2rhlbykamgUwM+SU/FeN6q 0TtrtZcAR+RqX8wo8CyVt8TsV56H0NitWIWeiaHcKPnuqDJINY5tLu4Pm//2j/YVuztaJE V/koGxFOoZvCl3tVzkU6kqk1SKMnW74= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=IswaN3be; spf=pass (imf01.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1751446105; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=9P/HggBDTGiN4FSKj5JuJB6QP5aE4j+fL8SIRJ5pI5U=; b=IswaN3befb5pdLCjudlhoILTtUKdH4WJudWQfj+79xiZV4oDXCPy/8PAKAICS1B6MxwDac iWm/TfmbvNtr+kky9h4UfQi3y6IPPAJn40WeoJPDsJsJMetfLWLAr9Tz6PaUHqkbKD9y62 SO2FxvRAJTOD6miBfx7iHfdysUZUHwg= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-509-EiTa0nGLObCxDG0CoKev0A-1; Wed, 02 Jul 2025 04:48:24 -0400 X-MC-Unique: EiTa0nGLObCxDG0CoKev0A-1 X-Mimecast-MFC-AGG-ID: EiTa0nGLObCxDG0CoKev0A_1751446103 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-4535ad64d30so34701965e9.3 for ; Wed, 02 Jul 2025 01:48:24 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751446103; x=1752050903; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=9P/HggBDTGiN4FSKj5JuJB6QP5aE4j+fL8SIRJ5pI5U=; b=SbHIrVR60NjFBJiHLA0fPut97Cq4Q3AWod1l2YDyjSVSlSLYaXW/WL/rDWlwl8X4XZ G3YL5ATZvsCVSvfE9Row921+YYxMvKClLS1KE1qGgFQKiAdXK9So/ZV8R3nZgSmYWMMg FLMupXVrYQflgDGiUh4Z/v0G3o/fBKsV8XLwDxrCtMc9ZbFcn8nQsojr7oAcM2yo75mL 27sqXvv8JcyVsHQ3u8oUPu06R7vLARPTez/TDWYAL4Ld8DhIS3Ys5jY3y/uPdmqvClvN qhBEOsBw6WaJJLvfwj/XjumskxD5ZdQbf6SUzEbrl3T40DopJMolLUreGmg5sI3vkN3d NBvQ== X-Forwarded-Encrypted: i=1; AJvYcCWcuEzH0fGdRfwmbQCg+fJA9tsx7KmI/iB9z9TI7F6LMrPzL0id6FiVnGfOs8VxK2sWaJoZEqXbVg==@kvack.org X-Gm-Message-State: AOJu0YxB+cMpN+m5572NfmjbOTjh2da3+/OdGqq6j+XWxgLi9TemF0ai WExwiX/8eNxRRYWU0bPG/4oqErCZ1tRx+R0ywoL+OMYLf5I3Ktc1TWcoR2XRNNG0tTrKZ8k8JXV jSMZLyIDxNqhCnijY8G2g+V5UMVUpHT597ZIXbk1W4LqScoGWk7IX X-Gm-Gg: ASbGncsaEH/FzJlvIRqizyCteT4LinrByTonHce8qJz9CkfJSsBXmp4M2NgFJ51mag6 Kxhrl3/z44mtHgC3LFpO7RjDjpnCQUbfWys4JnGocCpQxvW7xhDzaprr3lKCE0C2YMtZ8wkZyB0 S5QK9yeJfov/YpMmQ4KUpzYt6Vghm3Fg+WOEfVhwSRbz9F7WC8JrnQ/J4nnEt6dxkdY9FszQNSM AfeWhE6AqYO6/c/8Px+57rhmS/ydHod/FDsSPPM8qD3+3eof0/gb+B4evMFESyHuQsgHUlw31hu GK200irawlqYzEE+sdINSscVAN1Lebg4T7A2IWrWMVod3/DhJquzlD4= X-Received: by 2002:a05:600c:3145:b0:442:faa3:fadb with SMTP id 5b1f17b1804b1-454a36d7b1emr19830895e9.2.1751446103049; Wed, 02 Jul 2025 01:48:23 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFr03FFkhKIjxkAApS1G8x1uv4uDWxtyu/EEYFThgeKm/UX1jbUYcebDjpAIu4pm26pt1kO8Q== X-Received: by 2002:a05:600c:3145:b0:442:faa3:fadb with SMTP id 5b1f17b1804b1-454a36d7b1emr19830415e9.2.1751446102595; Wed, 02 Jul 2025 01:48:22 -0700 (PDT) Received: from ?IPV6:2a09:80c0:192:0:5dac:bf3d:c41:c3e7? ([2a09:80c0:192:0:5dac:bf3d:c41:c3e7]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-453823c42e1sm219717245e9.37.2025.07.02.01.48.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 02 Jul 2025 01:48:22 -0700 (PDT) Message-ID: <1d98e96b-4bc9-45c1-9861-e0f3c5930ec2@redhat.com> Date: Wed, 2 Jul 2025 10:48:20 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 2/4] mm: smaller folio_pte_batch() improvements To: Oscar Salvador Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Andrew Morton , "Liam R. Howlett" , Lorenzo Stoakes , Vlastimil Babka , Jann Horn , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Zi Yan , Matthew Brost , Joshua Hahn , Rakie Kim , Byungchul Park , Gregory Price , Ying Huang , Alistair Popple , Pedro Falcato , Rik van Riel , Harry Yoo References: <20250627115510.3273675-1-david@redhat.com> <20250627115510.3273675-3-david@redhat.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: KIIgCSMNUJbapPEv4b6zr71fABj-K4Emv9go98NmZ2c_1751446103 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 3E9B74000D X-Stat-Signature: eu37rkrqm73nhsz6sh1kep1o3fgpacz8 X-HE-Tag: 1751446106-178714 X-HE-Meta: U2FsdGVkX1/ecqBpACqymjMjr4v1O8fk2aYKD2mxaXuMDzHknp+QDtXDS2ELkNUbiSoZ1hmwOXklfXgyYCEXyrnDV4Trk5NBVdIqmlmkYL6/MgaUhGfs5OumdJgULzjURwwAuDh0ybBYjQm0yKVjlM2qmy15YMeMUydT8cQ84OuBYE4qsr/DeYE7sLWpPCpmLghcZ0pWDmlFARPDwwjMaw2tQfLngNZ9SQKUETp9onqXPl4fqQU8ZeO94+aoXM1Q2UdaMLoGLUW/D/6xZW0DFgsSExOAPKSkgwS8vjd+eDt9rkUqKVKQPAPltDj8gvfBuOyZ06qMpF5n7dDzjNgpXdG5LogHHC75bV+DWut2D4VAKnLoIwKYp0P7T4YofgHxNriDEA2IAIFWOHYzLLUJbP+MHRboMXQ00Bwobtbakf3QReMdX31O1q/97oTZkeIusZCffLB+QgjQOG50TjespK+wAa8n/0YwTqG6gJc0xob4aZm6+S+ixo+htkGd7JR817UlfIyIpAgsmWUh+6PipbGHQD5o+G+qoTPKzD4q62WdY8fnCaKGJrPYz+mT4M63LLsxJ1u05J3stg6NmCeqxdD0E8iBLpVGoXeX8eyv/1b2GRMT+eBScdsBJxyddEbAJbFlVbhLgP5hJVyQVa1bTmV7m12aMWps0kVhk52Ws2SVJaO5g59nGxCx8eLd0WObTjWVdbnsKUwHO/t3/S3ZQ0sHutBvShBvfgGSHItINoCf/SULm3MQwrEiDI36vBpT+ZtqDaPZMrdZzQ6+N+/pUwZaFdBv3Q8gFncrYoRxEGBvHcDzmTB/9P27US5pQ0enCsHVGa56bGElNRiF8Q+om/rhn68Y//h12CJsW0w/TgwHLdzM0ZWbHtFCTYpZ12CVs9byatVz1WzkyJT+Jbs8MbKQKF+/fB+Znxh4fKdoTal2sMIJiAO1qKCXLfrkB37BkiR8er5Br3yjV8aIgS3 jYgNigas pUbIHZGGDow+ibbz4E62PVu1gD2WiI4uQFZIVZSfdKzMhUNcCHysKezHnaKJ3wekW1oSLWiDt4E6ba0ITsN+RSm61lrwgf56OSt2nIKK/PzlOHJmwSC429sS6TvoOV7DLAuSmYuKoeM6PSTf+caWpTDzZ7aVfB7Sa636IGd5dR6bVXsE4Lvsw0wf6mi9FveLfpEbYLy/KGVOEItcw2OrwjwQkhGm7GatNVxV3eWgMTAUg7Ho2JZQbitRJlspcC2KcnSOZCC5aGN/sdStz5GOzFYtynTVjnf7qv8tamjfRE0Lk3y18jezv23MNJvIjKanF2lzsEBaizc4ShztRH3Xw+GbvfI1FWqdroVeJmXZFXF4hIDCE8cZPEGwEf9beH400g7WcpzOJDm9J1bV2suFCN4wWXlUF4J4Z8CXC8RPNfdOv8087BizPd7GVkITXOk+UPXopenkUknjGOPZ6kvicE/q7jhPZaMoTlbxwQHnLlLr6Bh3mLqwYKQ9XFmtpagcB4k/IoNj0uT+dfJ6GMkl86b11PE6sYEbsC7e1Me9xL9UQjFsFaNjj/gnSvG6omKUlFL7N X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 02.07.25 10:42, Oscar Salvador wrote: > On Fri, Jun 27, 2025 at 01:55:08PM +0200, David Hildenbrand wrote: >> Let's clean up a bit: >> >> (1) No need for start_ptep vs. ptep anymore, we can simply use ptep >> >> (2) Let's switch to "unsigned int" for everything >> >> (3) We can simplify the code by leaving the pte unchanged after the >> pte_same() check. >> >> (4) Clarify that we should never exceed a single VMA; it indicates a >> problem in the caller. >> >> No functional change intended. >> >> Signed-off-by: David Hildenbrand > > Hi David :-), > > I have to confess that I fell in the same trap as Lorenzo wrt. > __pte_batch_clear_ignored changing the pte value. > So I'm not sure if it would be nice to place a little comment in > __pte_batch_clear_ignored claryfing that pte's value remains unchanged ? I mean, that's how all our pte modification functions work, really? :) Thanks! -- Cheers, David / dhildenb