From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6B4A4C27C4F for ; Tue, 11 Jun 2024 03:38:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DC5586B0099; Mon, 10 Jun 2024 23:38:39 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D74DB6B009A; Mon, 10 Jun 2024 23:38:39 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C64306B009B; Mon, 10 Jun 2024 23:38:39 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id A8B096B0099 for ; Mon, 10 Jun 2024 23:38:39 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 21157A1173 for ; Tue, 11 Jun 2024 03:38:39 +0000 (UTC) X-FDA: 82217200758.06.EBD338E Received: from out30-100.freemail.mail.aliyun.com (out30-100.freemail.mail.aliyun.com [115.124.30.100]) by imf04.hostedemail.com (Postfix) with ESMTP id 16C5D4000C for ; Tue, 11 Jun 2024 03:38:35 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=linux.alibaba.com header.s=default header.b=nGijnC6e; spf=pass (imf04.hostedemail.com: domain of baolin.wang@linux.alibaba.com designates 115.124.30.100 as permitted sender) smtp.mailfrom=baolin.wang@linux.alibaba.com; dmarc=pass (policy=none) header.from=linux.alibaba.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1718077117; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=QDcikbdRYxYQ32eA9e+mi5J1LcxsHOoeSQCbKKlUbZ8=; b=fOIyl8zbwsBQWyYkCElIiwlHv2/wWxk0BFKv34R6NEBQJh+F4f++wXyiBKg8Fv3AKWfDDz n35RisY2fCvFy6HUBN9+/+dnjbmcnxfiRuMx72SNlPOd0pFDsFNfrcOmgUJxr/ZdZn80JV 7PpcUqjbWS3JP9Qki64EGTZ0X7YH25w= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=linux.alibaba.com header.s=default header.b=nGijnC6e; spf=pass (imf04.hostedemail.com: domain of baolin.wang@linux.alibaba.com designates 115.124.30.100 as permitted sender) smtp.mailfrom=baolin.wang@linux.alibaba.com; dmarc=pass (policy=none) header.from=linux.alibaba.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1718077117; a=rsa-sha256; cv=none; b=MMM2VI6kptVZzHPXeqMnG8LWlhifhOPXfQfqDpBWkoZnrZGLPZV5I9PBOC421eT4l8xUIV 9tc3WxnC5npL4cDxI6OSjiZ31ayNzl6okLculgnXQ7ePGUx118G2a06YAS6oViWx7v5YRK V7v2fUjSEEaQDxlLEUhQIA5QZw9VfFY= DKIM-Signature:v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.alibaba.com; s=default; t=1718077113; h=Message-ID:Date:MIME-Version:Subject:To:From:Content-Type; bh=QDcikbdRYxYQ32eA9e+mi5J1LcxsHOoeSQCbKKlUbZ8=; b=nGijnC6e0bReFiBvtO+VU9gk/xqhRTdimgcwu+fI7RfGfMmcT9v4G9W6fWedl3uCQI8AIxz3JLULO9kVWs0ZUi+7lgWJ3dxXvKzVBtEPyLIbSlFWLvyzY5FauudZA3+ppWSf816llsZTczaDqqk1Y0nSLu4J6yHx4L5+3s+bUNg= X-Alimail-AntiSpam:AC=PASS;BC=-1|-1;BR=01201311R101e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=maildocker-contentspam033037067109;MF=baolin.wang@linux.alibaba.com;NM=1;PH=DS;RN=16;SR=0;TI=SMTPD_---0W8Ezy66_1718077111; Received: from 30.97.56.68(mailfrom:baolin.wang@linux.alibaba.com fp:SMTPD_---0W8Ezy66_1718077111) by smtp.aliyun-inc.com; Tue, 11 Jun 2024 11:38:32 +0800 Message-ID: <1d951d46-8c80-4458-a1bf-b94680c451a6@linux.alibaba.com> Date: Tue, 11 Jun 2024 11:38:31 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 5/7] mm: add new 'orders' parameter for find_get_entries() and find_lock_entries() To: Matthew Wilcox Cc: akpm@linux-foundation.org, hughd@google.com, david@redhat.com, wangkefeng.wang@huawei.com, chrisl@kernel.org, ying.huang@intel.com, 21cnbao@gmail.com, ryan.roberts@arm.com, shy828301@gmail.com, ziy@nvidia.com, ioworker0@gmail.com, da.gomez@samsung.com, p.raghav@samsung.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <5304c4c54868336985b396d2c46132c2e0cdf803.1717673614.git.baolin.wang@linux.alibaba.com> From: Baolin Wang In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 16C5D4000C X-Stat-Signature: 8qmiaefh78jnkqmteuard8p7pjyz314n X-HE-Tag: 1718077115-739611 X-HE-Meta: U2FsdGVkX1/18hL7HD00Nu2MM42O5m0KcE/CWQBfsa498RgpAaSEFS0L+XHynSZd2aDOn/+yC5DONUFZAFp8lm6SsUcQHgSEIJTupykI8AA8NSkztgQLnmPiIQS8280E3fIOkUdo5fkhbabvcKBSPU3MjMTyoLCPiww6hGbEr/NAfAL33pSLoNPfCgnwnle5pwslxf3dozCKqTMMLZBxAw2seMrHId/L9tTSKGUCHPMmajiZTiwzQnLJs7dVsiidpeMP6e6QI0/kRygMJrlZCFfWbJLxkQElw16L3s0Ci1P3au24j76Bep4wOl8l8s54rPpWL5YwSA+iI6JL8MpZuqB3xVSiiojaAcrH51fW3THIEIAF2rY52F826/LrqJno54wiZRJ7x3q0mc1YIObvBk/Mh63qTf9YuqHKt/9LjrZmtJZlW9o11e9XXXIL9sqDHCxgFTunvRsWkvvQQ8JRKz8TQGDOitVb9T7x0lCzhRZSfGbikBGvnuC0Eb4plKU7bkfhr41J5i5lY1LcBkeTLvWcLexuUwRqPZ+0EuBj228l3xT6fA/rhDa6ACKDgKYlokhRyHoRzGdRYo24/anxnSWEyXifmmL70dqFYnFyfvPbKWrEEB5/DGJz5iX6MF0jYrXrZkAMY1PzlrvjJGWXdJDSRZWZHuCS3YUOORjtUE21GfIbdwdn5/mXaUvYlnu4TA7loaLzgxJKXzxhjXvazJ/0pFS9c23KvfabQxOSH9qAVjCMCFtkCvD027+DWSmwj+uYaYjZSugu7ZeuXJ54p9uF6Ywxnikz6gEtrGigIdomqjnOGLgUMOLZR81JdWYqLSdn0eJ8wi3kAVgqNgU3j91zvlzuzpJPHhgfBL+nrd/lk8tGqTA/Jw1+JlPp3DgMF4H1kITbrmqpy4LgXtXncj7ZHzFhFqqYKKUn8qpzS/zytxfIHUVSUXn6rRq78MHGH6XoNPTXyuy6BaX6ZYW iRq2pKPN ArYv1ZSwQFyWBvdU4xD4fYrY8YpJdJfTIBeGKy+mM6BTQSNc/2sZZg69AbiN18qc609wilG5l7aTuEpXl03SUyXCcAff3SJfsZ/AhqV3OafZtNkIptxTyDwLrw+LEkpWkTFd4I6cpH2vmArUM8lnHPk9Us9M33rrHoSDxMGsdxdxXtyacU+mAtE6kv7ztIYRWh9ivUc+DeX1jemCKoiW37ptQevvbVzpkyTGOt7GlK/hl5CFE+obuGDE8mgaAahCBmRRCYh3+c/1YDkAPbB6oixslkZ2KqMsuZFGfEyq4n5KNh+NFGWeMmsAwlUIxZoZRvBXpoy5WMvLyiXfSXfzTgIa81gW1PoMT7SWl6bmIJTkxX/1NoixF0zSTzqIAg7TLK0hWkUxAYOqLiAAnzwK5UXhUdw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2024/6/11 00:59, Matthew Wilcox wrote: > On Thu, Jun 06, 2024 at 07:58:55PM +0800, Baolin Wang wrote: >> In the following patches, shmem will support the swap out of large folios, >> which means the shmem mappings may contain large order swap entries, so an >> 'orders' array is added for find_get_entries() and find_lock_entries() to >> obtain the order size of shmem swap entries, which will help in the release >> of shmem large folio swap entries. > > I am not a fan. With Daniel's suggestion, I think I can drop the 'order' parameter if you don't like it. I was hoping that 'order' would be encoded in the swap > entry, not passed as a separate parameter. > > As I understand it, we currently have a free bit, or > swp_to_radix_entry() would not work. We can use that as detailed > here to encode the order in a single bit. > > https://kernelnewbies.org/MatthewWilcox/NaturallyAlignedOrder OK. This seems to deserve a separate patch set. I will look at your suggestion in detail. Thanks.