From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6DDFEC3F68F for ; Mon, 3 Feb 2020 22:07:37 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 2ECB020674 for ; Mon, 3 Feb 2020 22:07:37 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=nvidia.com header.i=@nvidia.com header.b="U8QvK34E" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2ECB020674 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=nvidia.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id D05BB6B0003; Mon, 3 Feb 2020 17:07:36 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id CB5546B0005; Mon, 3 Feb 2020 17:07:36 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BA5186B0006; Mon, 3 Feb 2020 17:07:36 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0200.hostedemail.com [216.40.44.200]) by kanga.kvack.org (Postfix) with ESMTP id 9F39B6B0003 for ; Mon, 3 Feb 2020 17:07:36 -0500 (EST) Received: from smtpin13.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 52CEA181AC9CC for ; Mon, 3 Feb 2020 22:07:36 +0000 (UTC) X-FDA: 76450203312.13.mom67_5f6e3752d870c X-HE-Tag: mom67_5f6e3752d870c X-Filterd-Recvd-Size: 4273 Received: from hqnvemgate25.nvidia.com (hqnvemgate25.nvidia.com [216.228.121.64]) by imf19.hostedemail.com (Postfix) with ESMTP for ; Mon, 3 Feb 2020 22:07:35 +0000 (UTC) Received: from hqpgpgate101.nvidia.com (Not Verified[216.228.121.13]) by hqnvemgate25.nvidia.com (using TLS: TLSv1.2, DES-CBC3-SHA) id ; Mon, 03 Feb 2020 14:07:11 -0800 Received: from hqmail.nvidia.com ([172.20.161.6]) by hqpgpgate101.nvidia.com (PGP Universal service); Mon, 03 Feb 2020 14:07:34 -0800 X-PGP-Universal: processed; by hqpgpgate101.nvidia.com on Mon, 03 Feb 2020 14:07:34 -0800 Received: from [10.110.48.28] (10.124.1.5) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Mon, 3 Feb 2020 22:07:33 +0000 Subject: Re: [PATCH v3 11/12] mm/gup_benchmark: support pin_user_pages() and related calls To: "Kirill A. Shutemov" CC: Andrew Morton , Al Viro , Christoph Hellwig , Dan Williams , Dave Chinner , Ira Weiny , Jan Kara , Jason Gunthorpe , Jonathan Corbet , =?UTF-8?B?SsOpcsO0bWUgR2xpc3Nl?= , Michal Hocko , Mike Kravetz , Shuah Khan , Vlastimil Babka , Matthew Wilcox , , , , , , LKML References: <20200201034029.4063170-1-jhubbard@nvidia.com> <20200201034029.4063170-12-jhubbard@nvidia.com> <20200203135845.ymfbghs7rf67awex@box> <20200203215553.q7zx6diprbby6ns5@box.shutemov.name> From: John Hubbard X-Nvconfidentiality: public Message-ID: <1d89f126-91b8-bab9-0d6c-0a789581dbff@nvidia.com> Date: Mon, 3 Feb 2020 14:07:33 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.2 MIME-Version: 1.0 In-Reply-To: <20200203215553.q7zx6diprbby6ns5@box.shutemov.name> X-Originating-IP: [10.124.1.5] X-ClientProxiedBy: HQMAIL105.nvidia.com (172.20.187.12) To HQMAIL107.nvidia.com (172.20.187.13) Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1580767631; bh=3g2jpP7PATIRShMbNa46mzIFlzlSWwEuhifQjWIA0qA=; h=X-PGP-Universal:Subject:To:CC:References:From:X-Nvconfidentiality: Message-ID:Date:User-Agent:MIME-Version:In-Reply-To: X-Originating-IP:X-ClientProxiedBy:Content-Type:Content-Language: Content-Transfer-Encoding; b=U8QvK34EGwtcRxqHonJOikQVH8V81FSRLWwtw4MkUI7C9VjLfhrlxTzvE+w9oTS/W F7AjIKlrxbA1U7WdKDvnEvXvcA9Owttra/Fa+MULA7zHQI1QiAha21jaJEOyySC98d GCxJRpBcK5guEW+dpfpJriF80N83GetmAwP0rQEgK00+PAhzBSRnHMcTVhEjeQl0xH c6wWwTN28IokxkfYyzrX93PaQUwEcVKotdnO8uAXY3mp2UsqKU6D5l5lXbZ1aojfEI GP9AynFsKx9PKu+mi2bDIv1QFLzjxT8sgD7GSdTisaCXA3NaDhNIQoR+cmCerg3D/q y2gHb76zk0kGQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2/3/20 1:55 PM, Kirill A. Shutemov wrote: > On Mon, Feb 03, 2020 at 01:17:40PM -0800, John Hubbard wrote: >> On 2/3/20 5:58 AM, Kirill A. Shutemov wrote: >> ... >>>> @@ -19,6 +21,48 @@ struct gup_benchmark { >>>> __u64 expansion[10]; /* For future use */ >>>> }; >>>> >>>> +static void put_back_pages(unsigned int cmd, struct page **pages, >>>> + unsigned long nr_pages) >>>> +{ >>>> + int i; >>>> + >>>> + switch (cmd) { >>>> + case GUP_FAST_BENCHMARK: >>>> + case GUP_LONGTERM_BENCHMARK: >>>> + case GUP_BENCHMARK: >>>> + for (i = 0; i < nr_pages; i++) >>> >>> 'i' is 'int' and 'nr_pages' is 'unsigned long'. >>> There's space for trouble :P >>> >> >> Yes, I've changed it to "unsigned int", thanks. > > I'm confused. If nr_pages is more than UINT_MAX, this is endless loop. > Hm? > Oh, I've been afflicted with 64-bit tunnel vision. OK, make that "unsigned long" and "%ul". yikes. :) thanks, -- John Hubbard NVIDIA