From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2FC68C27C79 for ; Wed, 12 Jun 2024 01:41:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B3D856B012B; Tue, 11 Jun 2024 21:41:09 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id AC5F96B012C; Tue, 11 Jun 2024 21:41:09 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9188D6B012D; Tue, 11 Jun 2024 21:41:09 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 6BAF96B012B for ; Tue, 11 Jun 2024 21:41:09 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 0CBAE140460 for ; Wed, 12 Jun 2024 01:41:09 +0000 (UTC) X-FDA: 82220533458.11.60B3D62 Received: from mail-oi1-f175.google.com (mail-oi1-f175.google.com [209.85.167.175]) by imf26.hostedemail.com (Postfix) with ESMTP id 29ECF14000B for ; Wed, 12 Jun 2024 01:41:06 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="FxZ/J1VF"; spf=pass (imf26.hostedemail.com: domain of shaun.tancheff@gmail.com designates 209.85.167.175 as permitted sender) smtp.mailfrom=shaun.tancheff@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1718156467; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ldw9Rb9bx9AbmOX5rP/jpzGDJM5O5xhaxyO961LfX/g=; b=hmzno0RGskiN6EI7rmLIZvCNjQ+7c8muWcHiyLL4Fh0DFreyF9Dv8//DacqcAU0Z4HLzPK FbiZePcbRnrFKzWhKvtClbp7IWo3VPtYgyqhdkGjLj2w9NepVK6Bb/ALCjBZK2sYsyGmgL yFMaTuvahoX5cWid5cfMddTMTNrVn6s= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1718156467; a=rsa-sha256; cv=none; b=cZJuqtmr6KwiZgOE8Os6mDfKHxJ1XM6+wRo0D7/VcU1OyX6e65uk+Q1TOa9SJ3uhEWfidH Mx+1KiFwreq5HSoi1xFfBTG3crSTMKOhl3SHwqgGtwaRGSxpgN/fzxVD7z3QEWHHyvHHg1 li07D0bWgqTuWBz+czzJCx7wLiFX8n8= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="FxZ/J1VF"; spf=pass (imf26.hostedemail.com: domain of shaun.tancheff@gmail.com designates 209.85.167.175 as permitted sender) smtp.mailfrom=shaun.tancheff@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-oi1-f175.google.com with SMTP id 5614622812f47-3d1d08c7c8aso3644584b6e.2 for ; Tue, 11 Jun 2024 18:41:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1718156466; x=1718761266; darn=kvack.org; h=in-reply-to:from:content-language:references:cc:to:subject :user-agent:mime-version:date:message-id:from:to:cc:subject:date :message-id:reply-to; bh=ldw9Rb9bx9AbmOX5rP/jpzGDJM5O5xhaxyO961LfX/g=; b=FxZ/J1VFP81o+ExK0agq7DYJWNew2C2lRu0yLgIpk6pGHxqroaXb5WndqG+o1JLzNo ONOK1+R3qddkihgEO/nSdv+s6QYEIe95RlFm+4XXDtePWuyCI1Az89uZ1uupeVcd0Zq+ MdD6QdXbxE1TN4MWOtGejlG6N9pei/zfFIlIs4nPWlqlKUGujYy2VNE3LDtH9QCpeeAm Eyw9rmb4KiY87WnY8+OSjn0xkJo36tVlS9rILP6HsZLwclLnVzeSEjX8IKOQFQIjEZVo NCVHaTywn8hQ39pkJhfH9JgixGIIiosIzoUMT2JGfzSGGFCXRa1R3LWfRurTgtRSsOGQ PeoA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718156466; x=1718761266; h=in-reply-to:from:content-language:references:cc:to:subject :user-agent:mime-version:date:message-id:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=ldw9Rb9bx9AbmOX5rP/jpzGDJM5O5xhaxyO961LfX/g=; b=bKhNbkyYgn7UQ5hpFLNt6nwM2zCG6YrbazVV0/aRly/jX9gFvayzfaERNd8y7Gvc1x L0PmAV2+ZqVuseJAd+ZanfPTZUS/eTWN1mdwfMd+xqNCa7ZYLu4VgzwXQ1k6XSP/6CdO tJY7UwOzDekWQ4rEgz1zqIyYxa+w2IeAbZF7cfpHL6TJ+uNqdqFjD0qrPP3IeT/zj6sO FZs4DH+a6gAmW0yynJ9kLI0p6FSAgTBhiTCwK9mEVa0FkJli3ZSlpVfrkW6JHj3ut47X bDBZmal3Ae420icEgf3EUqgs7EJkHgsYvgx0YAKcpYmbf/djuK/sHGbILDpkW/eT0qAr SmgA== X-Forwarded-Encrypted: i=1; AJvYcCWRPVaNkiUnODMXWSOxdZeCFs6+EEf+tT+nZL0vOQkggJUheqwznrX34sWsuMAMKsNJTuvHkpCCE/k0O94+fmH8cV4= X-Gm-Message-State: AOJu0YzDTvn80kmnC6C3qrMPvyLw4Z66gkvNMS1uw5gzEj31OU63T/9X WX+MTHFMYtJg/EJAot/oRiexeBtLE8uNlnDErjtccYFAvMkgKzrY X-Google-Smtp-Source: AGHT+IFpbE5noEo2r3Wwb4r1yF1zJVLYTNJh10UNxyJIeKXSM8eBPNUUTw28pHZ0Vy9wGJ5FkgQApQ== X-Received: by 2002:a05:6808:10c8:b0:3d2:2512:5a45 with SMTP id 5614622812f47-3d23e0cf35amr533427b6e.54.1718156465874; Tue, 11 Jun 2024 18:41:05 -0700 (PDT) Received: from [192.168.69.102] ([182.2.165.2]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-705b4b4e590sm1318806b3a.87.2024.06.11.18.41.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 11 Jun 2024 18:41:05 -0700 (PDT) Content-Type: multipart/alternative; boundary="------------01thHR8UgzZSWsAGovOc0iRb" Message-ID: <1d87741b-7178-4791-aca2-da3ac3033552@gmail.com> Date: Wed, 12 Jun 2024 08:41:01 +0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/2] filemap: Convert generic_perform_write() to support large folios To: Christoph Hellwig , Shaun Tancheff Cc: Trond Myklebust , Anna Schumaker , Matthew Wilcox , linux-nfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org References: <20240527163616.1135968-1-hch@lst.de> <20240527163616.1135968-2-hch@lst.de> <8e23be47-e542-4bb8-8da7-da7801c98e42@hpe.com> <20240611161311.GA12257@lst.de> Content-Language: en-US From: Shaun Tancheff In-Reply-To: <20240611161311.GA12257@lst.de> X-Rspamd-Queue-Id: 29ECF14000B X-Rspam-User: X-Rspamd-Server: rspam08 X-Stat-Signature: w8fypxsjm33eb5wa1r4kmoyhp98unh3w X-HE-Tag: 1718156466-607840 X-HE-Meta: U2FsdGVkX1+pkxmBctME9+FIE1RWKh3Gl6XK3lHeWL9O6ncJt2ppMoCKUHXox/5GWps8rapeONZ9CGim9AmdusP4OwBG7Xhww7FU+0K7p4eMkqbNbzp63g0gjUcWg5qAphTMjXJ//ZXYEtHJ4tLJaRvuLzgDG6xAerf19SPZjnDXpg+7/JwI4lLn+BQt58Tu0iHg2mZpVA6alGSij1OcSSIsof7HQ0gy/Kx+A5Cs/Hq7Ybivhu3L6T4G67UHhAPRR5oek8cvGtPEFHpH5aIQDo+r5skvDx6FRaXbojtg0VvmP5sUu3ElTr8cfgtfZnikuyWMx8CJ+LK1tNYD08qFuDoqVMbl2n25VztAgoCH8fBpgphwk2O7hZN8PqtTaLkyygnUK1YoCr5uwdFV3uW2bwAjdkMHejg+cRJHSwvu87Un1HqJSvnIoQ0IlZb9xTcfZaEOTnX5eHq4gYSFsEycXGuv4FXuGVsk80OX4Hjk8kqT4BUn9V3F+VOvzOjCyF3LA3j8fh47PYeH/XB3HdKbbj3H1m6PsORXhfZ4/gsXjVHj8ANgkYR3TLUkaG9eOObE8WjW7KfMYelMkHgDvm1VFC6bZLCmGLhtHWJX9yo0N811wvUjh6JSjX6yF1a2F8UHvFNRmwRKVeov0rOK8Dtw7gbHRCLUnVcgzlb+l425P3vs1APdy2fZfYcOvRRCNyUcvkf2qT0XzndtW8U0RVR1tVF1ost2DC6sLDq53JmjythyLN5Vu9XF/qCFRlR0iGKO23nuwttteDPY/wajhleJpuPFMZ9rZQv4/25Zk9aGN5OxOiqqcEZXwYhtqrEk6kCw0FM71jA5mOT27+JSZZfJecnI68hIfeyLBzT2oPbnRPAKRrKGmNQOIj63kO30+VXw+ncYRiCT2gWoMtgrWig+lhgn6htLuDhVlSBkYSJL9BtsDABQJVFVi8Ox3BaRAy4ORZ3k766iWRxfLRBCekc reMVeogh vdOd/l3Dj5z38dl+KuF2DpgIEd+FcJZnCL4Rwns0l5ps+irsKfFVKi8khtk7DYvLSP+fXVTeMBHRqB47pOcQM0IqnDCpsNU8ssq+EIf64H5pG2JAnKfs694QSSxF64fkUHK+HTwMsyZBzVpHAWVH5vdAhs4d85op4+WypfaLnV9oMvP+JXx/VymfhtptEiKkS0RbPySUf3cS8iQQJKykedKOH8eTlb5xZJDvsGYHAdMU0UCFIRILOo1Uk07QEBlUQ0Jc20U6BWd91Jj/WvGTPDLzB1uYj2Lic5LHoiOYnBuTz70Q39b5qUPgAL3lZywIPPqOkjRUIMyXekn1RsDpLS8kCZFe0d8tZhp8h2onDiMoRueX4gyAAIL9j9iLLlL4q3KYGuDnNZXfgWEi3P2PeVBM4sq6AVxS3N28qzIHiwQodm/5vhgnrn1PrZF1iQX98uwSrh7FahTE6RIPVHXkRh0GgAwmu9GS0PJLSV2nFdtYcb1FhuW6bPbVGds+j4LCe46IlevVWettHILJevMIJR4GdT56376Wcsw1baU845K8QV4tWXabGu65LUKR+vtO+OrF51/hytaeOMSp5AcUE+bWn8Kth2xL7smKP6IDWD887aWagvOpNUDOQLw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: This is a multi-part message in MIME format. --------------01thHR8UgzZSWsAGovOc0iRb Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 6/11/24 23:13, Christoph Hellwig wrote: > On Tue, Jun 11, 2024 at 05:47:12PM +0700, Shaun Tancheff wrote: >>> const struct address_space_operations *a_ops = mapping->a_ops; >>> + size_t chunk = mapping_max_folio_size(mapping); >> Better to default chunk to PAGE_SIZE for backward compat >> +       size_t chunk = PAGE_SIZE; >> >>> long status = 0; >>> ssize_t written = 0; >>> >> Have fs opt in to large folio support: >> >> +       if (mapping_large_folio_support(mapping)) >> +               chunk = PAGE_SIZE << MAX_PAGECACHE_ORDER; > I don't think you've actually read the code, have you? I checked from 6.6 to linux-next with this patch and my ext4 VM does not boot without the opt-in. Almost certainly there is something I am missing, probably not looking at the correct tree. Thanks! --Shaun --------------01thHR8UgzZSWsAGovOc0iRb Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 8bit 

    

      
On 6/11/24 23:13, Christoph Hellwig wrote:

    

    

      
On Tue, Jun 11, 2024 at 05:47:12PM +0700, Shaun Tancheff wrote:


      

        

          
  	const struct address_space_operations *a_ops = mapping->a_ops;
+	size_t chunk = mapping_max_folio_size(mapping);


        

        
Better to default chunk to PAGE_SIZE for backward compat
+       size_t chunk = PAGE_SIZE;



        

          
  	long status = 0;
  	ssize_t written = 0;
  


        

        
Have fs opt in to large folio support:

+       if (mapping_large_folio_support(mapping))
+               chunk = PAGE_SIZE << MAX_PAGECACHE_ORDER;


      

      
I don't think you've actually read the code, have you?

    

    
I checked from 6.6 to linux-next with this patch and my ext4 VM does not boot without the opt-in.

    
Almost certainly there is something I am missing, probably not looking at the correct tree.

Thanks!
--Shaun

  


--------------01thHR8UgzZSWsAGovOc0iRb--