From: Vincenzo Frascino <vincenzo.frascino@arm.com>
To: Arnd Bergmann <arnd@arndb.de>,
Christophe Leroy <christophe.leroy@csgroup.eu>,
linux-kernel@vger.kernel.org,
Linux-Arch <linux-arch@vger.kernel.org>,
linux-mm@kvack.org
Cc: Andy Lutomirski <luto@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
"Jason A . Donenfeld" <Jason@zx2c4.com>,
Michael Ellerman <mpe@ellerman.id.au>,
Nicholas Piggin <npiggin@gmail.com>,
Naveen N Rao <naveen@kernel.org>, Ingo Molnar <mingo@redhat.com>,
Borislav Petkov <bp@alien8.de>,
Dave Hansen <dave.hansen@linux.intel.com>,
"H. Peter Anvin" <hpa@zytor.com>, Theodore Ts'o <tytso@mit.edu>,
Andrew Morton <akpm@linux-foundation.org>,
Steven Rostedt <rostedt@goodmis.org>,
Masami Hiramatsu <mhiramat@kernel.org>,
Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Subject: Re: [PATCH 5/9] vdso: Split linux/minmax.h
Date: Fri, 6 Sep 2024 12:41:11 +0100 [thread overview]
Message-ID: <1d86a38b-dd57-48ac-875b-4d9d2f645d47@arm.com> (raw)
In-Reply-To: <780d969f-8057-41aa-901f-08a5fbebcba9@app.fastmail.com>
On 04/09/2024 18:23, Arnd Bergmann wrote:
> On Wed, Sep 4, 2024, at 17:17, Christophe Leroy wrote:
>> Le 03/09/2024 à 17:14, Vincenzo Frascino a écrit :
>>> The VDSO implementation includes headers from outside of the
>>> vdso/ namespace.
>>>
>>> Split linux/minmax.h to make sure that the generic library
>>> uses only the allowed namespace.
>>
>> It is probably easier to just don't use min_t() in VDSO. Can be open
>> coded without impeeding readability.
>
> Right, or possibly the even simpler MIN()/MAX() if the arguments
> have no side-effects.
>
Agreed, generally I do not like open-coding since it tends to introduce
duplication, but these cases are simple especially if we can use MIN()/MAX().
> Arnd
--
Regards,
Vincenzo
next prev parent reply other threads:[~2024-09-06 11:41 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-03 15:14 [PATCH 0/9] vdso: Use only headers from the vdso/ namespace Vincenzo Frascino
2024-09-03 15:14 ` [PATCH 1/9] x86: vdso: Introduce asm/vdso/mman.h Vincenzo Frascino
2024-09-03 15:16 ` Jason A. Donenfeld
2024-09-03 15:23 ` Vincenzo Frascino
2024-09-04 16:56 ` Christophe Leroy
2024-09-06 10:55 ` Vincenzo Frascino
2024-09-03 15:14 ` [PATCH 2/9] vdso: Introduce vdso/mman.h Vincenzo Frascino
2024-09-03 15:14 ` [PATCH 3/9] x86: vdso: Introduce asm/vdso/page.h Vincenzo Frascino
2024-09-04 14:52 ` Arnd Bergmann
2024-09-04 15:05 ` Christophe Leroy
2024-09-06 11:26 ` Vincenzo Frascino
2024-09-06 11:20 ` Vincenzo Frascino
2024-09-06 19:19 ` Arnd Bergmann
2024-09-06 18:40 ` Christophe Leroy
2024-09-08 20:48 ` Arnd Bergmann
2024-09-10 12:28 ` Christophe Leroy
2024-09-10 15:05 ` Arnd Bergmann
2024-09-04 17:14 ` Christophe Leroy
2024-09-03 15:14 ` [PATCH 4/9] vdso: Introduce vdso/page.h Vincenzo Frascino
2024-09-04 17:16 ` Christophe Leroy
2024-09-06 11:35 ` Vincenzo Frascino
2024-09-03 15:14 ` [PATCH 5/9] vdso: Split linux/minmax.h Vincenzo Frascino
2024-09-04 17:17 ` Christophe Leroy
2024-09-04 17:23 ` Arnd Bergmann
2024-09-06 11:41 ` Vincenzo Frascino [this message]
2024-09-08 19:58 ` David Laight
2024-09-03 15:14 ` [PATCH 6/9] vdso: Split linux/array_size.h Vincenzo Frascino
2024-09-04 17:18 ` Christophe Leroy
2024-09-06 11:42 ` Vincenzo Frascino
2024-09-03 15:14 ` [PATCH 7/9] x86: vdso: Modify asm/vdso/getrandom.h to include datapage Vincenzo Frascino
2024-09-04 17:19 ` Christophe Leroy
2024-09-06 11:48 ` Vincenzo Frascino
2024-09-03 15:14 ` [PATCH 8/9] vdso: Modify vdso/getrandom.h to include the asm header Vincenzo Frascino
2024-09-03 15:14 ` [PATCH 9/9] vdso: Modify getrandom to include the correct namespace Vincenzo Frascino
2024-09-04 17:26 ` Christophe Leroy
2024-09-06 11:52 ` Vincenzo Frascino
2024-09-06 12:04 ` Christophe Leroy
2024-09-06 12:40 ` Vincenzo Frascino
2024-09-06 12:49 ` Christophe Leroy
2024-09-06 12:51 ` Vincenzo Frascino
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1d86a38b-dd57-48ac-875b-4d9d2f645d47@arm.com \
--to=vincenzo.frascino@arm.com \
--cc=Jason@zx2c4.com \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=bp@alien8.de \
--cc=christophe.leroy@csgroup.eu \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=luto@kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=mhiramat@kernel.org \
--cc=mingo@redhat.com \
--cc=mpe@ellerman.id.au \
--cc=naveen@kernel.org \
--cc=npiggin@gmail.com \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox