From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A3346C369C2 for ; Fri, 25 Apr 2025 14:38:13 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7365B6B0007; Fri, 25 Apr 2025 10:38:11 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6E6C66B0008; Fri, 25 Apr 2025 10:38:11 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5AC7A6B000A; Fri, 25 Apr 2025 10:38:11 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 3AF886B0007 for ; Fri, 25 Apr 2025 10:38:11 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 679C55FB5A for ; Fri, 25 Apr 2025 14:38:12 +0000 (UTC) X-FDA: 83372821224.18.8713E6E Received: from fhigh-a5-smtp.messagingengine.com (fhigh-a5-smtp.messagingengine.com [103.168.172.156]) by imf18.hostedemail.com (Postfix) with ESMTP id 7DA3C1C000F for ; Fri, 25 Apr 2025 14:38:10 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=flygoat.com header.s=fm1 header.b=IIB197hI; dkim=pass header.d=messagingengine.com header.s=fm3 header.b="L RJEWNN"; spf=pass (imf18.hostedemail.com: domain of jiaxun.yang@flygoat.com designates 103.168.172.156 as permitted sender) smtp.mailfrom=jiaxun.yang@flygoat.com; dmarc=pass (policy=none) header.from=flygoat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1745591890; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=CLKLmE1kp6xGTNTaA1wv5clJAfh3naWBpIi72wRv0Pg=; b=NsQ4LOkHxImYZS69gQ/LrLxNEJPDJPIEi4DPBHocuu990eSwyqUcAAK37kNaLJrPJMao9S KRzAHNGqnRMHEck9vuz2ZTsZjIQ+1mr9lWujcB995UtU7Dr8Mz23PLrP8nLScx783Ba+pO Jm+4X8Z6ConcVz0mTluTvGgBt903m58= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=flygoat.com header.s=fm1 header.b=IIB197hI; dkim=pass header.d=messagingengine.com header.s=fm3 header.b="L RJEWNN"; spf=pass (imf18.hostedemail.com: domain of jiaxun.yang@flygoat.com designates 103.168.172.156 as permitted sender) smtp.mailfrom=jiaxun.yang@flygoat.com; dmarc=pass (policy=none) header.from=flygoat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1745591890; a=rsa-sha256; cv=none; b=gSq2LgM5NzfSEmcRKcgWBchOw7IQVU6lA0jsX1TJxrTnuyHh4lTVOtpVJgx6ghYDfS/YUf k1EmbAkEHuR78VOm3l4HTuGEVnoyr/6A0RM5FfVphNnoP7HnnTrvetD0nE2AfvQ2gIzVT7 KVdbYDAxX3uKt78JW5AL1u9htkxO7o8= Received: from phl-compute-06.internal (phl-compute-06.phl.internal [10.202.2.46]) by mailfhigh.phl.internal (Postfix) with ESMTP id E5BF41140223; Fri, 25 Apr 2025 10:38:09 -0400 (EDT) Received: from phl-imap-12 ([10.202.2.86]) by phl-compute-06.internal (MEProxy); Fri, 25 Apr 2025 10:38:09 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=flygoat.com; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm1; t=1745591889; x=1745678289; bh=CLKLmE1kp6xGTNTaA1wv5clJAfh3naWBpIi72wRv0Pg=; b= IIB197hInL3ZXnIKKy6AS6kpOVK9xVy0j5obPxdwlBy0J6OGKWsrTXOeKWb/GFlj ve92u2CZxbcNIgZSf78pMU3FI/1pcIoICPojYNg2ZRlirnuoBtjCSMYJS9GZZQkf 5PTbRYW45ZmO5VrUgM0+YeEID8Jvo7dmx805kKh1YQpscDhDNKfakERywUfswke2 tTVr8aQ7hD6WOUC7U6ET8kDqj9phJgB7GDUiL5S9MgDAAzOEx/Yzos8+XfhU47Lu dtTM5zLPJGuVbVGaXf9XnGHpoD2sLutnpnI2rdwYRkX97VtIP877giHIe4aGbhCn 7tLM0SgP6xr9f8bawLTBlw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1745591889; x= 1745678289; bh=CLKLmE1kp6xGTNTaA1wv5clJAfh3naWBpIi72wRv0Pg=; b=L RJEWNN15MJ38l74OO/K4mQICXWcPYYs769PSSoHQmGPocLrlNQhZc28n5vPF/ilM TJSErQn/epZEItdvkffJ+zh6S2hnmvFDhmmjFeFL20SQFBOGWtxX8+4mdgpR98VO gyaHgBAyUgkZI7AukVJzCthpOhruOtBt1Rtu2zdzWLGUmTFg8OdQB7+qIdXWh2KD WwQM1nnbZAz50ySCaO1It33jl6XoNvywyBbUtMSWls+5fI2nCfYqliZyaU5A7Y8j +oIkQ7vSvxdAQ04sBDdrXnfLkkG4iwajbPWGA2O3XA5LgHyXpjVpzfloyr35o4oD EC1C0SusAbQssqH0Ok/kA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefvddrtddtgddvhedvheelucetufdoteggodetrf dotffvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdggtfgfnhhsuhgsshgtrhhisggv pdfurfetoffkrfgpnffqhgenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpih gvnhhtshculddquddttddmnecujfgurhepofggfffhvfevkfgjfhfutgfgsehtqhertder tdejnecuhfhrohhmpedflfhirgiguhhnucgjrghnghdfuceojhhirgiguhhnrdihrghngh esfhhlhihgohgrthdrtghomheqnecuggftrfgrthhtvghrnhepjeehfeduvddtgffgvdff keethefhlefgvdevvdekuefffeekheehgeevhfevteejnecuvehluhhsthgvrhfuihiivg eptdenucfrrghrrghmpehmrghilhhfrhhomhepjhhirgiguhhnrdihrghnghesfhhlhihg ohgrthdrtghomhdpnhgspghrtghpthhtohepuddvpdhmohguvgepshhmthhpohhuthdprh gtphhtthhopehtshgsohhgvghnugesrghlphhhrgdrfhhrrghnkhgvnhdruggvpdhrtghp thhtohepsggvrhgtrghnthhusegrmhgriihonhdruggvpdhrtghpthhtohepugifmhifvd esihhnfhhrrgguvggrugdrohhrghdprhgtphhtthhopehlkhhpsehinhhtvghlrdgtohhm pdhrtghpthhtoheptghhvghnhhhurggtrghisehkvghrnhgvlhdrohhrghdprhgtphhtth hopehrphhptheskhgvrhhnvghlrdhorhhgpdhrtghpthhtoheplhhinhhugidqmhhmsehk vhgrtghkrdhorhhgpdhrtghpthhtoheprghkphhmsehlihhnuhigqdhfohhunhgurghtih honhdrohhrghdprhgtphhtthhopeihrghjuhhnrdguvghngheslhhinhhugidruggvvh X-ME-Proxy: Feedback-ID: ifd894703:Fastmail Received: by mailuser.phl.internal (Postfix, from userid 501) id B2DAB1C20067; Fri, 25 Apr 2025 10:38:08 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface MIME-Version: 1.0 X-ThreadId: T3a8c85c33977e557 Date: Fri, 25 Apr 2025 15:37:37 +0100 From: "Jiaxun Yang" To: "David Woodhouse" , "Bernardo C. Gutierrez Cantu" Cc: "Andrew Morton" , linux-kernel@vger.kernel.org, linux-mm@kvack.org, "kernel test robot" , rppt@kernel.org, yajun.deng@linux.dev, "Huang Pei" , "Thomas Bogendoerfer" , "Huacai Chen" , "linux-mips@vger.kernel.org" Message-Id: <1d6c1572-25fd-4865-9a61-d58d58d163f1@app.fastmail.com> In-Reply-To: <16911666479b2fe4bc65944605199a8b3f12e875.camel@infradead.org> References: <20250425102003.64122-1-bercantu@amazon.de> <16911666479b2fe4bc65944605199a8b3f12e875.camel@infradead.org> Subject: Re: [PATCH] mm: memblock: Fix arguments passed to memblock_set_node() Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Stat-Signature: xs4guezzrwrzgmzb53c3hffy6a467eh5 X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 7DA3C1C000F X-Rspam-User: X-HE-Tag: 1745591890-618319 X-HE-Meta: U2FsdGVkX1+DpEua/nXefRjUwA9bYa6X7Pfz+byAGz/7HlOJPfYG+V8oFPwhoEKdLQn4r8YKQlBGtB+siRLkEVbZi6av1L1iATFJEiXK+r3NtgvUKX/1GH+m0KZOsFeCJQzi7Q+pw5UuzpOtPelKXEOmLyZu5PgcWHMLRTO3/kSOWyjVVyQCmRPBHhG3z/39/AW+b/fDUlYdizvjuJjIoB4bIfF2ZSoJ0RKfYCu431fq+4JIuO7+xDYntS4JqFkmgQBMVvAN7wCzWTUqDvYmx/VhVu+5UZr0Q92lGkljUrbyBHsd01OfX7ZyDldhWZq+h2x9kaXAh5jaOgtt5Zlvf9aIy0n9ZpcGIW4xWqWh9WwlBICmjoG2ifPwyeqIMRMXbteoNqFcG6GlyAj0fQl+zi/du4BqaOiXqd5wOvBqfen4SrwXKf0GFsaHk6nG6y121C3S3Zoo7k182rw6Qm+pD0eFZzt+6hrxpRisVJvhQq6lV7+JZwVtOua5zS2uyBd+zPdBdBikz/Yi76q9j05KEDelr3lKmEQZFH2LgDblVGWbLJpSbvbuqZj3u9I92qWkTP0LHALFS0zyTLm8TQfACAr167fevlKOKzCB4MdTJjXFI67aFnULPO9wDsbeP7fgV1carr3vMRj5rZJOeP4zezEit05uemxOEzKpThDVUvEAwyfPFCrApC+mGUneyGKD53hsxeYfS9D0u52M51SUU1mbL9H1FgfENyWeZEbpWIuzSc+o22qakrj4jj6QoHx3faWk6B7uXgeeYQTim08Olim22GGN6FwWS7BMKX2XfOiSnJ1dK2W8x97BW6jQPJL10h+TIvQXLT78qFnnFB9t9MYOLZEcM0LL+upJ5VoT5n6g2So4jGHpXDM5r6NzGvKId2yV/2o0m9LktqhEqi+PC1abCb7ra5sP8DnnEEB2tcHEnK3AU9lyTywBoZ4sDKKba0yJl5IWYPRTSBAGv0C p3lsjLQa aX7AJpGV0xet7188GWMtip8dzfg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: =E5=9C=A82025=E5=B9=B44=E6=9C=8825=E6=97=A5=E5=91=A8=E4=BA=94 =E4=B8=8B=E5= =8D=883:18=EF=BC=8CDavid Woodhouse=E5=86=99=E9=81=93=EF=BC=9A [...] Hi David & co, > > > I did a quick grep for memblock_set_node() callers, and the one in > szmem() in arch/mips/loongson64/init.c looks odd. > > /* set nid for reserved memory */ > memblock_set_node((u64)node << 44, (u64)(node + 1) << 44, > &memblock.reserved, node); > > At first glance I suspect the 'size' should just be (1<<44) or maybe it > should be inside the loop over the memmap, and called with mem_start, > mem_size each time? You are right, it should be (1 << 44), it is an oversight when I was converting MIPS private boot allocator to memblock. > > And why are we calling memblock_reserve() for what appears to be a > single system-wide vgabios_addr, repeatedly each time szmem() is called > for a different NUMA node? Alas this should be done only for node 0. Thanks > > > =E9=99=84=E4=BB=B6: > * smime.p7s --=20 - Jiaxun