From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 12821C369CB for ; Wed, 23 Apr 2025 15:30:39 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0A2546B0099; Wed, 23 Apr 2025 11:30:37 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 05D126B009B; Wed, 23 Apr 2025 11:30:37 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DE76D6B009A; Wed, 23 Apr 2025 11:30:36 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id BE14A6B0098 for ; Wed, 23 Apr 2025 11:30:36 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id EA5FFBCD24 for ; Wed, 23 Apr 2025 15:30:37 +0000 (UTC) X-FDA: 83365695714.05.52178AD Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf26.hostedemail.com (Postfix) with ESMTP id 3F9D414001B for ; Wed, 23 Apr 2025 15:30:35 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Fwzs3stg; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf26.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1745422235; a=rsa-sha256; cv=none; b=6Vk9fn0ndw1LLs+ZRew67M0CVXZD9cb88HzTbBmjRqko52iOTZSL7OGDjZldad81myZ5Se Tlu6YfPFSb4GhFeFhZAlcwbiT2Z5KeOmUx0zjmo/u5OFBTmQKyA2iYhJNd36WUfKnGhJgo 9qPNuUMVQOB0pZ0GuizYZgKYjzTW4XM= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Fwzs3stg; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf26.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1745422235; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=M797C/ITF0HAWTXP5yhOrI7XoNfydx3Ludug+71sxiA=; b=7FkqVw8iwH+ZOfCN+BI5YVF1EPjyQ+XhGgstSftfzlnM7n2011NGmDnnIdiU4nNDwIGKHt GDz5p3QGx3eDp4Gxz1QzREGd+Roo6j9iWjJ1LrVKx6L28Z6yBjWQNPhusyPNscIev/hnpr thlTU0L1UXaddhINvvLzNEX8BOPXGZY= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1745422234; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=M797C/ITF0HAWTXP5yhOrI7XoNfydx3Ludug+71sxiA=; b=Fwzs3stg+ZP5mzc2+SNXuMIod/Y/261NwycIMuM2NoS0hlSqaCx5tXjbGylbtC1IcPk5Ih VX9SYZT2jVXHjSRUgBkVIr0E0SGtwXafTN+bel15hDuReN6IZfeiAQ2MRyMsO+CpYnLz2Y 9cShGhGHAwfn0d0XM+kXagnP3lPSC10= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-672-PvqjsXnpOYqceysLbJUe1Q-1; Wed, 23 Apr 2025 11:30:33 -0400 X-MC-Unique: PvqjsXnpOYqceysLbJUe1Q-1 X-Mimecast-MFC-AGG-ID: PvqjsXnpOYqceysLbJUe1Q_1745422232 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-3912fe32a30so2330721f8f.1 for ; Wed, 23 Apr 2025 08:30:33 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745422232; x=1746027032; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=M797C/ITF0HAWTXP5yhOrI7XoNfydx3Ludug+71sxiA=; b=enUul8TKuNf3WoS1PX14o6BVYanQESg4ZlU0tSGR8NfLuM7nxyV+aVkH3v6ARHP7zJ q5oWB3UJipBHMBoulGpQO8QfmqQgImQHPVChDT3N39zOiAkm8fZJQaXzmcyH7RtOQpyc gkc9nUcmiArVCauWLrAXFsRh81IcZfLEPz5W6kQ+REjC1we4rdqy1+3Lj1t4/L4XOTud SiLcntAkLLVMXwHsOUZvWHEusw25/Q8BE3ibR29ryDJ/wV3w1z1fhpWJTZTtO4wKiINK azF5Vdxs5ubxCnN1AeGEXySnBhTP68Ft2Yo0IgoG2K804/ZYHa8tz7TWjM920jnSju5G hE3w== X-Forwarded-Encrypted: i=1; AJvYcCX/KFub2MMoqC3DMlLZ7cA47pNcV6IcmZeeQ8zUzwFIYxLFWqctaJA0WuimGg8toXRL5ZSwTy1zLQ==@kvack.org X-Gm-Message-State: AOJu0YyH4bQQ+um7DCFA1xakm/4zPT92jBk7rd3WY8gnMOINuZ0kGgv+ f3lYhjaBBt3BSU4r4IuZT4wfaTWvy+ts1r1jQeNJMzYI36D9aEQATqMB71B2exQN+l86nRzOjjn afiYn5mwSxkDEzUTofLR/OMhfCaeVDnu51wdyfhTKW3sV/nN8 X-Gm-Gg: ASbGncvOA1/egcTSsd0ilp4dMflfGygKZX1hRpCV+22q1rXtBjJdTTOnrUNySeSJviY 2PF7d9XfuRg+X6PCwWDkT64+9EcEpQr3BcsD3A9sWFPR9Aoz8l/s3o5YrO9x67rAeSd0CoQTqOf fH/TRsDHr4d/d3uCNFjIT+Ql5DIunoWSQIFHkere3UgpMrstRzV3f0GRF9V3WrepDCDe+5ziYSt 5GTYdmhtHMxDQLwRbQa/23L5H5xyaUov0PZRHUsOjkA0VXnSkK4GC3cKOLclXcvO1tYChvYGzwn egewfKMX2lZKDWy8qpNxYnMcj7ZMG5WzVJSZBw6DGD3DU/5N74MfLxVC/9Dp5WCX67qr6YaRc/A V6haMcGjAgrmZBVxs8wGhDg38UJRf0AnpksZN4no= X-Received: by 2002:a05:6000:2483:b0:39f:f4a:e852 with SMTP id ffacd0b85a97d-3a06c3d281cmr8831f8f.55.1745422231923; Wed, 23 Apr 2025 08:30:31 -0700 (PDT) X-Google-Smtp-Source: AGHT+IF7jRETXRnxkRae/SMJsqLh+ziz7A4V2u74HPeURUqUHuiBNkAkhRAGBWIYLnde5zc4MmpWrQ== X-Received: by 2002:a05:6000:2483:b0:39f:f4a:e852 with SMTP id ffacd0b85a97d-3a06c3d281cmr8795f8f.55.1745422231512; Wed, 23 Apr 2025 08:30:31 -0700 (PDT) Received: from ?IPV6:2003:cb:c740:2c00:d977:12ba:dad2:a87f? (p200300cbc7402c00d97712badad2a87f.dip0.t-ipconnect.de. [2003:cb:c740:2c00:d977:12ba:dad2:a87f]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-39efa4a4c0fsm19072148f8f.88.2025.04.23.08.30.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 23 Apr 2025 08:30:30 -0700 (PDT) Message-ID: <1d65a3fa-b870-40ba-ab99-e7e17b6297e5@redhat.com> Date: Wed, 23 Apr 2025 17:30:29 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1] kernel/fork: only call untrack_pfn_clear() on VMAs duplicated for fork() To: Lorenzo Stoakes Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, x86@kernel.org, Andrew Morton , Ingo Molnar , Dave Hansen , Andy Lutomirski , Peter Zijlstra , Thomas Gleixner , Borislav Petkov , Rik van Riel , "H. Peter Anvin" , Linus Torvalds References: <20250422144942.2871395-1-david@redhat.com> <9b83ba9c-ca6b-4dd8-8f00-1384c22f5c80@redhat.com> <7f8ed4e6-1743-4eaa-916f-25dca7575346@lucifer.local> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <7f8ed4e6-1743-4eaa-916f-25dca7575346@lucifer.local> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: jDFrw5X2LIxWSfsSw6v4ZIK_pAXgThzkqNdPHI5aTH8_1745422232 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 3F9D414001B X-Stat-Signature: 1pr9qbiapwp9umjto4gpx7n8e7wjbbzc X-Rspam-User: X-HE-Tag: 1745422235-871484 X-HE-Meta: U2FsdGVkX1/e9qzRzoWAdPoyW1seumyak1nEFcA7Aj6o5npJKHQHzBTkxzKjP2oSv+8Lk0QykUW9laal5qpCJ7pFMKOuBN2q99Xwj6P6J4PFC2bEjdoafYjo9Jq/YCOQFoxV2vdeEKH8JHvUDRn+JnyRDSFDRbHrj/PoUQNqHMUvVMC8vuItl8Im7eHX5f6UEsdUzIzcAA4xj5zGe1c92b7fRvmpTM8zX/4of/+qm7UKQSdOdDZUWOiJqZ5DWfaJttz06vERwUi4C/5D73rzpd8p0/XQS4mR/0dcNNuIh2XO7UZ/dFcW8JboOAUaA8AbvBadRPBaNt9jq9noiAAi8ebIpwD/eGGtfKEGC6xE2qQU6bWikjT3GlA2k3rDqVNGgQ+oVja+yqAPO703mWOnUDHeB8WFWFG3pwkd3+f0G6ETOOkuqR85XwS5R21nUBkaimDADbEsQOvSjhckHRuWEgEIfvwU1DKSNunHt70wOQuYJiLn5a6Z9YbGAdfvq9TYNZPsq+9Xk8t8pE1mLDBGTKANiUZZvQkmfKydjFfRRpocNTI+UMhlOK70ocHXoTFLRIENSLidq/mLS6pfrH1/tLSk44CZH+xjHMmsAY8ZVERS8NqG6+xYpHkSlnY3lGwPpFT0kfUSQsvVrsyQ/KfmDKGiOgF7u9l+Z+fNRKLAYmmyp2lIpR2R7s25GYeofLxfMyMOeM1ocfRA4KSfQz7Rg1ZCqBDZuu2HXU/IvRRUvjPHIHxAQbP2xfuQYq0fNnU4a/E09aXr9Tk8hcA75flFRceBZ38c+z8A/AL/6bqIdmPIWAfx1VSUrlpHMdwM85pnDg7XRIlzGBUMzJ5zNmhwEWXExrQFyQWLd2lax6WU9/Ue8SYovLyRBajafzMu2EoDhY4LociPOHtdfYteKT/Q9vogwdkBH4cpDg2TUS3rzj9nTsv46ryx5WAA5sRYC44K0CFhptu7FIckwJk9lcX VBOCErNB J4q04dcSzmlYf6dQsXmC1CkEYnciIpdOS2Emcro2mdT7lTCUzjGWg6AVoJdPaFrIvWNVl03QP3hYB1UAqtP1sIbPQmLXYGJPvXzyYTfFYna3yHNJj53HqbjvS6wKbYprhsIFw54TtIc63ulbFl47GImaJG69Wbzz4ar07p/JlyT8cdHsDVzHwY4eVk0HZ54D9HXV+ntjucY+KipERPtuSkksR1S1cObOyrCrIBknHLWLVkYT1we9tX2ap9Vdjn01tcE4Pq1LlHFoDEKFoxKX3hBMwxDybSKoza78U7jc1JTv+RY42Mgs+sxnsNCFOs+8mobpB9d7nP8LJsGX4rGNzAMHzKZAZYmg3ZKMOBf0OarHNFbgn7C0Yqvz595pBeoBzllsm330yuHTh7nQl/ac+kd6a65DUmf2mFcriXxShYK+RAAcVG5IvJNVaLgKFCref56xJM4ufW8zTT3o= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 23.04.25 16:42, Lorenzo Stoakes wrote: > On Tue, Apr 22, 2025 at 04:54:54PM +0200, David Hildenbrand wrote: >> On 22.04.25 16:49, David Hildenbrand wrote: >>> Not intuitive, but vm_area_dup() located in kernel/fork.c is not only >>> used for duplicating VMAs during fork(), but also for duplicating VMAs >>> when splitting VMAs or when mremap()'ing them. >>> >>> VM_PFNMAP mappings can at least get ordinarily mremap()'ed (no change in >>> size) and apparently also shrunk during mremap(), which implies >>> duplicating the VMA in __split_vma() first. >>> >>> In case of ordinary mremap() (no change in size), we first duplicate the >>> VMA in copy_vma_and_data()->copy_vma() to then call untrack_pfn_clear() on >>> the old VMA: we effectively move the VM_PAT reservation. So the >>> untrack_pfn_clear() call on the new VMA duplicating is wrong in that >>> context. >>> >>> Splitting of VMAs seems problematic, because we don't duplicate/adjust the >>> reservation when splitting the VMA. Instead, in memtype_erase() -- called >>> during zapping/munmap -- we shrink a reservation in case only the end >>> address matches: Assume we split a VMA into A and B, both would share a >>> reservation until B is unmapped. >>> >>> So when unmapping B, the reservation would be updated to cover only A. When >>> unmapping A, we would properly remove the now-shrunk reservation. That >>> scenario describes the mremap() shrinking (old_size > new_size), where >>> we split + unmap B, and the untrack_pfn_clear() on the new VMA when >>> is wrong. >>> >>> What if we manage to split a VM_PFNMAP VMA into A and B and unmap A >>> first? It would be broken because we would never free the reservation. >>> Likely, there are ways to trigger such a VMA split outside of mremap(). >> >> As expected ... with a simple reproducer that uses mprotect() to split such >> a VMA I can trigger >> >> x86/PAT: pat_mremap:26448 freeing invalid memtype [mem >> 0x00000000-0x00000fff] > > Wow. > > Might be worth adding a self test for this if not too difficult, even if as > a skipped one w/comment just so we have it ready to go? Yeah, I think it's as stupid as mmaping two pages worth of /dev/mem, and then munmapping only a single one. It's so easy to trigger that it makes me absolutely angry. -- Cheers, David / dhildenb