From: David Hildenbrand <david@redhat.com>
To: JaeJoon Jung <rgbi3307@gmail.com>, Harry Yoo <harry.yoo@oracle.com>
Cc: cl@linux.com, penberg@kernel.org, rientjes@google.com,
iamjoonsoo.kim@lge.com, akpm@linux-foundation.org,
vbabka@suse.cz, roman.gushchin@linux.dev, 42.hyeyoo@gmail.com,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
rgbi3307@naver.com
Subject: Re: [PATCH] mm/slub: Removing unnecessary variable accesses in the get_freelist()
Date: Wed, 10 Sep 2025 11:06:22 +0200 [thread overview]
Message-ID: <1d5aa773-89ac-452d-999e-6a0c8ebce994@redhat.com> (raw)
In-Reply-To: <CAHOvCC695c3fBphYvVz0Gk3H2hR9O2GaQLPvOVSZbUyv5C5rwg@mail.gmail.com>
On 10.09.25 04:31, JaeJoon Jung wrote:
> Hi, Harry Hyeonggon Yoo,
>
> Thank you for your kind and detailed reply.
>
> I hadn't thought of the union data type.
>
> Since the counters, inuse, and frozen members are unioned within the
> slab structure,
> there is the problem that the above values are not applied to
> __slab_update_freelist() and try_cmpxchg_freelist() if the existing
> code is not followed.
>
> I canceled my patch request.
> I apologized for my inconvenience.
For the future, please
(1) Don't clean up code you don't fully understand
(2) Test your patches before submission
--
Cheers
David / dhildenb
next prev parent reply other threads:[~2025-09-10 9:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-10 0:59 JaeJoon Jung
2025-09-10 1:39 ` Harry Yoo
2025-09-10 2:31 ` JaeJoon Jung
2025-09-10 9:06 ` David Hildenbrand [this message]
2025-09-10 8:39 ` [syzbot ci] " syzbot ci
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1d5aa773-89ac-452d-999e-6a0c8ebce994@redhat.com \
--to=david@redhat.com \
--cc=42.hyeyoo@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=cl@linux.com \
--cc=harry.yoo@oracle.com \
--cc=iamjoonsoo.kim@lge.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=penberg@kernel.org \
--cc=rgbi3307@gmail.com \
--cc=rgbi3307@naver.com \
--cc=rientjes@google.com \
--cc=roman.gushchin@linux.dev \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox