From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 39F8CC83F17 for ; Mon, 14 Jul 2025 07:54:44 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CBE266B007B; Mon, 14 Jul 2025 03:54:43 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C6F746B0089; Mon, 14 Jul 2025 03:54:43 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B852C6B008A; Mon, 14 Jul 2025 03:54:43 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id AACD76B007B for ; Mon, 14 Jul 2025 03:54:43 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 343D210EF8E for ; Mon, 14 Jul 2025 07:54:43 +0000 (UTC) X-FDA: 83662108446.17.0A9510C Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf18.hostedemail.com (Postfix) with ESMTP id 798B81C0007 for ; Mon, 14 Jul 2025 07:54:41 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf18.hostedemail.com: domain of ryan.roberts@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=ryan.roberts@arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1752479681; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=aKjmHJ7v9eTFd/NqbyrOyMDTyxu0tclKgd/YVfA57Gg=; b=yT8axgweRP3iItE5ovhtIcaJst9TFxUIaQHjZdGX+61T/Oqmlx010yuKxaZwmQGs2kmHvT AgGTim/J/Cl+9s/Cdt/WVbmLd/o1vz99V8/d8WAjuqjaHr/vJGwAyJw/1W03OWCKUeFYSB in66OXCxRo4Hw5xDVyHcuU0pzVikeZo= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1752479681; a=rsa-sha256; cv=none; b=Glz1vnZDDAMc83Op/h/JL0nDNr7O10/F1j9/94FQx9f5LyTcuvrRGX5DRNFrFMfHKcaNua MuCby2NJK6ZADAcqI5mmLojzzFlzetKURtPGJxJlRLVKmywTbSqZ9CYqaAttnNCIE2kUEh Qu1OnS6oDUpI5iH/5o5au2MmnRSbXNE= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf18.hostedemail.com: domain of ryan.roberts@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=ryan.roberts@arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 2772A1D70; Mon, 14 Jul 2025 00:54:31 -0700 (PDT) Received: from [10.57.83.2] (unknown [10.57.83.2]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 60B533F6A8; Mon, 14 Jul 2025 00:54:38 -0700 (PDT) Message-ID: <1d515808-6589-4aa1-a363-f16bb6209b36@arm.com> Date: Mon, 14 Jul 2025 08:54:36 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] readahead: Use folio_nr_pages() instead of shift operation Content-Language: en-GB To: Andrew Morton , Chi Zhiling Cc: David Hildenbrand , willy@infradead.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Chi Zhiling References: <20250710060451.3535957-1-chizhiling@163.com> <479b493c-92c4-424a-a5c0-1c29a4325d15@redhat.com> <661ccfa4-a5ad-4370-a7f5-e17968d8a46e@163.com> <20250712152544.07f236ec277290c70a2a862f@linux-foundation.org> From: Ryan Roberts In-Reply-To: <20250712152544.07f236ec277290c70a2a862f@linux-foundation.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Stat-Signature: 4syiejkudujenuoorss54kxdx8zprnm5 X-Rspamd-Queue-Id: 798B81C0007 X-Rspamd-Server: rspam10 X-Rspam-User: X-HE-Tag: 1752479681-5109 X-HE-Meta: U2FsdGVkX1+QEhS4gUqRV7+3M9nmhL4C3E3y3htNIczXY8F6z/nggJ8l9v4lDC61h/Ot0K7qrr+sV2REikB45VpnDOoYvKa7sfcSwbbdJIhnO+lShWTXDTyrO0ghdPv4YXrMq0OvKNWGZq3lrXZ29giCGMqK0xJd0KRqxhw16dRWtMqGch7ZZCXAQAvthIhsIg622vN5Cpx/+6PYjH2UhKvVvnBIEiriM7pyVOmJsyMaYvTABgbZd08+3Og1f1LOnzSdokwFTi5s8Hi/LGxo/sEq88WYsnJyQveqxSyDvOh0OhuV3NqbhMC5i4kPcGD7/pJeWPK9r/8ky7j5zbxAJJqxgFBHb2ut4nJJFrT08ZDTSb70xq90Ur/X/boFq383VqI6K1du209HyWt+V0Kn0CvvqoutwrEZEY3KHjb5psufzjJQOANEZ+12NNzGMzrEGWyimJGOrvOILtHugo3/Ld5yIhfvUM3fYSliQWBBU5Ej4li5a49PBXzjyDeYzYl4Uz02cX+vyPm1rfbtKtP1nhLdyVVunOo7NhjmCsla3vS2zx/34u/yMFM46H3waF5Irvy66I25psUamc1dFQR9uVZkNfuJRw75uzz4Z6IAgzj1tUrBGH9hpaRZhC8tFIxEoUSsTE3AhmUKBF09zKQPPPWO3lul7XqEKUa9Hji3agLvLcvgYUCpwHJcHSxv4OGZDgAeN00BnbgYutSyVW8r5E+juwacQj8v1MBBvlNkAK/0gO+Dh4Km4mRuLaR9rS237W/sYHjLGg/w7DJLHWaezgFbc4H0Dl3JnIQ0kKqiUNCozglJpnejKWaQ1FGslSLOhNSS9gIYcQCxR99BQJveSG5GIPuYbfeg/cj6Onb0ZEBs0K6zIvKyjL8Mw/JNyME7iuWQiLbZHKLjWpRAhcG4LBWydZomVqN44X7GnWJJg4Pcau77w8oW3+XQmCogH7BX4AuXXM2XZDQkxwGEXyh 3D6zqFWS I9rMeY5Re1S8smVbCjr32ZPilflXCeb7enEwo0VkTLpru2cd664xvAAp8mlNOa5HnGBq7nm0PXSyrSKX3isAXXVJxf3cCnq0NpkCIkCCyHbRSLJNfjCq3KzH/7Fa2sOYy506h2zOTOCP3QUPfk8aApH2me9NwQYLPlUOyI3bL8ng+MckpS3nHev3JfcUt/Ggdkh6SwxLhkl7nfFXq9JOETxR9dq9SCbYmtLSHSlsVpwVKJhBoeS4bNXwnF67uRyAaNXoFMazfhaBCYtSqR1lCK+WZKMjiUh1Lluh98qEZJ97XEVwtHpx7+visNbZR0B48lHfk4RpI1xd+H4ePhGEwZk7gf3kQGFwhEsd7lTF3Wc6uGuUkFa8zQ9hCvHZjwQyIjw2e X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 12/07/2025 23:25, Andrew Morton wrote: > On Sat, 12 Jul 2025 10:23:32 +0800 Chi Zhiling wrote: > >> On 2025/7/12 00:15, David Hildenbrand wrote: >>> On 10.07.25 08:04, Chi Zhiling wrote: >>>> From: Chi Zhiling >>>> >>>> folio_nr_pages() is faster helper function to get the number of pages >>>> when NR_PAGES_IN_LARGE_FOLIO is enabled. >>>> >>>> Signed-off-by: Chi Zhiling >>>> --- >>>>   mm/readahead.c | 2 +- >>>>   1 file changed, 1 insertion(+), 1 deletion(-) >>>> >>>> diff --git a/mm/readahead.c b/mm/readahead.c >>>> index 95a24f12d1e7..406756d34309 100644 >>>> --- a/mm/readahead.c >>>> +++ b/mm/readahead.c >>>> @@ -649,7 +649,7 @@ void page_cache_async_ra(struct readahead_control >>>> *ractl, >>>>        * Ramp up sizes, and push forward the readahead window. >>>>        */ >>>>       expected = round_down(ra->start + ra->size - ra->async_size, >>>> -            1UL << folio_order(folio)); >>>> +            folio_nr_pages(folio)); >>>>       if (index == expected) { >>>>           ra->start += ra->size; >>>>           /* >>> >>> This should probably get squashed in Ryans commit? >> >> I have no objection, it's up to Ryan. > > "Ryans commit" is now c4602f9fa77f ("mm/readahead: store folio order in > struct file_ra_state") in mm-stable. I'd prefer not to rebase for this! > Sorry about that... the function was previously using foilio_order() and storing in a local variable and using it in 2 places, one of which was "1UL << order". Because the other user went away I just moved the folio_order() call inline. But agree folio_nr_pages() is better. FWIW: Reviewed-by: Ryan Roberts