From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 75202C25B79 for ; Thu, 16 May 2024 10:03:54 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CB97F6B007B; Thu, 16 May 2024 06:03:53 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C68F36B0167; Thu, 16 May 2024 06:03:53 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B06106B010E; Thu, 16 May 2024 06:03:53 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 91F696B007B for ; Thu, 16 May 2024 06:03:53 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id F4205121763 for ; Thu, 16 May 2024 10:03:52 +0000 (UTC) X-FDA: 82123822746.03.9232209 Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by imf24.hostedemail.com (Postfix) with ESMTP id CFBAB180009 for ; Thu, 16 May 2024 10:03:49 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=none; spf=pass (imf24.hostedemail.com: domain of wangkefeng.wang@huawei.com designates 45.249.212.188 as permitted sender) smtp.mailfrom=wangkefeng.wang@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1715853831; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=SGMlQ9I64gRb3HWf8TIlxY5qbBicwsmmZ+XwUs+7784=; b=NhjYWeQ04R+A2RODUZeJ5T2foMCU7frSoRISrJWE8iY/0czgI9lyS+eAvzJhfiJ5MpuHJs o3dNMM7OMzEpiaEhJibLg+lz3gm9qQABSZvlHXTkvSJ9LGd/KMylAfCvXCihVoxdl2/CKJ 94jNPTt99bbDSwsFW+dFGeHoL7vm+5U= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1715853831; a=rsa-sha256; cv=none; b=oPY/eUR+o31vFu4fl+gSvtEw39rSSSfLFpeRCopAabt3UJCJzFkxqT7sCm0OEhv3ZaVZLj jUvKQiI3URtxBQON6NIf1zsoI0Antny7OvbVQ72vwsKne1pcNEwL1eKn7hGyVBM2BtVD7R 8LxvsBdTbPw1445+aLeZ75DXJu5Xpts= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=none; spf=pass (imf24.hostedemail.com: domain of wangkefeng.wang@huawei.com designates 45.249.212.188 as permitted sender) smtp.mailfrom=wangkefeng.wang@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com Received: from mail.maildlp.com (unknown [172.19.88.194]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4Vg5HV2Y4gzcf7D; Thu, 16 May 2024 18:02:30 +0800 (CST) Received: from dggpemm100001.china.huawei.com (unknown [7.185.36.93]) by mail.maildlp.com (Postfix) with ESMTPS id 2747B14038F; Thu, 16 May 2024 18:03:45 +0800 (CST) Received: from [10.174.177.243] (10.174.177.243) by dggpemm100001.china.huawei.com (7.185.36.93) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Thu, 16 May 2024 18:03:44 +0800 Message-ID: <1d38aa26-cd2f-4330-9dcc-6c379cecb83b@huawei.com> Date: Thu, 16 May 2024 18:03:44 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm/cma: get nid from physical address Content-Language: en-US To: Yajun Deng , CC: , References: <20240516091701.1527002-1-yajun.deng@linux.dev> From: Kefeng Wang In-Reply-To: <20240516091701.1527002-1-yajun.deng@linux.dev> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.177.243] X-ClientProxiedBy: dggems702-chm.china.huawei.com (10.3.19.179) To dggpemm100001.china.huawei.com (7.185.36.93) X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: CFBAB180009 X-Rspam-User: X-Stat-Signature: jswti5mqhnk7cm4myzgeqtecwogbhxre X-HE-Tag: 1715853829-488336 X-HE-Meta: U2FsdGVkX191gmsdhgHk2PqUjUJu1wbet5nWMqhbcMSGdYTWQtLaR3tLSWJb/M7IPZLzzvCZc75sfSLLm9GGidwJmF8aUdFkQFCO7ahQer4EyDZZjjXx7bwJMawgDxoe1w35NbTLM7CYpHqAPbfX/Fd3nPz3dzUp4/yMVFbn4gMqCXFFR7HJX38LyKq5GjqYMw+Ml1NzgJIYqS6sOgsKSv2KZ3ORCiRMNus+dqdqCNDAs0ayR+/oElmONezxP1s6m3+n4LgZdbfaJg09ETf+9uM2dwp2LntPlui6kZGAaO+e+RSWa1CrE5AY/m+q92f/mhWxHpwFDw5z/79SAlOkjtIS/WHycxBoOUTt1MT3l6P7ExP001hoQld34bM2A9del5PAHlyCTYy4wdKBVzcEgkpFysyEcD1yqCbwJXunupyuAZr/Zqa/Tg0OzdWdlGXTEqF2ZYm7mh46lThaA2rLZTyUqsiWBQabDGIiwGnFOSEqwjxgZCNgRsmAbcR6X/j762kWLqKi/EgHXDFd3zEPxXHI04mD7rnzBEpvUgEvIed/uTVlzSxVpkJei7yoCq6YV2OudeicFhpJRaC1bv0FCjJVT2lJXekzXXvdn8ZSj8K2bCOvWIZ1y678SQkVQy5dZNqL/qpg7BimRUVqmT8W55VZ718JNucR5L1lzgpdMA2U8gEupI+dpOtlDR4QPEgqR0TRw/NqeLj2NXAYKbVjpCf/Herx9DFuXNhSehMuv4Le37gXLHZNJVqZBlmWuMJALH2iBA7H/HV1cXcvV6gOKoERCkccldorP1Zk7uJpaoi7zdg5K6wivXg5ISh+6GqJAIaNV5L+Fz3i50ps53ZpIV3rHoLn4boz5KAhYf1jGC0JbnNcBVXJbliV4JmRBsysAGIcZGEYCRTLwEvwTeS5MDeQuebOXjbORn1Irt2rznBvH0HT695tjba5K5nl/Ce0asxjlxH+N0B8oTt4DZR 4HIMiQU9 2dxY0soMvddJ0a74cyCwaFrl4jhG3QTFlXfmb4Cl+i6fgLVVlyZUBCNeCBRldzu1qQHJDdUqV2zJtdyiKgNolnFQfAA4/jf1KRPuRqJ6WAfhfF8HVTRkhmj8yuHJZBNtx3eAvvnby5ZjFWtELUkHr6k4Q4ASf/yZfYc6vqMWu6bSF3uIk2qQFU6nfw7zMVKoxERGZI8m8XEnLRfcsBYTFyPcCrWrgmV6GEZi4VU8V5CJzbS8XfyOBoNZGSUHsIiZJ9Fmg X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2024/5/16 17:17, Yajun Deng wrote: > The nid passed to cma_declare_contiguous_nid() may be NUMA_NO_NODE, > which is not the actual nid. To get the correct nid, we can get the nid > from physical address. > Please check https://lore.kernel.org/linux-riscv/47437c2b-5946-41c6-ad1b-cc03329eb230@huawei.com/ > Signed-off-by: Yajun Deng > --- > mm/cma.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/mm/cma.c b/mm/cma.c > index 3e9724716bad..be6cdde32944 100644 > --- a/mm/cma.c > +++ b/mm/cma.c > @@ -361,6 +361,7 @@ int __init cma_declare_contiguous_nid(phys_addr_t base, > kmemleak_ignore_phys(addr); > base = addr; > } > + nid = early_pfn_to_nid(PHYS_PFN(base)); > > ret = cma_init_reserved_mem(base, size, order_per_bit, name, res_cma); > if (ret)