From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 502D7EE49A6 for ; Mon, 21 Aug 2023 16:14:41 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id ADB1B8E0009; Mon, 21 Aug 2023 12:14:40 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A8B068E0002; Mon, 21 Aug 2023 12:14:40 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 953728E0009; Mon, 21 Aug 2023 12:14:40 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 83CF98E0002 for ; Mon, 21 Aug 2023 12:14:40 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 56E1F160257 for ; Mon, 21 Aug 2023 16:14:40 +0000 (UTC) X-FDA: 81148609920.07.E72DB82 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf14.hostedemail.com (Postfix) with ESMTP id 08454100021 for ; Mon, 21 Aug 2023 16:14:37 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Ml4pT7Bj; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf14.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1692634478; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=brmRX5IGieUMsxpE0HbAhY3LLaoFvqTaceanDysgv20=; b=G6yIxSOrTvg7DFTYN3hmjikZ2XYAhrgQ/zIgIaE0oqLjIwhotGwzY092vyB4f+sa3DMNcU PI9ROpG/Ira2oHe7IAWyQmXxHOFTjbYKz6CNTo433WXRTCS4R4jl2pjb6O73J3vlTymxYM sNoC5B+6NnxPIn/sxCOFbEyHQJw21Jc= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Ml4pT7Bj; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf14.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1692634478; a=rsa-sha256; cv=none; b=CuE4wJpj9ZRWlUMi0bGmTmOhfv92Xojlvy2zUkn6tONLztJlL5Z4rHYLeBKzkDC+qC+3+S QT52DHayVkLbMVnuX00D2X8LoluI/7Mrmh/fbrAxBMf31B3jivgLkOk7QXYeoyCBbt8064 3eP6hQoWDsk3nU93Ziry3mkg2JvajIE= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1692634477; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=brmRX5IGieUMsxpE0HbAhY3LLaoFvqTaceanDysgv20=; b=Ml4pT7Bjz0XTJNh4uMg6y9SW9YJISfHJd5B56sOcU1zYIzzKQbNPPQsPuDGUeWuca62yHY wPEsCoagHPjOIr5RyNkyY5iQgAnF6TVCGloeE3oznHYkKbjyq/tV4pJcewySRpVvsU06cj ORlUXnxPa6T5pvlWNwc9lOJ3XaHKNU8= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-543-wbUmX4BQMZOed3cNadnLrQ-1; Mon, 21 Aug 2023 12:14:35 -0400 X-MC-Unique: wbUmX4BQMZOed3cNadnLrQ-1 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-3fef698fb3cso1004455e9.1 for ; Mon, 21 Aug 2023 09:14:34 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692634474; x=1693239274; h=content-transfer-encoding:in-reply-to:subject:organization:from :references:cc:to:content-language:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=brmRX5IGieUMsxpE0HbAhY3LLaoFvqTaceanDysgv20=; b=ld2LUIiQC5liKX+Gh3blo2bJYELoozS+aOB8VBBW5CXVAGRDXjmOW51QyCZSjl9mWD QWgtsMm7wB6KION5Dg8zvHKjdJUK+3atMutXtIYKZy6qnXrhVqsm+ez/cP0x120wkZ0o we+GokPtaF53xcbN30uQDPt41kLHkfUXAPEb178nO4QGrExcOPGzW8sPKByrRX0ABhJD ySCrvFBhWdI/senaKe5cqavl4lE5ErYMoV6P2YRK6WwHB54EOj/CTKtfyBQYaoHMYVcj 7GsAxssT5AJyYCIk2nTgbYwrpCYt5+Nwzd6eG4ZEhGmXE+YfCmTc91obiHFurjbGb8yp Dv6Q== X-Gm-Message-State: AOJu0YzR8UhB1VovmHfJJutjxY9LwGFqgAQz75StGAKPjXErV7hTCSjc a775LPCaDWHiwlkM+Wkb8Cj4/r2/hmOdFJmGLFlpHpG8O2SJWMk6Rxn53i4BJySYj06YzZGM3eA AfX7CZcEX3NU= X-Received: by 2002:a05:600c:8516:b0:3fe:b7e4:276a with SMTP id gw22-20020a05600c851600b003feb7e4276amr5461125wmb.15.1692634473920; Mon, 21 Aug 2023 09:14:33 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEceuELjMcsavF6Om+ZUBbGSvIl1FAaaUPPOtU8lfHJgqOuLhFsvwqWx5YwgrB1cWeN6D0u6g== X-Received: by 2002:a05:600c:8516:b0:3fe:b7e4:276a with SMTP id gw22-20020a05600c851600b003feb7e4276amr5461110wmb.15.1692634473578; Mon, 21 Aug 2023 09:14:33 -0700 (PDT) Received: from ?IPV6:2003:cb:c715:5e00:f3e5:9995:b58b:3782? (p200300cbc7155e00f3e59995b58b3782.dip0.t-ipconnect.de. [2003:cb:c715:5e00:f3e5:9995:b58b:3782]) by smtp.gmail.com with ESMTPSA id f19-20020a7bcc13000000b003fe24441e23sm13184616wmh.24.2023.08.21.09.14.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 21 Aug 2023 09:14:33 -0700 (PDT) Message-ID: <1d2e0cae-25a2-3f7b-764d-d34160271414@redhat.com> Date: Mon, 21 Aug 2023 18:14:32 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 To: Matthew Wilcox Cc: Andrew Morton , linux-mm@kvack.org, Mike Rapoport References: <20230821141728.2536317-1-willy@infradead.org> <96895823-ce2a-5dc7-77a1-a28d1242bc6d@redhat.com> From: David Hildenbrand Organization: Red Hat Subject: Re: [PATCH] secretmem: Conert page_is_secretmem() to folio_is_secretmem() In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 08454100021 X-Stat-Signature: d1suo3u151c3ybg1gp5iqdyp3bz9chgs X-HE-Tag: 1692634477-492171 X-HE-Meta: U2FsdGVkX1/oo0CGi6+wKvYy9Z6PlyijvNShYvPUCFk1DzZe1co8bHUopi4rmmVyN/9VgmH+5vsFL2NuIjKWfjtpyX1vpcwCDUY/xxq2wqIlnlzNPMQe2N2trjaLnZQ7xqYgM0PJQw9FLw6tBsK94OOh2HWUkYTqk2kdUHPUKm1rYepGA4JteYVOxWjNBJ1onS7YqmyC0QFVUWrSpNkqDQK0McpCj5YTS+QYdbOBKBmYnPi5fjYqLQJegWK/wgwXPIbggPA/K/ktPXRpvI6frqaRJtTHq3spCg1kBwt4VbgptxPhkKIcVkwjFnu2+Jys+QqOp8ZQzmCQqj42lxCd7jhoPWGDiU7+3bIowDR4aPPZtcsxQtRWqaXjqnROyIxYjVqE/93Ju4G2JYOaE/91y7e1p5QmGRKOkzlMmmbt0pQK1kUphQaMt3dbfD36x7rMMTc5MXDpPyfwq8hYa3B+lOjKbLB0t6TPAUUUcACJiERPOk8MpzRPK2D6FZX4l0UwirStsvRAaN4EDd3p3tu+C9OfYieqBCRItVZwYmpswbycxgorZUTurlTU0Lhk3pSxvwjclTfpCR6rSkoapIUgU+q4zEYUe/XTqcnjs5c7VU5+34p/6TjD0UZtbrN31Dqyq9vvHv8OBPMRTkWyGfwsV+FAydx2pt1YD0rLnBHu9zV5UcL+4rxXeDRkLep/BpsbMzyHAm9M5LGp0KoY3pP6Jd+1KxaYKRRYYWShCFZ72S3hGmc53moMWnX8F9RItOYvsRDzKkyVlUhi//Bqo2bhgfGC+uJVo/RHQMYmVI7C2PvAsPh+3Q9GMGwKeS1csUy2Es+q169uAJYj/BgdklBkL7yJ1Qt1oqObYd7o171LdGib0u0c2FIDzXo1cUMK92YHGbhYUUezOWS329P21+Es1JE48ZvyiuGhG89iEA+Y+CEWe+40asoKhbzqW8RLVLr/qcjLJWbf/EblWjV6SGe mBM8vMeD OPMS3klUGuAgfSzJFXvShXWQObeMZwkgy+SL74SeHy2wzhukuBIqcx2PewhjDq4N320HI5AgJxP8DORkIL/ZBW55s3rD1I2QXk1oIeaO/MJfdyIuS+mVwV+p/aPlL+ESb6FwbihPPA1ALi9pS9lSYrCIcJPNl2iZoXv8qtYjGOsnXaaM2QthYDgoXlvXEgo9oAInEFXVI1W2ZLlAL7PxcWnM7gHkNZaMA0YrxigbDYqJHF4NSYO9EZgtdN1/HMUzD8my0lOdsFKyYo7ETuUbhscvbfv8Sx8frhbm5DqpOG5VdbmJ9Hiqd0BTPSwtrtCE1nS3J7ODgaT4akg8= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 21.08.23 17:53, Matthew Wilcox wrote: > On Mon, Aug 21, 2023 at 05:32:50PM +0200, David Hildenbrand wrote: >>> - if (PageCompound(page) || !PageLRU(page)) >>> + if (folio_test_large(folio) || folio_test_lru(folio)) >>> return false; >> >> You converted a "!PageLRU(page)" into a "folio_test_lru(folio)". >> >> Shouldn't that be a "!folio_test_lru(folio)" ? > > Well, that's embarrassing. Obviously I don't have any secretmem > hardware, so my smoke-test didn't catch it. Thanks, will do a v2. > We do have a selftest: tools/testing/selftests/mm/memfd_secret.c I doubt it would have caught it, because ptrace doesn't use GUP-fast IIRC, so we always fail early in GUP code when doing the vma_is_secretmem() check. We'd explicitly have to call something that triggers GUP-fast (get_user_pages_fast/pin_user_pages_fast). -- Cheers, David / dhildenb