From: Dan Carpenter <dan.carpenter@linaro.org>
To: oe-kbuild@lists.linux.dev, Honggyu Kim <honggyu.kim@sk.com>
Cc: lkp@intel.com, oe-kbuild-all@lists.linux.dev,
Linux Memory Management List <linux-mm@kvack.org>,
Andrew Morton <akpm@linux-foundation.org>,
Hyeongtak Ji <hyeongtak.ji@sk.com>, SeongJae Park <sj@kernel.org>
Subject: [linux-next:master 6602/7397] mm/damon/paddr.c:360 __damon_pa_migrate_folio_list() error: uninitialized symbol 'nr_succeeded'.
Date: Mon, 1 Jul 2024 17:41:50 +0200 [thread overview]
Message-ID: <1d0db7b1-74eb-4582-be17-e7dbce3e36bb@suswa.mountain> (raw)
tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head: 62c97045b8f720c2eac807a5f38e26c9ed512371
commit: 5311c0a2eee34fd8f4e17382a5f653b95a940ca5 [6602/7397] mm/damon/paddr: introduce DAMOS_MIGRATE_COLD action for demotion
config: um-randconfig-r071-20240623 (https://download.01.org/0day-ci/archive/20240625/202406251102.GE07hqfQ-lkp@intel.com/config)
compiler: clang version 19.0.0git (https://github.com/llvm/llvm-project ad79a14c9e5ec4a369eed4adf567c22cc029863f)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
| Closes: https://lore.kernel.org/r/202406251102.GE07hqfQ-lkp@intel.com/
smatch warnings:
mm/damon/paddr.c:360 __damon_pa_migrate_folio_list() error: uninitialized symbol 'nr_succeeded'.
vim +/nr_succeeded +360 mm/damon/paddr.c
5311c0a2eee34f Honggyu Kim 2024-06-14 331 static unsigned int __damon_pa_migrate_folio_list(
5311c0a2eee34f Honggyu Kim 2024-06-14 332 struct list_head *migrate_folios, struct pglist_data *pgdat,
5311c0a2eee34f Honggyu Kim 2024-06-14 333 int target_nid)
5311c0a2eee34f Honggyu Kim 2024-06-14 334 {
5311c0a2eee34f Honggyu Kim 2024-06-14 335 unsigned int nr_succeeded;
5311c0a2eee34f Honggyu Kim 2024-06-14 336 nodemask_t allowed_mask = NODE_MASK_NONE;
5311c0a2eee34f Honggyu Kim 2024-06-14 337 struct migration_target_control mtc = {
5311c0a2eee34f Honggyu Kim 2024-06-14 338 /*
5311c0a2eee34f Honggyu Kim 2024-06-14 339 * Allocate from 'node', or fail quickly and quietly.
5311c0a2eee34f Honggyu Kim 2024-06-14 340 * When this happens, 'page' will likely just be discarded
5311c0a2eee34f Honggyu Kim 2024-06-14 341 * instead of migrated.
5311c0a2eee34f Honggyu Kim 2024-06-14 342 */
5311c0a2eee34f Honggyu Kim 2024-06-14 343 .gfp_mask = (GFP_HIGHUSER_MOVABLE & ~__GFP_RECLAIM) |
5311c0a2eee34f Honggyu Kim 2024-06-14 344 __GFP_NOWARN | __GFP_NOMEMALLOC | GFP_NOWAIT,
5311c0a2eee34f Honggyu Kim 2024-06-14 345 .nid = target_nid,
5311c0a2eee34f Honggyu Kim 2024-06-14 346 .nmask = &allowed_mask
5311c0a2eee34f Honggyu Kim 2024-06-14 347 };
5311c0a2eee34f Honggyu Kim 2024-06-14 348
5311c0a2eee34f Honggyu Kim 2024-06-14 349 if (pgdat->node_id == target_nid || target_nid == NUMA_NO_NODE)
5311c0a2eee34f Honggyu Kim 2024-06-14 350 return 0;
5311c0a2eee34f Honggyu Kim 2024-06-14 351
5311c0a2eee34f Honggyu Kim 2024-06-14 352 if (list_empty(migrate_folios))
5311c0a2eee34f Honggyu Kim 2024-06-14 353 return 0;
5311c0a2eee34f Honggyu Kim 2024-06-14 354
5311c0a2eee34f Honggyu Kim 2024-06-14 355 /* Migration ignores all cpuset and mempolicy settings */
5311c0a2eee34f Honggyu Kim 2024-06-14 356 migrate_pages(migrate_folios, alloc_migrate_folio, NULL,
5311c0a2eee34f Honggyu Kim 2024-06-14 357 (unsigned long)&mtc, MIGRATE_ASYNC, MR_DAMON,
5311c0a2eee34f Honggyu Kim 2024-06-14 358 &nr_succeeded);
5311c0a2eee34f Honggyu Kim 2024-06-14 359
5311c0a2eee34f Honggyu Kim 2024-06-14 @360 return nr_succeeded;
This can be compiled with CONFIG_MIGRATION disabled so migrate_pages()
is a no-op that returns -ENOSYS.
5311c0a2eee34f Honggyu Kim 2024-06-14 361 }
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
next reply other threads:[~2024-07-01 15:41 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-01 15:41 Dan Carpenter [this message]
2024-07-01 16:56 ` SeongJae Park
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1d0db7b1-74eb-4582-be17-e7dbce3e36bb@suswa.mountain \
--to=dan.carpenter@linaro.org \
--cc=akpm@linux-foundation.org \
--cc=honggyu.kim@sk.com \
--cc=hyeongtak.ji@sk.com \
--cc=linux-mm@kvack.org \
--cc=lkp@intel.com \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=oe-kbuild@lists.linux.dev \
--cc=sj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox