From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E2576E77188 for ; Fri, 3 Jan 2025 03:56:50 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6A70F6B0088; Thu, 2 Jan 2025 22:56:50 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 656A36B0089; Thu, 2 Jan 2025 22:56:50 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4F7696B008A; Thu, 2 Jan 2025 22:56:50 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 301546B0088 for ; Thu, 2 Jan 2025 22:56:50 -0500 (EST) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id D3FEC1203C7 for ; Fri, 3 Jan 2025 03:56:49 +0000 (UTC) X-FDA: 82964777826.24.0E86052 Received: from mail-pl1-f179.google.com (mail-pl1-f179.google.com [209.85.214.179]) by imf11.hostedemail.com (Postfix) with ESMTP id CB73840005 for ; Fri, 3 Jan 2025 03:56:00 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b=IYbZOdAu; dmarc=pass (policy=quarantine) header.from=bytedance.com; spf=pass (imf11.hostedemail.com: domain of zhengqi.arch@bytedance.com designates 209.85.214.179 as permitted sender) smtp.mailfrom=zhengqi.arch@bytedance.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1735876560; a=rsa-sha256; cv=none; b=obJth7N7nFWfEA+tBQcALaWMkaU/ZQg2lgp7h7YPxUZ4Ms+fjQIvwFXa/oN31tEZAbCjGD YldMnvsw62Bn5xWmcYD/QgqsbiIa7b9xJ9ChszC1nKk9U/2kwnM+v13rE2Uea6P7ZvJgKU mZ2Pn2qG9zhBRdwfcYwJDMdy7LcF418= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b=IYbZOdAu; dmarc=pass (policy=quarantine) header.from=bytedance.com; spf=pass (imf11.hostedemail.com: domain of zhengqi.arch@bytedance.com designates 209.85.214.179 as permitted sender) smtp.mailfrom=zhengqi.arch@bytedance.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1735876560; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ZAFSLXktiWezwRLeMqNHQIZ8a5HqagkfYDHtpNVk3Hg=; b=YFtulzAj9pmzxlVFIOiGULO9bGqwcQnkgdoKMldyEEl6Iv4RW+Z6ZI7H3wZRHR//YAbE8K k21TV7FAL1gRQ80SGnCvFioJyHcPNsNdpI6yCxKwN5RMBcVdJFHHptxWLrt+ybeM9mIIn9 jB2pBq7QDe2HL8F0eqBhOnCACDXesos= Received: by mail-pl1-f179.google.com with SMTP id d9443c01a7336-216401de828so154144395ad.3 for ; Thu, 02 Jan 2025 19:56:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance.com; s=google; t=1735876607; x=1736481407; darn=kvack.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=ZAFSLXktiWezwRLeMqNHQIZ8a5HqagkfYDHtpNVk3Hg=; b=IYbZOdAufT5aBtvf+Yp7BtDWCyLIrrpZOSJrhOfbxV4d+jB3XPTwxQpt6XCiEW8I6x GMjJdrWjksiOTQrB/cZENl7Jz0cdvQX91fhUvVyai6yLiUAV/sIOG+03upuOkUXZ6Ykg sKtfWfbBylWDGZV3lN+2D/h+vGxRRTLsFYY3DGNQU1BfDtOhDCUeQcR1aTa/8hdA9TAY 1BUmm8nhZo1DODK4BCbchwB5lc/pYQUU2w/4HEvP0u2/Sasg/Sa6c+Dvgu2ieXAqTm1/ I4mnzujYtcc6YRA/W8iZ7AT5HkyxL5OzWaSA0i8p9Oxq1ZIGYrh1eYC6APGVORYfEVve fOag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1735876607; x=1736481407; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ZAFSLXktiWezwRLeMqNHQIZ8a5HqagkfYDHtpNVk3Hg=; b=QUfLoUQOYzWu8cZiDAYutQ3dKtYIMMkgYpynw6dBfpHNCW5NvcEEuiODHAyRJPo8Cm acQhrQWOBDOjKazJ8fOCygrD6AxC15IkTlQMmhzs8CBNttSKgoNSQ3nBqiTaZhoyF3+8 7Q2d5zt5Wr38P1nuobVnJEEpsptX1+6XqZjbEffl0n6om8+lY714tbZSoMz8vdcwFNVz a2p7WmCcNAobqxXSoNJL0vQV9WIbbqietYdek9HTq3VAa0YIz+PqbqsR4yKsKMzERRZS /rS5BQlA6qQD2Y748vehk46UNt1cerKFFtYuSmXUKjvmuIV1TQfw1jzMMBTeHEApB07O KmSw== X-Forwarded-Encrypted: i=1; AJvYcCUJjYlOqFSE78U70ePPwXx3t39TTmMd+X0dMoYptaBClTZrR/k+KnKhDM1diQ2SGAzvyBaj3AwINQ==@kvack.org X-Gm-Message-State: AOJu0YzsX7dyrQ3VQY3drbAHWVUH8Kkq8lt6SxpnxyWSXB+ha9yUjYkT 4RJLUCyvXN4MtggXtrkW0dG99kcBfko84fTM46qDIhKMwzIYLmwUUril70J0E7g= X-Gm-Gg: ASbGncsrpa9Tb3m4zda5qxssNbr1KE4MepMRcV5T1sLLnkrobbByCtJ6tAY1QaKqiy0 QqKMA+/ubkkMzaVx3sR1kv5dR9XYJkVTvBNx22396yH8JHKnStlfBUCcw88sLwgxm8i4DofXpME qqNrW6mHkguJNb7AnzvNDTE6A0Mz51fTHHZHB6Bu1YkMhiQ77ISowJNV/3B/euQTkHc9vHPdbgO ZJYwqVmsc7S3FaxS17ZFvCeH0UxhMOkJJYHFvQtI3kYrTsGTvRaN4KFYx88AmR0zJrI2ORciKzP tm6gEg== X-Google-Smtp-Source: AGHT+IEc/ggyHLTYoMeUluV4bigOVwXpofNkIsaBMCcId3pHP1FalWdw/+NGvDWYCJeax838Cotn8g== X-Received: by 2002:a05:6a21:158d:b0:1e1:ca91:b0e3 with SMTP id adf61e73a8af0-1e5e0800420mr68823527637.36.1735876606776; Thu, 02 Jan 2025 19:56:46 -0800 (PST) Received: from [10.84.148.23] ([203.208.167.148]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-72aad8dbafesm25847661b3a.128.2025.01.02.19.56.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 02 Jan 2025 19:56:46 -0800 (PST) Message-ID: <1cea8c66-626e-434f-aafd-9d44d37f5cc4@bytedance.com> Date: Fri, 3 Jan 2025 11:56:32 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 00/15] move pagetable_*_dtor() to __tlb_remove_table() Content-Language: en-US To: Kevin Brodsky Cc: peterz@infradead.org, agordeev@linux.ibm.com, palmer@dabbelt.com, tglx@linutronix.de, david@redhat.com, jannh@google.com, hughd@google.com, yuzhao@google.com, willy@infradead.org, muchun.song@linux.dev, vbabka@kernel.org, lorenzo.stoakes@oracle.com, akpm@linux-foundation.org, rientjes@google.com, vishal.moola@gmail.com, arnd@arndb.de, will@kernel.org, aneesh.kumar@kernel.org, npiggin@gmail.com, dave.hansen@linux.intel.com, rppt@kernel.org, ryan.roberts@arm.com, linux-mm@kvack.org, linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, sparclinux@vger.kernel.org, linux-kernel@vger.kernel.org, x86@kernel.org, linux-arch@vger.kernel.org, linux-csky@vger.kernel.org, linux-hexagon@vger.kernel.org, loongarch@lists.linux.dev, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-openrisc@vger.kernel.org, linux-sh@vger.kernel.org, linux-um@lists.infradead.org References: <04b0a778-7a6b-4df3-b40e-ca76adddb243@arm.com> From: Qi Zheng In-Reply-To: <04b0a778-7a6b-4df3-b40e-ca76adddb243@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Stat-Signature: f8tduzxqedekwpe61w4umrh89dyx7mqe X-Rspam-User: X-Rspamd-Queue-Id: CB73840005 X-Rspamd-Server: rspam08 X-HE-Tag: 1735876560-747574 X-HE-Meta: U2FsdGVkX18jT2xxs5MgHtBKidygr9b1glkIkgqVN0wwnVpE0p82kdEgTeKSN6Nt2GVCuVAKlRUSeJcoInW5IyJ+ppHLpoTW1yygxHR+0CFwqPshktM131c5itkI8hXvcbdiB3YGe7RkGMWZq+jO9PLoy17h3EP20kuLTzaAlDWDxdqHdDMdOzYHdH28ODgjTRFgY3P7Cyg+ON7v4FxpGPbq+ACUH2pupuYr6n1qX4dMLw9SeH6YKWhJ36axdbWkBGeTV1MlapAq3ARQ4lpCREEddea6bJxlj73apDt+DL56K10S775T9JUDYNmJR/MdtfYErK6UJGXLoXRGnPfivVS+9YKm3fg7dLCs+GO9hs2f3G1QQHUzrzBpVuX/kxwdQgCJafIb5vThRNm6eKwokqrGuzwSfMr8VCaYreOKKRrScM+gSUiDN48HOxZ6xjyXeQatta+2JXMt219720hgYRdD6NkA66O83f86/nciA5tZEvuENmNAgtASWiuWuSy5wLSuQmlPSUGVpxxctgvqe425H8lxksfyx41sCBdzkvBbgyqpmIq64Pe3Z6Ey4pwr9oAyWCyJeK771osvXvjQnPEys1Pa9HiQlGlvV4Z25aoIbeqGB3Dq6q7fyMQXUaL+Pdaua7EHihOvsiwrIDOaVVh4O0OxsDmWSSuDrSmlyeFUpZa7o3TRcitepcNIKaMcFPyELAqGN14iUfEpd/TzEkAvVL3vQL+WRDQ4dva/wn3HwHqrByCItKDFUL6VpiMMT6SQzr9+1lIUDHZR6S4GvjUXBugHC4MtrEGQuSkoqb2oGm9eBFAzesAX5q0Ln1PDqECQVOmCPEC9IM4QVZRoR8HBaoSnSpP8cOqVqfPejDPcKMAmlpDRF1nVRBxFUWOQ3LZe5lxPZPhZdipSAeOTaqrTmmKBWMaHQi4loJKPJRZRueBluuYFPxji9aEk7tk6A67KD6v1cf4MQLUZaEY 7dK36J1b /sCXuoOcZUomNg6ECTIF1+hhMO62mqbVdMjPQ0zshRQEx+HUpMzVg+yjSgeOEG+SFhIfGonQZJxDdxno1MCj2hA97QVIf9+kc7TtSaAzVOC/7Y9xKg20FVuRe5jQGJDu8xux3GWSGbc8o77JJ7f0Jmp9LGC/iA/J7OUwicAc8xeNXjg502dfg52U0VnL2BTTxoLkW5AxvX7sEpZH3hJtp6lcrV23Vxtm3xttqiimYABaZKPxBL/NygUnUSCzMkqjpbD8kxKFA6q9BQW1YuyGI/HNDCOCO3bSwo/0viFSBiXJ4/IQEwO3DuIvAzRNtJWjA3klBmA7kRhDGC+jOrjTqQxad0yyBj7+R5V3JKOVuKspEe/u0yhp82O5i1xT9yyryqxFI1YCESMStcmfVQYWDYOZOWitijSmdIqZdj41QtOrSqza48IU6uY0nsPV9AH1chRdXa9pcelESDkH3cJG46MGOXa91ECAqE5p4y3pFYdyLh+9rieI7RIQCFEUmhw1KXUlf X-Bogosity: Ham, tests=bogofilter, spamicity=0.000016, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2025/1/3 01:00, Kevin Brodsky wrote: > On 30/12/2024 10:07, Qi Zheng wrote: >> Qi Zheng (13): >> Revert "mm: pgtable: make ptlock be freed by RCU" >> mm: pgtable: add statistics for P4D level page table >> arm64: pgtable: use mmu gather to free p4d level page table >> s390: pgtable: add statistics for PUD and P4D level page table >> mm: pgtable: introduce pagetable_dtor() >> arm: pgtable: move pagetable_dtor() to __tlb_remove_table() >> arm64: pgtable: move pagetable_dtor() to __tlb_remove_table() >> riscv: pgtable: move pagetable_dtor() to __tlb_remove_table() >> x86: pgtable: move pagetable_dtor() to __tlb_remove_table() >> s390: pgtable: also move pagetable_dtor() of PxD to >> __tlb_remove_table() >> mm: pgtable: introduce generic __tlb_remove_table() >> mm: pgtable: move __tlb_remove_table_one() in x86 to generic file >> mm: pgtable: introduce generic pagetable_dtor_free() > > Aside from the nit on patch 4 and the request for clarification on patch > 10, this is looking good to me, so for the whole series (aside from my > own patches of course): > > Reviewed-by: Kevin Brodsky Thanks for your review! > > And happy new year! Happy New Year!! :) > > Cheers, > - Kevin