linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] selftests: cgroup: remove redundant addition of memory controller
@ 2024-05-01 10:06 Usama Arif
  2024-05-01 15:36 ` Markus Elfring
  0 siblings, 1 reply; 2+ messages in thread
From: Usama Arif @ 2024-05-01 10:06 UTC (permalink / raw)
  To: akpm
  Cc: hannes, yosryahmed, nphamcs, chengming.zhou, linux-mm,
	linux-kernel, kernel-team, Usama Arif

This is already done in main.

Signed-off-by: Usama Arif <usamaarif642@gmail.com>
---
 tools/testing/selftests/cgroup/test_zswap.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/tools/testing/selftests/cgroup/test_zswap.c b/tools/testing/selftests/cgroup/test_zswap.c
index fe0e7221525c..22cf586d2438 100644
--- a/tools/testing/selftests/cgroup/test_zswap.c
+++ b/tools/testing/selftests/cgroup/test_zswap.c
@@ -445,8 +445,6 @@ static int test_no_kmem_bypass(const char *root)
 	trigger_allocation_size = sys_info.totalram / 20;
 
 	/* Set up test memcg */
-	if (cg_write(root, "cgroup.subtree_control", "+memory"))
-		goto out;
 	test_group = cg_name(root, "kmem_bypass_test");
 	if (!test_group)
 		goto out;
-- 
2.43.0



^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] selftests: cgroup: remove redundant addition of memory controller
  2024-05-01 10:06 [PATCH] selftests: cgroup: remove redundant addition of memory controller Usama Arif
@ 2024-05-01 15:36 ` Markus Elfring
  0 siblings, 0 replies; 2+ messages in thread
From: Markus Elfring @ 2024-05-01 15:36 UTC (permalink / raw)
  To: Usama Arif, linux-mm, cgroups, linux-kselftest, kernel-janitors,
	Andrew Morton
  Cc: LKML, kernel-team, Chengming Zhou, Johannes Weiner, Nhat Pham,
	Shuah Khan, Tejun Heo, Yosry Ahmed, Zefan Li

> This is already done in main.

Please improve this change description.
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.9-rc6#n45

Will the tag “Fixes” become relevant here (besides an imperative wording)?

Regards,
Markus


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2024-05-01 15:37 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-05-01 10:06 [PATCH] selftests: cgroup: remove redundant addition of memory controller Usama Arif
2024-05-01 15:36 ` Markus Elfring

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox