From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C59B3C2D0EE for ; Mon, 30 Mar 2020 09:56:51 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 85B56208FE for ; Mon, 30 Mar 2020 09:56:51 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 85B56208FE Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.cz Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 1B29C6B0008; Mon, 30 Mar 2020 05:56:51 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 163DD6B000C; Mon, 30 Mar 2020 05:56:51 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0A01F6B0032; Mon, 30 Mar 2020 05:56:51 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0039.hostedemail.com [216.40.44.39]) by kanga.kvack.org (Postfix) with ESMTP id E72736B0008 for ; Mon, 30 Mar 2020 05:56:50 -0400 (EDT) Received: from smtpin17.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id AE9B5B9EA for ; Mon, 30 Mar 2020 09:56:50 +0000 (UTC) X-FDA: 76651574580.17.stamp99_1e99a58852e14 X-HE-Tag: stamp99_1e99a58852e14 X-Filterd-Recvd-Size: 2517 Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by imf38.hostedemail.com (Postfix) with ESMTP for ; Mon, 30 Mar 2020 09:56:50 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 16A64AE0F; Mon, 30 Mar 2020 09:56:48 +0000 (UTC) Subject: Re: [PATCH v3 2/2] mm: mmap: add trace point of vm_unmapped_area To: Matthew Wilcox , Jaewon Kim Cc: walken@google.com, bp@suse.de, akpm@linux-foundation.org, srostedt@vmware.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, jaewon31.kim@gmail.com, Steven Rostedt References: <20200320055823.27089-1-jaewon31.kim@samsung.com> <20200320055823.27089-3-jaewon31.kim@samsung.com> <20200329161410.GW22483@bombadil.infradead.org> From: Vlastimil Babka Message-ID: <1ccdcd2e-2a56-af61-5b37-26ad64da0e7d@suse.cz> Date: Mon, 30 Mar 2020 11:56:46 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 MIME-Version: 1.0 In-Reply-To: <20200329161410.GW22483@bombadil.infradead.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 3/29/20 6:14 PM, Matthew Wilcox wrote: > On Fri, Mar 20, 2020 at 02:58:23PM +0900, Jaewon Kim wrote: >> + TP_printk("addr=%lx err=%ld total_vm=0x%lx flags=0x%lx len=0x%lx lo=0x%lx hi=0x%lx mask=0x%lx ofs=0x%lx\n", >> + IS_ERR_VALUE(__entry->addr) ? 0 : __entry->addr, >> + IS_ERR_VALUE(__entry->addr) ? __entry->addr : 0, > > I didn't see the IS_ERR_VALUE problem that Vlastimil mentioned get resolved? Steven is fixing it in trace-cmd: https://lore.kernel.org/r/20200324200956.821799393@goodmis.org > I might suggest ... > > +++ b/include/linux/err.h > @@ -19,7 +19,8 @@ > > #ifndef __ASSEMBLY__ > > -#define IS_ERR_VALUE(x) unlikely((unsigned long)(void *)(x) >= (unsigned long)-MAX_ERRNO) > +#define __IS_ERR_VALUE(x) ((unsigned long)(void *)(x) >= (unsigned long)-MAX_ERRNO) > +#define IS_ERR_VALUE(x) unlikely(__IS_ERR_VALUE(x)) So this shouldn't be needed, as we are adding a new tracepoint, not "breaking" an existing one? > static inline void * __must_check ERR_PTR(long error) > { > > and then you can use __IS_ERR_VALUE() which removes the unlikely() problem. >