From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 155C4C00528 for ; Tue, 1 Aug 2023 19:05:31 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7ABAE2800EE; Tue, 1 Aug 2023 15:05:30 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 75C8F2800C8; Tue, 1 Aug 2023 15:05:30 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 623BE2800EE; Tue, 1 Aug 2023 15:05:30 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 4FE212800C8 for ; Tue, 1 Aug 2023 15:05:30 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 53A8D160CA2 for ; Tue, 1 Aug 2023 19:05:29 +0000 (UTC) X-FDA: 81076464378.21.3CCE50E Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf18.hostedemail.com (Postfix) with ESMTP id 56A6D1C0002 for ; Tue, 1 Aug 2023 19:05:27 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=grHpsCad; spf=pass (imf18.hostedemail.com: domain of broonie@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=broonie@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1690916727; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=UNmaBro9friNbMH7XWCiSQc7RE/rpzJHScPmtRxJvPE=; b=WfFB7lcn6WjgXETPwXXb2VBsaMCmEHawSZpKZ3C6et4gZ8nbXtFo6eVCzJrqIBkSCjECOs e2RsW82apZd4xVgupy9Fg5h+kEVjJZhg4+mqUxixZ0Jp2eidfBMtslB/Ug37qn3UwCFMlf KBtJXXUBbki/gcjWagmE12MXogDfqNE= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1690916727; a=rsa-sha256; cv=none; b=ztQSCwfKtYhKMYfC7xgChaBhdT5jxucu2lnB8TL/M89/YGf4J+g38iy0AOXVAwLtudLgjn r5EiajuUdLLT6Vk7ycsVrJuYL+t7rG2dktcflso02vI+oR9YQNvuLX+fhS+ZdtieHlc6IT UsKp+AYKykbqcdNxjavunkdWriJPTTc= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=grHpsCad; spf=pass (imf18.hostedemail.com: domain of broonie@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=broonie@kernel.org; dmarc=pass (policy=none) header.from=kernel.org Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 3A5136168C; Tue, 1 Aug 2023 19:05:26 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A61AAC433C8; Tue, 1 Aug 2023 19:05:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1690916725; bh=XaEyLOjcTNwc9YeWlOJYScuIZzeMlhSmUXhkTyWOcdo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=grHpsCade+4hhBefcy1y7pfmLc1TAcGI5yfjr3ji+PPlfsj7KES8fDhea9q6wXLgD xrGOW3viFBiZ2vyLfNwKC2X7e0UTc1/jdT+BIQoV/8PnGuJGh7RiYNNQpAaJGGf11f CdB8b0Gn5nYSkS4o8WfpNo99u2ppuAN14a1C5I5IwjPlP7/PUzBYiYFueK9jOe6o1g wKWlPPFaossUwjpE/h96bWJrEMfGbGHML66oQ9wJRkAletVZCNSjo4mwx9aKbjnxmW /wU5qh51gu/TWRN8ejWFeGscGFLY08HjeLHMeUYNUquMcFllxGCj3PCG7S0rJoDSlE IMkXmWaTTxdrg== Date: Tue, 1 Aug 2023 20:05:16 +0100 From: Mark Brown To: Mike Rapoport Cc: Catalin Marinas , Will Deacon , Jonathan Corbet , Andrew Morton , Marc Zyngier , Oliver Upton , James Morse , Suzuki K Poulose , Arnd Bergmann , Oleg Nesterov , Eric Biederman , Kees Cook , Shuah Khan , "Rick P. Edgecombe" , Deepak Gupta , Ard Biesheuvel , Szabolcs Nagy , "H.J. Lu" , Paul Walmsley , Palmer Dabbelt , Albert Ou , linux-arm-kernel@lists.infradead.org, linux-doc@vger.kernel.org, kvmarm@lists.linux.dev, linux-fsdevel@vger.kernel.org, linux-arch@vger.kernel.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org Subject: Re: [PATCH v3 11/36] arm64/mm: Map pages for guarded control stack Message-ID: <1cbd6d5a-0e58-4a3f-b7e5-bbab09f03c5d@sirena.org.uk> References: <20230731-arm64-gcs-v3-0-cddf9f980d98@kernel.org> <20230731-arm64-gcs-v3-11-cddf9f980d98@kernel.org> <20230801170231.GC2607694@kernel.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="zPbhvjZzJERchlQs" Content-Disposition: inline In-Reply-To: <20230801170231.GC2607694@kernel.org> X-Cookie: I thought YOU silenced the guard! X-Stat-Signature: jgxerrkhz6sauu8dgnhuusncxbhcqruc X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 56A6D1C0002 X-Rspam-User: X-HE-Tag: 1690916727-417614 X-HE-Meta: U2FsdGVkX19JiXd8p8ht210FMdapYvXsjgo57z+PmlebybDwXu61ZQq3jvExWiD/TmY2/Di4GuPnEOfKAiDH6JL52tvHplFC3pWhHYFXcN3tFJjgVGq9ePNCciWCCywpWEijYa7bylJCbB1qemUDUta6mUZN1Qj+8ahRTVbTCLV5a4Zq4zQ/cEIq6C/S+mwuMYenzvVnN7Vpya/esyXYrNmmAH6CGQmgFaPFousKR+pRtUJuEpa+d5eSpOnizZfjzwm/Df6kVC5ss4+Q6YfxPOy7OMQgg3uCOGTSU/xw8+fiXGuKTJo47/B+IUnerIG0No4vCfQrwMUIzbE1LzaKyULDPoddMJUMEkC6szIrwDHw6b+XKfWO41igqqUzwQ0ra78fBNJZtNItfQwjCacjAet/SCZ23Nh7+UdNGZE5uVg5MC7EntuKdbPkpfLdzlhCdPQchqT1TkxPaBbvF35kiYBA/Ef4nXwnZVHLAKMntH2dwAZzzp9szlAzrWjN+DOLT4EC9C1Y2KJjY1aHCZOvJkdiVF2frQlg5rG0/3e7WVbLGMoeUSlPiNEwOS24SNzVgeBCpN4LuaONAleJN+3U+4+I6PWpklJ9PnO7ksXRet8Q2bz5lanTKNVJccc9+cHW0FV6YttiYpQ5ZMK9/3mzQoO1swTeatE8PJ31tt9Pj5sW0EV1OuVoYtYo8RvPkX00+JyNkCc8avORkAZd+qECW5CQu+xuZqawwplHw/273XbSDEzgvrhLg9GNuyHe+MqmHu+sCDpEF7eiWx7f960jJqOOkwU1TJYHAQgODiZDI7BK1r14J3TKRYrCKfizWtTCuo0B4WxvKZvVffeazHvphyOBHUQFfn9fatfOzmlogv2JUUKr6Iq6Hnqh4A6aK9c0N9i5z8yRXepjZLSsg1y7lXm6cNvLHqYuNNfkc7rGIDCN9wOKyyeU9rp9HDP4MCt1axx6fYrnzECWyxfxZuq 7nQqqC51 SklafeLT9VZsZ0MKvgFX9N6tsT9xQsHMvmo+Mb/DYOaepHaG7vcqifFHBooanPAQOyQyFSr4xYFa+jIyig5Wl5XIfZqLARatCfqQ4Q74bHRyVjS2URsX63DIxKlCUoMfcQPoikAErX0QEVYOpdYsV4jP/GWEZxdHkza2ra6nbAa7lnpCcsuA+Ps3UnLLssjxs73nRa2LzfJX5cKz0GxdZDez96O/bpUutCGt9IRl64bl94DO/c6xBXc21OA0+aWhdZtNy4RDMfzCdiBPdffzjIwAVN5jcp4LMegOssPfH+/eawL1hu+yNqEaxwaGWfvXDlmUL+EIBDtPrNtbHHyTftHzRYQxqfVkzPFwtX5ZNdJALsi1ktHc/rq+GVlWd9xcKMYriu3w/+0wRyM+qJSJe6JxWCoUZCrrRuA713vbrwjc+I6U= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: --zPbhvjZzJERchlQs Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Aug 01, 2023 at 08:02:31PM +0300, Mike Rapoport wrote: > On Mon, Jul 31, 2023 at 02:43:20PM +0100, Mark Brown wrote: > > { > > - pteval_t prot = pgprot_val(protection_map[vm_flags & > > + pteval_t prot; > > + > > + /* > > + * If this is a GCS then only interpret VM_WRITE. > > + * > > + * TODO: Just make protection_map[] bigger? Nothing seems > > + * ideal here. > > + */ > I think extending protection_map and updating adjust_protection_map() is > cleaner and probably faster. That was my initial thought but then I immediately started second guessing myself about review comments. Hopefully Will or Catalin will weigh in. --zPbhvjZzJERchlQs Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmTJV2sACgkQJNaLcl1U h9AlrwgAheuf8ghyBKWYbkyMEXdB+oQMSgcGlnFgC7nJJfw06f2XaVrBNE+6Swjh pgt+0RrRPIXZHhZXP3vHWP0yM/pgwS3o0K+/jolpahP+ieFfiJa5X4GTuGzPYZiq 6XYZEXkdOtuuyx3McLXU4Eet7PsnmqDolbBcr2pV1oyvRj6zWbdfv+SYoL8DX6bA kUGWitWitEXi8bMTvWWg23s1MoFXLYxUWDZVwCl89aIipWnICzUze6O9FVMsfYJ1 h8ITi9V3QFo5uKkn1MySOUPaK7TI+VKZhAJMaNEQmCHMFXTkQhpp1jJvY4FFRVi2 rUxmpnOLBLA3hsMLGXV+tSV8S9P65g== =kTpO -----END PGP SIGNATURE----- --zPbhvjZzJERchlQs--