From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1B4B0C02181 for ; Mon, 20 Jan 2025 13:57:06 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8DADC280001; Mon, 20 Jan 2025 08:57:06 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 88D0E6B008A; Mon, 20 Jan 2025 08:57:06 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 704D6280001; Mon, 20 Jan 2025 08:57:06 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 4A61A6B0089 for ; Mon, 20 Jan 2025 08:57:06 -0500 (EST) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id C773C1A013C for ; Mon, 20 Jan 2025 13:57:05 +0000 (UTC) X-FDA: 83027981610.29.1F9BA5F Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf20.hostedemail.com (Postfix) with ESMTP id 6D6221C0008 for ; Mon, 20 Jan 2025 13:57:03 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=WAbcv18U; spf=pass (imf20.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1737381423; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=qcyithpCUM94o5b1nFPf/poYAlKB7Tn/nU0i8Lo+l7s=; b=n95RGpD+CLn+D5hQLx2VKc3jeyMosi6hwhX87Rdmx4/ErIViD8NVZMWmMxZcBzN+2ebCYB cGoILSxQCpBNkziqJ+8kBiRPYMiY4vZBG/SncVU+SAe4mRfegvyUwNyWNXi5GlrXhKq8zb H4CwJWChk6zwWNtg0L3i1xNKbTv7s1c= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1737381423; a=rsa-sha256; cv=none; b=ROIy9e30XZVT29n9yG6GXAXCKtf1m0cx8Bt2Bq//gZRX6QGsz0G/GDhwNGg3x8EE74a9Gk SvKYQgiwe+UyZ1enbGQBRTR0lVuB+CLYVMmjUwOsFptfOyKDG+yL7Z8MuCAF9c+akSZZZ5 7oHnxN3FZ7JTyNHAoAdXW/qybLonysE= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=WAbcv18U; spf=pass (imf20.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1737381422; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=qcyithpCUM94o5b1nFPf/poYAlKB7Tn/nU0i8Lo+l7s=; b=WAbcv18UjRXAy2N5FiUZpkbkSomEss88fk9xsNeVIH6/WIHbUMIOO1dCVLvwz44hiQWAgx 3gL7v3VbGSJ6A1l62JN2EAKKyINtIQAbjGk6hQbGrvakTomjcewJTLXynoTOjiE4riQDTQ i0b7SksS7q83SJE0n5ocgQC/RC7rokM= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-135-sYM4mIm9NzWKI7WHEqzLJA-1; Mon, 20 Jan 2025 08:56:59 -0500 X-MC-Unique: sYM4mIm9NzWKI7WHEqzLJA-1 X-Mimecast-MFC-AGG-ID: sYM4mIm9NzWKI7WHEqzLJA Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-43651b1ba8aso34370695e9.1 for ; Mon, 20 Jan 2025 05:56:59 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737381418; x=1737986218; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=qcyithpCUM94o5b1nFPf/poYAlKB7Tn/nU0i8Lo+l7s=; b=kpOyG0YFsSCiGf0ipd4Zb4//c8RF5tSECywgZKeRLGqCZUsPl4HDzNukeq5JcWcBrs n+Eg4Q+/2kVMHvzrHew6MSkB3t7/F83PNHTCBPrrmerHKnwhpmw4DLuR4LMyX/832M9R ZZWqVIxxOzArvxGLhVzUtD3SOZo/+pAGDAwNYKDnSbkjCrw/ljiEO1+oXDVev9s3gCL+ s7e7kU1dgsZPTg1bYcHnp3gQDrq9UzY/7Yyy9S/oADJDjdwotfMM13hung+kvWPX45iZ V4FRJ8pfhyZrTWNuwVvm7IxRBbiaYd32xL6FshSZgs9noCMNZYU7Z/XSK3ookPseMmY3 HLtg== X-Forwarded-Encrypted: i=1; AJvYcCUiBKGIbV27ri6GMzvsn5KWeg28jR4MHsnBuqa35Ritcj7c4I5rIAR43G8+o/RCeS00TVfki6JYMg==@kvack.org X-Gm-Message-State: AOJu0YwouutwljAr2OKafBDedaD6Tv2PLgW8Ns+5ZdMdb79489Y9KFqt avhPgUVcE1mabF1sXteHMTy+5nuODPSafp+YPJeh5KhsYWBAfl/VsEnOrJjcJ0TLZst1eYqZbcf jrKp9Ahd/8ZaDch8SsVC0kVOpp/kY9IC5widUOyWtG+zSH7yq X-Gm-Gg: ASbGncsxCoG0txFQvQRSxCE8EvIU0FTKjUf2qmidO1SHwn33MJlqwTEJ8s/E4EGm52w kBHoVXI9aY+qGRbKhyZp3Qet1IA8IZN1xsP1jLm+jUL/OaQk4uGtF/cCBbNtSLyrKoFGACj51ab 1SC6WO2WeJtfiFG5qXDk/6MJF+hw1Yuu57ukD+VqWvd2SRTxy9XPjlYSHa4o7Ol4hd3AM1cPOgQ UMhavinW5EIYcaW87VxjowjPxUrlBYgoJ6dQO/WYD19G6UYjrISBM+ByXbzicUVBZHDRhS2Sllp /XGUakmXp9ei615p+YP0iJi0nzT5Lhszcvnn3g5vHZnvvOZniuIzWNta4w6C8GaV1Ubpc+BvfPQ we6u/pFyrraqaf+mi0ZtfhA== X-Received: by 2002:a05:600c:ccc:b0:434:e9ee:c3d with SMTP id 5b1f17b1804b1-4389141c1e5mr105763715e9.20.1737381418383; Mon, 20 Jan 2025 05:56:58 -0800 (PST) X-Google-Smtp-Source: AGHT+IEk02cCvArGo1Q4FqvnvoIJ+fAu74VhEDW/L5RQpOBRXRb8y7p/q+2lGXTdU8pdc5rpappM2w== X-Received: by 2002:a05:600c:ccc:b0:434:e9ee:c3d with SMTP id 5b1f17b1804b1-4389141c1e5mr105763545e9.20.1737381418046; Mon, 20 Jan 2025 05:56:58 -0800 (PST) Received: from ?IPV6:2003:d8:2f22:1000:d72d:fd5f:4118:c70b? (p200300d82f221000d72dfd5f4118c70b.dip0.t-ipconnect.de. [2003:d8:2f22:1000:d72d:fd5f:4118:c70b]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-38bf3221b5asm10378195f8f.21.2025.01.20.05.56.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 20 Jan 2025 05:56:56 -0800 (PST) Message-ID: <1cbd3b3d-48b7-42b0-88e1-a9316e4acc53@redhat.com> Date: Mon, 20 Jan 2025 14:56:54 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC 1/1] mm/madvise: fail MADV_PAGEOUT on VM_DROPPABLE VMA To: Lance Yang , Lorenzo Stoakes Cc: akpm@linux-foundation.org, 21cnbao@gmail.com, ryan.roberts@arm.com, dev.jain@arm.com, shy828301@gmail.com, ziy@nvidia.com, libang.li@antgroup.com, baolin.wang@linux.alibaba.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Liam.Howlett@oracle.com, vbabka@suse.cz, jannh@google.com, Jason@zx2c4.com, Mingzhe Yang References: <20250120013038.6657-1-ioworker0@gmail.com> <04d81e18-c206-40f3-b469-5ea588d4bf8e@lucifer.local> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: il16STS9FVofScO3OMAp0oswDyGTG178foN0Vz7nKyU_1737381418 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Stat-Signature: dr8hq146t5s8614bynnrqun1zarorhxa X-Rspam-User: X-Rspamd-Queue-Id: 6D6221C0008 X-Rspamd-Server: rspam03 X-HE-Tag: 1737381423-917465 X-HE-Meta: U2FsdGVkX18SpqVLbDZReQahHXq5GeXJpCm/Zg7Ec+cVPfbaLLuRVRI1mCvPo9peykmceXo9ojXF1pco9tT7erQJCvfiAN4P6M5IDHCzrUvG5aW/oo0KTMYwXCv6Grt9upGnGy7x/k1+W7E0y+aJXcYyL3QjhcKXVsUiDcMJcwNbMCOMn/Qvli/GvACFqzZMcrgv04kFaxk+Ktbpr5j96nNJjrbezBrfDvNKEZjoC2kNpZs4mtx+l9zn4pywJBfNpMBAWErDQkH2WOPAPa2TSC+sMJ8C8jTEAwE1Aktsw6jf24uutks6u/A/TsqK9TCW8oe/+Hm1JSPXU0BRJzNLyS4apAnwYYFSJVEjc+vpM6bdS3/gYoMu1sIUdm2cwFpCHnXFTYKTggH3ceLX+rm1RVEHw6XUsx1wR4hqnuBbP5nSTG+GEZwyl3LtXRAS2yKiWifKo23Rsa+q8lVcpxaNqSE9qllvXJbCYGmOYcNmQYrfp0xysUHQV74s+PqOHZ+8WnlAWf9fCB/jkx6Ys135ml3k1jZukrclPJTFEdLO7AzRV2EVLSsKzRr4ajpgabQ/lw6Wv6HpmroriKmO31o14PkqsdwrzxJZLfDDZzDLNQWzgnGiZWyK/IM+ZF1RBibBDCd8tiCSGxSUHZ+yJTvtfVYWZSUgfX/6tAxZJtz0dlH9WOkrYJb7AgtZCSWvDV6J1ysip0uo/eC5pV3oJiHbiioOBpL8ZynLcgsqHpIdo8BC91BPucusZCeLSjCSwMXThyGY0b+LUgxDCu7Q1ChIc9CukCkMMPMKamrktHNKmvLT+Eds8nqy6lX3qVlj7csc/YEDDeYkBMq2asn3NBboVI+7pZ45wwBcD9buDMCcdCsn9vbOzL0WWuGHWSLGDYY7MpyF0Yz6Uyqfb973R/i/VFUss4EM/Ixugta+NBkc4HwNyPPF86FVN8CAfMRcMxWXJ5PK/vCO7nNB8TwTOJj 9Jj3WnR7 iwvthRMg/OzxzcIb0c+WvvBMgknh0bCHXAKP/tHv3ZFvZ95xxY9fnJfy5Fc7ZzAJYr/yb9OLKAOWNDryJainvNGm59i91m+5W4gpTMaUAICa/6OTcEaIqeFVBALp3Smj195EsjgvYGKZLmkZKshZiW9qAFVUSYPqP3Jp5dqmkeJyHo5YNldbTLckU9LxLfnyX9mbE1+44hmeaOpjVbh90swGF6hX8HMIVkj23W+zCy5N2kmECNFNd1a6+Dex7WDeiy92uHAstQ1tAs4hrXZfgduIEELGTiyEWihgpMBvtxEC/Fb6WlyfNJ9vUUx9xF/tIyRaJXCoWkgtKypVRubkwepdqRZb2pC+97aaCJo1vaRvKQ1Vi6Kn1d9I0DQrdF0KXi7JGNLMFuQiZcnP76OJSR5qxRBKBR1lduo+VGRv2LU/mHrIm009DpfM4uavSzMlRLSCwyv0LfLXghYUW+cgj0IaFgKeCxmTQtFnL8IG2HHkv9DPo0C9iFFog4g== X-Bogosity: Ham, tests=bogofilter, spamicity=0.013646, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 20.01.25 14:47, Lance Yang wrote: > Hi Barry, David and Lorenzo, > > Thanks a lot for taking time to review! > > On Mon, Jan 20, 2025 at 6:45 PM Lorenzo Stoakes > wrote: >> >> Sorry but NACK again on this :( >> >> On Mon, Jan 20, 2025 at 09:30:38AM +0800, Lance Yang wrote: >>> MADV_PAGEOUT should fail on VMAs with the VM_DROPPABLE flag. While >>> MADV_PAGEOUT is intended to move anonymous pages to swap, VM_DROPPABLE >>> should not be swapped out. >>> >>> There is an issue where using MADV_PAGEOUT on a VMA with the VM_DROPPABLE >>> flag behaves like MADV_DONTNEED, causing the pages to be dropped. This >>> could break the semantics of MADV_PAGEOUT, IMO. >>> >>> So, let's add a check to detect the VM_DROPPABLE flag before doing >>> MADV_PAGEOUT and returns -EINVAL. >> >> No, let's not. > > I think I completely got it wrong. Learning so much from your patient responses! Maybe you can make the documentation (man pages?) clearer in that regard? Thanks! -- Cheers, David / dhildenb