From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 674F1CCD199 for ; Thu, 16 Oct 2025 20:01:14 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B99AD8E0028; Thu, 16 Oct 2025 16:01:13 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B49BB8E0002; Thu, 16 Oct 2025 16:01:13 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A11E48E0028; Thu, 16 Oct 2025 16:01:13 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 8B07F8E0002 for ; Thu, 16 Oct 2025 16:01:13 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 46CC814041B for ; Thu, 16 Oct 2025 20:01:13 +0000 (UTC) X-FDA: 84005046426.22.F50BAFE Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf17.hostedemail.com (Postfix) with ESMTP id A774440005 for ; Thu, 16 Oct 2025 20:01:10 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Anx3tgIB; spf=pass (imf17.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1760644871; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=KB/d5MSyqNV+qLBPu1eFm53uolqbzqkkygOrp+ESl10=; b=ESdqxUTTmE7TQs/1JvpcyveB8Wig6HNBgvzNOY76IsDngemWaxW26kgYTB8GNDn3hfn6je a3hfTE5bkOMo6Ejd9kxCsyxvfvF+GzevKxTVuzC0Ny/Wb5RfOR7tCb8zcTqNb7JB9XA0FD 7ROU3oxG603yCNWlsQhDzlzv0Ui3a8A= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1760644871; a=rsa-sha256; cv=none; b=wiLtMD72wdQirBhnmJg6cmGz5h9TMS6p7pLDeMnXAmowDWxEsiN+BgBDHQkVN5PDSTpRcO mEW84yAItTCMGXpQKjfVuECczuit3Ugcw0VJL7EbPZHB9BoNPb9nHAh/1/u82AcO7AS450 /k+DubMbqaKUiAEPTHCxAQ8qS/TFNQM= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Anx3tgIB; spf=pass (imf17.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1760644870; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=KB/d5MSyqNV+qLBPu1eFm53uolqbzqkkygOrp+ESl10=; b=Anx3tgIBJU5baodNaJw1djkqz1j2nxdb3W0Apb3lTdc3llCSv41vndjLqym6Ka0CXUTOmg itMlnTlxJVeUTR3A6dbrd4eLumcpWWJsEKIXc1NPmD/Tf4UcsEOIwqU+2Yxm8S9pUqqh5X hKw4uXMJKaIfQnqt1I2pggRwC+2cLzA= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-489-lAjHhVVgOrC_ZJNGylwAUQ-1; Thu, 16 Oct 2025 16:01:08 -0400 X-MC-Unique: lAjHhVVgOrC_ZJNGylwAUQ-1 X-Mimecast-MFC-AGG-ID: lAjHhVVgOrC_ZJNGylwAUQ_1760644867 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-3f7b5c27d41so761646f8f.0 for ; Thu, 16 Oct 2025 13:01:08 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1760644867; x=1761249667; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=KB/d5MSyqNV+qLBPu1eFm53uolqbzqkkygOrp+ESl10=; b=PF4XqtrnIAAwpYrGfRwUk2M8LxZTzNBLHLsSqu1XJoC+KIZ/1IZFjVH3hpT3W8zLCu Y5ukD18goU7PfcmoqY8ROhVFK+987jcAU+jJNMa0wDVu6MGjJg/1W3+C+K3QL1oFeFxE PD4ukLTUxrLksC6AxukYtkrSySv+GjIsEJbzTobJj3wx9XkbrxTnA+aTnbYlO1YOsVV9 qtwfNNCBlR54HpkkFN+R6BSoJM0AOS08viSoNpWSavHXcYMeVJtc5i9O5FFMnkhl+qHS 3dDdjRYkNLtUe7dpP9CLjhn2mffV1Ja9Af3SAd++w/3G1axC676YeXySpR5Rn4hJ1dyT CG9A== X-Gm-Message-State: AOJu0YzHjMPJGG+zIbQqBJayzZboYKm2dfqwenGt83lnOOA1ZkJ0cCG4 m5sIUNhGmwneJ/VoedKXwRONqBaa2rMpQf2KpmFTthhodGR9k2Jp5skiHmuh0gnrZtt6N6XSHYX pQM8jtIG3JfA1BA8Xp1gynKOihTWzHpB4fwEk2g6GqFfu4kPMVrfH X-Gm-Gg: ASbGnctOO37M0W2kEEuJTEv/SCa/neVSa4vR75wzv7iDIghWsXpaIy9iNw/naDcQqBU quqXCxqLeLDZN3C/5Dh8SwjqUQQuaYlLEotjuoLnLFioDdj1C3Y05HXH/RSRHeF4VtgQrQqogaS EXpw3Uv4X/YYkGZuKo1zW+4PTnQfiux82PLR4XaEseYfQH/Gd/VFnpa4KGkYVogOU/UkhlIyBJ/ R1+OHSv/nSHaxcIn9JrWtSjlkZf2EzNnLXJURotak1nZL+7qVOwiCr1SrIcO1k/WWVylIo2SezB KGW/TTx+m8IG9d9fuP4jFR0OOshQJHENTK3oTOZvAKqIDLLIfbrjA2kj4TiS0AT+wZPXbhVNsyu 7Uvtd7ul6k9hIOWjXQAIGEfRGWjLAjlZhfJiUZqyW4HR6xqUiCje6s2p6HOfL2vdueMF5lvvB2H 4DLvMJGkKwQUNxV4fddEY5yfibNYc= X-Received: by 2002:a05:6000:2089:b0:427:521:134c with SMTP id ffacd0b85a97d-42705211378mr921537f8f.6.1760644867498; Thu, 16 Oct 2025 13:01:07 -0700 (PDT) X-Google-Smtp-Source: AGHT+IE/wf+YzE7MlPNmwm/QH+Z6IPMHhQnh5WfAJY9LwquIIjT0EeDmNwjUSRqVGuGIOaBD3q272Q== X-Received: by 2002:a05:6000:2089:b0:427:521:134c with SMTP id ffacd0b85a97d-42705211378mr921507f8f.6.1760644867115; Thu, 16 Oct 2025 13:01:07 -0700 (PDT) Received: from ?IPV6:2003:d8:2f0c:c200:fa4a:c4ff:1b32:21ce? (p200300d82f0cc200fa4ac4ff1b3221ce.dip0.t-ipconnect.de. [2003:d8:2f0c:c200:fa4a:c4ff:1b32:21ce]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4710ca4931csm32767135e9.0.2025.10.16.13.01.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 16 Oct 2025 13:01:06 -0700 (PDT) Message-ID: <1cb9f931-78cd-4091-9343-f55b94479d87@redhat.com> Date: Thu, 16 Oct 2025 22:01:05 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [Patch v2 1/2] mm/huge_memory: cache folio attribute in __split_unmapped_folio() To: Wei Yang , akpm@linux-foundation.org, lorenzo.stoakes@oracle.com, ziy@nvidia.com, baolin.wang@linux.alibaba.com, Liam.Howlett@oracle.com, npache@redhat.com, ryan.roberts@arm.com, dev.jain@arm.com, baohua@kernel.org, lance.yang@linux.dev Cc: linux-mm@kvack.org References: <20251016004613.514-1-richard.weiyang@gmail.com> <20251016004613.514-2-richard.weiyang@gmail.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZoEEwEIAEQCGwMCF4ACGQEFCwkIBwICIgIG FQoJCAsCBBYCAwECHgcWIQQb2cqtc1xMOkYN/MpN3hD3AP+DWgUCaJzangUJJlgIpAAKCRBN 3hD3AP+DWhAxD/9wcL0A+2rtaAmutaKTfxhTP0b4AAp1r/eLxjrbfbCCmh4pqzBhmSX/4z11 opn2KqcOsueRF1t2ENLOWzQu3Roiny2HOU7DajqB4dm1BVMaXQya5ae2ghzlJN9SIoopTWlR 0Af3hPj5E2PYvQhlcqeoehKlBo9rROJv/rjmr2x0yOM8qeTroH/ZzNlCtJ56AsE6Tvl+r7cW 3x7/Jq5WvWeudKrhFh7/yQ7eRvHCjd9bBrZTlgAfiHmX9AnCCPRPpNGNedV9Yty2Jnxhfmbv Pw37LA/jef8zlCDyUh2KCU1xVEOWqg15o1RtTyGV1nXV2O/mfuQJud5vIgzBvHhypc3p6VZJ lEf8YmT+Ol5P7SfCs5/uGdWUYQEMqOlg6w9R4Pe8d+mk8KGvfE9/zTwGg0nRgKqlQXrWRERv cuEwQbridlPAoQHrFWtwpgYMXx2TaZ3sihcIPo9uU5eBs0rf4mOERY75SK+Ekayv2ucTfjxr Kf014py2aoRJHuvy85ee/zIyLmve5hngZTTe3Wg3TInT9UTFzTPhItam6dZ1xqdTGHZYGU0O otRHcwLGt470grdiob6PfVTXoHlBvkWRadMhSuG4RORCDpq89vu5QralFNIf3EysNohoFy2A LYg2/D53xbU/aa4DDzBb5b1Rkg/udO1gZocVQWrDh6I2K3+cCs7BTQRVy5+RARAA59fefSDR 9nMGCb9LbMX+TFAoIQo/wgP5XPyzLYakO+94GrgfZjfhdaxPXMsl2+o8jhp/hlIzG56taNdt VZtPp3ih1AgbR8rHgXw1xwOpuAd5lE1qNd54ndHuADO9a9A0vPimIes78Hi1/yy+ZEEvRkHk /kDa6F3AtTc1m4rbbOk2fiKzzsE9YXweFjQvl9p+AMw6qd/iC4lUk9g0+FQXNdRs+o4o6Qvy iOQJfGQ4UcBuOy1IrkJrd8qq5jet1fcM2j4QvsW8CLDWZS1L7kZ5gT5EycMKxUWb8LuRjxzZ 3QY1aQH2kkzn6acigU3HLtgFyV1gBNV44ehjgvJpRY2cC8VhanTx0dZ9mj1YKIky5N+C0f21 zvntBqcxV0+3p8MrxRRcgEtDZNav+xAoT3G0W4SahAaUTWXpsZoOecwtxi74CyneQNPTDjNg azHmvpdBVEfj7k3p4dmJp5i0U66Onmf6mMFpArvBRSMOKU9DlAzMi4IvhiNWjKVaIE2Se9BY FdKVAJaZq85P2y20ZBd08ILnKcj7XKZkLU5FkoA0udEBvQ0f9QLNyyy3DZMCQWcwRuj1m73D sq8DEFBdZ5eEkj1dCyx+t/ga6x2rHyc8Sl86oK1tvAkwBNsfKou3v+jP/l14a7DGBvrmlYjO 59o3t6inu6H7pt7OL6u6BQj7DoMAEQEAAcLBfAQYAQgAJgIbDBYhBBvZyq1zXEw6Rg38yk3e EPcA/4NaBQJonNqrBQkmWAihAAoJEE3eEPcA/4NaKtMQALAJ8PzprBEXbXcEXwDKQu+P/vts IfUb1UNMfMV76BicGa5NCZnJNQASDP/+bFg6O3gx5NbhHHPeaWz/VxlOmYHokHodOvtL0WCC 8A5PEP8tOk6029Z+J+xUcMrJClNVFpzVvOpb1lCbhjwAV465Hy+NUSbbUiRxdzNQtLtgZzOV Zw7jxUCs4UUZLQTCuBpFgb15bBxYZ/BL9MbzxPxvfUQIPbnzQMcqtpUs21CMK2PdfCh5c4gS sDci6D5/ZIBw94UQWmGpM/O1ilGXde2ZzzGYl64glmccD8e87OnEgKnH3FbnJnT4iJchtSvx yJNi1+t0+qDti4m88+/9IuPqCKb6Stl+s2dnLtJNrjXBGJtsQG/sRpqsJz5x1/2nPJSRMsx9 5YfqbdrJSOFXDzZ8/r82HgQEtUvlSXNaXCa95ez0UkOG7+bDm2b3s0XahBQeLVCH0mw3RAQg r7xDAYKIrAwfHHmMTnBQDPJwVqxJjVNr7yBic4yfzVWGCGNE4DnOW0vcIeoyhy9vnIa3w1uZ 3iyY2Nsd7JxfKu1PRhCGwXzRw5TlfEsoRI7V9A8isUCoqE2Dzh3FvYHVeX4Us+bRL/oqareJ CIFqgYMyvHj7Q06kTKmauOe4Nf0l0qEkIuIzfoLJ3qr5UyXc2hLtWyT9Ir+lYlX9efqh7mOY qIws/H2t In-Reply-To: <20251016004613.514-2-richard.weiyang@gmail.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: y59eLWtEA6grPrRGtCRlVDa1hnWeyOzFIKF-BAwxL6o_1760644867 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam05 X-Stat-Signature: erd4u34fdnkj3jtera54wa8m33enthss X-Rspam-User: X-Rspamd-Queue-Id: A774440005 X-HE-Tag: 1760644870-683461 X-HE-Meta: U2FsdGVkX1+C7WhGoC+k9islzGvQ8xaEs1hRKzDkEYaERmymqgDpDQDofyRovCusqfGgItgqJaXBaZK8bmC0YHNR5ywxWOuB5ugEb/Q2pzbfNe1cbUmPgzVzqVmaBvO/kFT0NGrMqrk4XIckxdHd+HhKb3/swzg+gWEFhzMiKfpWMoC5LZiX2dcXs9ewPkUbaR5w8Bq5UyDNduFQVcB5alDUHXIYm2aVOc0o7P/UciR2ZJCUN8Pyo6vp4Sq/ssFSxq7E+LwXyvE7TghVJ8kE9msbBPLOP0dTo1hw+JLett9WLxzkdp3UAMRYSGa7LRgZTGJaxlQ96xWGBdryhAyueIHWO46qnqptuKJGeT3ofg7hF3rJLrMVtQcebo5aQ6wXi2OQgZZoP+H1T3elz17FNHHd0HdrYjYXCf9YqSuw1656B28m3rBbDoGrz6ysGQCpZv9MurD1+M//bpUxroxmt9S/rmQdPuuZk1kPG3cfD1BY8PurfB08lNgdZrx8is47f8cjeR2dRPBax1xax1zSynrwk3Xmrhs58qnH1ZuyX+6mki6mrOD5JHa+mq7Lo/KJJ/z9yHVIotDb2gviWjFUCrVkGqlEbAYVig8UP5Z0gNuy6nqgy5WGodl8PKjH/y7+ssg6jrHN6mLmNfwOVBnWCVvLJY6+xU0oS1fIykOsROzXOgVo5aZuyfEoCfvD1PDzm3Q0M3WHKM4GjnhIO43jEmoUA49Az0qoxmuUEDRUUdzIC/624Cay/8IVhIpSFvdgwZMdxP9oL8PVC6/7dWjohUGPJDQU6x9rFquIoFe2xx7LWzwhJF//ZhCM/1YHMq0ge9DAhMk3x67zDOBGjxywWnYIKxU/+itNxW0lgX+Af8L22767dfzPBy8ZZjJjnmwe7ybXWihTxW0W5s/hAqm6z2TOpLYvQutygMoEKiSdihybCQGTf0HY6foagytRTV73pbtAKktLm+ujgAzgPHQ bOOJdc7y MQKr+vLH+ckzHgfBAtEu7xf8At9px+8ETHRGkirdwOHMQM9Ej6qkjr9oZ44DUt8QCW3PFMJP9WjVA8dgvG91XE55Z3P/kDrWiJtF9LabEMyJSBfBWM0DaGkEOQsPO3N2retveEi3ToqWgT3LAwDORxErrWwY0g8Uyh3o9J5ztExmTqkCVaFqzlbUhCO4qHHuPFs9lszklpGiVFcWUCnla8HTuRWje7l1Dcist/WAgB8NkIr+kbh+thYELSu5sdZQyFabR+V1Gwg0AOYgDGRQ5r0vhXKrIp6f68eEOMEv/AFTyP46HUGKi1lC7t5yeMm+hcY3Zab1dYWoaxpVrWIrrR23lzGBnghZElndQXgG51qsFf61fsyQq0TDk0CrQvMJpnAGX18wsx4fIOAP52gsdtA2Ik14LexJYTgIk+9VvEAF7w7hVXqPOOq2d0fdWF/tVQWd5GxksZz/9rgbIE1wsSOGnt8MFOIwExmS3Ycm39z+i2UkTUjSDjl9PLSzq4h2ZtPaj8+YAOy17zskwXR7IOZkz1PY/+HNjs5jHE6DO1IQME+kFglaTogkBtkkCzDqEFiiUhy/wS4GfeYI= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 16.10.25 02:46, Wei Yang wrote: > During the execution of __split_unmapped_folio(), the folio's anon/!anon > attribute is invariant (not expected to change). > > Therefore, it is safe and more efficient to retrieve this attribute once > at the start and reuse it throughout the function. > > Signed-off-by: Wei Yang > Cc: Zi Yan > Reviewed-by: Zi Yan > Reviewed-by: wang lian > --- > mm/huge_memory.c | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) > > diff --git a/mm/huge_memory.c b/mm/huge_memory.c > index 3c74227cc847..4b2d5a7e5c8e 100644 > --- a/mm/huge_memory.c > +++ b/mm/huge_memory.c > @@ -3527,6 +3527,7 @@ static int __split_unmapped_folio(struct folio *folio, int new_order, > struct page *split_at, struct xa_state *xas, > struct address_space *mapping, bool uniform_split) > { > + bool is_anon = folio_test_anon(folio); Can be const. Acked-by: David Hildenbrand -- Cheers David / dhildenb