From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B869FC3065C for ; Tue, 2 Jul 2024 20:25:50 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3F74E6B008A; Tue, 2 Jul 2024 16:25:50 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3A6DD6B008C; Tue, 2 Jul 2024 16:25:50 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 247CB6B0092; Tue, 2 Jul 2024 16:25:50 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 0442E6B008A for ; Tue, 2 Jul 2024 16:25:49 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 7CAABA1ECB for ; Tue, 2 Jul 2024 20:25:49 +0000 (UTC) X-FDA: 82295943618.29.7DFAD5A Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by imf20.hostedemail.com (Postfix) with ESMTP id 0837E1C000D for ; Tue, 2 Jul 2024 20:25:46 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=tq+Q3qFX; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b="lpCn2Hr/"; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=tq+Q3qFX; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b="lpCn2Hr/"; spf=pass (imf20.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1719951925; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=0yB16rVp9eY/YSMS3lLlCWH9q42cwgJDJXfiM1UZGlg=; b=kdlZq82lfbMXcQCSo5Jup9ZQLmiJzgv5WSssHAQP62jC11fY7GaLLlG0i2LzvnkodLRsyk as0GkyC3Rxvm8x5GyXzTaTm1HCwZ90UUNFZNDfLp6feND3E2g9sPutQvFJNEXVBU/My4+G mLh6+0eUX9Z5hXBQ9r7CSIGufbeHOGY= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1719951925; a=rsa-sha256; cv=none; b=Ub5j9sNeDIdFvfiMnf3ftCw6IOIC8guNAHHjXBjKd8X/eJNvOBjM/BlmU1dV9pN6hFiOap MS4PhkW+c4D7nagVaYZBZo5Xao7mSNj2jW18Q9ph1y15EzLVXyp7MxXi9Dq6xdZzPg1FeX 3ZRov44eL3/x56T01Lmr/2m9A16cDRg= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=tq+Q3qFX; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b="lpCn2Hr/"; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=tq+Q3qFX; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b="lpCn2Hr/"; spf=pass (imf20.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 409E81FBDE; Tue, 2 Jul 2024 20:25:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1719951945; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=0yB16rVp9eY/YSMS3lLlCWH9q42cwgJDJXfiM1UZGlg=; b=tq+Q3qFXjL4sJLNr4yI+OVzDiXtqQAHLeq4iyoFYM2+K6/KoqIeI9HiNOXzoZ9HdRaHAlV x0LEThpbwOGIUYNpZLvvESORGCH2rpOgT8M9bIgTLDxcOmh98jGFPju08CYjwwK0v1Jz1F BbasFg6YQfWpoUzjq7aiNdWBw1Gsbd4= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1719951945; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=0yB16rVp9eY/YSMS3lLlCWH9q42cwgJDJXfiM1UZGlg=; b=lpCn2Hr/IJ4pnPff7/wD+G+7OAffBjsRzvkX7Kdu0O94XUY+qBgpLRqA+Cs3yAygtWyj7k DBzTCdDl0nUZ9lDA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1719951945; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=0yB16rVp9eY/YSMS3lLlCWH9q42cwgJDJXfiM1UZGlg=; b=tq+Q3qFXjL4sJLNr4yI+OVzDiXtqQAHLeq4iyoFYM2+K6/KoqIeI9HiNOXzoZ9HdRaHAlV x0LEThpbwOGIUYNpZLvvESORGCH2rpOgT8M9bIgTLDxcOmh98jGFPju08CYjwwK0v1Jz1F BbasFg6YQfWpoUzjq7aiNdWBw1Gsbd4= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1719951945; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=0yB16rVp9eY/YSMS3lLlCWH9q42cwgJDJXfiM1UZGlg=; b=lpCn2Hr/IJ4pnPff7/wD+G+7OAffBjsRzvkX7Kdu0O94XUY+qBgpLRqA+Cs3yAygtWyj7k DBzTCdDl0nUZ9lDA== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 26BD613A9A; Tue, 2 Jul 2024 20:25:45 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id Wz/JCElihGZBewAAD6G6ig (envelope-from ); Tue, 02 Jul 2024 20:25:45 +0000 Message-ID: <1ca7b081-c1f0-45a3-b901-39c503368f43@suse.cz> Date: Tue, 2 Jul 2024 22:25:44 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm, slab: extend kmalloc() alignment for non power-of-two sizes Content-Language: en-US To: Roman Gushchin Cc: linux-mm@kvack.org, David Rientjes , Christoph Lameter , Hyeonggon Yoo <42.hyeyoo@gmail.com>, Kees Cook , Alice Ryhl , Boqun Feng , rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org, patches@lists.linux.dev References: <20240702155800.166503-2-vbabka@suse.cz> From: Vlastimil Babka Autocrypt: addr=vbabka@suse.cz; keydata= xsFNBFZdmxYBEADsw/SiUSjB0dM+vSh95UkgcHjzEVBlby/Fg+g42O7LAEkCYXi/vvq31JTB KxRWDHX0R2tgpFDXHnzZcQywawu8eSq0LxzxFNYMvtB7sV1pxYwej2qx9B75qW2plBs+7+YB 87tMFA+u+L4Z5xAzIimfLD5EKC56kJ1CsXlM8S/LHcmdD9Ctkn3trYDNnat0eoAcfPIP2OZ+ 9oe9IF/R28zmh0ifLXyJQQz5ofdj4bPf8ecEW0rhcqHfTD8k4yK0xxt3xW+6Exqp9n9bydiy tcSAw/TahjW6yrA+6JhSBv1v2tIm+itQc073zjSX8OFL51qQVzRFr7H2UQG33lw2QrvHRXqD Ot7ViKam7v0Ho9wEWiQOOZlHItOOXFphWb2yq3nzrKe45oWoSgkxKb97MVsQ+q2SYjJRBBH4 8qKhphADYxkIP6yut/eaj9ImvRUZZRi0DTc8xfnvHGTjKbJzC2xpFcY0DQbZzuwsIZ8OPJCc LM4S7mT25NE5kUTG/TKQCk922vRdGVMoLA7dIQrgXnRXtyT61sg8PG4wcfOnuWf8577aXP1x 6mzw3/jh3F+oSBHb/GcLC7mvWreJifUL2gEdssGfXhGWBo6zLS3qhgtwjay0Jl+kza1lo+Cv BB2T79D4WGdDuVa4eOrQ02TxqGN7G0Biz5ZLRSFzQSQwLn8fbwARAQABzSBWbGFzdGltaWwg QmFia2EgPHZiYWJrYUBzdXNlLmN6PsLBlAQTAQoAPgIbAwULCQgHAwUVCgkICwUWAgMBAAIe AQIXgBYhBKlA1DSZLC6OmRA9UCJPp+fMgqZkBQJkBREIBQkRadznAAoJECJPp+fMgqZkNxIQ ALZRqwdUGzqL2aeSavbum/VF/+td+nZfuH0xeWiO2w8mG0+nPd5j9ujYeHcUP1edE7uQrjOC Gs9sm8+W1xYnbClMJTsXiAV88D2btFUdU1mCXURAL9wWZ8Jsmz5ZH2V6AUszvNezsS/VIT87 AmTtj31TLDGwdxaZTSYLwAOOOtyqafOEq+gJB30RxTRE3h3G1zpO7OM9K6ysLdAlwAGYWgJJ V4JqGsQ/lyEtxxFpUCjb5Pztp7cQxhlkil0oBYHkudiG8j1U3DG8iC6rnB4yJaLphKx57NuQ PIY0Bccg+r9gIQ4XeSK2PQhdXdy3UWBr913ZQ9AI2usid3s5vabo4iBvpJNFLgUmxFnr73SJ KsRh/2OBsg1XXF/wRQGBO9vRuJUAbnaIVcmGOUogdBVS9Sun/Sy4GNA++KtFZK95U7J417/J Hub2xV6Ehc7UGW6fIvIQmzJ3zaTEfuriU1P8ayfddrAgZb25JnOW7L1zdYL8rXiezOyYZ8Fm ZyXjzWdO0RpxcUEp6GsJr11Bc4F3aae9OZtwtLL/jxc7y6pUugB00PodgnQ6CMcfR/HjXlae h2VS3zl9+tQWHu6s1R58t5BuMS2FNA58wU/IazImc/ZQA+slDBfhRDGYlExjg19UXWe/gMcl De3P1kxYPgZdGE2eZpRLIbt+rYnqQKy8UxlszsBNBFsZNTUBCACfQfpSsWJZyi+SHoRdVyX5 J6rI7okc4+b571a7RXD5UhS9dlVRVVAtrU9ANSLqPTQKGVxHrqD39XSw8hxK61pw8p90pg4G /N3iuWEvyt+t0SxDDkClnGsDyRhlUyEWYFEoBrrCizbmahOUwqkJbNMfzj5Y7n7OIJOxNRkB IBOjPdF26dMP69BwePQao1M8Acrrex9sAHYjQGyVmReRjVEtv9iG4DoTsnIR3amKVk6si4Ea X/mrapJqSCcBUVYUFH8M7bsm4CSxier5ofy8jTEa/CfvkqpKThTMCQPNZKY7hke5qEq1CBk2 wxhX48ZrJEFf1v3NuV3OimgsF2odzieNABEBAAHCwXwEGAEKACYCGwwWIQSpQNQ0mSwujpkQ PVAiT6fnzIKmZAUCZAUSmwUJDK5EZgAKCRAiT6fnzIKmZOJGEACOKABgo9wJXsbWhGWYO7mD 8R8mUyJHqbvaz+yTLnvRwfe/VwafFfDMx5GYVYzMY9TWpA8psFTKTUIIQmx2scYsRBUwm5VI EurRWKqENcDRjyo+ol59j0FViYysjQQeobXBDDE31t5SBg++veI6tXfpco/UiKEsDswL1WAr tEAZaruo7254TyH+gydURl2wJuzo/aZ7Y7PpqaODbYv727Dvm5eX64HCyyAH0s6sOCyGF5/p eIhrOn24oBf67KtdAN3H9JoFNUVTYJc1VJU3R1JtVdgwEdr+NEciEfYl0O19VpLE/PZxP4wX PWnhf5WjdoNI1Xec+RcJ5p/pSel0jnvBX8L2cmniYnmI883NhtGZsEWj++wyKiS4NranDFlA HdDM3b4lUth1pTtABKQ1YuTvehj7EfoWD3bv9kuGZGPrAeFNiHPdOT7DaXKeHpW9homgtBxj 8aX/UkSvEGJKUEbFL9cVa5tzyialGkSiZJNkWgeHe+jEcfRT6pJZOJidSCdzvJpbdJmm+eED w9XOLH1IIWh7RURU7G1iOfEfmImFeC3cbbS73LQEFGe1urxvIH5K/7vX+FkNcr9ujwWuPE9b 1C2o4i/yZPLXIVy387EjA6GZMqvQUFuSTs/GeBcv0NjIQi8867H3uLjz+mQy63fAitsDwLmR EP+ylKVEKb0Q2A== In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 0837E1C000D X-Stat-Signature: czrd5t6nk1ojhn96hxx4dpwzxiwsnt89 X-Rspamd-Server: rspam09 X-Rspam-User: X-HE-Tag: 1719951946-711499 X-HE-Meta: U2FsdGVkX19YeDotodfP+kr7Ti2aOYyG3XqC+jPFWOCBAUDm9pSWFrc4xpWwtj9EI2YdpCWFUuK8QNqdPbp230tgB5jP/M/bZoNy6mXa866SA2ibrGmH1k5g/aaqi/sGoDkOlbxJYhmhpU1d/YPD0/civxQdeiHfUfYePfoOpjRY79dwVyPNEgKve7QbdYKNme/U45FlXKXhpVK229Zyr0h9sVSgmGwy9VLbt9Pe4IJ9ETdHQDQyOCEzAwrthIR5wbwioOFZzLsx9NIP3XCSJINcz2RIlNnMaABavCUQ+yS9R6rS4Tio1MYL+71X8ceYfOrE5Tbpog2h43Dq9/ojNb3zmlEX/GY12qKMrPwy2jpbRqs3tA8oEA+ZcKjRgBAJJeHkKijk9H8jK1jV2prGepnGm2AKdJLqaE7ru+uHdjA8GVFkyzHVkUyv63E8PdRZ8jkwnYvOwqkN3wl1Ie8f4e/XvZJroInhnOJqTE+WmUnGZX+dpO4OKHlOg5FiPXwFsB4Ec314eQMvcK7FXQ2k9d1Rm9v6cG604ApMdclLSI9iCTNbL0RlnYiJU0KD+D4wzuGyUuVHuxXsoyXcMV9kSHy3NfpCy9+Ci3CoIhFPu4qeSekexxa7P9Shdzi1oyMwN6jl8aiwIr2GSftf86jZfgiiWiLhpJHO3F268PX0fdzu/T2YI+heoUCqFatZ1DEkuCPIBNmG4EQyvF3c9nwrELM7ERKCrTOUkUwWz4PN9/djLjjjfSUz3GxX5uGNoi/rErOnhCTS94zGCIsUO01UBSochqRK5Wg+wuRkzvn9wsTO3I4Il6IdtPlfZDq8kFzrb5SyLiv95po7h3I7ZGF19OuYlkuMzIoGDdGGMiQSLm+vyqY1GAiDWLrYldpQSJvbnPGcZeC76Vtjx1q6ipRAnDRzvC6RFbX0weaQXRQFseIjSwWxAjre+tNBfF81yXeuZX+CQAqEDxcLNqLa4FB WplFN0hN mC+DMvDnD5HbD51PWtPV4i5r15J3Yze7o3Aqu21PFq563Jy7L1lFiX5r6K2V3sfQGFD38cP4wt1HkBIqZ9Hd5B3j4//bd4GM8Phsh5SVccRrBK7HSJibySYnigGNDnIsf7gAhUqasiw6E7tOEBM2lDRNHG5UPMFY47W0DZ/T/9KlZhW68SSc8zhcaCounzE9t2XL+v0+s1fzPta8OJ38BnNN9h2M6fTMOQDUGhP5eghQbn/olEZg4IOCxjJrY9ewDoCMvL78yzFoyegB/JysT3xP0kn4nl0XQFlYU80MZPTy6aoCGcwgqF+QYYRxkJID1wSkA2AIVKOYKPrw= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000021, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 7/2/24 9:30 PM, Roman Gushchin wrote: > On Tue, Jul 02, 2024 at 05:58:01PM +0200, Vlastimil Babka wrote: > Hello Vlastimil, > > the idea and the implementation makes total sense to me. > > Do you have an estimate for the memory overhead it will typically introduce? There's no new overhead for the non-debug case as the layout already naturally has the same alignment as is now guaranteed. Debug has its own overhead so it's enabled only when needed, and this will not add much more. > I don't think it will be too large though and actually can be compensated > by potential performance gains due to a better memory alignment. What do you > think? Yeah but again, the difference would be only in the debug case and performance gains there are not so interesting :) > Thanks!