From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 08A56C27C55 for ; Mon, 10 Jun 2024 14:34:05 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8B6956B0088; Mon, 10 Jun 2024 10:34:04 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8663E6B008C; Mon, 10 Jun 2024 10:34:04 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 706046B0092; Mon, 10 Jun 2024 10:34:04 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 50E396B0088 for ; Mon, 10 Jun 2024 10:34:04 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id E6265C1004 for ; Mon, 10 Jun 2024 14:34:03 +0000 (UTC) X-FDA: 82215223566.25.E992134 Received: from mail-ej1-f53.google.com (mail-ej1-f53.google.com [209.85.218.53]) by imf30.hostedemail.com (Postfix) with ESMTP id E5EDC80005 for ; Mon, 10 Jun 2024 14:34:01 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=BcIsimVU; spf=pass (imf30.hostedemail.com: domain of usamaarif642@gmail.com designates 209.85.218.53 as permitted sender) smtp.mailfrom=usamaarif642@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1718030042; a=rsa-sha256; cv=none; b=7EgaEiKOX2/E6xLC9LJOFKipkDzehHd0/gRsE6FdycbfOoccRX5QGILigdVvXCvRVkCAQK sriG817HZ6ERZ7nYK1dcKPK2j9quuqh4dF7uLH++vGXpDB2IAfGdbbZV33hqnNU53gW9C8 JduV8Pnb6XYTO5QNYu1CJbsJfcabxPw= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=BcIsimVU; spf=pass (imf30.hostedemail.com: domain of usamaarif642@gmail.com designates 209.85.218.53 as permitted sender) smtp.mailfrom=usamaarif642@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1718030042; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=E3GG5XXobvKjAZfA7PiVHtxRsMACN+t5KN+R+O7yXqM=; b=W2wzUyzwv/ybbxrqEDE/AGDEytjTWoEkFouKBG1ztnaL1JoMd/eg9npQE1igPgJ0kcs3eI ZFq8E2NOJT4BkBtuHZ0MEzgnCXMw09kA2inRrC/zbMXvCd+7KxBX/iqM51iR8b+g9vvOjN eSmdGK+ILgNcRhJeiLj4JGn2Vuq/U+8= Received: by mail-ej1-f53.google.com with SMTP id a640c23a62f3a-a62ef52e837so582966066b.3 for ; Mon, 10 Jun 2024 07:34:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1718030040; x=1718634840; darn=kvack.org; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:from:subject:user-agent:mime-version:date:message-id:from:to :cc:subject:date:message-id:reply-to; bh=E3GG5XXobvKjAZfA7PiVHtxRsMACN+t5KN+R+O7yXqM=; b=BcIsimVUo9t1XQHC6DD/fKS6+HU8JeNMnYAQpwRa3v+Fvz+GNX1TE/VUjRBAUzfuBg a+C+/juZ58gZhADKPkDJ34k2rN97vKSWiTBTc56aimm8qOLnxSyxvHDcw+V6rhXtHTu8 sad8/u/DJqXB5YUpAArLOD6buGQbO5b+7YEgpdW4EgOOJ/8gkfxNNbTcRencFPyCiFNq sa89PgWic1rolfBXkPQzHC2K/GWpOFmOLkMIuKEWs8+mX3rUQqDPGEZ6Icosy1Uu7VjY QyTohyD+DsD7xWpr1NG2faAc/UzmmrZKV1NOmn4W5cxJofAQvrzahyIJV+rP6l8PP44S OY8g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718030040; x=1718634840; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:from:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=E3GG5XXobvKjAZfA7PiVHtxRsMACN+t5KN+R+O7yXqM=; b=B1Jt4Wn1eUH7JNCGgNRUKKIFgiZiZ12yAv7KwKvUoEf9wbf7G+CS4xZEm3AWVhgX+P X5CVMN0EmgEmpyPMQFVF/IVf2KCg4V9M68NU+WCVByOYpfHBUS9l3s6My3AOva30bwvH 742zDWOn04XnSuF8Ts4vXUEfmXzZsrOHcvGQXnMpAi3Iog8qTVDZ2/4JfhT4mu8pOxki rzWK6Jguc8/7Wx+XYxbNxHcxczAO8diG6xo8egdxRVSGB4VCgduLtqpPgihs3XO0Zh2j lLzZ5CwTvYGc6PAd1oPdSYhrAAADVa7d6z0XYKvH/vALvinwWyvDC4ODcAMtWaZmfYuJ qU8g== X-Forwarded-Encrypted: i=1; AJvYcCXtKt04MTMv7UeTJk6HhDNYJRfdy9xY0ZC/8YpC7Y1wCXyFI4z/r0tnHZXQDhQEuUGVGWp+n1j3hxWBfp+95S15QOE= X-Gm-Message-State: AOJu0Yz4RHU53SPUqPa7SSSIxbNHoMeS8nDYja7WBMhxCYPhTV0TB7Bl rG0OKIp1BSnrkmXVl0k7bF0Plld8IO4G6TLYCeN3/8VfxZ4Icp+k X-Google-Smtp-Source: AGHT+IEXptukpboZLCf6DOn3vAUsLYvh18GiqGT8z6pVfXgmN374h/RR/lx3N7wpxf43P9IJYFrXzw== X-Received: by 2002:a17:906:3e09:b0:a6d:ff12:5bd1 with SMTP id a640c23a62f3a-a6dff125c77mr503625766b.41.1718030040172; Mon, 10 Jun 2024 07:34:00 -0700 (PDT) Received: from ?IPV6:2a03:83e0:1126:4:eb:d0d0:c7fd:c82c? ([2620:10d:c092:500::7:493]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a6f01a060dcsm337538366b.182.2024.06.10.07.33.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 10 Jun 2024 07:33:59 -0700 (PDT) Message-ID: <1ca65f97-572a-412a-b6fa-b1e811592094@gmail.com> Date: Mon, 10 Jun 2024 15:33:59 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 1/2] mm: store zero pages to be swapped out in a bitmap From: Usama Arif To: Matthew Wilcox , hannes@cmpxchg.org, yosryahmed@google.com, nphamcs@gmail.com Cc: akpm@linux-foundation.org, david@redhat.com, ying.huang@intel.com, hughd@google.com, chengming.zhou@linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org, kernel-team@meta.com References: <20240610121820.328876-1-usamaarif642@gmail.com> <20240610121820.328876-2-usamaarif642@gmail.com> <2d52b1a5-4c44-4cea-bccf-57972ca79f04@gmail.com> Content-Language: en-US In-Reply-To: <2d52b1a5-4c44-4cea-bccf-57972ca79f04@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: E5EDC80005 X-Stat-Signature: 9ogdecddi4539z9jpd8y3cgdojsugjid X-HE-Tag: 1718030041-412258 X-HE-Meta: U2FsdGVkX1+ggZxbzeUQUJaftjJ9z8CWIN/KS5kYQZb4gUyvRoq5pENWG6TT30lxVkMOrnXGYRRhgohz25X3AeScXoP1aKDQJ7XY3oP0yka76XcEADxYywGD5B7YSqhTaej+LVUBubOn6zEvozSnXhcr+vFhxOAcHmmdj+gUTQka9SIyMCebgLZ7yaXtnZdLFAxzICC/ZFKY53f1ATPmNmvzqGQ1bCWou2Hm5JqAhiqwPNcb70QIEHfW4TZd1cQqFEgbqXCUG+vcyjHXcfLIEw0zcexDT640H0L80lHr7+qOnRAeItUnEkIjCKr58+etn9gmxNxFQvGMQ0/rnDTvwmXiCjzrv+86GRXvQZwj6qgPRG/8+/6Pl8Jcgi5I467FBroovx7mUtLWa9bnkhwkh0cbGtIX7Vm3iW2LB9DfKopGDKvxklvTgiussZq0pNKTutOvqlPti9nBTVw2vf1kSJBvnga6fGWGuHdIamgMHnrQ5cDUdnTJNE3vGG05kxNhwTD/hxFtIZUbWBPclkrFFPMlBQz3L+BraQU9h3JJXOIBquA7LEzCcCSTKcRwprZuXjahBcfsVCHekJvz1ufUuByXIePN7XRwT0ltRCzR8mVD+kN+wmJmZYyLQdgiF07305Kf4L1/M6hAB86I0JOZHGvGOuI5hSBq9aAHM1LqFthldYOlWFgh1COhaae132bO6FRqq4abvkxUQv1bSCQV1FwqOc0PBF/3fKey+DUCUX2sd1eZXS6e/HZhf1gTa5EMFy8nfjda6+DeC4/+a4ME0TECOf3+W/hx0kVJgP+cKMc8KuaM8028x0l9EZd4e1YXV2ZhwYTMR301xSbQKSihMf2XQGAbruGx0m7a2XJ+DwPun4vFptQeCfR7KeWQEgNeH/2QpHu36C0dz66/1gcPnYoTyiU2LPh96Jg+PejT9uch5KvsX7zXWIpUJ3feXFKTkO7lj6rf85K1kEYe+sO BIXs3wYY 5KZVFZB1bk27BWwJZuNRsez6dY8EAPPT7aLBopxrKjQTnndTFEakXYgflvutlL3GDzQGbjlvCW99x1q6EHDCmUqEK+vrFMmtPHSoIZvU0/TgYWb9xxDdM5EmQgWYiWgOpP6amKQGo1IYP1R9qCAfv6ykJ/mUlNfDsGxzw3y5CW4TX/AStOQ4uT8D78epjyGZ9gT9vQ56CFCUjnFQQwd6nJB5byBGbJ/ib3UhQK5PawYSGC6JZ2AqgtE3APxGyzzLThNGqcyriDSlBxMoCCrfRunz/EJZREg1oIJk/ks3B6R7Bhc2rvYFAt29J+XFXPzRTh3GqJVYLE0Ij5PfYqMJadSTMrhFrMye/CcNC0Kvx7+R21qme7LXI0/GqVSHmG4QFhHuaA4U8Obk0JhOF03CUzc/s2yKlK4wz5+LF71fKgMvF8b480JYp/gQyjQGDauMxm6Y3nlNF/fd99v6K31MSUHdkEUzBQTBqDgTTftf90mXhWKVVfetXnMoD4o9ltK1Pdj2/1HIRHdHWvz1eik3igdhwNaXJkP3t8goUCW9MR4MvZrwMcubPBxVXuSlT8OqZeCE6QEsU/kmQcEzUj2FlfPPJrQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.018529, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 10/06/2024 15:14, Usama Arif wrote: > > On 10/06/2024 15:06, Matthew Wilcox wrote: >> On Mon, Jun 10, 2024 at 02:56:09PM +0100, Usama Arif wrote: >>> I am guessing what you are suggesting is just do this? >>> >>>      if (is_folio_zero_filled(folio)) { >>>          swap_zeromap_folio_set(folio); >>>          folio_unlock(folio); >>>          return 0; >>>      } >> Right. > > Thanks! Will change to this in the next revision. > >>> If we have zswap enabled, the zero filled pages (infact any page >>> that is >>> compressed), will be saved in zswap_entry and NR_WRITTEN will be >>> wrongly >>> incremented. So the behaviour for NR_WRITTEN does not change in this >>> patch >>> when encountering zero pages with zswap enabled (even if its wrong). >> We should fiz zswap too. >> > Will send the below diff as a separate patch for zswap: > > diff --git a/mm/page_io.c b/mm/page_io.c index > 2cac1e11fb85..82796b9f08c7 100644 --- a/mm/page_io.c +++ > b/mm/page_io.c @@ -281,9 +281,7 @@ int swap_writepage(struct page > *page, struct writeback_control *wbc) } > swap_zeromap_folio_clear(folio); if (zswap_store(folio)) { - > folio_start_writeback(folio); folio_unlock(folio); - > folio_end_writeback(folio); return 0; } > My mail client seems to have messed up the diff, but have sent the patch here (https://lore.kernel.org/all/20240610143037.812955-1-usamaarif642@gmail.com/). Tested with test_zswap kselftest.