From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D9BE0C54E64 for ; Thu, 28 Mar 2024 13:30:51 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0AF316B0082; Thu, 28 Mar 2024 09:30:51 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 05EB26B0083; Thu, 28 Mar 2024 09:30:50 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E419C6B0085; Thu, 28 Mar 2024 09:30:50 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id C0D4A6B0082 for ; Thu, 28 Mar 2024 09:30:50 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id EC1D7A1029 for ; Thu, 28 Mar 2024 13:30:48 +0000 (UTC) X-FDA: 81946532976.29.56FECE6 Received: from szxga07-in.huawei.com (szxga07-in.huawei.com [45.249.212.35]) by imf05.hostedemail.com (Postfix) with ESMTP id A829A10004B; Thu, 28 Mar 2024 13:30:42 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf05.hostedemail.com: domain of wangkefeng.wang@huawei.com designates 45.249.212.35 as permitted sender) smtp.mailfrom=wangkefeng.wang@huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1711632645; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=hbagkwfpI2q7R/dlkf187Qdl5TV6yoA6kUyac7nl7V0=; b=oxukNq3yZVk48xat7ZJ0/eQLtWt8G9uv6yWd10tHJhvqNwEjQ9wbVfECWJBxADrLmkYMSv dFU57A14E5WhneKGp9vkTrISE/C0Bjalmw8nkGqH+FX2NerydH5P+TnDQi39hlBebSjCO1 PR2XpSKdTko2a5ddHTuwlwptG9MdnRs= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf05.hostedemail.com: domain of wangkefeng.wang@huawei.com designates 45.249.212.35 as permitted sender) smtp.mailfrom=wangkefeng.wang@huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1711632645; a=rsa-sha256; cv=none; b=VEXLgKii58ARsGclOWkzda7GrayEYUZWgSOXV6VlBokS02PGrD7Jq6nfw0ydU7iO3ry46H kcGvkrcIwlhwEgFzAiq4RK0+X+3BINW/wpRAYuvTc31S+WUXSxhyIdOHkup6CajSJx2767 VkJYv7zMJZnfIyBA/L//kVRAUnABw+Y= Received: from mail.maildlp.com (unknown [172.19.88.234]) by szxga07-in.huawei.com (SkyGuard) with ESMTP id 4V549834nCz1R7yM; Thu, 28 Mar 2024 21:27:56 +0800 (CST) Received: from dggpemm100001.china.huawei.com (unknown [7.185.36.93]) by mail.maildlp.com (Postfix) with ESMTPS id 4BCD2140258; Thu, 28 Mar 2024 21:30:37 +0800 (CST) Received: from [10.174.177.243] (10.174.177.243) by dggpemm100001.china.huawei.com (7.185.36.93) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Thu, 28 Mar 2024 21:30:36 +0800 Message-ID: <1c8b52d2-485f-4972-aa46-0493b18186f9@huawei.com> Date: Thu, 28 Mar 2024 21:30:36 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 00/11] mm: migrate: support poison recover from migrate folio Content-Language: en-US To: Andrew Morton , CC: Tony Luck , Naoya Horiguchi , Miaohe Lin , Matthew Wilcox , David Hildenbrand , Muchun Song , Benjamin LaHaise , , , , Zi Yan , Jiaqi Yan , Hugh Dickins References: <20240321032747.87694-1-wangkefeng.wang@huawei.com> From: Kefeng Wang In-Reply-To: <20240321032747.87694-1-wangkefeng.wang@huawei.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.177.243] X-ClientProxiedBy: dggems705-chm.china.huawei.com (10.3.19.182) To dggpemm100001.china.huawei.com (7.185.36.93) X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: A829A10004B X-Stat-Signature: fd6chcxzymr9ezaz5uarxywzowy3zqxw X-Rspam-User: X-HE-Tag: 1711632642-663236 X-HE-Meta: U2FsdGVkX180ldoONgsZSUI9WGUrjvjaRlrIo9l16XbRZAwW2tTy72lDTfFaUUCv8C9kMep1wF6IhG6/4lTIM6O6lat6fZmNYv2tZn7APyXSh3zD3KzDoBBIuAXmaRsTKnmk97GeURWcdRvI8UA25ebAQWxz7MYxhWYObaW7oLLSZHW1w4EwiLaTDSA8NwlFDqdzCqY05hNMV0C+7ZCn19npJs1jM3VDJyCDO0YzsqCfa78b6CuDkzXY21/oz8vpc3iK068BXVV/zfDZV/OJ/M4ov9ni4hV/CvfJrm1Yv7aKUFpcjgwnqH0jxp2oFTsTSNFcg7846+JO4tAswphuP2xGFIRwH2kZuR8Es7sR5xkq5+2zoKR9DkNQ2oIFEq44871FW+7D/GwwJnpnxyvI9W4KXuxv2s346l2lcmD3/J2OGkQFYV5VUyNDWevTafAWZe6wIM5Qy1OGSSI0P+fMZe8/eJJUoAzmOtsCUyDz7w6Zf7HyZtqGxwJxA+k+8yDdw+mQ17HohF9zLpuvuOcjts3DrEwHrclccBZUUSGEFQSCeJ08Tuq4bvkYxKZSffmvL2Xhra0sxbSDkXWzVhgp9Be8ytApPht+7gz4OzVWMkM5RYYuv5HC5iRCau/m0lk3wCKCLuQCPAQiosTSovSy/nAyfvIwoB2zoXMgiQV4lvvoQiFYNBZo7Y1CbPs1BlOYIwhyZkiV7/O2DYiwFywNqGLeY8A2z5MkXL7fBaRbYr5XvITblYUcLMg+NIsZrv5SjGNYfVuDoUVnOQ/YSiUDajz0eB+1Q67sXfaWYU6c4mbscg1znHnUkC2WwrJe4If8ScChY+lfzm/MlbZ8zIoLP+WtFNA3YPQpM3K+vA6MeZpJ4GQO9GOnfePypXEwWIqJOOXXO80qE2xexQpxqXDWbf4MaqOORfNllr0T7ICCH1hxN3ktU3/zngTZHoMQOXfSnssIEFuaW7zvbVENv2a OEE7WMMq 17JfQskZ4bvUoTBvU1s7l5TmJw8u3bb4NxR+EwuReik5G6Z2o9dt32ONGOtOBqXPQR5XKhE/ACZdu1n1egZrT61Vu25piOApkKn5lR17eUWz7l+ee5DfSUjb29iKrLM75hyJz2ZAURBb3NEQdkpqYJvmasbzUa/qxkzSlBLJJVVx2F+c= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi, since rfcv2, there is no more changes, kindly ping, any comments, thanks all. On 2024/3/21 11:27, Kefeng Wang wrote: > The folio migration is widely used in kernel, memory compaction, memory > hotplug, soft offline page, numa balance, memory demote/promotion, etc, > but once access a poisoned source folio when migrating, the kerenl will > panic. > > There is a mechanism in the kernel to recover from uncorrectable memory > errors, ARCH_HAS_COPY_MC(Machine Check Safe Memory Copy), which is already > used in NVDIMM or core-mm paths(eg, CoW, khugepaged, coredump, ksm copy), > see copy_mc_to_{user,kernel}, copy_mc_{user_}highpage callers. > > This series of patches provide the recovery mechanism from folio copy for > the widely used folio migration. Please note, because folio migration is > no guarantee of success, so we could chose to make folio migration tolerant > of memory failures, adding folio_mc_copy() which is a #MC versions of > folio_copy(), once accessing a poisoned source folio, we could return error > and make the folio migration fail, and this could avoid the similar panic > shown below. > > CPU: 1 PID: 88343 Comm: test_softofflin Kdump: loaded Not tainted 6.6.0 > pc : copy_page+0x10/0xc0 > lr : copy_highpage+0x38/0x50 > ... > Call trace: > copy_page+0x10/0xc0 > folio_copy+0x78/0x90 > migrate_folio_extra+0x54/0xa0 > move_to_new_folio+0xd8/0x1f0 > migrate_folio_move+0xb8/0x300 > migrate_pages_batch+0x528/0x788 > migrate_pages_sync+0x8c/0x258 > migrate_pages+0x440/0x528 > soft_offline_in_use_page+0x2ec/0x3c0 > soft_offline_page+0x238/0x310 > soft_offline_page_store+0x6c/0xc0 > dev_attr_store+0x20/0x40 > sysfs_kf_write+0x4c/0x68 > kernfs_fop_write_iter+0x130/0x1c8 > new_sync_write+0xa4/0x138 > vfs_write+0x238/0x2d8 > ksys_write+0x74/0x110 > > v1: > - no change, resend and rebased on 6.9-rc1 > > rfcv2: > - Separate __migrate_device_pages() cleanup from patch "remove > migrate_folio_extra()", suggested by Matthew > - Split folio_migrate_mapping(), move refcount check/freeze out > of folio_migrate_mapping(), suggested by Matthew > - add RB > > Kefeng Wang (11): > mm: migrate: simplify __buffer_migrate_folio() > mm: migrate_device: use more folio in __migrate_device_pages() > mm: migrate_device: unify migrate folio for MIGRATE_SYNC_NO_COPY > mm: migrate: remove migrate_folio_extra() > mm: remove MIGRATE_SYNC_NO_COPY mode > mm: migrate: split folio_migrate_mapping() > mm: add folio_mc_copy() > mm: migrate: support poisoned recover from migrate folio > fs: hugetlbfs: support poison recover from hugetlbfs_migrate_folio() > mm: migrate: remove folio_migrate_copy() > fs: aio: add explicit check for large folio in aio_migrate_folio() > > fs/aio.c | 15 ++-- > fs/hugetlbfs/inode.c | 5 +- > include/linux/migrate.h | 3 - > include/linux/migrate_mode.h | 5 -- > include/linux/mm.h | 1 + > mm/balloon_compaction.c | 8 -- > mm/migrate.c | 157 +++++++++++++++++------------------ > mm/migrate_device.c | 28 +++---- > mm/util.c | 20 +++++ > mm/zsmalloc.c | 8 -- > 10 files changed, 115 insertions(+), 135 deletions(-) >