From: Tim Chen <tim.c.chen@linux.intel.com>
To: "Matthew Wilcox (Oracle)" <willy@infradead.org>, linux-mm@kvack.org
Cc: Jan Kara <jack@suse.cz>
Subject: Re: [PATCH 1/2] pagevec: Allow pagevecs to be different sizes
Date: Fri, 6 Nov 2020 09:17:43 -0800 [thread overview]
Message-ID: <1c857e99-5985-5bc2-ca29-c77d612460fa@linux.intel.com> (raw)
In-Reply-To: <20201105172651.2455-2-willy@infradead.org>
>
> +static inline unsigned pagevec_size(struct pagevec *pvec)
> +{
> + return pvec->sz;
> +}
> +
> static inline unsigned pagevec_count(struct pagevec *pvec)
> {
Willy,
I was expecting pagevec_size to be used in pagevec_lookup_range*
where we hardcoded the pagevec's top range to look for pages
as PAGEVEC_SIZE. You define pagevec_size but seems like it is not used.
Or am I missing something?
Thanks.
Tim
next prev parent reply other threads:[~2020-11-06 17:17 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-05 17:26 [PATCH 0/2] Increase the size of LRU pagevecs Matthew Wilcox (Oracle)
2020-11-05 17:26 ` [PATCH 1/2] pagevec: Allow pagevecs to be different sizes Matthew Wilcox (Oracle)
2020-11-06 17:17 ` Tim Chen [this message]
2020-11-06 19:12 ` Matthew Wilcox
2020-11-06 22:18 ` Tim Chen
2020-11-07 1:21 ` Matthew Wilcox
2020-11-05 17:26 ` [PATCH 2/2] pagevec: Increase the size of LRU pagevecs Matthew Wilcox (Oracle)
2020-11-06 0:51 ` [PATCH 0/2] " Tim Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1c857e99-5985-5bc2-ca29-c77d612460fa@linux.intel.com \
--to=tim.c.chen@linux.intel.com \
--cc=jack@suse.cz \
--cc=linux-mm@kvack.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox