From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C03E8C369AB for ; Mon, 21 Apr 2025 05:16:57 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5AD0E6B0008; Mon, 21 Apr 2025 01:16:55 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 55C526B000A; Mon, 21 Apr 2025 01:16:55 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 423226B000C; Mon, 21 Apr 2025 01:16:55 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 25BFC6B0008 for ; Mon, 21 Apr 2025 01:16:55 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 70D8C1CFC80 for ; Mon, 21 Apr 2025 05:16:56 +0000 (UTC) X-FDA: 83356891632.08.0D84BCE Received: from out-171.mta0.migadu.com (out-171.mta0.migadu.com [91.218.175.171]) by imf02.hostedemail.com (Postfix) with ESMTP id 910A180006 for ; Mon, 21 Apr 2025 05:16:54 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=Kde8CY+a; spf=pass (imf02.hostedemail.com: domain of lance.yang@linux.dev designates 91.218.175.171 as permitted sender) smtp.mailfrom=lance.yang@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1745212614; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=V4O7CDAquGBCTH1tiwOC9eraJRYUQuQ5ReGibCOzzl0=; b=HOmfuFJtEvob/9ye7vdBtXHb2EidMz0Ilm2b60zeCKRT09SsepnkIxWQFSd78LJCGMSdp5 /wd8kJTytbCo1P5Fx4j2rqe4woUF0ODX93xfoiXrulrTvdPK8+K7Sfv/FWS13op5H3l1dT BXlDg38EMJa9lQIQ4yHwM5C5+jMdfQk= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=Kde8CY+a; spf=pass (imf02.hostedemail.com: domain of lance.yang@linux.dev designates 91.218.175.171 as permitted sender) smtp.mailfrom=lance.yang@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1745212614; a=rsa-sha256; cv=none; b=3q0IfocbDF/6rqRC1sCtcvyjBCGuH3P8s6DBf2N4zkfAV0mxvc0eZOdKQUSzkIrF+Rf/Pd V2DLWUJZsmi76dA62wqa3S68d0AGQ/pKJS4STqHMTqGeJPgstwFRvO4yvXyMyAyDhBAcQp 5ny2Pre2HyzttRoCGnNtRsLKEkRDZJ0= MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1745212612; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=V4O7CDAquGBCTH1tiwOC9eraJRYUQuQ5ReGibCOzzl0=; b=Kde8CY+aUjqemZ8mMv8sIYFX7XhfWT3GRsXUqStLU5wXG3xNdw6LgfIGgsfFCVKldO0OTO Mu/nHnj4lulDD1iwzaKdt7zHWuOKa1y/0kBK70sqgnmCm0kOqFMKUAc7/lU2UlXB8u/2mA wVFDUaXclW5F7wFkexcX2WQdIlNcz/g= Date: Mon, 21 Apr 2025 05:16:50 +0000 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: "Lance Yang" Message-ID: <1c81b176893c349dfb12feaebd17e0694fedec0b@linux.dev> TLS-Required: No Subject: Re: [RESEND PATCH v2 1/1] mm/rmap: add CONFIG_MM_ID guard for folio_test_large_maybe_mapped_shared() To: "Andrew Morton" , "David Hildenbrand" Cc: mingzhe.yang@ly.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, "Lance Yang" In-Reply-To: <641755b75b4ecb9c9822e15e707a0ebf1e250788@linux.dev> References: <20250418152228.20545-1-lance.yang@linux.dev> <20250420162925.2c58c018defee9ee192be553@linux-foundation.org> <641755b75b4ecb9c9822e15e707a0ebf1e250788@linux.dev> X-Migadu-Flow: FLOW_OUT X-Rspam-User: X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 910A180006 X-Stat-Signature: zzzzkzg6jzgqqeo85e1su755kmnhyee1 X-HE-Tag: 1745212614-364585 X-HE-Meta: U2FsdGVkX1/3xiUj0tu12FVAZUlncOSeGzUMtETrfRso7LWYY7lu5sEDd4oJg6v96/yVVGaaLIYE5jCeRe1UcXVLbj9MjbbYiLhB7qbmNphhHTimg7SB9URgiIQ2m8qqsnl2+NSOgxwlbuFiAm7wqHf6LV8fqu5DJSk27YY0ydYwFwLllOIxm5hAQ9gYh78azuKtTAcTDsSMRYBK7A2QESRpUcCf814ny6pAmd8JrsFEsd1Oy3waKwg0enGf/raz2vlWqY23gxG9au/08ioj3sskVEHFYETCkSrsNqW3+6HkcWFZIhMwvk6imqY+cVo1qwof09mLwNUleWgIzdHfU+wCKvTcJu/TboNNEGhlOqVOCeaW0nysymoMFi6gsPUb5Ej462ILsr9TdYVpux7TW3taK8X/j6n6YMgspWpsC0YtR0gBKsIO5gXtIex7MUib137tXuTHs4xRn7ZkNeP6yXL9FDTdoWGtkCvk+SSWzw5yk0j9NyiUzRTG/R1o4fN3SIVatGmsWFnFEo8whMqtn5azk/p93LVPUUzo4541sAIEEuDtuJo7gGVwHubsX8T1qP/JlMpKiBlyGKHeLTqG5boe02K+a5YB6zwz4GcfLyE+uVpfhLAjHy4R2hErnWySkiYUuC/Y0SdtuHXehMGwFyVo5+XicQFM0QKka3dJ6Ocn5JyEHdDpuchFRrHW0h/ZdVht6La3Y23LYjA9q/0QYCFhlof7XvfBaLYtdFuzQt7NpNjXFQSYvcMqAfUz0Yo4+gPOGELuVjeKAlPdiMFGHgC4vPARrpSWBmiAn3HcwGPh9NRpk7k0APi1QiKSQg4D4zuAkEzLbjIWh96W3GC5vkwqHq7SLp2nwK8HS0TrkQsu+D1+R87EMN94HqzKsPXL/1uynUhjKriXFh9zcsJqnnI35bTLu1kJo+P271CmDzsSB/+eBLqDzFBnvh5jiWrOntzm/IFLjmHvhkFHDsR e9HMuYw4 2DgAmnfoy092BxGAMbtpWSAW17RkFZrH2i+2nFeMlXexOAhXMiYzdOo5c6owMPYHOIa/UuKaf5P8aQLem+EGQFaZj1jvh6BzmUDLjdY7hZC2ekjlAxrxpsd7EE3rVJ2xbRAArD02f+NQIJa2bT+kAbwcvwbLY8UuXlyONThjWS4uT89oQGV1YKEwxbncGL3ZDjuBNO1ol1LK8Hj5WUa1PWODTB68UasrvIgdpMPKfBXjgMbVTiIwje3fdELLpJJbFyGcAhsCvtrd74fMDmRPNh80c+PO3wCNs2MC4i6ql6qXHlHXt2VyH6vGMqg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: April 21, 2025 at 1:13 PM, "Lance Yang" wrote: >=20 >=20April 21, 2025 at 7:29 AM, "Andrew Morton" wrote: >=20 >=20>=20 >=20> On Fri, 18 Apr 2025 23:22:28 +0800 Lance Yang = wrote: > >=20 >=20>=20=20 >=20>=20 >=20>=20=20 >=20>=20 >=20> From: Lance Yang > >=20 >=20>=20=20 >=20>=20 >=20>=20=20 >=20>=20 >=20>=20=20 >=20>=20 >=20> To prevent folio_test_large_maybe_mapped_shared() from being used = without > >=20 >=20>=20=20 >=20>=20 >=20> CONFIG_MM_ID, we add a compile-time check rather than wrapping it = in > >=20 >=20>=20=20 >=20>=20 >=20> '#ifdef', avoiding even more #ifdef in callers that already use > >=20 >=20>=20=20 >=20>=20 >=20> IS_ENABLED(CONFIG_MM_ID). > >=20 >=20>=20=20 >=20>=20 >=20>=20=20 >=20>=20 >=20>=20=20 >=20>=20 >=20> Also, we used plenty of IS_ENABLED() on purpose to keep the code f= ree of > >=20 >=20>=20=20 >=20>=20 >=20> '#ifdef' mess. > >=20 >=20>=20=20 >=20>=20 >=20>=20=20 >=20>=20 >=20> I dunno, this just seems really whacky. > >=20 >=20 > I'd hope David could leave some comments on that. >=20 >=20>=20 >=20> --- a/include/linux/page-flags.h > >=20 >=20>=20=20 >=20>=20 >=20> +++ b/include/linux/page-flags.h > >=20 >=20>=20=20 >=20>=20 >=20> @@ -1232,6 +1232,8 @@ static inline int folio_has_private(const st= ruct folio *folio) > >=20 >=20>=20=20 >=20>=20 >=20>=20=20 >=20>=20 >=20>=20=20 >=20>=20 >=20> static inline bool folio_test_large_maybe_mapped_shared(const stru= ct folio *folio) > >=20 >=20>=20=20 >=20>=20 >=20> { > >=20 >=20>=20=20 >=20>=20 >=20> + /* This function should never be called without CONFIG_MM_ID ena= bled. */ > >=20 >=20>=20=20 >=20>=20 >=20>=20=20 >=20>=20 >=20> A correcter comment would be "This function should never be compil= ed > >=20 >=20>=20=20 >=20>=20 >=20> without CONFIG_MM_ID enabled". > >=20 >=20 > Yes, that is more exact ;) >=20 >=20>=20 >=20> Which lets the cat out of the bag. Why the heck is it being compile= d > >=20 >=20>=20=20 >=20>=20 >=20> with CONFIG_MM_ID=3Dn?? We have tools to prevent that. > >=20 >=20>=20=20 >=20>=20 >=20> Can we just slap "#ifdef CONFIG_MM_ID" around the whole function? = It > >=20 >=20>=20=20 >=20>=20 >=20> should have no callers, right? If the linker ends up complaining t= hen > >=20 >=20>=20=20 >=20>=20 >=20> something went wrong. > >=20 >=20 > The reason we can't simply add #ifdef CONFIG_MM_ID around folio_test_la= rge_maybe_mapped_shared() >=20 >=20is because its caller folio_maybe_mapped_shared() relies on IS_ENABLE= D(CONFIG_MM_ID). static inline bool folio_maybe_mapped_shared(struct folio *folio) { [...] if (!IS_ENABLED(CONFIG_MM_ID)) return true; [...] return folio_test_large_maybe_mapped_shared(folio); } folio_maybe_mapped_shared() is always available - doesn't depend on CONFIG_MM_ID or CONFIG_TRANSPARENT_HUGEPAGE. Thanks, Lance >=20 >=20If we do, with CONFIG_TRANSPARENT_HUGEPAGE=3DN, we'll hit compilation= errors like: >=20 >=20./include/linux/mm.h: In function =E2=80=98folio_maybe_mapped_shared= =E2=80=99: >=20 >=20./include/linux/mm.h:2337:16: error: implicit declaration of function= =E2=80=98folio_test_large_maybe_mapped_shared=E2=80=99; did you mean =E2= =80=98folio_maybe_mapped_shared=E2=80=99? [-Werror=3Dimplicit-function-de= claration] >=20 >=20 2337 | return folio_test_large_maybe_mapped_shared(folio); >=20 >=20 | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ >=20 >=20 | folio_maybe_mapped_shared >=20 >=20cc1: some warnings being treated as errors >=20 >=20Thanks, >=20 >=20Lance > >=20 >=20>=20 >=20> >